accumulo.git
2 years ago[maven-release-plugin] prepare release rel/2.0.0 rel/2.0.0
Christopher Tubbs [Mon, 29 Jul 2019 19:51:48 +0000 (15:51 -0400)] 
[maven-release-plugin] prepare release rel/2.0.0

2 years agoMerge branch '1.9' into 2.0
Christopher Tubbs [Mon, 29 Jul 2019 19:08:16 +0000 (15:08 -0400)] 
Merge branch '1.9' into 2.0

2 years agoUpdates to support Java 11 on 1.9 branch (#1295)
Christopher Tubbs [Mon, 29 Jul 2019 18:48:59 +0000 (14:48 -0400)] 
Updates to support Java 11 on 1.9 branch (#1295)

This includes partial backports of:
ec76015d6e357d3a799fc2507ae0c4f33e53bba0 and
0e89ab238b14d257f9f901a36a9b87a7491c1ea9

* Build on travis with Java 11
* Update maven-javadoc-plugin
* Drop `<javadocVersion>` from maven-javadoc-plugin configuration
* Replace `<tt>` tags with `<code>`, since the former is no longer supported
* Add `<caption>` for tables (weird Java 11 javadoc requirement)
* Remove unnecessary suppressions with EasyMock updates
* Make ShellServerIT.classpath test handle output under Java 11
* Convert dubious DynamicThreadPoolsIT from an IT to a unit test
  (TabletServerResourceManagerDynamicCompactionPoolTest)
* Give SimpleGarbageCollector 16MB of memory instead of 10MB for its
  gcLotsOfCandidatesIT test, so it doesn't crash under Java 11 before the
  test runs (Java 11 needs slightly more base memory, it appears)
* Fix proxy tests in Java 11 by updating resource loading to be based
  on containing class
* Update compiler compliance settings in Eclipse, in the m2e profile
* Use newer version of minikdc for Kerberos testing

2 years agoMerge branch '1.9' into 2.0
Keith Turner [Fri, 26 Jul 2019 19:20:31 +0000 (15:20 -0400)] 
Merge branch '1.9' into 2.0

2 years agoImprove busy tracker handling of reloaded tablets (#1296)
Keith Turner [Fri, 26 Jul 2019 18:38:09 +0000 (14:38 -0400)] 
Improve busy tracker handling of reloaded tablets (#1296)

2 years agoMerge branch '1.9' into 2.0
Christopher Tubbs [Thu, 25 Jul 2019 21:52:38 +0000 (17:52 -0400)] 
Merge branch '1.9' into 2.0

2 years agofix #1286 throw exception on empty bulk import (#1292)
Keith Turner [Thu, 25 Jul 2019 20:39:42 +0000 (16:39 -0400)] 
fix #1286 throw exception on empty bulk import (#1292)

2 years agoFix #1273 Fix Bulk Messages (#1287)
hkeebler [Thu, 25 Jul 2019 20:38:24 +0000 (16:38 -0400)] 
Fix #1273 Fix Bulk Messages (#1287)

* Also added BulkImportFilterInvalidTest

2 years agoFix spotbugs when building on Java 11
Christopher Tubbs [Thu, 25 Jul 2019 19:33:37 +0000 (15:33 -0400)] 
Fix spotbugs when building on Java 11

Also remove NOOP `@Deprecated` tag that does nothing on package elements
(which now generates a warning in JDK9 and later)

2 years agoMerge branch '1.9' into 2.0
Keith Turner [Thu, 25 Jul 2019 18:36:59 +0000 (14:36 -0400)] 
Merge branch '1.9' into 2.0

2 years agoMerge pull request #1291 from keith-turner/accumulo-1187
Keith Turner [Thu, 25 Jul 2019 18:10:22 +0000 (14:10 -0400)] 
Merge pull request #1291 from keith-turner/accumulo-1187

2 years agoImproved logging of busiest tablets. 1291/head
Keith Turner [Wed, 24 Jul 2019 20:42:15 +0000 (16:42 -0400)] 
Improved logging of busiest tablets.

Now the deltas of tablets ingest and query counts are used for computing
the busiest N tablets. The previous code used the absolute counts.
Restructured code that so that it is unit testable and found a few bugs
while writing the unit test.  Found the prioQ was not properly tracking
the top N tablets.

2 years agoSupport builds with JDK9 and later
Christopher Tubbs [Thu, 25 Jul 2019 18:02:41 +0000 (14:02 -0400)] 
Support builds with JDK9 and later

2 years agoRename Bulk ITs to be less confusing (#1290)
Mike Miller [Thu, 25 Jul 2019 14:15:05 +0000 (10:15 -0400)] 
Rename Bulk ITs to be less confusing (#1290)

2 years agoImprove exception javadoc in TableOperations (#1289)
Mike Miller [Wed, 24 Jul 2019 23:59:10 +0000 (19:59 -0400)] 
Improve exception javadoc in TableOperations (#1289)

2 years agoMerge branch '1.9' into 2.0
Mike Miller [Wed, 24 Jul 2019 22:34:36 +0000 (18:34 -0400)] 
Merge branch '1.9' into 2.0

2 years agoFix misspelling
Mike Miller [Wed, 24 Jul 2019 22:30:52 +0000 (18:30 -0400)] 
Fix misspelling

2 years agoAdd logging of top tablets to enable better hot spot detection
Adam Lerman [Thu, 6 Jun 2019 21:09:48 +0000 (17:09 -0400)] 
Add logging of top tablets to enable better hot spot detection

2 years agoPurge mortbay logger from example configs (#1284)
Christopher Tubbs [Tue, 23 Jul 2019 18:59:18 +0000 (14:59 -0400)] 
Purge mortbay logger from example configs (#1284)

We no longer have a dependency on mortbay versions of jetty, so there
should be no reason to regulate its spamminess in our config files.

2 years agoLexicoder API improvements (#1285)
Christopher Tubbs [Tue, 23 Jul 2019 18:58:51 +0000 (14:58 -0400)] 
Lexicoder API improvements (#1285)

* Remove public API use of internal ValueFormatException and
  TypedValueCombiner.Encoder interface
* Remove exception in Apilyzer configuration for ValueFormatException in
  Lexicoder public APIs
* Remove redundant and no-longer needed TypedValueCombiner.Encoder
  interface
* Update comments in the Lexicoders to indicate the reason for
  preserving override methods for the purpose of binary compatibility

2 years agoFix CVE-2019-12814 Use jackson-databind 2.9.9.1
Christopher Tubbs [Tue, 23 Jul 2019 16:35:34 +0000 (12:35 -0400)] 
Fix CVE-2019-12814 Use jackson-databind 2.9.9.1

2 years agoFix formatting
Christopher Tubbs [Tue, 23 Jul 2019 16:26:13 +0000 (12:26 -0400)] 
Fix formatting

2 years agoFix: #1222 Verify size is valid (#1280)
Jeffrey Manno [Tue, 23 Jul 2019 14:47:08 +0000 (10:47 -0400)] 
Fix: #1222 Verify size is valid (#1280)

2 years agoFix #1252 Created SequenceLexicoder (#1257)
Richard W. Eggert II [Mon, 22 Jul 2019 21:31:07 +0000 (17:31 -0400)] 
Fix #1252 Created SequenceLexicoder (#1257)

created SequenceLexicoder that supports empty lists

2 years agoLog per tserver contact times at trace in Master (#1283)
Keith Turner [Mon, 22 Jul 2019 20:39:14 +0000 (16:39 -0400)] 
Log per tserver contact times at trace in Master (#1283)

2 years agofix #1277 respond to Hadoop shutdown hook more aggressively (#1279)
Keith Turner [Mon, 22 Jul 2019 15:06:06 +0000 (11:06 -0400)] 
fix #1277 respond to Hadoop shutdown hook more aggressively (#1279)

2 years agoMerge branch '1.9' into 2.0
Christopher Tubbs [Tue, 16 Jul 2019 21:18:47 +0000 (17:18 -0400)] 
Merge branch '1.9' into 2.0

2 years agoLimit log size in Travis CI builds
Christopher Tubbs [Tue, 16 Jul 2019 21:16:38 +0000 (17:16 -0400)] 
Limit log size in Travis CI builds

Suppress the downloading messages for maven dependency resolution,
because they result in a very long build log, which causes Travis CI to
fail the build when it exceeds 4MB. These settings will ensure that the
dependency resolver will only show warnings and higher for download
actions.

2 years agoFix #1272 Reset navbar count for clear logs action (#1274)
hkeebler [Mon, 15 Jul 2019 20:08:10 +0000 (16:08 -0400)] 
Fix #1272 Reset navbar count for clear logs action (#1274)

2 years agoMake bulk load mapping matching more strict #1260 (#1269)
Keith Turner [Mon, 15 Jul 2019 15:02:27 +0000 (11:02 -0400)] 
Make bulk load mapping matching more strict #1260 (#1269)

2 years agoUpgrade to Commons Lang3 for 2.0 (#1270)
Mike Miller [Sat, 13 Jul 2019 00:51:44 +0000 (20:51 -0400)] 
Upgrade to Commons Lang3 for 2.0 (#1270)

* Replace IntRange with Range<Integer>
* Replace NotImplementedException with UnsupportedOperationException
* Drop dependency where no longer used
* Use isParsable instead of isNumber (which is deprecated)

2 years agocorrectly handle first and last tablets in LinkingIterator #1260 (#1266)
Keith Turner [Thu, 11 Jul 2019 21:58:47 +0000 (17:58 -0400)] 
correctly handle first and last tablets in LinkingIterator #1260 (#1266)

The LinkingIterator checks the structure of the AccumuloMetadata table
as it is scans.   It was not properly handling a split of the first
tablet.  It was also not ensuring the default tablet for a table was seen.
This patch fixes those two issues.  These issues were discovered while
researching #1260, however I am not sure if these issues could have
caused #1260.

2 years agoImprove error handling in Monitor. Fixes #1258 (#1262)
Mike Miller [Wed, 10 Jul 2019 20:09:22 +0000 (16:09 -0400)] 
Improve error handling in Monitor. Fixes #1258 (#1262)

* Make rest calls fail fast and return empty objects
* This will make the Monitor more stable when Master is down

2 years agoImprove ID javadoc (#1261)
Mike Miller [Wed, 10 Jul 2019 20:08:26 +0000 (16:08 -0400)] 
Improve ID javadoc (#1261)

2 years agoFix oldest age on bulk import page. Closes #1251 (#1256)
Mike Miller [Tue, 9 Jul 2019 14:56:34 +0000 (10:56 -0400)] 
Fix oldest age on bulk import page. Closes #1251 (#1256)

2 years agochange FATE prefix #1247
Keith Turner [Mon, 8 Jul 2019 18:20:04 +0000 (14:20 -0400)] 
change FATE prefix #1247

2 years agofix #1247 store fate txid in ~blip marker value (#1248)
Keith Turner [Mon, 8 Jul 2019 17:30:27 +0000 (13:30 -0400)] 
fix #1247 store fate txid in ~blip marker value (#1248)

Before this change the bulk import code was serializing and logging fate
transaction ids differently than other parts of the code.  When adding
FATE transaction ids to blip markers, I decided it would be best if they
were consistently persisted (in metadata table ) and logged. That
decision made this change much larger than simply adding something to
the blip value, but I feel its worth it.

The following are the main changes :

 * Introduce new class FateTxId with methods for consistenly formatting
   fate transaction ids.
 * Make bulk fate logging use FateTxId
 * Update ~blip and loaded family to use FateTxId.  Made loaded family
   backwards compat.
 * Update existing fate logging code to use FateTxId.  Instead of
   String.format

Follow on work to update all Repos to use FateTxId would be nice.  Chose
not do to that in the change because it would make it harder to review.

2 years agoChange Bulk warnings to debug. Fixes #1250 (#1255)
Mike Miller [Mon, 8 Jul 2019 16:35:42 +0000 (12:35 -0400)] 
Change Bulk warnings to debug. Fixes #1250 (#1255)

2 years agoMake bulk import move idempotent (#1246)
Keith Turner [Wed, 3 Jul 2019 13:34:59 +0000 (09:34 -0400)] 
Make bulk import move idempotent (#1246)

2 years agofix #1231 prevent hadoop shutdown hook from failing FATE tx (#1245)
Keith Turner [Wed, 3 Jul 2019 13:34:01 +0000 (09:34 -0400)] 
fix #1231 prevent hadoop shutdown hook from failing FATE tx (#1245)

3 years agoImprove Error msg on Bulk checkPath (#1235)
Mike Miller [Wed, 26 Jun 2019 20:30:48 +0000 (16:30 -0400)] 
Improve Error msg on Bulk checkPath (#1235)

3 years agoSome monitor javascript updates (#1234)
Christopher Tubbs [Wed, 26 Jun 2019 18:49:16 +0000 (14:49 -0400)] 
Some monitor javascript updates (#1234)

* Fix #1233 Use thead in tables in monitor page
* Fix #475 display bulk import rows correctly

3 years agoFix #1230 INVALID date for GC on master monitor page
Holly Keebler [Fri, 21 Jun 2019 20:39:18 +0000 (16:39 -0400)] 
Fix #1230 INVALID date for GC on master monitor page

3 years agoMerge branch '1.9' into 2.0
Christopher Tubbs [Fri, 21 Jun 2019 08:20:36 +0000 (04:20 -0400)] 
Merge branch '1.9' into 2.0

3 years agoUpdate travis-ci configuration
Christopher Tubbs [Fri, 21 Jun 2019 08:16:45 +0000 (04:16 -0400)] 
Update travis-ci configuration

3 years agoFix #1223 Correct recovery status on monitor
Christopher Tubbs [Thu, 20 Jun 2019 23:49:06 +0000 (19:49 -0400)] 
Fix #1223 Correct recovery status on monitor

Fix the Log Recovery table on the master page in the monitor to:

* Show the recovery time as duration
* Show the progress as a percentage
* Stop deleting the headers

3 years agoFix #811 Unit test InputFormatBuilder.java (#1150)
elinaawise [Thu, 20 Jun 2019 20:53:30 +0000 (16:53 -0400)] 
Fix #811 Unit test InputFormatBuilder.java (#1150)

Unit test InputFormatBuilder.java classLoaderContext() and executionHints() functions

3 years agoMerge branch '1.9' into 2.0
Christopher Tubbs [Thu, 20 Jun 2019 20:18:55 +0000 (16:18 -0400)] 
Merge branch '1.9' into 2.0

3 years agoUpdate formatter-maven-plugin
Christopher Tubbs [Thu, 20 Jun 2019 20:17:26 +0000 (16:17 -0400)] 
Update formatter-maven-plugin

Update formatter plugin to 2.10.0; resolves a reproducibility issue
where earlier versions would grab transitive dependencies of the plugin
from a range of versions, making the formatter potentially change the
way it formats between two different executions.

3 years agoDrop Unused boolean flag and Remove internal static objects (#1224)
Mike Miller [Thu, 20 Jun 2019 06:48:48 +0000 (02:48 -0400)] 
Drop Unused boolean flag and Remove internal static objects (#1224)

* Remove internal static objects
* Drop unused initialize flag

3 years agoUpdate packaged class path for Java 11 (#1218)
Christopher Tubbs [Wed, 19 Jun 2019 18:42:06 +0000 (14:42 -0400)] 
Update packaged class path for Java 11 (#1218)

* Update several dependencies, mostly pertaining to the monitor, which are
included in the build, so that the class path is sufficient for the
monitor to run on Java 8 or 11.

* Update build plugins

3 years agoFix WebViewsIT under Java 11
Christopher Tubbs [Mon, 17 Jun 2019 07:40:07 +0000 (03:40 -0400)] 
Fix WebViewsIT under Java 11

3 years agoRemove unnecessary warnings suppressions
Christopher Tubbs [Mon, 17 Jun 2019 00:42:43 +0000 (20:42 -0400)] 
Remove unnecessary warnings suppressions

3 years agoFix javadocs when building with Java 11
Christopher Tubbs [Sun, 16 Jun 2019 21:50:11 +0000 (17:50 -0400)] 
Fix javadocs when building with Java 11

* Update maven-javadoc-plugin
* Drop `<javadocVersion>` from maven-javadoc-plugin configuration
* Replace `<tt>` tags with `<code>`, since the former is no longer supported
* Add `<caption>` for tables (weird Java 11 javadoc requirement)

* Also update hibernate-validator groupId (not javadoc related, but
  removed build warning from Maven about relocated artifact)

3 years agoFix more tests building 2.0 with Java 11 (#1215)
Christopher Tubbs [Sun, 16 Jun 2019 21:48:01 +0000 (17:48 -0400)] 
Fix more tests building 2.0 with Java 11 (#1215)

* Fix more tests building 2.0 with Java 11

* Update monitor dependencies to release versions (instead of beta
  versions) for WebViewsIT
* Simplify parameters to TabletServerResourceManager (everything it
  needs is in the ServerContext; other params were redundant)
* Ensure TabletServerResourceManager updates the dynamic thread pools in
  the correct order (cannot increase the corePoolSize before increasing
  the maxPoolSize)
* Make ShellServerIT.classpath test handle output under Java 11
* Convert dubious DynamicThreadPoolsIT from an IT to a unit test
  (TabletServerResourceManagerDynamicCompactionPoolTest)
* Give SimpleGarbageCollector 16MB of memory instead of 10MB for its
  gcLotsOfCandidatesIT test, so it doesn't crash under Java 11 before the
  test runs (Java 11 needs slightly more base memory, it appears)

3 years agoUpdate spotbugs filters to accomodate Java 11 (#1214)
Christopher Tubbs [Sun, 16 Jun 2019 01:48:24 +0000 (21:48 -0400)] 
Update spotbugs filters to accomodate Java 11 (#1214)

Update filters to suppress triaged warnings from spotbugs findsecbugs
when building with Java 11

3 years agoFix bad unit tests found while building on Java 11 (#1213)
Christopher Tubbs [Sat, 15 Jun 2019 04:37:08 +0000 (00:37 -0400)] 
Fix bad unit tests found while building on Java 11 (#1213)

* Fix bad unit tests found while building on Java 11

* Primarily fixes some bad unit tests
* But also helps build and run unit tests on Java 11

* Fixes #1195 Updates EasyMock and PowerMock
* Fixes #1194 Remove assumptions in AccumuloVFSClassLoader about the
  type of the system class loader and the system's app class loader
  (specifically, stop assuming they are a URLClassloader instance by
  accounting for some other instances they could also be)

3 years agoFormatting
Mike Miller [Fri, 14 Jun 2019 19:30:59 +0000 (15:30 -0400)] 
Formatting

3 years agoAdded a catch all for dropped Client properties. (#1197)
Mike Miller [Fri, 14 Jun 2019 18:03:55 +0000 (14:03 -0400)] 
Added a catch all for dropped Client properties. (#1197)

* Make ClientOps throw error and print bad options

3 years agoFix #822 Add thread-safety info to AccumuloClient javadoc (#1205)
Christopher Tubbs [Fri, 14 Jun 2019 16:37:15 +0000 (12:37 -0400)] 
Fix #822 Add thread-safety info to AccumuloClient javadoc (#1205)

3 years agoFix tests broken due to #1202
Christopher Tubbs [Fri, 14 Jun 2019 04:44:54 +0000 (00:44 -0400)] 
Fix tests broken due to #1202

3 years agoFix #1202 Correct documented vfs cache dir default
Christopher Tubbs [Thu, 13 Jun 2019 21:13:59 +0000 (17:13 -0400)] 
Fix #1202 Correct documented vfs cache dir default

Update the default value for general.vfs.cache.dir to reflect the actual
default used in AccumuloVFSClassLoader. Also update the description to
more accurately represent how the value is used as a base directory for
a subdirectory which the vfs class loader code uses.

3 years agoAllow master start to block waiting for a number of tservers (#1204)
EdColeman [Thu, 13 Jun 2019 20:59:45 +0000 (16:59 -0400)] 
Allow master start to block waiting for a number of tservers (#1204)

Adds two parameters:

 - MASTER_STARTUP_TSERVER_AVAIL_MIN_COUNT - sets desried number of tservers
 - MASTER_STARTUP_TSERVER_AVAIL_MAX_WAIT - sets maximum time to wait.

This is the same changes submitted as pull request #1158 for 1.9.x, merged to
2.0.  Request #1158 will be available as a patch, but is not expected to be merged
becuase of semver requirements.

3 years agoMerge remote-tracking branch 'upstream/1.9' into 2.0
Ed Coleman [Thu, 13 Jun 2019 16:05:24 +0000 (12:05 -0400)] 
Merge remote-tracking branch 'upstream/1.9' into 2.0

3 years agofixed time calculation to use nano delta (#1184)
EdColeman [Thu, 13 Jun 2019 15:55:48 +0000 (11:55 -0400)] 
fixed time calculation to use nano delta (#1184)

* fixed time calculation to use nano delta

* changed the nanoTime usage in this file to be consistent

3 years agoUpdate travis to use default ZK for all builds
Christopher Tubbs [Tue, 11 Jun 2019 17:40:54 +0000 (13:40 -0400)] 
Update travis to use default ZK for all builds

3 years agoMerge branch '1.9' into 2.0
Christopher Tubbs [Mon, 10 Jun 2019 02:08:19 +0000 (22:08 -0400)] 
Merge branch '1.9' into 2.0

3 years agoFix xml namespace declarations in pom.xml files
Christopher Tubbs [Mon, 10 Jun 2019 01:57:50 +0000 (21:57 -0400)] 
Fix xml namespace declarations in pom.xml files

* Fix root pom.xml xmlns:xsi namespace (must be http, not https)
* Update all schemaLocation values for xsi to consistently use current
  canonical location

3 years agoImprove use of Hadoop's DistributedCache (#1188) 1188/head
Christopher Tubbs [Mon, 10 Jun 2019 01:17:23 +0000 (21:17 -0400)] 
Improve use of Hadoop's DistributedCache (#1188)

Update DistributedCacheHelper to both add a cached file to a MapReduce
job and to retrieve an InputStream from the DistributedCache (or HDFS,
if the item was not successfully cached).

Ensure uniqueness in the local cached file names and that the files are
read from the correct filesystem.

Add some tests to TokenFileIT

Specify the charset explicitly when java.util.Scanner is used (most
occurrences were related to code using the DistributedCache, but also
fixed two trivial occurrences in shell-related code).

3 years agoFix #1052 Correct distributed cache usage (#1112)
Jeffrey L. Zeiberg [Wed, 10 Apr 2019 11:46:24 +0000 (07:46 -0400)] 
Fix #1052 Correct distributed cache usage (#1112)

* Correct distributed cache usage for Tokenfile and Property and
  RangePartition key cut files.

3 years agoResolve bad merge of #1185 by removing unused import
Christopher Tubbs [Fri, 7 Jun 2019 17:21:09 +0000 (13:21 -0400)] 
Resolve bad merge of #1185 by removing unused import

3 years agoRemove accumulo-proxy from main accumulo build (#1182)
Christopher Tubbs [Fri, 7 Jun 2019 16:44:40 +0000 (12:44 -0400)] 
Remove accumulo-proxy from main accumulo build (#1182)

New home repository is "accumulo-proxy".

3 years agoMerge branch '1.9' into 2.0
Christopher Tubbs [Fri, 7 Jun 2019 16:41:25 +0000 (12:41 -0400)] 
Merge branch '1.9' into 2.0

3 years agoEnsures correct use of ZooKeeper getAcl (#1185)
Christopher Tubbs [Fri, 7 Jun 2019 16:40:06 +0000 (12:40 -0400)] 
Ensures correct use of ZooKeeper getAcl (#1185)

This fixes a bug in Accumulo where we were using an unauthenticated
ZooKeeper session to read ACLs on a node that we had previously written.

ZooKeeper 3.4.14 fixed a bug in their code that allowed unauthenticated
connections to read ACLs on paths for which they did not have READ
permission.

Using Accumulo with that version of ZooKeeper exposed the bug in our
code that passed the incorrect ZooKeeper session when retrieving ACLs.

3 years agoUpdate ZooKeeper (CVE-2019-0201)
Christopher Tubbs [Wed, 5 Jun 2019 17:42:31 +0000 (13:42 -0400)] 
Update ZooKeeper (CVE-2019-0201)

3 years agoFix #418 Javadoc updated with workaround for createIfNotExists (#1178)
hkeebler [Wed, 5 Jun 2019 16:54:56 +0000 (12:54 -0400)] 
Fix #418 Javadoc updated with workaround for createIfNotExists (#1178)

includes comment cleanup

3 years agoRemove unused code
Christopher Tubbs [Tue, 4 Jun 2019 23:42:58 +0000 (19:42 -0400)] 
Remove unused code

* Remove `@Ignore` JUnit tests
* Remove unnecessary use of PowerMock when EasyMock sufficed
* Remove unnecessary duplicate parameter in Initialize.checkInit

Note: IDE added missing curly braces around single-statement blocks; I
kept these as a side effect, because, it's better to have them and the
formatter can't be configured to automatically add them, so they get
added as I edit.

3 years agoRemove custom property interpolations (#1179)
Christopher Tubbs [Tue, 4 Jun 2019 22:56:38 +0000 (18:56 -0400)] 
Remove custom property interpolations (#1179)

* Remove custom property interpolations

Remove unnecessary custom property interpolations in code. Instead, rely
on property interpolation features of commons-configuration2, as needed,
to set properties based on environment.

A side effect of this change, as well as the fact that
GENERAL_DYNAMIC_CLASSPATHS is deprecated, is that the default value for
that property is now blank (and the empty lib/ext directory is no longer
created in the assembly tarball).

In future, commons-configuration2 could also be used to interpolate
values of configuration properties stored in ZooKeeper, but that is out
of scope of this issue, and can be added later, if there is interest.

This change further decouples the reliance on specialized environment,
and reduces assumptions made in our code, making it more
environment-agnostic.

* Fix unit tests and remove long-time ignored tests

3 years agoFix #1084 partial - IT tests failing on Standalone (#1164)
hkeebler [Tue, 4 Jun 2019 19:28:55 +0000 (15:28 -0400)] 
Fix #1084 partial - IT tests failing on Standalone (#1164)

* Fixed AccumuloClientIT, ManyWariteaheadLogsIT, ReadWriteIT, YieldScannersIT, BadDeleteMarkersIT
* And others that failed due to null in the command prefix
* Also includes IteratorEnvIT fix

3 years agoUpdate to commons-configuration2.5 (#1176)
Christopher Tubbs [Mon, 3 Jun 2019 20:45:05 +0000 (16:45 -0400)] 
Update to commons-configuration2.5 (#1176)

* Update dependencies
* Use FileBasedConfigurationBuilder to load configuration files
* Use PropertiesConfigurationLayout to serialize/deserialize when needed
* Simplified some calls to get system properties en route to updating
the PropertiesConfiguration usages.

Note: list delimiter is disabled by default now, so those API calls
aren't needed and were removed; also removed setThrowsOnMissing(false)
calls becuase that was also the default behavior

3 years agoClean up and refactor metrics for maintainability (#1175)
Christopher Tubbs [Sat, 1 Jun 2019 06:18:37 +0000 (02:18 -0400)] 
Clean up and refactor metrics for maintainability (#1175)

* Create base class for common code
* Remove unneeded shims from legacy metrics
* Inline fields and methods used only once
* Rename classes to be easier to understand
* Retain current metric names and context/record tags
* Standardize metrics initialization
* Consolidate helper classes into abstract base class
* Separate fields/members to one per line for readability and group
fields according to function (gauge vs. stat vs. class helper like log)

3 years agoMerge pull request #1172 from EdColeman/remove_legacy_metrics
Christopher Tubbs [Thu, 30 May 2019 21:28:38 +0000 (17:28 -0400)] 
Merge pull request #1172 from EdColeman/remove_legacy_metrics

Remove option for legacy metrics.

3 years agoRemove unused dependency and config file 1172/head
Christopher Tubbs [Tue, 28 May 2019 22:50:47 +0000 (18:50 -0400)] 
Remove unused dependency and config file

3 years agoFix #886 Deprecate general.dynamic.classpaths (#1166)
Holly Keebler [Tue, 21 May 2019 17:21:03 +0000 (13:21 -0400)] 
Fix #886 Deprecate general.dynamic.classpaths (#1166)

3 years agoRemove more legacy metrics classes
Christopher Tubbs [Tue, 28 May 2019 21:58:49 +0000 (17:58 -0400)] 
Remove more legacy metrics classes

3 years agoMerge branch '1.9' into 2.0
Keith Turner [Tue, 28 May 2019 19:17:51 +0000 (15:17 -0400)] 
Merge branch '1.9' into 2.0

3 years agoAvoid multiple threads loading same cache block (#990)
Keith Turner [Mon, 25 Feb 2019 23:44:18 +0000 (18:44 -0500)] 
Avoid multiple threads loading same cache block (#990)

3 years agoLog status times to debug log (#1067)
Adam Lerman [Mon, 1 Apr 2019 15:28:27 +0000 (15:28 +0000)] 
Log status times to debug log (#1067)

3 years agoMerge branch '1.9'
Josh Elser [Fri, 24 May 2019 17:14:34 +0000 (13:14 -0400)] 
Merge branch '1.9'

3 years agoSwitch POM project xml attrs from HTTP to HTTPS
Josh Elser [Fri, 24 May 2019 14:52:29 +0000 (10:52 -0400)] 
Switch POM project xml attrs from HTTP to HTTPS

Closes #1173

3 years agoFixes #1159. Refactor DurabilityIT (#1165)
Jeffrey Manno [Fri, 24 May 2019 14:07:14 +0000 (10:07 -0400)] 
Fixes #1159. Refactor DurabilityIT (#1165)

3 years agoRemove option for legacy metrics.
Ed Coleman [Thu, 23 May 2019 23:59:24 +0000 (19:59 -0400)] 
Remove option for legacy metrics.

Hadoop Metrics 2 were adopted in 1.7 and previous metrics marked legacy.
This removed the propery to enable legacy metics and the obvious dead code.
There will be more code to remove, but this is a first pass.

3 years agoUpdate jackson to 2.9.9 (#1170)
Mike Miller [Thu, 23 May 2019 19:48:16 +0000 (15:48 -0400)] 
Update jackson to 2.9.9 (#1170)

(CVE-2019-12086)

3 years agoFormatting
Mike Miller [Wed, 22 May 2019 15:56:46 +0000 (11:56 -0400)] 
Formatting

3 years agoRef #1084 Fixes File not Found Error (#1162)
Jeffrey Manno [Thu, 16 May 2019 18:43:57 +0000 (14:43 -0400)] 
Ref #1084 Fixes File not Found Error (#1162)

3 years agoRemove direct uses of log4j (#1163)
Christopher Tubbs [Thu, 16 May 2019 16:34:01 +0000 (12:34 -0400)] 
Remove direct uses of log4j (#1163)

* Use more slf4j when possible
* Update default console logger in log4j.properties to use STDERR
* Eliminate custom log level manipulation in code (Fixes #1109)
* Remove/deprecate dynamic logging manipulation in the shell
* Add commented out informative option to log4j.properties
* Remove unnecessary apilyzer exceptions (since these are only public API in deprecated classes)
* Use format-string messages instead of String concatenation, in any loggers converted to use slf4j from log4j

3 years agofix #576 added more unit tests for NewTableConfiguration (#1161)
elinaawise [Wed, 15 May 2019 21:42:29 +0000 (17:42 -0400)] 
fix #576 added more unit tests for NewTableConfiguration (#1161)

3 years agoFix trivial warnings
Christopher Tubbs [Tue, 14 May 2019 21:10:51 +0000 (17:10 -0400)] 
Fix trivial warnings

3 years agoFix #1119 Improve Retry Code (#1125)
Jeffrey Zeiberg [Tue, 14 May 2019 20:55:16 +0000 (16:55 -0400)] 
Fix #1119 Improve Retry Code (#1125)

* Make backoff exponential
* Add some jitter to backoff, to further avoid collisions on retry

3 years agoFix #405 Utilize NewTableConfiguration in ITs (#1160)
hkeebler [Tue, 14 May 2019 19:54:29 +0000 (15:54 -0400)] 
Fix #405 Utilize NewTableConfiguration in ITs (#1160)