activemq-artemis.git
4 days agoThis closes #2550 master
Michael Andre Pearce [Thu, 14 Feb 2019 13:42:14 +0000 (13:42 +0000)] 
This closes #2550

4 days agoNO-JIRA Fix a "Computation of average could overflow" SpotBugs warning
Jiri Danek [Thu, 14 Feb 2019 12:22:11 +0000 (13:22 +0100)] 
NO-JIRA Fix a "Computation of average could overflow" SpotBugs warning

https://spotbugs.readthedocs.io/en/stable/bugDescriptions.html#im-computation-of-average-could-overflow-im-average-computation-could-overflow

4 days agoThis closes #2522
Michael Andre Pearce [Thu, 14 Feb 2019 00:20:52 +0000 (00:20 +0000)] 
This closes #2522

4 days agoARTEMIS-2239 Zero-copy NIO/MAPPED TimedBuffer
Francesco Nigro [Fri, 25 Jan 2019 13:40:28 +0000 (14:40 +0100)] 
ARTEMIS-2239 Zero-copy NIO/MAPPED TimedBuffer

NIO/MAPPED journal types can use directly the buffer of TimedBuffer
to perform file writes, avoiding an expensive copy + zeroing.

6 days agoARTEMIS-1058 Fixing testsuite
Clebert Suconic [Tue, 12 Feb 2019 08:42:28 +0000 (09:42 +0100)] 
ARTEMIS-1058 Fixing testsuite

Possible NPE that will happen on ReplicatedFailoverTest only

9 days agoARTEMIS-2246 Fixing testsuite
Clebert Suconic [Fri, 8 Feb 2019 23:41:20 +0000 (18:41 -0500)] 
ARTEMIS-2246 Fixing testsuite

10 days agoThis closes #2542
Justin Bertram [Thu, 7 Feb 2019 21:20:04 +0000 (15:20 -0600)] 
This closes #2542

10 days agoARTEMIS-2081 listConfiguredQueues returns only queues created by config
Michael André Pearce [Thu, 7 Feb 2019 17:19:23 +0000 (17:19 +0000)] 
ARTEMIS-2081 listConfiguredQueues returns only queues created by config

Move configuration managed in persister before consumer dispatch so then the fix can be applied in 2.6.x branch safely.

10 days agoThis closes #2544
Justin Bertram [Thu, 7 Feb 2019 20:19:19 +0000 (14:19 -0600)] 
This closes #2544

10 days agoARTEMIS-2246 Setting the max-disk-usage as 100 on the testsuite
Clebert Suconic [Thu, 7 Feb 2019 20:07:47 +0000 (15:07 -0500)] 
ARTEMIS-2246 Setting the max-disk-usage as 100 on the testsuite

This is to avoid issues with CI and Dev Machiens, while still preserving
a sensible default for production systems.

10 days agoARTEMIS-2246 clarify docs for defaults; change max-disk-usage default
Justin Bertram [Wed, 6 Feb 2019 21:58:27 +0000 (15:58 -0600)] 
ARTEMIS-2246 clarify docs for defaults; change max-disk-usage default

10 days agoThis closes #2532
Clebert Suconic [Thu, 7 Feb 2019 15:16:01 +0000 (10:16 -0500)] 
This closes #2532

10 days agoARTEMIS-2243 user/role ops for PropertiesLoginModule via mgmnt
Justin Bertram [Wed, 30 Jan 2019 00:35:16 +0000 (18:35 -0600)] 
ARTEMIS-2243 user/role ops for PropertiesLoginModule via mgmnt

10 days agoThis closes #2539
Clebert Suconic [Thu, 7 Feb 2019 15:04:52 +0000 (10:04 -0500)] 
This closes #2539

10 days agoARTEMIS-2248 don't create sslEngine w/sniHost in NettyConnector
Justin Bertram [Wed, 6 Feb 2019 17:12:53 +0000 (11:12 -0600)] 
ARTEMIS-2248 don't create sslEngine w/sniHost in NettyConnector

11 days agoThis closes #2540
Clebert Suconic [Wed, 6 Feb 2019 23:32:30 +0000 (18:32 -0500)] 
This closes #2540

11 days agoARTEMIS-2247 remove quotes from etc dir for Win service
Justin Bertram [Wed, 6 Feb 2019 21:24:33 +0000 (15:24 -0600)] 
ARTEMIS-2247 remove quotes from etc dir for Win service

11 days agoARTEMIS-1058 Fixing checkstyle
Clebert Suconic [Wed, 6 Feb 2019 23:29:53 +0000 (18:29 -0500)] 
ARTEMIS-1058 Fixing checkstyle

11 days agoThis closes #2534
Clebert Suconic [Wed, 6 Feb 2019 15:02:25 +0000 (10:02 -0500)] 
This closes #2534

11 days agoARTEMIS-1058 Jars in web tmp dir locked on Windows
Howard Gao [Thu, 31 Jan 2019 14:33:33 +0000 (22:33 +0800)] 
ARTEMIS-1058 Jars in web tmp dir locked on Windows

This is the second commit. It improves the windows service
configuration file so that the service can be shutdown
gracefully (clean shutdown) and allow for a chance to
clean up the web tmp dir.

12 days agoThis closes #2537
Clebert Suconic [Wed, 6 Feb 2019 14:36:04 +0000 (09:36 -0500)] 
This closes #2537

12 days agoARTEMIS-1058 Improving web temporary cleanup
Clebert Suconic [Mon, 4 Feb 2019 15:20:01 +0000 (10:20 -0500)] 
ARTEMIS-1058 Improving web temporary cleanup

* Using SpawnedVMSupport (used to be on testsuite, moving it to Utils)
* Building the classpath for ./lib, similar to what happens on Bootstrap
* Using Path as much as possible to avoid issues encoding files

12 days agoThis closes #2533
Clebert Suconic [Tue, 5 Feb 2019 20:51:26 +0000 (15:51 -0500)] 
This closes #2533

12 days agoARTEMIS-2244 Adding critical check around checkDepage
Clebert Suconic [Tue, 5 Feb 2019 20:15:10 +0000 (15:15 -0500)] 
ARTEMIS-2244 Adding critical check around checkDepage

12 days agoARTEMIS-2244 checkDepage method placed outside CRITICAL_DELIVER avoid critical analyz...
yb [Thu, 31 Jan 2019 09:20:06 +0000 (17:20 +0800)] 
ARTEMIS-2244 checkDepage method placed outside CRITICAL_DELIVER avoid critical analyzer timeout

12 days agoThis closes #2536
Clebert Suconic [Tue, 5 Feb 2019 18:57:29 +0000 (13:57 -0500)] 
This closes #2536

12 days agoARTEMIS-2245 Moving docker files under artemis-docker and other improvements
Clebert Suconic [Mon, 4 Feb 2019 23:49:59 +0000 (18:49 -0500)] 
ARTEMIS-2245 Moving docker files under artemis-docker and other improvements

12 days agoARTEMIS-2245 adding Docker images User guide
Francesco Nigro [Mon, 4 Feb 2019 17:54:57 +0000 (18:54 +0100)] 
ARTEMIS-2245 adding Docker images User guide

12 days agoARTEMIS-2245 Cleaning and Extending Docker images
Francesco Nigro [Sat, 2 Feb 2019 08:12:17 +0000 (09:12 +0100)] 
ARTEMIS-2245 Cleaning and Extending Docker images

Cleaning Docker images and adding CentOS version

12 days agoARTEMIS-2245 Implement Docker images
Clebert Suconic [Tue, 23 Oct 2018 01:11:02 +0000 (21:11 -0400)] 
ARTEMIS-2245 Implement Docker images

13 days agoThis closes #2538
Clebert Suconic [Mon, 4 Feb 2019 22:46:20 +0000 (17:46 -0500)] 
This closes #2538

13 days agoNO-JIRA fix race condition in QueueQueryTest
Justin Bertram [Mon, 4 Feb 2019 22:01:37 +0000 (16:01 -0600)] 
NO-JIRA fix race condition in QueueQueryTest

My previous commit to fix this was amended which nullified the fix.

2 weeks agoThis closes #2535
Clebert Suconic [Thu, 31 Jan 2019 18:24:53 +0000 (13:24 -0500)] 
This closes #2535

2 weeks agoNO-JIRA update docs for gitbox
Justin Bertram [Thu, 31 Jan 2019 15:41:49 +0000 (09:41 -0600)] 
NO-JIRA update docs for gitbox

2 weeks agoThis closes #2531
Clebert Suconic [Wed, 30 Jan 2019 20:38:37 +0000 (15:38 -0500)] 
This closes #2531

2 weeks agoARTEMIS-2205 Fixing Divert Example
Clebert Suconic [Wed, 30 Jan 2019 18:04:21 +0000 (13:04 -0500)] 
ARTEMIS-2205 Fixing Divert Example

This is simply fixing the example under examples/features/standard/divert
Other tests are passing.
No additional tests are needed as the example on this case acts like a test.

2 weeks agoARTEMIS-2189 Fixing queueRequestor example
Clebert Suconic [Wed, 30 Jan 2019 20:37:42 +0000 (15:37 -0500)] 
ARTEMIS-2189 Fixing queueRequestor example

2 weeks agoThis closes #2524
Michael Andre Pearce [Wed, 30 Jan 2019 08:14:58 +0000 (08:14 +0000)] 
This closes #2524

2 weeks agoARTEMIS-2240 ActiveMQThreadPoolExecutor should use LinkedTransferQueue
Francesco Nigro [Sun, 27 Jan 2019 01:27:21 +0000 (02:27 +0100)] 
ARTEMIS-2240 ActiveMQThreadPoolExecutor should use LinkedTransferQueue

2 weeks agoThis closes #2525
Michael Andre Pearce [Wed, 30 Jan 2019 08:11:46 +0000 (08:11 +0000)] 
This closes #2525

2 weeks agoARTEMIS-2241 Support direct deliver for InVMAcceptors
Michael André Pearce [Fri, 25 Jan 2019 00:35:55 +0000 (00:35 +0000)] 
ARTEMIS-2241 Support direct deliver for InVMAcceptors

Push isDirectDeliver method from netty impl, to the Connection interface
Add support to InVMConnection for isDirectDeliver flag and ability to set via config, defaulting to false, to keep current default behavior.
Extend DirectDeliverTest to check InVM as well.

2 weeks agoThis closes #2527
Clebert Suconic [Wed, 30 Jan 2019 04:09:20 +0000 (23:09 -0500)] 
This closes #2527

2 weeks agoNO-JIRA add logging to LegacyLDAPSecuritySettingPlugin
Justin Bertram [Mon, 28 Jan 2019 17:40:48 +0000 (11:40 -0600)] 
NO-JIRA add logging to LegacyLDAPSecuritySettingPlugin

2 weeks agoARTEMIS-2242 Reverting regression caused by ARTEMIS-2229
Clebert Suconic [Tue, 29 Jan 2019 15:50:41 +0000 (10:50 -0500)] 
ARTEMIS-2242 Reverting regression caused by ARTEMIS-2229

Revert "ARTEMIS-2229 Qpid jms consumer cannot receive from multicast queue using FQQN"

This reverts commit 882da19c8a9a2ad12ca089d45445fe408d850330.

3 weeks agoThis closes #2520
Michael Andre Pearce [Mon, 28 Jan 2019 13:30:22 +0000 (13:30 +0000)] 
This closes #2520

3 weeks agoARTEMIS-2238 Enhancement to queueQuery on producer
Clebert Suconic [Fri, 25 Jan 2019 18:27:53 +0000 (13:27 -0500)] 
ARTEMIS-2238 Enhancement to queueQuery on producer

this is an adjustment on top of 33f56c81bdefa3492f722a67b5282b527545886c

3 weeks agoARTEMIS-2238 Enhancement to queueQuery on producer
Michael André Pearce [Fri, 25 Jan 2019 01:05:13 +0000 (01:05 +0000)] 
ARTEMIS-2238 Enhancement to queueQuery on producer

Move logic to ActiveMQSession
Use same method for createProducer, avoiding duplicated logic
Specific exception messages, for users

3 weeks agoARTEMIS-2238 Enhancement to queueQuery on producer
Clebert Suconic [Thu, 24 Jan 2019 21:01:21 +0000 (16:01 -0500)] 
ARTEMIS-2238 Enhancement to queueQuery on producer

3 weeks agoThis closes #2519
Clebert Suconic [Thu, 24 Jan 2019 19:35:18 +0000 (14:35 -0500)] 
This closes #2519

3 weeks agoARTEMIS-2238 Fixing QueueQuery on every single send on topics
Clebert Suconic [Thu, 24 Jan 2019 18:38:31 +0000 (13:38 -0500)] 
ARTEMIS-2238 Fixing QueueQuery on every single send on topics

3 weeks agoThis closes #2516
Clebert Suconic [Thu, 24 Jan 2019 19:34:27 +0000 (14:34 -0500)] 
This closes #2516

3 weeks agoARTEMIS-2192 fix listener for LegacyLDAPSecuritySettingPlugin
Justin Bertram [Thu, 24 Jan 2019 16:34:14 +0000 (10:34 -0600)] 
ARTEMIS-2192 fix listener for LegacyLDAPSecuritySettingPlugin

3 weeks agoThis closes #2518
Clebert Suconic [Thu, 24 Jan 2019 19:33:09 +0000 (14:33 -0500)] 
This closes #2518

3 weeks agoNO-JIRA fix race condition in QueueQueryTest
Justin Bertram [Thu, 24 Jan 2019 17:21:42 +0000 (11:21 -0600)] 
NO-JIRA fix race condition in QueueQueryTest

3 weeks agoThis closes #2427
Michael Andre Pearce [Thu, 24 Jan 2019 08:31:11 +0000 (08:31 +0000)] 
This closes #2427

3 weeks agoARTEMIS-2170 Optimized CoreMessage clearInternalProperties
Michael André Pearce [Mon, 21 Jan 2019 21:23:57 +0000 (21:23 +0000)] 
ARTEMIS-2170 Optimized CoreMessage clearInternalProperties

Ensure only iterate properties, if internal property is set.

3 weeks agoARTEMIS-2170 Optimized CoreMessage check and cleanup methods
Francesco Nigro [Sun, 11 Nov 2018 09:44:29 +0000 (10:44 +0100)] 
ARTEMIS-2170 Optimized CoreMessage check and cleanup methods

Any checkProperties();<usage of this.properties> pattern has been
replaced by an atomic checkProperties().<usage of returned properties>
to help both performance and consistency.
The cleanup is now performed into CoreTypedProperties both
for performance reasons (avoid lock/unlock many times)
and consistency, given that the operation is now atomic.

3 weeks agoThis closes #2305
Clebert Suconic [Thu, 24 Jan 2019 02:30:36 +0000 (21:30 -0500)] 
This closes #2305

3 weeks agoARTEMIS-2088 - Page.write() should throw exception if file is closed
Howard Gao [Fri, 14 Sep 2018 02:52:02 +0000 (10:52 +0800)] 
ARTEMIS-2088 - Page.write() should throw exception if file is closed

In Page.write(final PagedMessage message) if the page file is closed
it returns silently. The caller has no way to know that if the message
is paged to file or not. It should throw an exception so that the
caller can handle it correctly.

This causes random failure PagingTest#testExpireLargeMessageOnPaging().
The test shows that when the server stops it closes the page file.
In the mean time a message is expired to the expiry queue and if
the expiry queue is in paging mode, it goes to Page.write() and
returns without any error. The result is that the message is removed
from the original queue and not added to the expiry queue.

If we throw exception here it makes the expiration failed, the message
will not be removed from the orginal queue. Next time broker is started,
the message will be reloaded and expired again. no message lost.

3 weeks agoNO-JIRA Update year to 2019
Clebert Suconic [Thu, 24 Jan 2019 02:05:57 +0000 (21:05 -0500)] 
NO-JIRA Update year to 2019

3 weeks agoThis closes #2515
Clebert Suconic [Wed, 23 Jan 2019 18:32:10 +0000 (13:32 -0500)] 
This closes #2515

3 weeks agoARTEMIS-1867 fix FQQNOpenWireTest
Justin Bertram [Wed, 23 Jan 2019 17:32:02 +0000 (11:32 -0600)] 
ARTEMIS-1867 fix FQQNOpenWireTest

3 weeks agoARTEMIS-196 Removing dead variables
Clebert Suconic [Wed, 23 Jan 2019 18:28:28 +0000 (13:28 -0500)] 
ARTEMIS-196 Removing dead variables

Fixing build after removing variable used by FieldUpdater

3 weeks agoThis closes #2451
Clebert Suconic [Wed, 23 Jan 2019 16:52:33 +0000 (11:52 -0500)] 
This closes #2451

3 weeks agoARTEMIS-2192 LegacyLDAPSecuritySettingPlugin uses hard-coded RDN types
Justin Bertram [Thu, 4 Oct 2018 17:41:40 +0000 (12:41 -0500)] 
ARTEMIS-2192 LegacyLDAPSecuritySettingPlugin uses hard-coded RDN types

Change the LegacyLDAPSecuritySettingPlugin to interpret the search
results based on the order of the returned RDNs rather than hard-coded
types.

3 weeks agoThis closes #2490
Clebert Suconic [Wed, 23 Jan 2019 16:30:58 +0000 (11:30 -0500)] 
This closes #2490

3 weeks agoARTEMIS-196 Removing dead variables
Clebert Suconic [Wed, 23 Jan 2019 16:24:16 +0000 (11:24 -0500)] 
ARTEMIS-196 Removing dead variables

This is really a NO-JIRA
however it was done in the context of merging ARTEMIS-196

3 weeks agoARTEMIS-196 Implement Consumer Priority
Michael André Pearce [Thu, 10 Jan 2019 20:09:02 +0000 (20:09 +0000)] 
ARTEMIS-196 Implement Consumer Priority

Add consumer priority support
Includes refactor of consumer iterating in QueueImpl to its own logical class, to be able to implement.
Add OpenWire JMS Test - taken from ActiveMQ5
Add Core JMS Test
Add AMQP Test
Add Docs

3 weeks agoThis closes #2510
Clebert Suconic [Wed, 23 Jan 2019 15:17:03 +0000 (10:17 -0500)] 
This closes #2510

3 weeks agoARTEMIS-2156 Message Duplication when using exclusive divert and clustering
Luis De Bello [Sun, 20 Jan 2019 04:09:36 +0000 (01:09 -0300)] 
ARTEMIS-2156 Message Duplication when using exclusive divert and clustering

3 weeks agoThis closes #2514
Clebert Suconic [Wed, 23 Jan 2019 15:10:53 +0000 (10:10 -0500)] 
This closes #2514

3 weeks agoARTEMIS-2236 Address Latency Impact caused by ARTEMIS-1451
Michael André Pearce [Wed, 23 Jan 2019 09:59:15 +0000 (09:59 +0000)] 
ARTEMIS-2236 Address Latency Impact caused by ARTEMIS-1451

Readdress ARTEMIS-1451 concern of sync blocks, remove synchronization by simplifying original code and using atomics.

3 weeks agoARTEMIS-2236 - Revert Original ARTEMIS-1451
Michael André Pearce [Wed, 23 Jan 2019 09:52:24 +0000 (09:52 +0000)] 
ARTEMIS-2236 - Revert Original ARTEMIS-1451

This reverts commit f8b758d1

3 weeks agoThis closes #2506
Clebert Suconic [Tue, 22 Jan 2019 22:42:57 +0000 (17:42 -0500)] 
This closes #2506

3 weeks agoARTEMIS-2230 Exception closing advisory consumers when supportAdvisory=false
Howard Gao [Fri, 18 Jan 2019 02:32:25 +0000 (10:32 +0800)] 
ARTEMIS-2230 Exception closing advisory consumers when supportAdvisory=false

When broker's advisory is disabled (supportAdvisory=false) any
advisory consumer won't get created at broker and the advisory
consumer ID won't be stored.

Legacy openwire clients can have a reference of advisory consumer
regardless broker's settings and therefore when it closes the
advisory consumer the broker has no reference to it.
Therefore broker throws an exception like:

javax.jms.IllegalStateException: Cannot
remove a consumer that had not been registered

If the broker stores the consumer info (even it doesn't create
it) the exception can be avoided.

3 weeks agoThis closes #2473
Clebert Suconic [Tue, 22 Jan 2019 22:37:13 +0000 (17:37 -0500)] 
This closes #2473

3 weeks agoARTEMIS-1058 Jars in web tmp dir locked on Windows
Howard Gao [Fri, 18 Jan 2019 03:36:07 +0000 (11:36 +0800)] 
ARTEMIS-1058 Jars in web tmp dir locked on Windows

Because Sun's URLClassLoader never closes it's jar file handles
Jetty doesn't cleanup is temp web dir after Artemis broker shut
down normally on Windows.

To work around this a new process is forked before broker VM
exits to clean up the tmp dir if they are not deleted. The
new process out lives the main VM so that those jar's handles
are released and the temp dir can be cleaned up.

3 weeks agoNO-JIRA update shade plugin
Clebert Suconic [Tue, 22 Jan 2019 14:40:39 +0000 (09:40 -0500)] 
NO-JIRA update shade plugin

We were hitting a bug on shade, where shade was trying to download our own sources
instead of using from the local built repository.

3 weeks agoThis closes #2513
Francesco Nigro [Tue, 22 Jan 2019 11:08:28 +0000 (12:08 +0100)] 
This closes #2513

3 weeks agoARTEMIS-2235 - remove credentials from browser log
andytaylor [Tue, 22 Jan 2019 10:57:50 +0000 (10:57 +0000)] 
ARTEMIS-2235 - remove credentials from browser log

https://issues.apache.org/jira/browse/ARTEMIS-2235

3 weeks agoThis closes #2512
Francesco Nigro [Tue, 22 Jan 2019 10:54:28 +0000 (11:54 +0100)] 
This closes #2512

3 weeks agoRemove test scope for jaxrs module
Martyn Taylor [Wed, 4 Apr 2018 13:30:09 +0000 (14:30 +0100)] 
Remove test scope for jaxrs module

3 weeks agoAdd Interceptor Example
Martyn Taylor [Fri, 14 Dec 2018 14:20:38 +0000 (14:20 +0000)] 
Add Interceptor Example

3 weeks agoAdded ability to skip doc and website creation
Martyn Taylor [Wed, 10 Oct 2018 13:57:20 +0000 (14:57 +0100)] 
Added ability to skip doc and website creation

3 weeks agoThis closes #2511
Justin Bertram [Mon, 21 Jan 2019 20:20:57 +0000 (14:20 -0600)] 
This closes #2511

3 weeks agoARTEMIS-2234 fix warning from LoggingConfigurationFileReloader
Emmanuel Hugonnet [Mon, 21 Jan 2019 17:16:09 +0000 (18:16 +0100)] 
ARTEMIS-2234 fix warning from LoggingConfigurationFileReloader

return the LogContextConfiguration if we have one

4 weeks agoThis closes #2509
Howard Gao [Mon, 21 Jan 2019 05:27:53 +0000 (13:27 +0800)] 
This closes #2509

4 weeks agoNO-JIRA Fix Possible NPE in connectToNodeInReplicatedCluster
Michael André Pearce [Fri, 18 Jan 2019 23:09:53 +0000 (23:09 +0000)] 
NO-JIRA Fix Possible NPE in connectToNodeInReplicatedCluster

Variable possibleLive may be null, as signified by trace log above, also dedupe code.

4 weeks agoThis closes #2444
Michael Andre Pearce [Sat, 19 Jan 2019 08:16:09 +0000 (08:16 +0000)] 
This closes #2444

4 weeks agoARTEMIS-2186 Large message incomplete when server is crashed
yang wei [Wed, 28 Nov 2018 12:37:09 +0000 (20:37 +0800)] 
ARTEMIS-2186 Large message incomplete when server is crashed

4 weeks agoThis closes #2508
Michael Andre Pearce [Fri, 18 Jan 2019 22:42:40 +0000 (22:42 +0000)] 
This closes #2508

4 weeks agoNO-JIRA fix writableBuffer so that its only visible after sub statements
Michael André Pearce [Fri, 18 Jan 2019 22:41:17 +0000 (22:41 +0000)] 
NO-JIRA fix writableBuffer so that its only visible after sub statements

Potential race condition. This assignment to writableBuffer is visible to other threads before the subsequent statements are executed.

4 weeks agoThis closes #2434
Michael Andre Pearce [Fri, 18 Jan 2019 09:03:30 +0000 (09:03 +0000)] 
This closes #2434

4 weeks agoARTEMIS-1867 FQQN for producers
Justin Bertram [Mon, 12 Nov 2018 22:05:53 +0000 (16:05 -0600)] 
ARTEMIS-1867 FQQN for producers

There's a *slight* semantic change with the behavior of the queue query
and binding query to make them consistent with the address query, namely
that they will return the name of the queue and the name of the address
in every case and the returned names will be not use the FQQN syntax but
will be parsed to reflect their actual names in the broker.

4 weeks agoNO-JIRA de-duplicate createQueue()
Justin Bertram [Sat, 10 Nov 2018 02:17:39 +0000 (20:17 -0600)] 
NO-JIRA de-duplicate createQueue()

There were two different but nearly identical implementations of
createQueue(). I consolidated these into a single method. There should
be no semantic differences.

4 weeks agoThis closes #2507
Michael Andre Pearce [Fri, 18 Jan 2019 08:53:15 +0000 (08:53 +0000)] 
This closes #2507

4 weeks agoNO-JIRA Fix possible IOE
Michael André Pearce [Fri, 18 Jan 2019 08:33:49 +0000 (08:33 +0000)] 
NO-JIRA Fix possible IOE

This array access might be out of bounds, as the index might be equal to the array length.

4 weeks agoNO-JIRA Fix possible IOE
Michael André Pearce [Fri, 18 Jan 2019 08:20:14 +0000 (08:20 +0000)] 
NO-JIRA Fix possible IOE

id must be less than values.length,  values[id] array access might be out of bounds, as the index might be equal to the array length.

4 weeks agoNO-JIRA Fix double check locking in ActiveMQJMSContext
Michael André Pearce [Fri, 18 Jan 2019 08:16:10 +0000 (08:16 +0000)] 
NO-JIRA Fix double check locking in ActiveMQJMSContext

Double checked locking was operating on a non-volatile field this is not threadsafe, make field volatile.

4 weeks agoARTEMIS-2200 NPE fix
Clebert Suconic [Fri, 18 Jan 2019 02:51:24 +0000 (21:51 -0500)] 
ARTEMIS-2200 NPE fix

This was a typo on my last commit around ARTEMIS-2200