activemq-artemis.git
2 months agoThis closes #4077
Justin Bertram [Mon, 23 May 2022 16:53:44 +0000 (11:53 -0500)] 
This closes #4077

2 months agoARTEMIS-3830 add index on filename to large_messages
Alexander Schwab [Fri, 13 May 2022 12:31:18 +0000 (14:31 +0200)] 
ARTEMIS-3830 add index on filename to large_messages

2 months agoThis closes #4091
Justin Bertram [Mon, 23 May 2022 16:09:25 +0000 (11:09 -0500)] 
This closes #4091

2 months agoARTEMIS-3845 Update hawtio
Chuf [Sun, 22 May 2022 10:45:33 +0000 (12:45 +0200)] 
ARTEMIS-3845 Update hawtio

Update hawtio to 2.15.0 - drops support for Java8 and updates dependencies

2 months agoThis closes #4090
Justin Bertram [Mon, 23 May 2022 16:08:30 +0000 (11:08 -0500)] 
This closes #4090

2 months agoARTEMIS-3844 Update Maven dependencies
Chuf [Sun, 22 May 2022 10:09:07 +0000 (12:09 +0200)] 
ARTEMIS-3844 Update Maven dependencies

Update Maven Enforcer Plugin from 3.0.0-M3 to 3.0.0
Update Maven Bundle Plugin from 5.1.2 to 5.1.6
Update Maven Shade Plugin from 3.2.4 to 3.3.0

2 months agoThis closes #4061
Justin Bertram [Mon, 23 May 2022 15:57:50 +0000 (10:57 -0500)] 
This closes #4061

2 months agoARTEMIS-3808 support start/stop embedded web server via mngmnt
Justin Bertram [Mon, 9 May 2022 18:05:49 +0000 (13:05 -0500)] 
ARTEMIS-3808 support start/stop embedded web server via mngmnt

It would be useful to be able to cycle the embedded web server if, for
example, one needed to renew the SSL certificates. To support
functionality I made a handful of changes, e.g.:

 - Refactoring WebServerComponent so that all the necessary
   configuration would happen in the start() method.
 - Refactoring WebServerComponentTest to re-use code.

2 months ago[ARTEMIS-3700]: Provinding a JakartaEE 10 implementation.
Emmanuel Hugonnet [Mon, 23 May 2022 12:05:08 +0000 (14:05 +0200)] 
[ARTEMIS-3700]: Provinding a JakartaEE 10 implementation.

* Upgrading the API to Jakarta Messaging 3.1.0
* Updating the metadata to 3.1.0

Jira: https://issues.apache.org/jira/browse/ARTEMIS-3700
Signed-off-by: Emmanuel Hugonnet <ehugonne@redhat.com>
2 months agoARTEMIS-3837 Adding support for AMQPLargeMessage.getData()
Clebert Suconic [Tue, 17 May 2022 23:07:37 +0000 (19:07 -0400)] 
ARTEMIS-3837 Adding support for AMQPLargeMessage.getData()

2 months agoARTEMIS-3806 Upgrade jboss-logging dependencies
Dominik Lenoch [Tue, 17 May 2022 14:00:17 +0000 (16:00 +0200)] 
ARTEMIS-3806 Upgrade jboss-logging dependencies

Minor upgrade for jboss-logging from 3.4.3 to 3.5.0
Patch upgrade for jboss-logging-annotations from 2.2.0.Final to 2.2.1.Final
Patch upgrade for jboss-logging-processor from 2.2.0.Final to 2.2.1.Final

2 months agoARTEMIS-3835 - deprecate addressesSettings in place of addressSettings on the Configu...
Gary Tully [Mon, 16 May 2022 12:40:12 +0000 (13:40 +0100)] 
ARTEMIS-3835 - deprecate addressesSettings in place of addressSettings on the Configuration bean

2 months agoARTEMIS-3826 - allow address/queue configuration via properties
Gary Tully [Thu, 12 May 2022 11:37:10 +0000 (12:37 +0100)] 
ARTEMIS-3826 - allow address/queue configuration via properties

2 months agoARTEMIS-3833 Preserve JMSCorrelationID of distributed AMQP large messages
Domenico Francesco Bruscino [Mon, 16 May 2022 06:57:24 +0000 (08:57 +0200)] 
ARTEMIS-3833 Preserve JMSCorrelationID of distributed AMQP large messages

2 months agoARTEMIS-3836 PrintData may miss messages if cleanup happened in the middle of the...
Clebert Suconic [Fri, 13 May 2022 21:19:17 +0000 (17:19 -0400)] 
ARTEMIS-3836 PrintData may miss messages if cleanup happened in the middle of the stream

2 months agoARTEMIS-3838: Update to Netty 4.1.77 (and netty-tcnative to 2.0.52) 4083/head
Robbie Gemmell [Tue, 17 May 2022 10:40:54 +0000 (11:40 +0100)] 
ARTEMIS-3838: Update to Netty 4.1.77 (and netty-tcnative to 2.0.52)

3 months agoNO-JIRA Fix QueuesTest after ARTEMIS-3773
Domenico Francesco Bruscino [Wed, 11 May 2022 07:17:42 +0000 (09:17 +0200)] 
NO-JIRA Fix QueuesTest after ARTEMIS-3773

3 months agoARTEMIS-3770 mitigate potential NPE
Justin Bertram [Tue, 10 May 2022 17:12:35 +0000 (12:12 -0500)] 
ARTEMIS-3770 mitigate potential NPE

This was being triggered by
org.apache.activemq.artemis.tests.integration.routing.MQTTRedirectTest.

3 months agoARTEMIS-3825 Improve Print-data output with non existing queues
Clebert Suconic [Tue, 10 May 2022 17:49:24 +0000 (13:49 -0400)] 
ARTEMIS-3825 Improve Print-data output with non existing queues

3 months agoARTEMIS-3816 Fix connection router null pointer dereferences
Domenico Francesco Bruscino [Fri, 6 May 2022 11:18:35 +0000 (13:18 +0200)] 
ARTEMIS-3816 Fix connection router null pointer dereferences

3 months agoARTEMIS-3823 - limit modulo operation to positive hash values
Gary Tully [Mon, 9 May 2022 18:38:19 +0000 (19:38 +0100)] 
ARTEMIS-3823 - limit modulo operation to positive hash values

3 months agoThis closes #4021
Justin Bertram [Mon, 9 May 2022 19:51:06 +0000 (14:51 -0500)] 
This closes #4021

3 months agoARTEMIS-3770 refactor MQTT handling of client ID
Justin Bertram [Thu, 7 Apr 2022 21:33:29 +0000 (16:33 -0500)] 
ARTEMIS-3770 refactor MQTT handling of client ID

It would be useful for security manager implementations to be able to
alter the client ID of MQTT connections.

This commit supports this functionality by moving the code which handles
the client ID *ahead* of the authentication code. There it sets the
client ID on the connection and thereafter any component (e.g. security
managers) which needs to inspect or modify it can do so on the
connection.

This commit also refactors the MQTT connection class to extend the
abstract connection class. This greatly simplifies the MQTT connection
class and will make it easier to maintain in the future.

3 months agoARTEMIS-3817 SchedulePageCleanup operation on AddressControl
Clebert Suconic [Fri, 6 May 2022 16:47:25 +0000 (12:47 -0400)] 
ARTEMIS-3817 SchedulePageCleanup operation on AddressControl

3 months agoARTEMIS-3812 upgrade Micrometer
Justin Bertram [Tue, 3 May 2022 15:46:36 +0000 (10:46 -0500)] 
ARTEMIS-3812 upgrade Micrometer

3 months agoARTEMIS-3759 Add mirror controller address filter support
iliya [Tue, 26 Apr 2022 16:36:42 +0000 (19:36 +0300)] 
ARTEMIS-3759 Add mirror controller address filter support

Allow replication only certain addresses with mirror controller.
The configuration is similar to cluster address configuration.

Co-authored-by: Robbie Gemmell <robbie@apache.org>
3 months agoNO-JIRA: correct JUnit 4 license note, it was changed to EPL 1.0 in 2013
Robbie Gemmell [Wed, 4 May 2022 12:30:09 +0000 (13:30 +0100)] 
NO-JIRA: correct JUnit 4 license note, it was changed to EPL 1.0 in 2013

3 months agoARTEMIS-3814: update activemq deps to 5.17.1 4065/head
Robbie Gemmell [Wed, 4 May 2022 12:25:17 +0000 (13:25 +0100)] 
ARTEMIS-3814: update activemq deps to 5.17.1

3 months agoARTEMIS-3811 Cluster connections clashing with ANYCast addresses
Clebert Suconic [Tue, 3 May 2022 13:36:25 +0000 (09:36 -0400)] 
ARTEMIS-3811 Cluster connections clashing with ANYCast addresses

This is a test fix for AMQPClusterReplicaTest

3 months agoNO-JIRA clarify default for send-to-dla-on-no-route
Justin Bertram [Tue, 3 May 2022 16:15:28 +0000 (11:15 -0500)] 
NO-JIRA clarify default for send-to-dla-on-no-route

3 months agoARTEMIS-3810 Do not throw error resuming already active XA Transaction
Clebert Suconic [Mon, 2 May 2022 18:24:29 +0000 (14:24 -0400)] 
ARTEMIS-3810 Do not throw error resuming already active XA Transaction

3 months agoNO-JIRA stopping object on finalize on openWire test
Clebert Suconic [Fri, 29 Apr 2022 12:29:39 +0000 (08:29 -0400)] 
NO-JIRA stopping object on finalize on openWire test

trying to avoid a few test failure seen on CI

3 months agoARTEMIS-3807 Simplify Redistributor avoid races, and fix ProtocolMessageLoadBalancingTest
Clebert Suconic [Thu, 28 Apr 2022 23:35:26 +0000 (19:35 -0400)] 
ARTEMIS-3807 Simplify Redistributor avoid races, and fix ProtocolMessageLoadBalancingTest

The control existing in Redistributor is not needed as the Queue::deliver will already have a control on re-scheduling the loop and avoid holding references for too long.

3 months agoARTEMIS-3806 upgrade logging dependencies
Justin Bertram [Thu, 28 Apr 2022 15:24:42 +0000 (10:24 -0500)] 
ARTEMIS-3806 upgrade logging dependencies

3 months ago[maven-release-plugin] prepare for next development iteration
Clebert Suconic [Wed, 27 Apr 2022 21:26:46 +0000 (17:26 -0400)] 
[maven-release-plugin] prepare for next development iteration

3 months ago[maven-release-plugin] prepare release 2.22.0 2.22.0
Clebert Suconic [Wed, 27 Apr 2022 21:26:45 +0000 (17:26 -0400)] 
[maven-release-plugin] prepare release 2.22.0

3 months agoNO-JIRA fixing openTracingPluginTest
Clebert Suconic [Wed, 27 Apr 2022 20:03:30 +0000 (16:03 -0400)] 
NO-JIRA fixing openTracingPluginTest

3 months agoARTEMIS-3799 Fix default ping command pipe error for Windows
Domenico Francesco Bruscino [Wed, 27 Apr 2022 09:17:54 +0000 (11:17 +0200)] 
ARTEMIS-3799 Fix default ping command pipe error for Windows

3 months agoARTEMIS-3803 Fix first NetworkHealthCheck execution
Domenico Francesco Bruscino [Tue, 26 Apr 2022 15:18:53 +0000 (17:18 +0200)] 
ARTEMIS-3803 Fix first NetworkHealthCheck execution

The NetworkHealthCheck hasn't to execute the default command if a custom
command is defined.

3 months agoARTEMIS-3805 producer-window-size default
Clebert Suconic [Mon, 25 Apr 2022 13:58:14 +0000 (09:58 -0400)] 
ARTEMIS-3805 producer-window-size default

3 months agoARTEMIS-3802 Avoiding races on deleteWithID and Iterator.remove
Clebert Suconic [Mon, 25 Apr 2022 22:43:11 +0000 (18:43 -0400)] 
ARTEMIS-3802 Avoiding races on deleteWithID and Iterator.remove

3 months agoNO-JIRA: update release instructions to reflect change to CDN, and clarify some bits
Robbie Gemmell [Tue, 26 Apr 2022 15:39:27 +0000 (16:39 +0100)] 
NO-JIRA: update release instructions to reflect change to CDN, and clarify some bits

3 months agoARTEMIS-3799 Fix default ping command for Windows
Domenico Francesco Bruscino [Tue, 26 Apr 2022 13:49:14 +0000 (15:49 +0200)] 
ARTEMIS-3799 Fix default ping command for Windows

The Windows ping command doesn't fail on destination host unreachable

3 months agoNO-JIRA Fixing Thread Leakage on test from UDP thread
Clebert Suconic [Tue, 26 Apr 2022 15:52:06 +0000 (11:52 -0400)] 
NO-JIRA Fixing Thread Leakage on test from UDP thread

When running a UDP connection factory you have to either keep it running, or close it so the UDP thread is closed.
this is an issue for the testsuite as we validate for leaked threads. This needs to be fixed on the test.

3 months agoARTEMIS-3804: make the version number available to reference in the user manual,...
Robbie Gemmell [Tue, 26 Apr 2022 14:50:13 +0000 (15:50 +0100)] 
ARTEMIS-3804: make the version number available to reference in the user manual, add it to the intro page

Updates release instructions to note using the filtered scratch area from artemis-website for other builds

3 months agoARTEMIS-3801 fix test
Justin Bertram [Tue, 26 Apr 2022 14:53:38 +0000 (09:53 -0500)] 
ARTEMIS-3801 fix test

3 months agoARTEMIS-3800 Fixing failing test
Clebert Suconic [Tue, 26 Apr 2022 01:53:56 +0000 (21:53 -0400)] 
ARTEMIS-3800 Fixing failing test

3 months agoARTEMIS-3801 not getting messages on MQTT subscriptions with $
Justin Bertram [Mon, 25 Apr 2022 22:07:17 +0000 (17:07 -0500)] 
ARTEMIS-3801 not getting messages on MQTT subscriptions with $

3 months agoARTEMIS-3800 allow CLI to delete address with queues
Justin Bertram [Mon, 25 Apr 2022 18:09:13 +0000 (13:09 -0500)] 
ARTEMIS-3800 allow CLI to delete address with queues

3 months agoRevert "ARTEMIS-3707 ResourceAdapter Documentation"
Clebert Suconic [Mon, 25 Apr 2022 19:38:49 +0000 (15:38 -0400)] 
Revert "ARTEMIS-3707 ResourceAdapter Documentation"

This reverts commit 6b784daff1bb3ff178e4b501d6c60bdcf0b456ca.

3 months ago[ARTEMIS-3799]: Ping command is wrong on Windows.
Emmanuel Hugonnet [Mon, 25 Apr 2022 16:01:20 +0000 (18:01 +0200)] 
[ARTEMIS-3799]: Ping command is wrong on Windows.

* Changing the default ping command for Windows.

Jira: https://issues.apache.org/jira/browse/ARTEMIS-3799

3 months agoThis closes #4040
Clebert Suconic [Mon, 25 Apr 2022 13:44:36 +0000 (09:44 -0400)] 
This closes #4040

3 months agoARTEMIS-3798 Allow binary deserialization of message properties AMQ_MSG_MESSAGE_ID...
Marco Roehrs [Fri, 22 Apr 2022 13:35:27 +0000 (15:35 +0200)] 
ARTEMIS-3798 Allow binary deserialization of message properties AMQ_MSG_MESSAGE_ID, AMQ_MSG_ORIG_DESTINATION, AMQ_MSG_PRODUCER_ID & AMQ_MSG_REPLY_TO from existing messages.

co-authored: Justin Bertram contributed OpenWireMessageConverterTest changes

3 months agoARTEMIS-3707 ResourceAdapter Documentation
waldi5001 [Fri, 22 Apr 2022 18:24:52 +0000 (20:24 +0200)] 
ARTEMIS-3707 ResourceAdapter Documentation

3 months agoARTEMIS-3707 fix ra.xml
waldi5001 [Fri, 4 Mar 2022 20:46:42 +0000 (21:46 +0100)] 
ARTEMIS-3707 fix ra.xml

* update xml schemas
* fix ConnectionParameters
* remove TransactionManagerLocatorMethod and "The producer max rate"
* remove The max connections

3 months agoARTEMIS-3753 Small Improvement on RouterContext.internalOnly calculation
Clebert Suconic [Sat, 23 Apr 2022 15:17:24 +0000 (11:17 -0400)] 
ARTEMIS-3753 Small Improvement on RouterContext.internalOnly calculation

3 months agoThis closes #4012
Clebert Suconic [Sat, 23 Apr 2022 14:15:00 +0000 (10:15 -0400)] 
This closes #4012

3 months agoARTEMIS-3753 Prevent sending message to internal queues on mirror 4038/head
iliya [Mon, 4 Apr 2022 21:21:37 +0000 (00:21 +0300)] 
ARTEMIS-3753 Prevent sending message to internal queues on mirror

In cluster configuration messages could be routed to internal queues for
further delivering on different broker. We need to check that before
sending to SNF, otherwise message can stuck on target server and will
never receive ACK.

co-author: Clebert Suconic

Discusssions on https://github.com/apache/activemq-artemis/pull/4012 and https://github.com/apache/activemq-artemis/pull/4038

3 months agoARTEMIS-3756 Removing test that is now invalid
Clebert Suconic [Fri, 22 Apr 2022 15:27:54 +0000 (11:27 -0400)] 
ARTEMIS-3756 Removing test that is now invalid

3 months agoARTEMIS-3752: update to Spring 5.3.19 and Spring Boot 2.6.7 which uses it
Robbie Gemmell [Fri, 22 Apr 2022 09:16:55 +0000 (10:16 +0100)] 
ARTEMIS-3752: update to Spring 5.3.19 and Spring Boot 2.6.7 which uses it

3 months agoThis closes #4009
Clebert Suconic [Thu, 21 Apr 2022 23:10:00 +0000 (19:10 -0400)] 
This closes #4009

3 months ago[ARTEMIS-3756]: Enabling extra parameters to be passed by the URI.
Emmanuel Hugonnet [Thu, 7 Apr 2022 15:10:31 +0000 (17:10 +0200)] 
[ARTEMIS-3756]: Enabling extra parameters to be passed by the URI.

 * passing the full list of parameters when creating the URI.
 * moving the WARN message to DEBUG when unknown parameters are
   received.

Jira: https://issues.apache.org/jira/browse/ARTEMIS-3756

3 months agoARTEMIS-3755 mitigate NPE related to fail-back
Justin Bertram [Fri, 1 Apr 2022 18:15:21 +0000 (13:15 -0500)] 
ARTEMIS-3755 mitigate NPE related to fail-back

3 months agoARTEMIS-3771 Avoid not needed lookup for address on OpenWire connections
AntonRoskvist [Thu, 21 Apr 2022 19:12:27 +0000 (21:12 +0200)] 
ARTEMIS-3771 Avoid not needed lookup for address on OpenWire connections

3 months agoARTEMIS-3788 don't send MQTT will message if will flag = false
Justin Bertram [Wed, 20 Apr 2022 17:01:33 +0000 (12:01 -0500)] 
ARTEMIS-3788 don't send MQTT will message if will flag = false

3 months agoThis closes #4037
Clebert Suconic [Thu, 21 Apr 2022 19:34:30 +0000 (15:34 -0400)] 
This closes #4037

3 months agoARTEMIS-3789 respect session expiry interval on MQTT disconnect message
Justin Bertram [Wed, 20 Apr 2022 17:33:51 +0000 (12:33 -0500)] 
ARTEMIS-3789 respect session expiry interval on MQTT disconnect message

3 months agoARTEMIS-3791 Openwire failover leaving sessions leaked
Clebert Suconic [Wed, 20 Apr 2022 21:39:13 +0000 (17:39 -0400)] 
ARTEMIS-3791 Openwire failover leaving sessions leaked

3 months agoARTEMIS-3765 Fixing testsuite
Clebert Suconic [Thu, 21 Apr 2022 01:20:07 +0000 (21:20 -0400)] 
ARTEMIS-3765 Fixing testsuite

we cannot really change the attribute's name as it may break user's applications.
I am adding the previous property here.

3 months agoARTEMIS-3786 - ensure named properties config from routerConfiguration can be created...
Gary Tully [Wed, 20 Apr 2022 15:51:24 +0000 (16:51 +0100)] 
ARTEMIS-3786 - ensure named properties config from routerConfiguration can be created from string property value

3 months agoARTEMIS-3780 - OpenWire, UTF8Buffer to String before setting properties to avoid...
AntonRoskvist [Tue, 19 Apr 2022 10:42:09 +0000 (12:42 +0200)] 
ARTEMIS-3780 - OpenWire, UTF8Buffer to String before setting properties to avoid exception

3 months agoARTEMIS-3781 send PUBREC on duplicate PUBLISH for MQTT QoS 2
Justin Bertram [Tue, 19 Apr 2022 18:04:20 +0000 (13:04 -0500)] 
ARTEMIS-3781 send PUBREC on duplicate PUBLISH for MQTT QoS 2

The MQTT 5 (and 3.1.1) specification states:

    Until it has received the corresponding PUBREL packet, the receiver
MUST acknowledge any subsequent PUBLISH packet with the same Packet
Identifier by sending a PUBREC. It MUST NOT cause duplicate messages to
be delivered to any onward recipients in this case [MQTT-4.3.3-10].

The broker prevents a duplicate message, but it doesn't respond with a
PUBREC. This commit fixes that.

3 months agoNO-JIRA Fix MQTT trace logging NPE
Justin Bertram [Tue, 19 Apr 2022 17:39:56 +0000 (12:39 -0500)] 
NO-JIRA Fix MQTT trace logging NPE

3 months agoARTEMIS-3783: rationalise config for alternate jakarta spec versions to simplify... 4033/head
Robbie Gemmell [Wed, 20 Apr 2022 09:57:32 +0000 (10:57 +0100)] 
ARTEMIS-3783: rationalise config for alternate jakarta spec versions to simplify and align their use

3 months agoARTEMIS-3782: use existing managed version for maven-shade-plugin uses
Robbie Gemmell [Wed, 20 Apr 2022 09:33:57 +0000 (10:33 +0100)] 
ARTEMIS-3782: use existing managed version for maven-shade-plugin uses

3 months agoThis closes #4019
Justin Bertram [Tue, 19 Apr 2022 14:49:31 +0000 (09:49 -0500)] 
This closes #4019

3 months agoARTEMIS-3765 Display validated user in Hawtio
aaron.hoffer [Mon, 4 Apr 2022 20:34:46 +0000 (13:34 -0700)] 
ARTEMIS-3765 Display validated user in Hawtio

This PR adds a "Validated User" column to the Hawtio plugin. The column is
not visible by default. The "Validated User" column is available in the
Session, Consumer, and Producer tabs of the artemis-navigation notebook.
"Validated User" is also available for sort and filtering in those view.
The "Validated Consumer" in the Producer view is always blank. I debugged
as far as I could, but did not find the cause of the issue.

3 months agoARTEMIS-3775 don't carry forward MQTT topic aliases to new connection
Justin Bertram [Tue, 12 Apr 2022 18:55:12 +0000 (13:55 -0500)] 
ARTEMIS-3775 don't carry forward MQTT topic aliases to new connection

3 months agoARTEMIS-3777 fix MQTT request/response + nolocal
Justin Bertram [Wed, 13 Apr 2022 16:45:14 +0000 (11:45 -0500)] 
ARTEMIS-3777 fix MQTT request/response + nolocal

Removing the connection ID property from the actual *message* breaks the
nolocal functionality. Removing the property isn't necessary in the
first place so this commit reomves that code.

3 months agoNO-JIRA improve MQTT trace logging
Justin Bertram [Wed, 13 Apr 2022 03:40:12 +0000 (22:40 -0500)] 
NO-JIRA improve MQTT trace logging

3 months agoThis closes #4030
Clebert Suconic [Mon, 18 Apr 2022 19:11:47 +0000 (15:11 -0400)] 
This closes #4030

3 months agoARTEMIS-3751 Do not override large message size
iliya [Sun, 17 Apr 2022 10:15:47 +0000 (13:15 +0300)] 
ARTEMIS-3751 Do not override large message size

It is possible to receive a compressed message from the client as regular message. Such a message will already contain correct body size, that takes compression into account.

3 months agoARTEMIS-3779 Critial IO Exception logged as Error
Clebert Suconic [Thu, 14 Apr 2022 22:03:50 +0000 (18:03 -0400)] 
ARTEMIS-3779 Critial IO Exception logged as Error

3 months agoARTEMIS-3778 Just avoiding NPE on Expiry Reaper
Clebert Suconic [Thu, 14 Apr 2022 21:12:39 +0000 (17:12 -0400)] 
ARTEMIS-3778 Just avoiding NPE on Expiry Reaper

Added an extra check on null, just in case
it should not happen, but I preferred adding this clause on the safe side

3 months agoARTEMIS-3778 Streamline Expiration Reaping
Clebert Suconic [Wed, 13 Apr 2022 17:17:44 +0000 (13:17 -0400)] 
ARTEMIS-3778 Streamline Expiration Reaping

Instead of holding a thread and an iterator, we should instead keep moving to next references
without holding any threads. Just with callbacks.

3 months agoARTEMIS-3776 just my OCD applying aesthetic tweaks to recediveOW.groovy
Clebert Suconic [Wed, 13 Apr 2022 16:34:30 +0000 (12:34 -0400)] 
ARTEMIS-3776 just my OCD applying aesthetic tweaks to recediveOW.groovy

3 months agoARTEMIS-3776 Avoid Integer.MAX_VALUE overflow on openwire clients
Clebert Suconic [Wed, 13 Apr 2022 01:58:13 +0000 (21:58 -0400)] 
ARTEMIS-3776 Avoid Integer.MAX_VALUE overflow on openwire clients

Older versions of Openwire clients wil be affected by AMQ-6431.
As a result of the issue if the ID of the message>Integer.MAX_VALUE
a consumer configured with Failover and doing duplicate detection on the client
will not be able to process duplicate detection accordingly and miss messages.

3 months agoARTEMIS-3773 remove defunct rate references from web console
Justin Bertram [Fri, 8 Apr 2022 18:25:04 +0000 (13:25 -0500)] 
ARTEMIS-3773 remove defunct rate references from web console

This is a follow-up from ARTEMIS-3397. This commit removes the last
traces of the "rate" queue metric from the web console.

3 months agoARTEMIS-3774 support user properties on MQTT will message
Justin Bertram [Tue, 12 Apr 2022 15:05:03 +0000 (10:05 -0500)] 
ARTEMIS-3774 support user properties on MQTT will message

4 months agoARTEMIS-3772: update to mockito 4.4.0 4022/head
Robbie Gemmell [Fri, 8 Apr 2022 12:38:41 +0000 (13:38 +0100)] 
ARTEMIS-3772: update to mockito 4.4.0

4 months agoARTEMIS-3761 Improve page cleanup to remove messages in the middle of the stream...
Clebert Suconic [Fri, 1 Apr 2022 02:01:30 +0000 (22:01 -0400)] 
ARTEMIS-3761 Improve page cleanup to remove messages in the middle of the stream as well

Paging only removes files at the beginning of the stream...
Say you have paged files 1 through 1000...
if all the messages are ack, but one message on file 1 is missing an ack, all the 999 subsequent files would not be removed until all the messages on file 1 is ack.
This was working as engineered, but sometimes devs don't have complete control on their app.
With this improvement we will now remove messages in the middle of the stream as well.

There is also some improvement to how browsing and page work with this

4 months agoARTEMIS-3769 Fixing queue browsing iterator avoiding NoSuchElement exception from...
Clebert Suconic [Thu, 7 Apr 2022 13:19:16 +0000 (09:19 -0400)] 
ARTEMIS-3769 Fixing queue browsing iterator avoiding NoSuchElement exception from the Iteration

QueueImpl::browserIterator could throw NoSuchElementException and this is fixing the iterator
Found this while testing ARTEMIS-3761

4 months agoNO-JIRA Making AmqpFlowControlFailTest more accurate
Clebert Suconic [Tue, 5 Apr 2022 22:18:27 +0000 (18:18 -0400)] 
NO-JIRA Making AmqpFlowControlFailTest more accurate

this test was relying on internal details such as number of credits on the link.
The test was flaky and eventually failing or hunging.

4 months agoARTEMIS-3768: update to Qpid JMS 1.6.0
Robbie Gemmell [Thu, 7 Apr 2022 11:58:38 +0000 (12:58 +0100)] 
ARTEMIS-3768: update to Qpid JMS 1.6.0

4 months agoARTEMIS-3758: clean up lots of tests that never run, remove related files + dependenc... 4010/head
Robbie Gemmell [Mon, 4 Apr 2022 14:28:06 +0000 (15:28 +0100)] 
ARTEMIS-3758: clean up lots of tests that never run, remove related files + dependencies and some unnecessary deps

4 months agoARTEMIS-3762: update docs build, add version overrides to clear security warnings 4016/head
Robbie Gemmell [Wed, 6 Apr 2022 15:07:06 +0000 (16:07 +0100)] 
ARTEMIS-3762: update docs build, add version overrides to clear security warnings

4 months agoThis closes #4014
Robbie Gemmell [Thu, 7 Apr 2022 10:01:06 +0000 (11:01 +0100)] 
This closes #4014

4 months agoARTEMIS-3760 Upgrade jackson version to 2.13.2
Domenico Francesco Bruscino [Tue, 5 Apr 2022 07:45:34 +0000 (09:45 +0200)] 
ARTEMIS-3760 Upgrade jackson version to 2.13.2

4 months agoARTEMIS-3764 wrong CONNACK return code for MQTT5
Justin Bertram [Wed, 6 Apr 2022 16:38:29 +0000 (11:38 -0500)] 
ARTEMIS-3764 wrong CONNACK return code for MQTT5

This bug is causing tests in o.a.a.a.t.i.m.s.c.ConnectTestsWithSecurity
to fail.

This commit fixes the problem by setting the session's version earlier
in the logic handling the CONNECT packet so that the proper CONNACK
return code can be supplied to the remote client in case of
authentication failure.

4 months agoensure temp files are off the base class temp folder rule root to get cleaned up...
Gary Tully [Tue, 5 Apr 2022 12:15:44 +0000 (13:15 +0100)] 
ensure temp files are off the base class temp folder rule root to get cleaned up post test