Unit tests for Docker Local implementation
authorDavid Bosschaert <davidb@apache.org>
Thu, 1 Jun 2017 16:34:04 +0000 (18:34 +0200)
committerDavid Bosschaert <davidb@apache.org>
Thu, 1 Jun 2017 16:34:04 +0000 (18:34 +0200)
containers-docker-local/src/main/java/org/apache/aries/containers/docker/local/impl/LocalDockerController.java
containers-docker-local/src/main/java/org/apache/aries/containers/docker/local/impl/ProcessRunner.java
containers-docker-local/src/test/java/org/apache/aries/containers/docker/local/impl/LocalDockerControllerTest.java [new file with mode: 0644]

index cf3ede1..4904c20 100644 (file)
@@ -28,7 +28,7 @@ class LocalDockerController {
         return kill(id, "KILL");
     }
 
-    private String kill(String id, String signal) throws Exception {
+    public String kill(String id, String signal) throws Exception {
         return runCommandExpectSingleID("docker", "kill", "-s", signal, id);
     }
 
@@ -91,7 +91,7 @@ class LocalDockerController {
         return res;
     }
 
-    private String runCommand(String... command) {
+    String runCommand(String... command) {
         return ProcessRunner.waitFor(ProcessRunner.run(command));
     }
 }
index f9284ad..18e7ac0 100644 (file)
@@ -76,6 +76,9 @@ public class ProcessRunner {
     }
 
     public static String waitFor(final Process process) {
+        if (process == null)
+            return null;
+
         try {
             process.waitFor();
             String res = new String(Streams.suck(process.getInputStream())).trim();
diff --git a/containers-docker-local/src/test/java/org/apache/aries/containers/docker/local/impl/LocalDockerControllerTest.java b/containers-docker-local/src/test/java/org/apache/aries/containers/docker/local/impl/LocalDockerControllerTest.java
new file mode 100644 (file)
index 0000000..4581a35
--- /dev/null
@@ -0,0 +1,74 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.aries.containers.docker.local.impl;
+
+import org.junit.AfterClass;
+import org.junit.BeforeClass;
+import org.junit.Test;
+
+import static org.junit.Assert.assertArrayEquals;
+import static org.junit.Assert.assertEquals;
+
+public class LocalDockerControllerTest {
+    @BeforeClass
+    public static void setupClass() {
+        System.setProperty(ProcessRunner.SKIP_RUN, "true");
+    }
+
+    @AfterClass
+    public static void teardownClass() {
+        System.setProperty(ProcessRunner.SKIP_RUN, "false");
+    }
+
+    @Test
+    public void testKill() throws Exception {
+        LocalDockerController ldc = new LocalDockerController() {
+            @Override
+            String runCommandExpectSingleID(String... command) throws Exception {
+                assertArrayEquals(new String [] {"docker", "kill", "-s", "KILL", "123abc"}, command);
+                return "ok";
+            }
+        };
+        assertEquals("ok", ldc.kill("123abc"));
+    }
+
+    @Test
+    public void testKillSignal() throws Exception {
+        LocalDockerController ldc = new LocalDockerController() {
+            @Override
+            String runCommandExpectSingleID(String... command) throws Exception {
+                assertArrayEquals(new String [] {"docker", "kill", "-s", "TERM", "123abc"}, command);
+                return "ok";
+            }
+        };
+        assertEquals("ok", ldc.kill("123abc", "TERM"));
+    }
+
+    @Test
+    public void testRemove() throws Exception {
+        LocalDockerController ldc = new LocalDockerController() {
+            @Override
+            String runCommandExpectSingleID(String... command) throws Exception {
+                assertArrayEquals(new String [] {"docker", "rm", "-f", "123abc"}, command);
+                return "ok";
+            }
+        };
+        assertEquals("ok", ldc.remove("123abc"));
+    }
+}