14 months agoCASSANDRA-16729 -
David Capwell [Thu, 10 Jun 2021 23:35:22 +0000 (16:35 -0700)] 
CASSANDRA-16729 - uses retries to avoid flakyness

patch by David Capwell; reviewed by Brandon Williams for CASSANDRA-16729

14 months agoCASSANDRA-16728 - test_tombstone_failure_threshold_message assert checking if array...
David Capwell [Wed, 9 Jun 2021 23:01:18 +0000 (16:01 -0700)] 
CASSANDRA-16728 - test_tombstone_failure_threshold_message assert checking if array == string, should check for array truthiness
patch by David Capwell; reviewed by Yifan Cai for CASSANDRA-16728

14 months agoMove flaky in-jvm fql dtest to python
Brandon Williams [Wed, 9 Jun 2021 13:48:08 +0000 (08:48 -0500)] 
Move flaky in-jvm fql dtest to python

Patch by brandonwilliams; reviewed by edimitrova for CASSANDRA-16720

14 months agodtest for setting hostId upon node startup
fibersel [Wed, 26 May 2021 23:49:56 +0000 (02:49 +0300)] 
dtest for setting hostId upon node startup

patch by Abi Palagashvili; reviewed by Stefan Miklosovic and Paulo Motta for CASSANDRA-14582

14 months agoFlaky TestConsistency.test_13880
Bereng [Mon, 7 Jun 2021 07:50:09 +0000 (09:50 +0200)] 
Flaky TestConsistency.test_13880

patch by Berenguer Blasi; reviewed by Andres de la Peña for CASSANDRA-16716

14 months agoAdd 4.0.0 branch
Brandon Williams [Thu, 3 Jun 2021 16:46:39 +0000 (11:46 -0500)] 
Add 4.0.0 branch

14 months agoFailure to execute queries should emit a KPI other than read timeout/unavailable...
David Capwell [Fri, 14 May 2021 22:53:41 +0000 (15:53 -0700)] 
Failure to execute queries should emit a KPI other than read timeout/unavailable so it can be alerted/tracked

patch by David Capwell; reviewed by Sam Tunnicliffe for CASSANDRA-16581

14 months agoninja fix six >=1.12.0
Brandon Williams [Wed, 26 May 2021 21:51:39 +0000 (16:51 -0500)] 
ninja fix six >=1.12.0

14 months agoFlaky TestPaxos.test_replica_availability
Bereng [Tue, 25 May 2021 06:46:07 +0000 (08:46 +0200)] 
Flaky TestPaxos.test_replica_availability

patch by Berenguer Blasi; reviewed by Ekaterina Dimitrova for CASSANDRA-16693

14 months agoDon't pip install ccm in editable mode. Because of the "movable" cassandra-test tag...
Mick Semb Wever [Sun, 23 May 2021 15:45:33 +0000 (17:45 +0200)] 
Don't pip install ccm in editable mode. Because of the "movable" cassandra-test tag, pip needs to re-install ccm each time.

 patch by Mick Semb Wever; reviewed by David Capwell, Berenguer Blasi, Ekaterina Dimitrova for CASSANDRA-16688

14 months agoStandaloneVerifier does not fail when unable to verify SSTables, it only fails if...
David Capwell [Fri, 21 May 2021 22:50:06 +0000 (15:50 -0700)] 
StandaloneVerifier does not fail when unable to verify SSTables, it only fails if Corruption is thrown

patch by David Capwell; reviewed by Marcus Eriksson for CASSANDRA-16683

14 months agoFix paxos_test::test_cluster_availability
Ekaterina Dimitrova [Mon, 17 May 2021 23:53:04 +0000 (19:53 -0400)] 
Fix paxos_test::test_cluster_availability
authored by Ekaterina Dimitrova; reviewed by Berenguer Blasi for CASSANDRA-16657

14 months agoFix jmx_test
Brandon Williams [Tue, 18 May 2021 22:23:34 +0000 (17:23 -0500)] 
Fix jmx_test

14 months agoadd bloom filter false ratio tests
Jaroslaw Grabowski [Tue, 26 May 2020 12:45:07 +0000 (14:45 +0200)] 
add bloom filter false ratio tests

Patch by Jaroslaw Grabowski, reviewed by brandonwilliams and paulo for

Verifies if BloomFilterFalseRatio takes into account true negatives.
Without this fix, the following scenario (many reads for non-existing
rows) would yield BloomFilterFalseRatio=1.0. With the fix we assume
it should be less then the default bloom_filter_fp_chance.

14 months agoFlaky TestTransientReplicationRing.test_move_backwards_and_cleanup
Bereng [Mon, 10 May 2021 05:28:56 +0000 (07:28 +0200)] 
Flaky TestTransientReplicationRing.test_move_backwards_and_cleanup

patch by Berenguer Blasi; reviewed by Ekaterina Dimitrova for CASSANDRA-16644

15 months agoMove CASSANDRA-14559s
David Capwell [Thu, 13 May 2021 19:42:44 +0000 (12:42 -0700)] 
Move CASSANDRA-14559s into a jvm-dtest

patch by David Capwell; reviewed by Stefan Miklosovic for CASSANDRA-16662

15 months agoFix test_counters upgrade test for 4.0
Andrés de la Peña [Wed, 12 May 2021 19:48:23 +0000 (20:48 +0100)] 
Fix test_counters upgrade test for 4.0

patch by Andrés de la Peña; reviewed by Ekaterina Dimitrova for CASSANDRA-16653

15 months agopython test failures caused by error checks not filtering JAVA_TOOL_OPTIONS
David Capwell [Thu, 6 May 2021 21:27:42 +0000 (14:27 -0700)] 
python test failures caused by error checks not filtering JAVA_TOOL_OPTIONS

patch by David Capwell; reviewed by Benjamin Lerer for CASSANDRA-16660

15 months agoAdd 4_0_x to Python DTest's upgrade_manifest
Bereng [Tue, 4 May 2021 08:06:44 +0000 (10:06 +0200)] 
Add 4_0_x to Python DTest's upgrade_manifest

patch by Berenguer Blasi; reviewed by Mick Semb Wever for CASSANDRA-16648

Co-authored-by: Mick Semb Wever <>
Co-authored-by: Bereng <>
15 months agoAdd gossip tests that were useful while validating CASSANDRA-16588
Matt Fleming [Mon, 26 Apr 2021 11:10:18 +0000 (12:10 +0100)] 
Add gossip tests that were useful while validating CASSANDRA-16588

Patch by Matt Fleming; reviewed by brandonwilliams for CASSANDRA-16632

15 months agoFix flaky test_pending_range
Andrés de la Peña [Wed, 21 Apr 2021 15:53:39 +0000 (16:53 +0100)] 
Fix flaky test_pending_range

patch by Andrés de la Peña; reviewed by Berenguer Blasi for CASSANDRA-16614

Co-authored-by: Andrés de la Peña <>
Co-authored-by: Bereng <>
15 months agoRemove references to in the README
Matt Fleming [Wed, 21 Apr 2021 13:32:22 +0000 (14:32 +0100)] 
Remove references to in the README
Authored by Matt Fleming; reviewed by Michael Semb Wever and Ekaterina Dimitrova for CASSANDRA-16623

16 months agoAdd test for bootstrap when schema changes with removed nodes
Brandon Williams [Thu, 8 Apr 2021 14:41:57 +0000 (09:41 -0500)] 
Add test for bootstrap when schema changes with removed nodes

Patch by brandonwilliams, reviewed by Adam Holmberg, adelpena and
bdeggleston for CASSANDRA-16577

16 months agoRelax timeouts and less concurrency for test_contention_many_threads
Adam Holmberg [Fri, 26 Mar 2021 00:16:41 +0000 (00:16 +0000)] 
Relax timeouts and less concurrency for test_contention_many_threads
authored by Adam Holmberg; reviewed by Ekaterina Dimitrova and Benjamin Lerer for CASSANDRA-13517

16 months agosimplify/harden GPFS test
Brandon Williams [Wed, 17 Mar 2021 20:42:59 +0000 (15:42 -0500)] 
simplify/harden GPFS test

Patch by brandonwilliams, reviewed by edimitrova for CASSANDRA-13196

16 months agoRemove flaky annotation from `test_resumable_rebuild` and add ignore-log pattern.
Gianluca Righetto [Mon, 22 Mar 2021 06:40:43 +0000 (03:40 -0300)] 
Remove flaky annotation from `test_resumable_rebuild` and add ignore-log pattern.

 patch by Gianluca Righetto; reviewed by Ekaterina Dimitrova, Mick Semb Wever, Zhao Yang for CASSANDRA-15892

16 months agoFix flaky test_ttl_deletions
Bereng [Mon, 22 Mar 2021 10:42:46 +0000 (11:42 +0100)] 
Fix flaky test_ttl_deletions
patch authored by Berenguer Blasi; reviewed by Ekaterina Dimitrova and Andres de la Pena for CASSANDRA-16530

16 months agoReduce data amount and allow one read for reset interval
Brandon Williams [Fri, 12 Mar 2021 19:41:52 +0000 (13:41 -0600)] 
Reduce data amount and allow one read for reset interval

Patch by brandonwilliams; reviewed by Berenguer Blasi for

17 months agoTests fixed and new ones added for CASSANDRA-15897
Ekaterina Dimitrova [Fri, 11 Dec 2020 15:06:19 +0000 (10:06 -0500)] 
Tests fixed and new ones added for CASSANDRA-15897

patch by Ekaterina Dimitrova; reviewed by Benjamin Lerer and Brandon Williams

17 months agoInclude column selections in TestCQLSlowQuery
Andrés de la Peña [Wed, 10 Mar 2021 17:39:07 +0000 (17:39 +0000)] 
Include column selections in TestCQLSlowQuery

patch by Andrés de la Peña; reviewed by Benjamin Lerer for CASSANDRA-16483

17 months agoAdd annotations to stop running batch write and hinted handoff tests that have been...
Caleb Rackliffe [Mon, 8 Mar 2021 17:13:52 +0000 (17:13 +0000)] 
Add annotations to stop running batch write and hinted handoff tests that have been ported to the in-JVM framework in 4.0

patch by Caleb Rackliffe; reviewed by Andrés de la Peña and Ekaterina Dimitrova for CASSANDRA-16181#

17 months agoincremental_repair_test's test_manual_session_fail, test_manual_session_cancel_non_co...
Marcus Eriksson [Mon, 22 Feb 2021 13:21:09 +0000 (14:21 +0100)] 
incremental_repair_test's test_manual_session_fail, test_manual_session_cancel_non_coordinator_failure and test_manual_session_force_cancel,  migrated to in-jvm dtests

 patch by Marcus Eriksson; reviewed by Adam Holmberg, Mick Semb Wever for CASSANDRA-16425

17 months agoAdd checks to test the RepairMetrics.previewFailures counter
Yasar Arafath Baigh [Fri, 20 Nov 2020 02:51:49 +0000 (08:21 +0530)] 
Add checks to test the RepairMetrics.previewFailures counter

patch by Yasar Arafath Baigh; reviewed by Adam Holmberg, Andrés de la Peña and Benjamin
Lerer for CASSANDRA-16191

17 months agofix
Mick Semb Wever [Sat, 27 Feb 2021 10:07:15 +0000 (11:07 +0100)] 

Patch by mck; reviewed by brandonwilliams for CASSANDRA-16381

17 months agoadd simple removenode test
Brandon Williams [Mon, 1 Feb 2021 23:47:54 +0000 (17:47 -0600)] 
add simple removenode test

Patch by brandonwilliams; reviwed by mck for CASSANDRA-16381

17 months agoFix selections of JDKs in debian docker images on arm64
Mick Semb Wever [Sun, 7 Feb 2021 10:38:06 +0000 (11:38 +0100)] 
Fix selections of JDKs in debian docker images on arm64

 patch by Mick Semb Wever; reviewed by Zhao Renhai,Brandon Williams for CASSANDRA-16428

17 months agoFix reg exp in replication_test.TestReplication.test_network_topology to include...
Bereng [Thu, 25 Feb 2021 09:58:19 +0000 (10:58 +0100)] 
Fix reg exp in replication_test.TestReplication.test_network_topology to include 4.0 verbs

 patch by Berenguer Blasi; reviewed by Mick Semb Wever for CASSANDRA-16469

17 months agoUpdate dtests following CASSANDRA-14973 (#127)
Sam Tunnicliffe [Thu, 25 Feb 2021 19:49:02 +0000 (19:49 +0000)] 
Update dtests following CASSANDRA-14973 (#127)

* Specify v5 for pushed notification test if available
* Add v5 to cqlsh protocol negotiation test
* Default to v5 for 4.0

Patch by Sam Tunnicliffe; reviewed by Brandon Williams for CASSANDRA-14973

17 months agoDisable autocompaction during snapshot test
Brandon Williams [Tue, 23 Feb 2021 23:25:51 +0000 (17:25 -0600)] 
Disable autocompaction during snapshot test

Patch by brandonwilliams; reviewed by mck for CASSANDRA-16441

17 months agoAdd tests for parent repair session cleanup
jtgrabowski [Wed, 24 Feb 2021 18:50:46 +0000 (18:50 +0000)] 
Add tests for parent repair session cleanup

patch by Jaroslaw Grabowski and Berenguer Blasi; reviewed by Ekaterina Dimitrova and Andrés de la Peña for CASSANDRA-16446

Co-authored-by: jtgrabowski <>
Co-authored-by: Bereng <>
17 months agoFix Cassandra version families, and more…
jacek-lewandowski [Tue, 9 Feb 2021 16:23:21 +0000 (17:23 +0100)] 
Fix Cassandra version families, and more…

 - Remove OVERRIDE_MANIFEST, as it is unused.
 - Upgrade manifest, remove upgrades from unsupported indev versions, and remove upgrades to current if indev is still supported.
 - Correct the enforced protocol version to use v3 for 2.2/3.0 upgrades. (ref: CASSANDRA-15193)
 - Fix broken
 - Fix (not applicable before 3.11.6, ref: CASSANDRA-15035)
 - Remove hardcoded references to gitbox.a.o
 - Remove unnecessary implicit upgrade scenarios. `--upgrade-target-version-only` only tests upgrades from the target version and to the target version, i.e. those upgrade paths where the target (indev) version was the origin or destination version. Previously the filter was applied only for the version family but not on the variant, pulling in completely unrelated upgrade scenarios.

 patch by Jacek Lewandowski; reviewed by Tomek Łasica, Mick Semb Wever for CASSANDRA-16433

17 months agoAdd explicit DC to tests where we have multidc setup
Bereng [Mon, 15 Feb 2021 07:13:22 +0000 (08:13 +0100)] 
Add explicit DC to tests where we have multidc setup

 patch by Berenguer Blasi; reviewed by Ekaterina Dimitrova, Tomek Łasica, Andres de la Peña for CASSANDRA-16411

17 months agoAdd test to verify that a node can join when RF > N in multi-DC
Bereng [Thu, 18 Feb 2021 11:46:32 +0000 (11:46 +0000)] 
Add test to verify that a node can join when RF > N in multi-DC

patch by Berenguer Blasi; reviewed by Andrés de la Peña, Ekaterina Dimitrova and Tomasz Lasica for CASSANDRA-16296

17 months agoMark tests for short read protection and put-get tests as ported to in-JVM
Andrés de la Peña [Mon, 30 Nov 2020 18:05:04 +0000 (18:05 +0000)] 
Mark tests for short read protection and put-get tests as ported to in-JVM

patch by Andrés de la Peña; reviewed by Caleb Rackliffe, Alex Petrov and Blake Eggleston for CASSANDRA-16180

18 months agoUpdate requirements.txt with the new ccm update strategy
Ekaterina Dimitrova [Wed, 10 Feb 2021 17:57:49 +0000 (12:57 -0500)] 
Update requirements.txt with the new ccm update strategy
Patch by Ekaterina Dimitrova, reviewed by Michael Semb Wever for CASSANDRA-16438

18 months agoAdd explicit DC to tests where we have multidc setup
Bereng [Tue, 2 Feb 2021 07:28:10 +0000 (08:28 +0100)] 
Add explicit DC to tests where we have multidc setup
patch by Berenguer Blasi, reviewed by Tomasz Lasica, Andres de la Peña and Ekaterina Dimitrova for CASSANDRA-16411

18 months agoUpdate tests for CASSANDRA-14793
Benjamin Lerer [Mon, 28 Sep 2020 12:23:44 +0000 (14:23 +0200)] 
Update tests for CASSANDRA-14793

patch by Benjamin Lerer; reviewed by Andrés de la Peña and  Marcus
Eriksson for CASSANDRA-14793

18 months agoImprove flake8
Tomek Lasica [Tue, 26 Jan 2021 19:40:07 +0000 (20:40 +0100)] 
Improve flake8

patch by Tomek Łasica; reviewed by Mick Semb Wever

18 months agoHandle NodeError as it may be raised from ccm
Tomek Lasica [Tue, 26 Jan 2021 15:29:20 +0000 (16:29 +0100)] 
Handle NodeError as it may be raised from ccm

patch by Tomek Łasica; reviewed by Mick Semb Wever for CASSANDRA-16405

18 months agoListing tests (--collect-only and --dtest-print-tests-only) only lists tests that...
jacek-lewandowski [Fri, 22 Jan 2021 07:55:28 +0000 (08:55 +0100)] 
Listing tests (--collect-only and --dtest-print-tests-only) only lists tests that will run according to other arguments specified

This patch fixes behaviour for both `` and `pytest`.
- Error handling for invalid parameter values / combinations is in a single place (``) and is executed before we actually traverse through the tests
- We exit with just a clean error message instead of tons of spam
- `` will not loose the exit code of `pytest` any more so we can clearly detect when test cases collection fails
- removed a bit of boilerplate code from ``, e.g. what it did with xml processing is simply provided with `-q` argument of `pytest`
- tests filtering has been refactored to be cleaner
- fixed filtering of resource intensive tests and other tests (note that except for upgrade tests, we took care only about test method annotations - module level annotations were ignored for vnodes, no_vnodes, no_offheap_memtables and resource_intensive, ...)
- added meta_tests for the filtering and parsing exception handling
- added special parameter --metatests which is enough to run all the meta tests
- fixed Travis configuration so that it runs meta tests

Note that now `` seems to be redundant. If we need it only for listing dtests, we can simply achieve exactly the same effect using `--collect-only -q --ignore=meta_tests` arguments for `pytest` instead of `--dtest-print-tests-only`, plus  we need to filter output with `grep '.py::'` (in order to not include the summary line) and pipe stdout to the target file. It is now simplified so `` just uses `pytest` with those arguments.

patch by Jacek Lewandowski; reviewed by Tomek Łasica and Mick Semb Wever for CASSANDRA-16399

18 months agoProtocol v5 is only supported in 4.0+ (#116)
Sam Tunnicliffe [Fri, 22 Jan 2021 11:16:50 +0000 (11:16 +0000)] 
Protocol v5 is only supported in 4.0+ (#116)

Follow up to CASSANDRA-15299

Patch by Sam Tunnicliffe; reviewed by Marcus Eriksson

18 months agoFix `--keep-failed-test-dir` on skipped dtests
Mick Semb Wever [Thu, 21 Jan 2021 13:58:53 +0000 (14:58 +0100)] 
Fix `--keep-failed-test-dir` on skipped dtests

 patch by Mick Semb Wever; reviewed by Tomek Lasica for CASSANDRA-16397

18 months agoExplicit node start timeouts
Tomek Lasica [Mon, 18 Jan 2021 19:47:09 +0000 (20:47 +0100)] 
Explicit node start timeouts

Some tests require longer start timeout than default 90s:
* bootstrap with reset state
* node replacement
* cdc tests (due to checks for other seeds connectivity)

Before: use default timeout, 90s or rather 600s (due to bug in ccm)
After: use explicit timeout per test case: 120s or 180s

 patch by Tomek Lasica; reviewed by Mick Semb Wever for CASSANDRA-16395

19 months agoAdd empty text values to cqlsh copy test
Aleksandr Sorokoumov [Sat, 9 Jan 2021 15:52:30 +0000 (16:52 +0100)] 
Add empty text values to cqlsh copy test

Patch by Aleksandr Sorokoumov, reviewed by brandonwilliams for

19 months agofix version checking for 4.0+ conditionals
Adam Holmberg [Wed, 23 Dec 2020 18:31:31 +0000 (12:31 -0600)] 
fix version checking for 4.0+ conditionals

patch by Adam Holmberg; reviewed by Benjamin Lerer, David Capwell for CASSANDRA-16330

19 months agostart rolling clusters with protocol capping overridden
Adam Holmberg [Tue, 5 Jan 2021 20:31:07 +0000 (14:31 -0600)] 
start rolling clusters with protocol capping overridden

patch by Adam Holmberg; reviewed by David Capwell for CASSANDRA-16347

19 months agooverride overly strict max protocol in 3.0 upgrade test
Adam Holmberg [Tue, 22 Dec 2020 16:07:17 +0000 (10:07 -0600)] 
override overly strict max protocol in 3.0 upgrade test

patch by Adam Holmberg; reviewed by David Capwell, Sam Tunnicliffe for CASSANDRA-16354

19 months agopytest is not meant to run internal parameterized test method
Adam Holmberg [Tue, 5 Jan 2021 22:24:08 +0000 (16:24 -0600)] 
pytest is not meant to run internal parameterized test method

patch by Adam Holmberg; reviewed by David Capwell for CASSANDRA-16331

19 months agoFix upgrade python dtest test_static_columns_with_2i - upgrade_tests.cql_tests.TestCQ...
Adam Holmberg [Fri, 18 Dec 2020 22:37:18 +0000 (14:37 -0800)] 
Fix upgrade python dtest test_static_columns_with_2i - upgrade_tests.cql_tests.TestCQLNodes

patch by Adam Holmberg; reviewed by Caleb Rackliffe, David Capwell for CASSANDRA-16332

19 months agoFix upgrade python dtest test_static_columns_with_2i - upgrade_tests.cql_tests.TestCQ...
Adam Holmberg [Fri, 18 Dec 2020 22:37:18 +0000 (14:37 -0800)] 
Fix upgrade python dtest test_static_columns_with_2i - upgrade_tests.cql_tests.TestCQLNodes

patch by Adam Holmberg; reviewed by Caleb Rackliffe, David Capwell for CASSANDRA-16332

19 months agoUse the token allocation strategy generator tool for 4.0 vnode clusters, from CASSAND...
Mick Semb Wever [Sun, 15 Nov 2020 16:14:15 +0000 (17:14 +0100)] 
Use the token allocation strategy generator tool for 4.0 vnode clusters, from CASSANDRA-16205

 patch by Mick Semb Wever; reviewed by Adam Holmberg, Paulo Motta for CASSANDRA-16079

19 months agoFix upgrade python dtest test_crc_check_chance_upgrade - upgrade_crc_check_chance_tes...
Aleksandr Sorokoumov [Tue, 15 Dec 2020 17:37:12 +0000 (18:37 +0100)] 
Fix upgrade python dtest test_crc_check_chance_upgrade - upgrade_crc_check_chance_test.TestCrcCheckChanceUpgrade

patch by Aleksandr Sorokoumov; reviewed by David Capwell for CASSANDRA-16346

20 months agopython upgrade tests include tests which are not impacted by the version under test...
dcapwell [Mon, 14 Dec 2020 18:20:54 +0000 (10:20 -0800)] 
python upgrade tests include tests which are not impacted by the version under test (#106)

patch by David Capwell, Michael Semb Wever; reviewed by Marcus Eriksson, Michael Semb Wever  for CASSANDRA-16328

20 months agoMerge pull request #104 from ifesdjeen/CASSANDRA-16217-followup
Alex Petrov [Tue, 8 Dec 2020 07:25:15 +0000 (08:25 +0100)] 
Merge pull request #104 from ifesdjeen/CASSANDRA-16217-followup

Follow-up: remove tests deprecated by CASSANDRA-16217

20 months agoChange expected response when role data is corrupt
Sam Tunnicliffe [Fri, 13 Nov 2020 17:36:22 +0000 (17:36 +0000)] 
Change expected response when role data is corrupt

Patch by Sam Tunnicliffe; reviewed by Adam Holmberg for CASSANDRA-16275

20 months agoninja-fix: in TestBootstrap::_monitor_datadir, variable sstables needs...
Mick Semb Wever [Wed, 25 Nov 2020 19:58:23 +0000 (20:58 +0100)] 
ninja-fix: in TestBootstrap::_monitor_datadir, variable sstables needs to be defined first (CASSANDRA-15997)

20 months agoFollow-up: remove tests deprecated by CASSANDRA-16217 104/head
Alex Petrov [Fri, 20 Nov 2020 15:21:43 +0000 (16:21 +0100)] 
Follow-up: remove tests deprecated by CASSANDRA-16217

Patch by Alex Petrov; reviewed by Ekaterina Dimitrova for CASSANDRA-16217

20 months agoExplicitly define num_tokens=1 when not using vnodes
Brandon Williams [Tue, 17 Nov 2020 23:33:13 +0000 (17:33 -0600)] 
Explicitly define num_tokens=1 when not using vnodes

21 months agoAdd tests to cover ClientRequest metrics
Adam Holmberg [Wed, 11 Nov 2020 11:46:56 +0000 (11:46 +0000)] 
Add tests to cover ClientRequest metrics

patch by Adam Holmberg; reviewed by Andrés de la Peña for CASSANDRA-16183

21 months agoCASSANDRA-15158 give node a bit more time to come up
Blake Eggleston [Fri, 9 Oct 2020 17:12:01 +0000 (10:12 -0700)] 
CASSANDRA-15158 give node a bit more time to come up

21 months agoFix test_pending_range
Ekaterina Dimitrova [Thu, 22 Oct 2020 22:23:38 +0000 (18:23 -0400)] 
Fix test_pending_range

Patch by Ekaterina Dimitrova, reviewed by Berenguer Blasi and
brandonwilliams for CASSANDRA-16220

21 months agoRename master branch to trunk in cassandra-dtest
Mick Semb Wever [Sun, 25 Oct 2020 12:00:08 +0000 (13:00 +0100)] 
Rename master branch to trunk in cassandra-dtest

 patch by Mick Semb Wever; reviewed by Brandon Williams for CASSANDRA-16166

21 months agoSet max window correctly.
Bereng [Thu, 15 Oct 2020 07:53:40 +0000 (09:53 +0200)] 
Set max window correctly.

Patch by Berenguer Blasi, reviwewed by brandonwilliams for

21 months agoWhen running python dtest and using JAVA_TOOL_OPTIONS to inject cassandra configurati...
David Capwell [Wed, 21 Oct 2020 19:46:26 +0000 (12:46 -0700)] 
When running python dtest and using JAVA_TOOL_OPTIONS to inject cassandra configurations, tests fail as they don't expect this flag in stderr

patch by David Capwell; reviewed by Jordan West for CASSANDRA-16219

21 months agoRevert "Revert "Add test_truncate_failure""
Brandon Williams [Wed, 21 Oct 2020 14:12:37 +0000 (09:12 -0500)] 
Revert "Revert "Add test_truncate_failure""

This restores test_truncate_failure.
This reverts commit 016a0eb38db25ab36e1adabbc0bfe9575212b2ec.

21 months agoSkip read repair tests ported to in-JMV
Andrés de la Peña [Mon, 19 Oct 2020 14:42:08 +0000 (15:42 +0100)] 
Skip read repair tests ported to in-JMV

patch by Andrés de la Peña; reviewed by Caleb Rackliffe and Benjamin Lerer for CASSANDRA-15977

21 months agoRevert "Add test_truncate_failure"
Brandon Williams [Thu, 15 Oct 2020 16:46:48 +0000 (11:46 -0500)] 
Revert "Add test_truncate_failure"

This reverts commit 8cb6bd23e62c4d3b4e208d3909361d6812182bc6.

22 months agoAdd test_truncate_failure
Ekaterina Dimitrova [Thu, 8 Oct 2020 13:23:00 +0000 (09:23 -0400)] 
Add test_truncate_failure

Patch by Ekaterina Dimitrova, reviewed by brandonwilliams for

22 months agoFix file size calculations racing with async file deletions
Adam Holmberg [Tue, 13 Oct 2020 14:28:47 +0000 (09:28 -0500)] 
Fix file size calculations racing with async file deletions

Patch by Adam Holmberg, reviewed by brandonwilliams for CASSANDRA-16196

22 months agoUpdate compact storage related tests
Ekaterina Dimitrova [Tue, 13 Oct 2020 15:42:17 +0000 (16:42 +0100)] 
Update compact storage related tests

patch by Ekaterina Dimitrova; reviewed by Andrés de la Peña and Sylvain Lebresne for CASSANDRA-16063

22 months agoRemove flaky metrics assertion
Adam Holmberg [Mon, 12 Oct 2020 17:21:16 +0000 (12:21 -0500)] 
Remove flaky  metrics assertion

Patch by Adam Holmberg, reviewed by brandonwilliams for CASSANDRA-15992

22 months agoFixed a NullPointerException when calling nodetool enablethrift
David Capwell [Mon, 12 Oct 2020 16:30:33 +0000 (09:30 -0700)] 
Fixed a NullPointerException when calling nodetool enablethrift

patch by David Capwell; reviewed by Ekaterina Dimitrova, Jordan West, Yifan Cai for CASSANDRA-16127

22 months agorelocate flaky repair/digest test to avoid cqlsh trace queries
Adam Holmberg [Wed, 7 Oct 2020 18:38:40 +0000 (13:38 -0500)] 
relocate flaky repair/digest test to avoid cqlsh trace queries

patch by Adam Holmberg; reviewed by Benjamin Lerer for CASSANDRA-14157

22 months agoMove debugging to error in TestBootstrap::test_cleanup
Brandon Williams [Fri, 2 Oct 2020 20:19:45 +0000 (15:19 -0500)] 
Move debugging to error in TestBootstrap::test_cleanup

Patch by brandonwilliams, reviewed by Berenguer Blasi for

22 months agoFix flaky timeouts coming from concurrent view builds and schema modification
Adam Holmberg [Wed, 30 Sep 2020 21:40:41 +0000 (16:40 -0500)] 
Fix flaky timeouts coming from concurrent view builds and schema modification

Patch by Adam Holmberg, reviewed by Berenguer Blasi and brandonwilliams
for CASSANDRA-15993

22 months agofix flakiness in TestDiskBalance caused by random token generation
Adam Holmberg [Tue, 29 Sep 2020 17:55:48 +0000 (12:55 -0500)] 
fix flakiness in TestDiskBalance caused by random token generation

patch by Adam Holberg, reviewed by brandonwilliams for CASSANDRA-16089

22 months agofix bad rebase, remove remove_perf_disable_shared_mem
Marcus Eriksson [Mon, 28 Sep 2020 07:38:36 +0000 (09:38 +0200)] 
fix bad rebase, remove remove_perf_disable_shared_mem

22 months agoFix duplicate ttl overflow policy tests
Adam Holmberg [Thu, 24 Sep 2020 21:31:34 +0000 (16:31 -0500)] 
Fix duplicate ttl overflow policy tests

Patch by Adam Holmberg, reviewed by paulo and brandonwilliams for

22 months agoAdd flag to ignore unreplicated keyspaces during repair
Marcus Eriksson [Fri, 25 Sep 2020 02:31:34 +0000 (19:31 -0700)] 
Add flag to ignore unreplicated keyspaces during repair

patch by Marcus Eriksson; reviewed by Blake Eggleston, David Capwell for CASSANDRA-15160

22 months agoupgrade jolokia agent to 1.6.2 and drop remove_perf_disable_shared_mem workaround
Christopher Lambert [Thu, 24 Sep 2020 07:17:05 +0000 (09:17 +0200)] 
upgrade jolokia agent to 1.6.2 and drop remove_perf_disable_shared_mem workaround has been fixed since jolokia 1.3.7,
so there is no reason to keep the remove_perf_disable_shared_mem workaround anymore.
It is assumed that the '-XX:-PerfDisableSharedMem' usage was added exclusively for
jolokia as well.

patch by Christopher Lambert; reviewed by Mick Semb Wever

22 months agoremove redundant param wait_other_notice=True from Node.start calls
Christopher Lambert [Wed, 23 Sep 2020 12:25:55 +0000 (14:25 +0200)] 
remove redundant param wait_other_notice=True from Node.start calls

Since ccm Node.start() defaults to:

Since the presence could suggest that this is a non-default value, we
clean up the code by removing it.

patch by Christopher Lambert; reviewed by Mick Semb Wever

22 months agoremove redundant params wait_for_binary_proto=True and wait_other_notice=True from...
Christopher Lambert [Wed, 23 Sep 2020 09:01:24 +0000 (11:01 +0200)] 
remove redundant params wait_for_binary_proto=True and wait_other_notice=True from Cluster.start calls

Since ccm Cluster.start() defaults to:

Since their presence could suggest that these are non-default values, we
clean up the code by removing them.

patch by Christopher Lambert; reviewed by Mick Semb Wever

22 months agoAdditional expected error in repair test
Adam Holmberg [Mon, 21 Sep 2020 20:38:02 +0000 (15:38 -0500)] 
Additional expected error in repair test

Patch by Adam Holmberg, reviewed by brandonwilliams for CASSANDRA-15963

23 months agoWhen compaction gets interrupted, the exception should include the compactionId
Yifan Cai [Tue, 8 Sep 2020 21:41:12 +0000 (14:41 -0700)] 
When compaction gets interrupted, the exception should include the compactionId

patch by Yifan Cai; reviewed by David Capwell, Caleb Rackliffe for CASSANDRA-15954

23 months agoRevert generic timeout increase and target to the specific test instead
Bereng [Thu, 27 Aug 2020 05:04:15 +0000 (07:04 +0200)] 
Revert generic timeout increase and target to the specific test instead

patch by Berenguer Blasi; reviewed by Benjamin Lerer for CASSANDRA-16073

23 months agoResolve JMX output inconsistencies from CASSANDRA-7544 storage-port-configurable...
Jon Meredith [Wed, 26 Aug 2020 19:57:07 +0000 (12:57 -0700)] 
Resolve JMX output inconsistencies from CASSANDRA-7544 storage-port-configurable-per-node

patch by Jon Meredith; reviewed by David Capwell for CASSANDRA-15937

23 months agoCASSANDRA-15899 - fix repair_admin tests
Blake Eggleston [Wed, 26 Aug 2020 20:35:50 +0000 (13:35 -0700)] 
CASSANDRA-15899 - fix repair_admin tests

23 months agoIncrease several timeouts on test failures
Bereng [Mon, 24 Aug 2020 15:19:45 +0000 (17:19 +0200)] 
Increase several timeouts on test failures

patch by Berenguer Blasi; reviewed by Benjamin Lerer for CASSANDRA-16073

23 months agomake request a kwarg to cleanup_cluster
Brandon Williams [Tue, 25 Aug 2020 02:24:25 +0000 (21:24 -0500)] 
make request a kwarg to cleanup_cluster

23 months agoAdd "--keep-failed-test-dir" option that only keeps the ccm test directory for failed...
Mick Semb Wever [Sun, 23 Aug 2020 21:26:31 +0000 (23:26 +0200)] 
Add "--keep-failed-test-dir" option that only keeps the ccm test directory for failed tests

 patch by Mick Semb Wever; reviewed by Brandon Williams