Gary Gregory [Fri, 12 Aug 2022 11:13:55 +0000 (07:13 -0400)]
Bump actions/cache from 3.0.6 to 3.0.7
Gary Gregory [Fri, 5 Aug 2022 12:34:19 +0000 (08:34 -0400)]
Bump actions/cache from 3.0.5 to 3.0.6
Gary Gregory [Fri, 29 Jul 2022 12:38:16 +0000 (08:38 -0400)]
Update GitHub builds to use Temurin
Gary Gregory [Fri, 29 Jul 2022 11:51:46 +0000 (07:51 -0400)]
Bump spotbugs-maven-plugin from 4.7.1.0 to 4.7.1.1 #204
dependabot[bot] [Fri, 29 Jul 2022 11:50:48 +0000 (07:50 -0400)]
Bump spotbugs-maven-plugin from 4.7.1.0 to 4.7.1.1 (#204)
Bumps [spotbugs-maven-plugin](https://github.com/spotbugs/spotbugs-maven-plugin) from 4.7.1.0 to 4.7.1.1.
- [Release notes](https://github.com/spotbugs/spotbugs-maven-plugin/releases)
- [Commits](https://github.com/spotbugs/spotbugs-maven-plugin/compare/spotbugs-maven-plugin-4.7.1.0...spotbugs-maven-plugin-4.7.1.1)
---
updated-dependencies:
- dependency-name: com.github.spotbugs:spotbugs-maven-plugin
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Gary Gregory [Fri, 29 Jul 2022 11:50:34 +0000 (07:50 -0400)]
Bump junit-jupiter from 5.8.2 to 5.9.0 #203
dependabot[bot] [Fri, 29 Jul 2022 11:49:41 +0000 (07:49 -0400)]
Bump junit-jupiter from 5.8.2 to 5.9.0 (#203)
Bumps [junit-jupiter](https://github.com/junit-team/junit5) from 5.8.2 to 5.9.0.
- [Release notes](https://github.com/junit-team/junit5/releases)
- [Commits](https://github.com/junit-team/junit5/compare/r5.8.2...r5.9.0)
---
updated-dependencies:
- dependency-name: org.junit.jupiter:junit-jupiter
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Gary Gregory [Sun, 17 Jul 2022 13:15:00 +0000 (09:15 -0400)]
Use streams and reuse internal Utils code
Gary Gregory [Sat, 16 Jul 2022 00:14:12 +0000 (20:14 -0400)]
Bump actions/cache 3.0.4 to 3.0.5
Gary Gregory [Fri, 15 Jul 2022 12:34:27 +0000 (08:34 -0400)]
Bump actions/cache 3.0.4 to 3.0.5
Gary Gregory [Mon, 11 Jul 2022 14:08:40 +0000 (10:08 -0400)]
Add URLs to JDBC and Commons Pool.
Gary Gregory [Sun, 10 Jul 2022 20:29:32 +0000 (16:29 -0400)]
Format nit
Gary Gregory [Sun, 10 Jul 2022 20:23:21 +0000 (16:23 -0400)]
Use generics in makeMap() and then reuse makeMap()
Refactor duplication
Gary Gregory [Sun, 10 Jul 2022 19:54:36 +0000 (15:54 -0400)]
Reuse createMap()
Gary Gregory [Sun, 10 Jul 2022 19:44:46 +0000 (15:44 -0400)]
Simplify
Gary Gregory [Sun, 10 Jul 2022 19:39:08 +0000 (15:39 -0400)]
Reuse java.util.Map.computeIfAbsent()
Gary Gregory [Sun, 10 Jul 2022 19:34:19 +0000 (15:34 -0400)]
Reuse Utils.clone(char[])
Gary Gregory [Sun, 10 Jul 2022 19:26:42 +0000 (15:26 -0400)]
Add PMD CPD check to default Maven goal
Gary Gregory [Sun, 10 Jul 2022 19:21:55 +0000 (15:21 -0400)]
Refactor duplicate pattern
Gary Gregory [Sun, 10 Jul 2022 18:57:47 +0000 (14:57 -0400)]
Refactor duplicate pattern using AbandonedTrace
Gary Gregory [Sun, 10 Jul 2022 18:42:12 +0000 (14:42 -0400)]
Use forEach and make AbandonedTrace processing type-safe
Gary Gregory [Sun, 10 Jul 2022 18:06:39 +0000 (14:06 -0400)]
Move normalization for package private class PooledConnectionImpl into
PStmtKey.
Gary Gregory [Sun, 10 Jul 2022 16:03:16 +0000 (12:03 -0400)]
Declutter internals
Gary Gregory [Sun, 10 Jul 2022 12:47:47 +0000 (08:47 -0400)]
Convert inline comments to Javadoc, formatting
Gary Gregory [Sun, 10 Jul 2022 12:26:21 +0000 (08:26 -0400)]
Format nits
Gary Gregory [Sat, 9 Jul 2022 22:55:20 +0000 (18:55 -0400)]
Internal refactoring
Gary Gregory [Sat, 9 Jul 2022 22:49:34 +0000 (18:49 -0400)]
Update comment
Gary Gregory [Sat, 9 Jul 2022 22:44:20 +0000 (18:44 -0400)]
Make package-private classes final
Gary Gregory [Sat, 9 Jul 2022 22:38:58 +0000 (18:38 -0400)]
Use Objects#toString()
Gary Gregory [Sat, 9 Jul 2022 22:34:08 +0000 (18:34 -0400)]
Internal refactoring
Gary Gregory [Sat, 9 Jul 2022 21:42:53 +0000 (17:42 -0400)]
Simplify implementation
Gary Gregory [Sat, 9 Jul 2022 21:32:07 +0000 (17:32 -0400)]
Bump apache-rat-plugin 0.13 to 0.14.
Gary Gregory [Sat, 9 Jul 2022 20:02:16 +0000 (16:02 -0400)]
Capitalize private static final constant names.
Don't use FQCNs for java.io classes.
Gary Gregory [Sat, 9 Jul 2022 18:10:47 +0000 (14:10 -0400)]
Simplify
Gary Gregory [Fri, 8 Jul 2022 22:15:00 +0000 (18:15 -0400)]
Bump spotbugs-maven-plugin from 4.7.0.0 to 4.7.1.0 #200
dependabot[bot] [Fri, 8 Jul 2022 22:14:17 +0000 (18:14 -0400)]
Bump spotbugs-maven-plugin from 4.7.0.0 to 4.7.1.0 (#200)
Bumps [spotbugs-maven-plugin](https://github.com/spotbugs/spotbugs-maven-plugin) from 4.7.0.0 to 4.7.1.0.
- [Release notes](https://github.com/spotbugs/spotbugs-maven-plugin/releases)
- [Commits](https://github.com/spotbugs/spotbugs-maven-plugin/compare/spotbugs-maven-plugin-4.7.0.0...spotbugs-maven-plugin-4.7.1.0)
---
updated-dependencies:
- dependency-name: com.github.spotbugs:spotbugs-maven-plugin
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Gary Gregory [Mon, 4 Jul 2022 18:12:24 +0000 (14:12 -0400)]
Whitespace
Gary Gregory [Mon, 4 Jul 2022 17:10:07 +0000 (13:10 -0400)]
Add missing namespace and XSD to SpotBugs filter file.
Gary Gregory [Mon, 4 Jul 2022 14:07:34 +0000 (10:07 -0400)]
Remove obsolete entry in SpotBugs suppressions file.
Gary Gregory [Mon, 4 Jul 2022 14:05:30 +0000 (10:05 -0400)]
Add SpotBugs check to default Maven goal
Gary Gregory [Mon, 4 Jul 2022 13:52:15 +0000 (09:52 -0400)]
SpotBugs: An overridable method is called from a constructor
Calling an overridable method during in a constructor may result in the
use of uninitialized data. It may also leak the this reference of the
partially constructed object. Only static, final or private methods
should be invoked from a constructor.
See SEI CERT rule MET05-J. Ensure that constructors do not call
overridable methods.
Bug kind and pattern: MC - MC_OVERRIDABLE_METHOD_CALL_IN_CONSTRUCTOR
Gary Gregory [Mon, 4 Jul 2022 13:27:21 +0000 (09:27 -0400)]
Reuse pattern of throwing XAException instead of NullPointerException in
LocalXAConnectionFactory.LocalXAResource
Gary Gregory [Mon, 4 Jul 2022 13:08:44 +0000 (09:08 -0400)]
Performance: Refactor to use a static inner class in
DataSourceXAConnectionFactory.
Gary Gregory [Mon, 4 Jul 2022 12:54:00 +0000 (08:54 -0400)]
Performance: No need for map lookups if we traverse map entries instead
of keys.
Gary Gregory [Mon, 4 Jul 2022 12:43:53 +0000 (08:43 -0400)]
Bump spotbugs from 4.7.0 to 4.7.1
Gary Gregory [Mon, 4 Jul 2022 12:43:22 +0000 (08:43 -0400)]
Typo
dependabot[bot] [Mon, 4 Jul 2022 12:41:52 +0000 (08:41 -0400)]
Bump spotbugs from 4.7.0 to 4.7.1 (#198)
Bumps [spotbugs](https://github.com/spotbugs/spotbugs) from 4.7.0 to 4.7.1.
- [Release notes](https://github.com/spotbugs/spotbugs/releases)
- [Changelog](https://github.com/spotbugs/spotbugs/blob/master/CHANGELOG.md)
- [Commits](https://github.com/spotbugs/spotbugs/compare/4.7.0...4.7.1)
---
updated-dependencies:
- dependency-name: com.github.spotbugs:spotbugs
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Gary Gregory [Mon, 4 Jul 2022 12:34:11 +0000 (08:34 -0400)]
Declutter the root folder
Gary Gregory [Mon, 4 Jul 2022 12:33:55 +0000 (08:33 -0400)]
Declutter the root folder
Gary Gregory [Mon, 4 Jul 2022 11:33:45 +0000 (07:33 -0400)]
Fix XML for 'LifetimeExceededException should extend SQLException.'
Gary Gregory [Sun, 3 Jul 2022 18:25:24 +0000 (14:25 -0400)]
Sort members
Gary Gregory [Sun, 3 Jul 2022 18:11:37 +0000 (14:11 -0400)]
Javadoc
Gary Gregory [Sun, 3 Jul 2022 18:11:30 +0000 (14:11 -0400)]
Reflection is no longer needed as of our 2.8.0
Gary Gregory [Sun, 3 Jul 2022 17:56:01 +0000 (13:56 -0400)]
Replace Exception with SQLException in some method signatures (preserves
binary compatibility, not source).
Gary Gregory [Sun, 3 Jul 2022 17:54:36 +0000 (13:54 -0400)]
Don't leak Connections when PoolableConnectionFactory.makeObject() fails
to create a JMX ObjectName.
Gary Gregory [Sun, 3 Jul 2022 17:34:05 +0000 (13:34 -0400)]
Camcel-case internal names.
Gary Gregory [Sun, 3 Jul 2022 17:28:09 +0000 (13:28 -0400)]
Replace Exception with SQLException in some method signatures (preserves
binary compatibility, not source).
Gary Gregory [Sun, 3 Jul 2022 17:05:41 +0000 (13:05 -0400)]
Refactor duplicate logic and throw SQLException instead of Exception in
internal validateLifetime() methods.
Gary Gregory [Sun, 3 Jul 2022 16:54:45 +0000 (12:54 -0400)]
Fix message now that values are Durations instead of milliseconds.
Gary Gregory [Sun, 3 Jul 2022 16:53:53 +0000 (12:53 -0400)]
Javadoc
Gary Gregory [Sun, 3 Jul 2022 14:37:23 +0000 (10:37 -0400)]
LifetimeExceededException should extend SQLException.
Gary Gregory [Sun, 3 Jul 2022 13:30:07 +0000 (09:30 -0400)]
Comment not needed
Gary Gregory [Sun, 3 Jul 2022 13:29:54 +0000 (09:29 -0400)]
Comment not needed
Gary Gregory [Sun, 3 Jul 2022 13:00:17 +0000 (09:00 -0400)]
Refactor duplicate code
Gary Gregory [Sun, 3 Jul 2022 12:57:49 +0000 (08:57 -0400)]
Javadoc
Gary Gregory [Sun, 3 Jul 2022 12:40:46 +0000 (08:40 -0400)]
Bump maven-surefire-plugin 2.22.2 to 3.0.0-M7
Gary Gregory [Sun, 3 Jul 2022 12:33:55 +0000 (08:33 -0400)]
Call addObjects(int) instead of looping over addObject()
Gary Gregory [Sun, 3 Jul 2022 12:10:16 +0000 (08:10 -0400)]
Refactor duplicate pattern
Gary Gregory [Sun, 3 Jul 2022 11:53:52 +0000 (07:53 -0400)]
Refactor duplicate pattern
Gary Gregory [Sat, 2 Jul 2022 22:47:16 +0000 (18:47 -0400)]
Replace Exception with SQLException in some method signatures (preserves
binary compatibility, not source).
Gary Gregory [Sat, 2 Jul 2022 16:59:49 +0000 (12:59 -0400)]
Add Utils.getDisconnectionSqlCodes() and Utils.DISCONNECTION_SQL_CODES.
Gary Gregory [Sat, 2 Jul 2022 16:57:48 +0000 (12:57 -0400)]
Move SpotBugs configuration from root to to src/conf folder
Gary Gregory [Sat, 2 Jul 2022 15:08:01 +0000 (11:08 -0400)]
Fix inconsistent synchronization (IS2_INCONSISTENT_SYNC)
Gary Gregory [Sat, 2 Jul 2022 13:39:30 +0000 (09:39 -0400)]
org.apache.commons.dbcp2.datasources.UserPassKey should be Serializable
(SpotBugs)
Gary Gregory [Sat, 2 Jul 2022 13:18:05 +0000 (09:18 -0400)]
Bump JaCoCo from 0.8.7 to 0.8.8
Gary Gregory [Sat, 2 Jul 2022 13:17:57 +0000 (09:17 -0400)]
Refactor duplicate code
Gary Gregory [Sat, 2 Jul 2022 13:10:17 +0000 (09:10 -0400)]
Add PMD check to default Maven goal.
Gary Gregory [Sat, 2 Jul 2022 13:00:18 +0000 (09:00 -0400)]
Fix PMD UselessOverridingMethod (Design)
Gary Gregory [Sat, 2 Jul 2022 12:58:18 +0000 (08:58 -0400)]
Fix PMD UselessQualifiedThis (Code Style)
Gary Gregory [Sat, 2 Jul 2022 12:55:55 +0000 (08:55 -0400)]
Suppress PMD EmptyCatchBlock from ruleset Error Prone
Gary Gregory [Sat, 2 Jul 2022 12:37:37 +0000 (08:37 -0400)]
Bump maven-pmd-plugin from 3.16.0 to 3.17.0
Bump pmd from 6.44.0 to 6.47.0
Gary Gregory [Fri, 24 Jun 2022 11:13:58 +0000 (07:13 -0400)]
Bump h2 from 2.1.212 to 2.1.214 #196
dependabot[bot] [Fri, 24 Jun 2022 11:12:55 +0000 (07:12 -0400)]
Bump h2 from 2.1.212 to 2.1.214 (#196)
Bumps [h2](https://github.com/h2database/h2database) from 2.1.212 to 2.1.214.
- [Release notes](https://github.com/h2database/h2database/releases)
- [Commits](https://github.com/h2database/h2database/compare/version-2.1.212...version-2.1.214)
---
updated-dependencies:
- dependency-name: com.h2database:h2
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Gary Gregory [Fri, 24 Jun 2022 11:12:44 +0000 (07:12 -0400)]
Bump narayana-jta from 5.12.6.Final to 5.12.7.Final #197
dependabot[bot] [Fri, 24 Jun 2022 11:11:28 +0000 (07:11 -0400)]
Bump narayana-jta from 5.12.6.Final to 5.12.7.Final (#197)
Bumps narayana-jta from 5.12.6.Final to 5.12.7.Final.
---
updated-dependencies:
- dependency-name: org.jboss.narayana.jta:narayana-jta
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Gary Gregory [Wed, 15 Jun 2022 12:19:05 +0000 (08:19 -0400)]
Normalize Javadoc spelling
Gary Gregory [Fri, 10 Jun 2022 18:24:08 +0000 (14:24 -0400)]
Bump spotbugs-maven-plugin from 4.6.0.0 to 4.7.0.0 #192
dependabot[bot] [Fri, 10 Jun 2022 18:23:21 +0000 (14:23 -0400)]
Bump spotbugs-maven-plugin from 4.6.0.0 to 4.7.0.0 (#192)
Bumps [spotbugs-maven-plugin](https://github.com/spotbugs/spotbugs-maven-plugin) from 4.6.0.0 to 4.7.0.0.
- [Release notes](https://github.com/spotbugs/spotbugs-maven-plugin/releases)
- [Commits](https://github.com/spotbugs/spotbugs-maven-plugin/compare/spotbugs-maven-plugin-4.6.0.0...spotbugs-maven-plugin-4.7.0.0)
---
updated-dependencies:
- dependency-name: com.github.spotbugs:spotbugs-maven-plugin
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Gary Gregory [Fri, 10 Jun 2022 18:23:13 +0000 (14:23 -0400)]
Bump maven-pmd-plugin from 3.16.0 to 3.17.0 #195
dependabot[bot] [Fri, 10 Jun 2022 18:22:29 +0000 (14:22 -0400)]
Bump maven-pmd-plugin from 3.16.0 to 3.17.0 (#195)
Bumps [maven-pmd-plugin](https://github.com/apache/maven-pmd-plugin) from 3.16.0 to 3.17.0.
- [Release notes](https://github.com/apache/maven-pmd-plugin/releases)
- [Commits](https://github.com/apache/maven-pmd-plugin/compare/maven-pmd-plugin-3.16.0...maven-pmd-plugin-3.17.0)
---
updated-dependencies:
- dependency-name: org.apache.maven.plugins:maven-pmd-plugin
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Gary Gregory [Wed, 8 Jun 2022 16:50:33 +0000 (12:50 -0400)]
Add coverage.yml
Gary Gregory [Tue, 7 Jun 2022 17:56:48 +0000 (13:56 -0400)]
Bump actions/cache from 3.0.3 to 3.0.4
Gary Gregory [Tue, 7 Jun 2022 17:56:39 +0000 (13:56 -0400)]
Organize
Gary Gregory [Fri, 3 Jun 2022 14:59:05 +0000 (10:59 -0400)]
Bump mockito-core from 4.5.1 to 4.6.1 #193
dependabot[bot] [Fri, 3 Jun 2022 14:58:21 +0000 (10:58 -0400)]
Bump mockito-core from 4.5.1 to 4.6.1 (#193)
Bumps [mockito-core](https://github.com/mockito/mockito) from 4.5.1 to 4.6.1.
- [Release notes](https://github.com/mockito/mockito/releases)
- [Commits](https://github.com/mockito/mockito/compare/v4.5.1...v4.6.1)
---
updated-dependencies:
- dependency-name: org.mockito:mockito-core
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Gary Gregory [Tue, 31 May 2022 20:32:51 +0000 (16:32 -0400)]
Bump actions/cache from 3.0.2 to 3.0.3
Gary Gregory [Fri, 6 May 2022 11:39:04 +0000 (07:39 -0400)]
Bump checkstyle from 9.2.1 to 9.3 #190
dependabot[bot] [Fri, 6 May 2022 11:38:34 +0000 (07:38 -0400)]
Bump checkstyle from 9.2.1 to 9.3 (#190)
* Bump checkstyle from 9.2.1 to 10.2
Bumps [checkstyle](https://github.com/checkstyle/checkstyle) from 9.2.1 to 10.2.
- [Release notes](https://github.com/checkstyle/checkstyle/releases)
- [Commits](https://github.com/checkstyle/checkstyle/compare/checkstyle-9.2.1...checkstyle-10.2)
---
updated-dependencies:
- dependency-name: com.puppycrawl.tools:checkstyle
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
* Checkstyle 9.2.1 -> 9.3
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Gary Gregory <garydgregory@users.noreply.github.com>
Gary Gregory [Fri, 6 May 2022 11:33:31 +0000 (07:33 -0400)]
Bump spotbugs from 4.6.0 to 4.7.0 #189
dependabot[bot] [Fri, 6 May 2022 11:32:51 +0000 (07:32 -0400)]
Bump spotbugs from 4.6.0 to 4.7.0 (#189)
Bumps [spotbugs](https://github.com/spotbugs/spotbugs) from 4.6.0 to 4.7.0.
- [Release notes](https://github.com/spotbugs/spotbugs/releases)
- [Changelog](https://github.com/spotbugs/spotbugs/blob/master/CHANGELOG.md)
- [Commits](https://github.com/spotbugs/spotbugs/compare/4.6.0...4.7.0)
---
updated-dependencies:
- dependency-name: com.github.spotbugs:spotbugs
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>