commons-rng.git
3 months agoCompute p-value for the chi square test once.
Alex Herbert [Tue, 1 Mar 2022 23:58:32 +0000 (23:58 +0000)] 
Compute p-value for the chi square test once.

Use String.format for the assertion message.

8 months agoCache another constant in the large mean Poisson sampler
Alex Herbert [Sat, 23 Oct 2021 20:33:39 +0000 (21:33 +0100)] 
Cache another constant in the large mean Poisson sampler

This avoids evaluating a constant sqrt expression in the sampling loop.

8 months agoFormatting
Alex Herbert [Sat, 23 Oct 2021 11:56:20 +0000 (12:56 +0100)] 
Formatting

8 months agoCorrect javadoc for the bounds on the Poisson sampler mean
aherbert [Wed, 6 Oct 2021 17:10:17 +0000 (18:10 +0100)] 
Correct javadoc for the bounds on the Poisson sampler mean

8 months agoCorrect probability typo.
Alex Herbert [Sat, 2 Oct 2021 22:42:14 +0000 (23:42 +0100)] 
Correct probability typo.

8 months agoRNG-166: LogNormalSamplers to allow a negative mean.
Alex Herbert [Fri, 1 Oct 2021 18:29:35 +0000 (19:29 +0100)] 
RNG-166: LogNormalSamplers to allow a negative mean.

Changes:

- LogNormalSampler
- BoxNormalLogNormalSamplers

Also updated the constructor parameters from shape and scale to mu and
sigma. This matches the wikipedia reference and implementations in
Wolfram.

8 months agoRNG-165: Track changes
Alex Herbert [Fri, 1 Oct 2021 18:02:45 +0000 (19:02 +0100)] 
RNG-165: Track changes

8 months agoRNG-165: Allow a zero exponent in the Zipf sampler 103/head
aherbert [Wed, 29 Sep 2021 16:43:58 +0000 (17:43 +0100)] 
RNG-165: Allow a zero exponent in the Zipf sampler

8 months agoRNG-160: Use ternary operator to sort two long values
aherbert [Wed, 29 Sep 2021 15:52:06 +0000 (16:52 +0100)] 
RNG-160: Use ternary operator to sort two long values

This removes a 50:50 branch statement from concave overhang sampling.

9 months agoDirectly test the SamplerBase class
Alex Herbert [Sat, 18 Sep 2021 07:05:19 +0000 (08:05 +0100)] 
Directly test the SamplerBase class

There is no requirement to extend the class to access the pass-through
methods.

9 months agoAllow ziggurat sampling from only the overhangs in the performance test
aherbert [Thu, 16 Sep 2021 12:45:02 +0000 (13:45 +0100)] 
Allow ziggurat sampling from only the overhangs in the performance test

Add additional ternary variant for testing.

9 months agoFix javadoc mix up between convex and concave regions
aherbert [Thu, 16 Sep 2021 11:40:41 +0000 (12:40 +0100)] 
Fix javadoc mix up between convex and concave regions

9 months agoAdded ternary variations to the ziggurat benchmark
Alex Herbert [Wed, 15 Sep 2021 23:43:53 +0000 (00:43 +0100)] 
Added ternary variations to the ziggurat benchmark

9 months agoEnsure stream is closed using try-with-resources
Alex Herbert [Wed, 15 Sep 2021 22:37:57 +0000 (23:37 +0100)] 
Ensure stream is closed using try-with-resources

9 months agoRemove badges from examples README.md
aherbert [Tue, 14 Sep 2021 12:47:13 +0000 (13:47 +0100)] 
Remove badges from examples README.md

The badges do not relate to the examples code.

The build badge is for the main RNG modules. No check is made if the
examples code even builds.

The coverage badge is for the main RNG code. Coverage of the examples is
low to minimal and is not reported on.

9 months agoFix links for browsing the examples javadoc
aherbert [Tue, 14 Sep 2021 12:43:25 +0000 (13:43 +0100)] 
Fix links for browsing the examples javadoc

9 months agoRemove badges and maven dependency from the examples modules.
aherbert [Tue, 14 Sep 2021 12:34:49 +0000 (13:34 +0100)] 
Remove badges and maven dependency from the examples modules.

The examples are no longer released to maven central so badges for the
code or the javadoc are not applicable.

9 months agoUpdate Travis CI badge from .org to .com domain.
aherbert [Tue, 14 Sep 2021 12:26:43 +0000 (13:26 +0100)] 
Update Travis CI badge from .org to .com domain.

9 months agoUpdate note about sending e-mail from an apache.org account.
aherbert [Tue, 14 Sep 2021 12:17:29 +0000 (13:17 +0100)] 
Update note about sending e-mail from an apache.org account.

9 months agoCorrect javadoc
aherbert [Tue, 14 Sep 2021 10:53:45 +0000 (11:53 +0100)] 
Correct javadoc

9 months agoUpdate announce subject line in release guide
aherbert [Mon, 13 Sep 2021 15:24:10 +0000 (16:24 +0100)] 
Update announce subject line in release guide

9 months agoChange release notes to use new commons tag format
aherbert [Mon, 13 Sep 2021 12:20:28 +0000 (13:20 +0100)] 
Change release notes to use new commons tag format

Add note about how to modify the release notes during a release process.

9 months agoUpdate release notes following release 1.4
aherbert [Mon, 13 Sep 2021 11:52:01 +0000 (12:52 +0100)] 
Update release notes following release 1.4

9 months agoAdd release 1.4 javadoc links to the site.xml
aherbert [Mon, 13 Sep 2021 11:36:58 +0000 (12:36 +0100)] 
Add release 1.4 javadoc links to the site.xml

9 months agoUpdate examples app version to 1.5-SNAPSHOT
aherbert [Mon, 13 Sep 2021 10:33:19 +0000 (11:33 +0100)] 
Update examples app version to 1.5-SNAPSHOT

9 months agoUpdate release and BC version in parent pom
aherbert [Mon, 13 Sep 2021 10:32:04 +0000 (11:32 +0100)] 
Update release and BC version in parent pom

9 months agoUpdate README to refer to 1.4 release
aherbert [Mon, 13 Sep 2021 10:31:03 +0000 (11:31 +0100)] 
Update README to refer to 1.4 release

9 months agoUpdate pom to next development version (1.4 to 1.5)
aherbert [Mon, 13 Sep 2021 10:27:51 +0000 (11:27 +0100)] 
Update pom to next development version (1.4 to 1.5)

9 months agoRetrieve 1.4 release details from the release branch
aherbert [Mon, 13 Sep 2021 10:20:43 +0000 (11:20 +0100)] 
Retrieve 1.4 release details from the release branch

9 months agoUpdate javadoc.
aherbert [Tue, 7 Sep 2021 11:39:11 +0000 (12:39 +0100)] 
Update javadoc.

Correct description of new RandomSource.create(...) method where the
enum defines the concrete implementation, not the first argument to
create.

Move description of parallel applications to a sub-section. Add
description of parallel support from the jumpable generators with a code
example.

9 months agoPlace @since tags after @see tags following Oracle's order convension
aherbert [Mon, 6 Sep 2021 11:19:46 +0000 (12:19 +0100)] 
Place @since tags after @see tags following Oracle's order convension

9 months agoAdd @since tags to new RandomSource.create methods
aherbert [Mon, 6 Sep 2021 11:01:54 +0000 (12:01 +0100)] 
Add @since tags to new RandomSource.create methods

9 months agoDo not perform minimal site checkout in pre-site phase
Alex Herbert [Sun, 5 Sep 2021 13:50:08 +0000 (14:50 +0100)] 
Do not perform minimal site checkout in pre-site phase

This profile must now be explicitly activated.

9 months agoExclude site-content.README from rat check
Alex Herbert [Sun, 5 Sep 2021 13:34:55 +0000 (14:34 +0100)] 
Exclude site-content.README from rat check

Use the same excludes in the build and reporting section

9 months agoFix changes typo
Alex Herbert [Sun, 5 Sep 2021 13:32:40 +0000 (14:32 +0100)] 
Fix changes typo

9 months agoUpdate user guide dependencies to require Java 1.8
Alex Herbert [Sun, 5 Sep 2021 13:31:21 +0000 (14:31 +0100)] 
Update user guide dependencies to require Java 1.8

9 months agoFormat ziggurat tables
aherbert [Wed, 1 Sep 2021 15:33:27 +0000 (16:33 +0100)] 
Format ziggurat tables

The byte[] MAP is now initialized using (byte) casting.

9 months agoAdd ziggurat versions with multiple max epsilon values
aherbert [Tue, 31 Aug 2021 16:44:23 +0000 (17:44 +0100)] 
Add ziggurat versions with multiple max epsilon values

Correct exponential epsilon values to use the ceiling of the float value
before rounding to a long integer.

9 months agoUpdate grammar for conscious language checker
Alex Herbert [Sun, 29 Aug 2021 18:13:00 +0000 (19:13 +0100)] 
Update grammar for conscious language checker

9 months agoUpdate grammar for conscious language checker
Alex Herbert [Sun, 29 Aug 2021 18:05:25 +0000 (19:05 +0100)] 
Update grammar for conscious language checker

9 months agoUpdate grammar for conscious language checker
Alex Herbert [Sun, 29 Aug 2021 18:01:58 +0000 (19:01 +0100)] 
Update grammar for conscious language checker

10 months agoAdd more platform results for exp(z)
Alex Herbert [Sat, 28 Aug 2021 09:46:04 +0000 (10:46 +0100)] 
Add more platform results for exp(z)

10 months agoFix trailing spaces
Alex Herbert [Sat, 28 Aug 2021 09:16:17 +0000 (10:16 +0100)] 
Fix trailing spaces

10 months agoAdd performance test for exp(x) with x in [-8, 0]
Alex Herbert [Sat, 28 Aug 2021 09:13:04 +0000 (10:13 +0100)] 
Add performance test for exp(x) with x in [-8, 0]

10 months agoDisable tests in JMH module.
Alex Herbert [Fri, 27 Aug 2021 14:46:59 +0000 (15:46 +0100)] 
Disable tests in JMH module.

Add a better fixed seed with a note on how to test samplers using a
random seed.

10 months agoAdd performance test for extracting the sign bit
Alex Herbert [Fri, 27 Aug 2021 13:49:58 +0000 (14:49 +0100)] 
Add performance test for extracting the sign bit

Update tests requiring a fast generator to use a LCG. Only applicable
when the upper bits are required.

10 months agoRemove branch frequencies from performance variations
Alex Herbert [Fri, 27 Aug 2021 13:27:04 +0000 (14:27 +0100)] 
Remove branch frequencies from performance variations

The branch frequencies are the same as the main sampler. This eliminates
duplication and eases maintenance.

10 months agoParameterise the ziggurat sampler test
Alex Herbert [Fri, 27 Aug 2021 13:17:48 +0000 (14:17 +0100)] 
Parameterise the ziggurat sampler test

Duplicate the test in the JMH module. This ensures all variations
correctly sample the distribution, i.e. changes do not introduce errors
in the algorithm.

This identified an error in ModifiedZigguratExponentialSamplerRecursion.

10 months agoUpdate ziggurat performance benchmark to match main code
Alex Herbert [Fri, 27 Aug 2021 11:49:20 +0000 (12:49 +0100)] 
Update ziggurat performance benchmark to match main code

Naming conventions and comments have been updated to match those in the
main sampling package. This is for ease of maintenance.

10 months agoComment typo
Alex Herbert [Fri, 27 Aug 2021 11:47:15 +0000 (12:47 +0100)] 
Comment typo

10 months agoChange another mask operation to a bit shift.
aherbert [Thu, 26 Aug 2021 17:05:34 +0000 (18:05 +0100)] 
Change another mask operation to a bit shift.

10 months agoUpdate ziggurat sampler using result of the performance tests
aherbert [Thu, 26 Aug 2021 17:05:04 +0000 (18:05 +0100)] 
Update ziggurat sampler using result of the performance tests

Use a single method to interpolate x and y. This avoids a subtraction in
the interpolation of y.

Avoid recursion in the exponential sampler.

Use shifts to generate unsigned longs. This favours the upper bits of
the uniform deviate.

Each change is either mute or may have a marginal benefit depending on
the platform. Together the sampler should be consistently performant
across JDKs and platforms.

Update tests that manipulate the output from the exponential sampler:
stable sampler test
ziggurat sampler test

10 months agoDisable interpolation test method
aherbert [Thu, 26 Aug 2021 14:47:37 +0000 (15:47 +0100)] 
Disable interpolation test method

10 months agoUpdate ziggurat test to target regions of the ziggurat.
aherbert [Thu, 26 Aug 2021 14:22:33 +0000 (15:22 +0100)] 
Update ziggurat test to target regions of the ziggurat.

This targets concave, inflection, and convex overhangs and the tail of
the Gaussian.

This targets concave overhangs, and the tail of the exponential.

Note: This test is still not able to identify minor errors in the sampling algorithm. The test cannot detect the difference between a concave region sampled correctly or sampled using a uniform sample from the lower-left triangle.

10 months agoPMD: Allow long class for ZigguratSampler
Alex Herbert [Wed, 25 Aug 2021 22:35:11 +0000 (23:35 +0100)] 
PMD: Allow long class for ZigguratSampler

10 months agoUpdate ziggurat performance benchmark with more methods
Alex Herbert [Wed, 25 Aug 2021 20:02:41 +0000 (21:02 +0100)] 
Update ziggurat performance benchmark with more methods

Use only bit shifts for random positive longs.

Use a different method to sample y.

Benchmark methods to interpolate X or Y

10 months agoUpdate observed frequencies with expected where appropriate.
aherbert [Wed, 25 Aug 2021 15:53:44 +0000 (16:53 +0100)] 
Update observed frequencies with expected where appropriate.

The expected frequencies are obtained during the table construction.
They closely match the previously measured observed frequencies.

10 months agoAdd description of sampling method to the ziggurat sampler.
aherbert [Wed, 25 Aug 2021 15:36:32 +0000 (16:36 +0100)] 
Add description of sampling method to the ziggurat sampler.

Update the javadoc for all values and methods to be consistent with the
summary description.

10 months agoEnsure same samplers are tested in single and sequential
Alex Herbert [Wed, 25 Aug 2021 08:40:28 +0000 (09:40 +0100)] 
Ensure same samplers are tested in single and sequential

Use a base class to define the samplers.

10 months agoBenchmark using a long to get an index, compare it, and return the index
aherbert [Tue, 24 Aug 2021 17:13:00 +0000 (18:13 +0100)] 
Benchmark using a long to get an index, compare it, and return the index

10 months agoAdd ziggurat exponential sampler with no recursion to the benchmark
aherbert [Tue, 24 Aug 2021 16:42:55 +0000 (17:42 +0100)] 
Add ziggurat exponential sampler with no recursion to the benchmark

10 months agoUpdate ZigguaratSampler branch frequencies
aherbert [Tue, 24 Aug 2021 15:14:23 +0000 (16:14 +0100)] 
Update ZigguaratSampler branch frequencies

10 months agoUpdate ZigguaratSampler point of inflection for the Gaussian.
aherbert [Tue, 24 Aug 2021 13:36:26 +0000 (14:36 +0100)] 
Update ZigguaratSampler point of inflection for the Gaussian.

The point of inflection is the largest x value below 1. When x=1 the
second derivative of the Gaussian is zero (i.e. the point of
inflection).

10 months agoUpdate ZigguaratSampler concave epsilon for the exponential.
aherbert [Tue, 24 Aug 2021 12:57:17 +0000 (13:57 +0100)] 
Update ZigguaratSampler concave epsilon for the exponential.

This should be equal to approximately 9.2%. The previous value was
approximately 5.6% resulting in fast acceptance too often for overhangs.

10 months agoRNG-163: Track changes
aherbert [Tue, 24 Aug 2021 09:28:10 +0000 (10:28 +0100)] 
RNG-163: Track changes

10 months agoUpdate release howto
Alex Herbert [Thu, 19 Aug 2021 12:33:44 +0000 (13:33 +0100)] 
Update release howto

Change testing mvn command to 'verify' in place of 'package' to ensure
checks are run.

Separate site generation from the release build of the binary artifacts.

10 months agoRemove examples from the release profile.
Alex Herbert [Thu, 19 Aug 2021 08:40:59 +0000 (09:40 +0100)] 
Remove examples from the release profile.

10 months agoRemove legacy assembly directory.
Alex Herbert [Thu, 19 Aug 2021 08:38:29 +0000 (09:38 +0100)] 
Remove legacy assembly directory.

Functionality is in the dist-archive module.

10 months agoRename LICENCE and NOTICE files
Alex Herbert [Thu, 19 Aug 2021 08:37:00 +0000 (09:37 +0100)] 
Rename LICENCE and NOTICE files

Drop the .txt suffix to use the preferred name in the ASF release
guidelines.

10 months agoRemove examples from the binary distribution
Alex Herbert [Thu, 19 Aug 2021 08:18:30 +0000 (09:18 +0100)] 
Remove examples from the binary distribution

10 months agoRemove redundant fileSet
Alex Herbert [Thu, 19 Aug 2021 08:13:20 +0000 (09:13 +0100)] 
Remove redundant fileSet

Dependencies are packaged due to the dependencies resolution from the
dependencySet

10 months agoUpdate plugin order in pom
Alex Herbert [Wed, 18 Aug 2021 23:38:10 +0000 (00:38 +0100)] 
Update plugin order in pom

Use a consistent order with commons-math:

checkstyle
spotbugs
pmd

10 months agoClarify purpose of module in the description
Alex Herbert [Wed, 18 Aug 2021 15:51:10 +0000 (16:51 +0100)] 
Clarify purpose of module in the description

10 months agoRemove docs archive from the binary distribution.
Alex Herbert [Wed, 18 Aug 2021 15:45:38 +0000 (16:45 +0100)] 
Remove docs archive from the binary distribution.

This javadoc directory duplicates the javadoc jars within the binary
release archive.

10 months agoCreate aggregate javadoc report in docs module
Alex Herbert [Tue, 17 Aug 2021 21:42:06 +0000 (22:42 +0100)] 
Create aggregate javadoc report in docs module

10 months agoRemove checksum from installed artifacts
Alex Herbert [Tue, 17 Aug 2021 21:11:33 +0000 (22:11 +0100)] 
Remove checksum from installed artifacts

This creates md5 and sha1 checksums for the dist-archive pom in the
local maven repository. It is not required.

10 months agoRemove unused wildcard
Alex Herbert [Tue, 17 Aug 2021 20:50:04 +0000 (21:50 +0100)] 
Remove unused wildcard

10 months agoExclude site-content generated file from archive
Alex Herbert [Tue, 17 Aug 2021 20:44:31 +0000 (21:44 +0100)] 
Exclude site-content generated file from archive

10 months agoCorrect the help comment
Alex Herbert [Tue, 17 Aug 2021 09:57:29 +0000 (10:57 +0100)] 
Correct the help comment

10 months agoAdd aggregator module for documentation
Alex Herbert [Tue, 17 Aug 2021 09:53:32 +0000 (10:53 +0100)] 
Add aggregator module for documentation

10 months agoNo diamond operator on anonymous inner class
Alex Herbert [Tue, 17 Aug 2021 08:16:04 +0000 (09:16 +0100)] 
No diamond operator on anonymous inner class

10 months agoRemove duplicate ConstantName module
Alex Herbert [Mon, 16 Aug 2021 23:07:40 +0000 (00:07 +0100)] 
Remove duplicate ConstantName module

10 months agoUse diamond operator
Alex Herbert [Mon, 16 Aug 2021 23:06:40 +0000 (00:06 +0100)] 
Use diamond operator

10 months agoRNG-163: Make tests and test classes package-private 101/head
Alex Herbert [Mon, 16 Aug 2021 22:57:38 +0000 (23:57 +0100)] 
RNG-163: Make tests and test classes package-private

JUnit 5 does not require public fixtures.

10 months agoUse diamond operator
Alex Herbert [Mon, 16 Aug 2021 21:10:12 +0000 (22:10 +0100)] 
Use diamond operator

10 months agoDrop redundant array to Arrays.asList
Alex Herbert [Mon, 16 Aug 2021 21:06:04 +0000 (22:06 +0100)] 
Drop redundant array to Arrays.asList

10 months agoRNG-163: Replace try-catch with assertThrows
Alex Herbert [Sun, 15 Aug 2021 21:37:01 +0000 (22:37 +0100)] 
RNG-163: Replace try-catch with assertThrows

10 months agoRNG-163: Remove JUnit 4 support
Alex Herbert [Sun, 15 Aug 2021 20:46:50 +0000 (21:46 +0100)] 
RNG-163: Remove JUnit 4 support

Drop the junit-vintage-engine dependency.

10 months agoRNG-163: Update JUnit 4 @Test to JUnit 5 @Test
Alex Herbert [Sun, 15 Aug 2021 20:30:13 +0000 (21:30 +0100)] 
RNG-163: Update JUnit 4 @Test to JUnit 5 @Test

Requires changing:

- @BeforeClass to @BeforeAll
- @Rule timeout to Assertions.assertTimeout

10 months agoRNG-163: Update parametric tests to JUnit 5 ParameterizedTest
Alex Herbert [Sun, 15 Aug 2021 20:24:51 +0000 (21:24 +0100)] 
RNG-163: Update parametric tests to JUnit 5 ParameterizedTest

10 months agoRNG-163: Replace expected thrown exception with assertThrows
Alex Herbert [Sun, 15 Aug 2021 15:11:53 +0000 (16:11 +0100)] 
RNG-163: Replace expected thrown exception with assertThrows

Some multiple methods, one per exception, have been merged into a common
method.

10 months agoRNG-163: Replace JUnit 4 Assert with JUnit 5 Assertions
Alex Herbert [Sun, 15 Aug 2021 12:55:25 +0000 (13:55 +0100)] 
RNG-163: Replace JUnit 4 Assert with JUnit 5 Assertions

Tests for float equality with a delta of 0.0 have been updated to remove the delta.

Replace JUnit 4 Assume with JUnit 5 Assumptions

10 months agoRemove Java 8 profiles from modules
Alex Herbert [Sun, 15 Aug 2021 08:22:09 +0000 (09:22 +0100)] 
Remove Java 8 profiles from modules

10 months agoRNG-163: Update pom dependency JUnit 4 to JUnit 5
Alex Herbert [Sun, 15 Aug 2021 08:19:20 +0000 (09:19 +0100)] 
RNG-163: Update pom dependency JUnit 4 to JUnit 5

Inclusion of the junit-vintage-engine allows all existing tests to run.

10 months agoUpdate user guide Gaussian performance table
Alex Herbert [Sun, 15 Aug 2021 07:02:55 +0000 (08:02 +0100)] 
Update user guide Gaussian performance table

This has been repeated following changes to the new ZigguratSampler

10 months agoTrack changes
Alex Herbert [Sat, 14 Aug 2021 06:26:37 +0000 (07:26 +0100)] 
Track changes

10 months agoMerge pull request #98 from arturobernalg/feature/simplify
Alex Herbert [Sat, 14 Aug 2021 06:24:53 +0000 (07:24 +0100)] 
Merge pull request #98 from arturobernalg/feature/simplify

Simplify assertions with equivalent but more simple.

10 months agoSimplify assertions with equivalent but more simple. 98/head
Arturo Bernal [Sat, 14 Aug 2021 05:15:50 +0000 (07:15 +0200)] 
Simplify assertions with equivalent but more simple.

10 months agoRemove comment about a change to use a Supplier
Alex Herbert [Fri, 13 Aug 2021 22:42:18 +0000 (23:42 +0100)] 
Remove comment about a change to use a Supplier

Use of the JDK 8 Supplier function has been implemented.

10 months agoReplace benchmarking interfaces with java.util.function
Alex Herbert [Fri, 13 Aug 2021 19:31:42 +0000 (20:31 +0100)] 
Replace benchmarking interfaces with java.util.function