cordova-android.git
13 days agoimprove test readme (#582) master
Jan Piotrowski [Tue, 4 Dec 2018 19:38:31 +0000 (20:38 +0100)] 
improve test readme (#582)

<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist
is intended as a quick reference, for complete details please see our Contributor Guidelines:

http://cordova.apache.org/contribute/contribute_guidelines.html

Thanks!
-->

### Platforms affected

### What does this PR do?

### What testing has been done on this change?

### Checklist
- [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [ ] Added automated test coverage as appropriate for this change.

2 weeks agoRewrite install dir resolution for legacy plugins (#589)
Jule- [Wed, 28 Nov 2018 11:46:45 +0000 (12:46 +0100)] 
Rewrite install dir resolution for legacy plugins (#589)

* Improve target-dir restriction for detecting new android project structure used in plugin.xml. (#575)

* Clarify old source-file declaration way from the new one and improve ambiguous code.

* Better check `src/main` forms.

* Replace path search with RegExp vars.

* Fix RegExp in order to match `/` or `EOL`.

* Remove template strings for NodeJS 4 support (wanted in case we port these changes to `7.1.x` at some point).

* Add pointer to deprecation plan in GH-580.

3 weeks agoResolve issue with plugin target-dir="app*" subdirs (#572)
Chris Brody [Thu, 22 Nov 2018 13:59:33 +0000 (08:59 -0500)] 
Resolve issue with plugin target-dir="app*" subdirs (#572)

(subdirectories) such as "appco", with unit tests to verify

Needed for @katzer plugins that use de/appplant subdirectory,
for example:
* cordova-plugin-local-notifications
* cordova-plugin-badge
* cordova-plugin-background-mode

Also needed for cordova-plugin-inappbrowser

Co-authored-by: Christopher J. Brody <chris.brody@gmail.com>
Co-authored-by: Julio César <jcesarmobile@gmail.com>
Co-authored-by: Jan Piotrowski <piotrowski+github@gmail.com>
3 weeks agoOutput current package name if package name can't be validated
Jan Piotrowski [Wed, 21 Nov 2018 05:54:55 +0000 (06:54 +0100)] 
Output current package name if package name can't be validated

We have this of the package name. It only outputs that the current one is bad, not what the current one actually is. Added an output of the current one to the error.

3 weeks agoMerge pull request #507 from dpogue/gradle-updates
エリス [Wed, 21 Nov 2018 05:44:00 +0000 (14:44 +0900)] 
Merge pull request #507 from dpogue/gradle-updates

Gradle Updates

3 weeks agoSilence some deprecation linter warnings 507/head
Darryl Pogue [Wed, 26 Sep 2018 07:30:42 +0000 (00:30 -0700)] 
Silence some deprecation linter warnings

3 weeks agoUpdates for latest gradle/build tools
Darryl Pogue [Wed, 26 Sep 2018 07:29:31 +0000 (00:29 -0700)] 
Updates for latest gradle/build tools

Ref GH-504.

4 weeks agoeslint ignore version file (#559)
Chris Brody [Thu, 15 Nov 2018 01:35:47 +0000 (20:35 -0500)] 
eslint ignore version file (#559)

Quick workaround to resolve build error

needed since cordova-coho generates version file with double-quotes

4 weeks agoMerge pull request #550 from brodybits/gh-547-bugfix
Chris Brody [Wed, 14 Nov 2018 22:44:31 +0000 (17:44 -0500)] 
Merge pull request #550 from brodybits/gh-547-bugfix

Fix for old plugins with non-Java sources (GH-547)

4 weeks agoSet version & VERSION to 8.0.0-dev (coho) 558/head
Christopher J. Brody [Wed, 14 Nov 2018 20:37:22 +0000 (15:37 -0500)] 
Set version & VERSION to 8.0.0-dev (coho)

4 weeks agoUpdate JS to version 8.0.0-dev (via coho)
Christopher J. Brody [Wed, 14 Nov 2018 20:37:22 +0000 (15:37 -0500)] 
Update JS to version 8.0.0-dev (via coho)

4 weeks agoCB-9366 cordova.js log error.stack (cordova-js@4.2.4)
Christopher J. Brody [Wed, 14 Nov 2018 20:30:26 +0000 (15:30 -0500)] 
CB-9366 cordova.js log error.stack (cordova-js@4.2.4)

(Update cordova.js from cordova-js@4.2.4, using coho copy-js)

4 weeks agoUpdate cordova.js from cordova-js@4.2.3
Christopher J. Brody [Wed, 14 Nov 2018 20:24:48 +0000 (15:24 -0500)] 
Update cordova.js from cordova-js@4.2.3

using coho copy-js

with the following change from cordova-js-src:
* Remove obsolete check for JellyBean to work properly on Android Pie
  (GH-534)

4 weeks agoGH-547 Fix for old plugins with non-Java sources 550/head
Christopher J. Brody [Wed, 14 Nov 2018 18:19:58 +0000 (13:19 -0500)] 
GH-547 Fix for old plugins with non-Java sources

(source-file entries)

including aidl, aar, jar, and so files

4 weeks agoFix comments in getInstallDestination
Christopher J. Brody [Wed, 14 Nov 2018 16:40:33 +0000 (11:40 -0500)] 
Fix comments in getInstallDestination

(in pluginHandlers.js)

4 weeks agoCleanup getInstallDestination in pluginHandlers.js
Christopher J. Brody [Wed, 14 Nov 2018 16:38:39 +0000 (11:38 -0500)] 
Cleanup getInstallDestination in pluginHandlers.js

4 weeks agoGH-552 (android) check for build-extras.gradle in the app-parent directory (#553)
David Boho [Wed, 14 Nov 2018 13:00:36 +0000 (14:00 +0100)] 
GH-552 (android) check for build-extras.gradle in the app-parent directory (#553)

as documented in https://cordova.apache.org/docs/en/latest/guide/platforms/android/?#extending-buildgradle

and deal with multiple build-extras.gradle locations

Co-authored-by: David Boho <david.boho@tu-ilmenau.de>
Co-authored-by: Christopher J. Brody <chris.brody@gmail.com>
4 weeks agoMerge pull request #551 from DavidWiesner/cast-min-sdk-version
Darryl Pogue [Wed, 14 Nov 2018 07:06:38 +0000 (23:06 -0800)] 
Merge pull request #551 from DavidWiesner/cast-min-sdk-version

(android) add missing cast for cdvMinSdkVersion

4 weeks agoadd missing cast for cdvMinSdkVersion 551/head
David Boho [Wed, 14 Nov 2018 05:18:53 +0000 (06:18 +0100)] 
add missing cast for cdvMinSdkVersion

4 weeks agoTest old plugin aidl & lib mapping - repros GH-547
Christopher J. Brody [Tue, 13 Nov 2018 18:06:48 +0000 (13:06 -0500)] 
Test old plugin aidl & lib mapping - repros GH-547

(reproduces GH-547)

5 weeks agoCheck old compat of other extension (CB-14125)
Christopher J. Brody [Tue, 13 Nov 2018 03:01:13 +0000 (22:01 -0500)] 
Check old compat of other extension (CB-14125)

of plugin source file installed into app/src/main with
old target-dir scheme

NOTE: These tests do *not* check compatibility of
plugins with old lib target-dir scheme.

5 weeks agoCheck target-dir mapping of plugin xml source file
Christopher J. Brody [Tue, 13 Nov 2018 02:50:20 +0000 (21:50 -0500)] 
Check target-dir mapping of plugin xml source file

Possibly related to: CB-13830: Add handlers for plugins
that use non-Java source files, such as Camera

5 weeks agoFix tests of plugin files with new app dir scheme
Christopher J. Brody [Tue, 13 Nov 2018 02:42:31 +0000 (21:42 -0500)] 
Fix tests of plugin files with new app dir scheme

(new app target-dir scheme)

5 weeks agoMerge pull request #542 from brodybits/gh-540-hotfix
Chris Brody [Mon, 12 Nov 2018 18:23:23 +0000 (13:23 -0500)] 
Merge pull request #542 from brodybits/gh-540-hotfix

Resolve GH-539 & GH-540 on master

5 weeks agoRemove obsolete check for JellyBean (GH-534) (#544)
Chris Brody [Mon, 12 Nov 2018 17:06:45 +0000 (12:06 -0500)] 
Remove obsolete check for JellyBean (GH-534) (#544)

to work properly on Android Pie

was introduced in dc0bfeb0c (CB-11828)

Resolves #534

Co-authored-by: <pradiv-kumar@users.noreply.github.com>
Co-authored-by: Christopher J. Brody <chris.brody@gmail.com>
5 weeks agoGH-540 fix for source-file with app target-dir 542/head
Christopher J. Brody [Sun, 11 Nov 2018 20:26:04 +0000 (15:26 -0500)] 
GH-540 fix for source-file with app target-dir

5 weeks agounit test uninstall of <source-file> with app dest
Christopher J. Brody [Sun, 11 Nov 2018 18:36:31 +0000 (13:36 -0500)] 
unit test uninstall of <source-file> with app dest

for Java source, JAR, and AAR

Co-authored-by: Christopher J. Brody <chris.brody@gmail.com>
Co-authored-by: Kyle Kirbatski <kkirbatski@gmrmarketing.com>
Co-authored-by: Antonio Facciolo <afdev82@users.noreply.github.com>
5 weeks agounit test source-file with custom lib target-dir
Christopher J. Brody [Fri, 9 Nov 2018 19:43:47 +0000 (14:43 -0500)] 
unit test source-file with custom lib target-dir

for JAR and AAR

(GH-540)

Co-Authored-By: Kyle Kirbatski <kkirbatski@gmrmarketing.com>
Co-Authored-By: Christopher J. Brody <chris.brody@gmail.com>
Co-Authored-By: @afdev82 (Antonio Facciolo)
5 weeks agoGH-539 fix destination path fallback
Christopher J. Brody [Sun, 11 Nov 2018 20:07:01 +0000 (15:07 -0500)] 
GH-539 fix destination path fallback

Fallback to old path mapping if no Android Studio path mapping exists

Co-authored-by: Christopher J. Brody <chris.brody@gmail.com>
Co-authored-by: Kyle Kirbatski <kkirbatski@gmrmarketing.com>
5 weeks agounit test uninstall of <source-file> with app dest
Christopher J. Brody [Sun, 11 Nov 2018 18:36:31 +0000 (13:36 -0500)] 
unit test uninstall of <source-file> with app dest

for Java source only (GH-539)

Co-Authored-By: Christopher J. Brody <chris.brody@gmail.com>
Co-Authored-By: Kyle Kirbatski <kkirbatski@gmrmarketing.com>
5 weeks agoAdd a unit test to test source-file target-dir /app/src/main/…
Kyle Kirbatski [Thu, 8 Nov 2018 18:23:29 +0000 (12:23 -0600)] 
Add a unit test to test source-file target-dir /app/src/main/…

5 weeks agoMerge pull request #538 from erisu/bump-common-3x
Darryl Pogue [Thu, 8 Nov 2018 02:04:28 +0000 (18:04 -0800)] 
Merge pull request #538 from erisu/bump-common-3x

Dependency bump cordova-common@^3.0.0

5 weeks agoDependency bump cordova-common@^3.0.0 538/head
エリス [Thu, 8 Nov 2018 00:23:01 +0000 (09:23 +0900)] 
Dependency bump cordova-common@^3.0.0

5 weeks agoMerge pull request #536 from erisu/remove-node_module-copy
Darryl Pogue [Tue, 6 Nov 2018 18:06:46 +0000 (10:06 -0800)] 
Merge pull request #536 from erisu/remove-node_module-copy

Only copy platform node_modules when created by binary

6 weeks agoOnly copy platform node_modules when create by bin 536/head
エリス [Thu, 27 Sep 2018 07:17:44 +0000 (16:17 +0900)] 
Only copy platform node_modules when create by bin

6 weeks agoMerge pull request #465 from erisu/CB-14201
Darryl Pogue [Thu, 1 Nov 2018 04:25:26 +0000 (21:25 -0700)] 
Merge pull request #465 from erisu/CB-14201

CB-14201: (android) Removes Gradle property in-line command arguments…

7 weeks agoMerge pull request #523 from dpogue/gradle-repo-order
Darryl Pogue [Tue, 23 Oct 2018 17:33:57 +0000 (10:33 -0700)] 
Merge pull request #523 from dpogue/gradle-repo-order

Always put the Google repo above jcenter

7 weeks agoAlways put the Google repo above jcenter 523/head
Darryl Pogue [Tue, 23 Oct 2018 15:21:05 +0000 (08:21 -0700)] 
Always put the Google repo above jcenter

2 months agoremove JIRA link
Jan Piotrowski [Wed, 3 Oct 2018 23:12:02 +0000 (01:12 +0200)] 
remove JIRA link

2 months agoMerge pull request #486 from jedrivisser/7.1.x
Darryl Pogue [Wed, 26 Sep 2018 05:30:46 +0000 (22:30 -0700)] 
Merge pull request #486 from jedrivisser/7.1.x

GH-485: (android) Replace deprecated "compile" with "implementation"

3 months agoUpdate comments (#496)
Chris Brody [Wed, 12 Sep 2018 11:52:11 +0000 (07:52 -0400)] 
Update comments (#496)

as followup to GH-495

3 months agoMerge pull request #495 from Darshan-Chauhan/incorrect-default-sdk-version
Chris Brody [Wed, 12 Sep 2018 11:17:16 +0000 (07:17 -0400)] 
Merge pull request #495 from Darshan-Chauhan/incorrect-default-sdk-version

Incorrect default sdk version issue fix

3 months agoIncorrect default sdk version issue fix 495/head
Darshan-Chauhan [Wed, 12 Sep 2018 10:04:00 +0000 (15:34 +0530)] 
Incorrect default sdk version issue fix

3 months agoMerge pull request #493 from raphinesse/remove-bundled-dependencies
Darryl Pogue [Tue, 11 Sep 2018 20:30:12 +0000 (13:30 -0700)] 
Merge pull request #493 from raphinesse/remove-bundled-dependencies

Remove bundled dependencies

3 months agoRemove bundled node_modules 493/head
Raphael von der Grün [Tue, 11 Sep 2018 19:23:24 +0000 (21:23 +0200)] 
Remove bundled node_modules

3 months agoIgnore the whole node_modules folder
Raphael von der Grün [Tue, 11 Sep 2018 19:20:47 +0000 (21:20 +0200)] 
Ignore the whole node_modules folder

3 months agoRemove bundledDependencies key from package.json
Raphael von der Grün [Tue, 11 Sep 2018 19:18:18 +0000 (21:18 +0200)] 
Remove bundledDependencies key from package.json

3 months agoGH-485: (android) Change deprecated "compile" to "implementation" 486/head
Jedri Visser [Thu, 6 Sep 2018 17:24:12 +0000 (19:24 +0200)] 
GH-485: (android) Change deprecated "compile" to "implementation"

3 months agoCB-14201: (android) Removes Gradle property in-line command arguments for gradle... 465/head
エリス [Wed, 11 Jul 2018 03:14:04 +0000 (12:14 +0900)] 
CB-14201: (android) Removes Gradle property in-line command arguments for gradle.properties

3 months agoFixes build & run related bugs from builder refactor PR #461 (#490)
エリス [Thu, 6 Sep 2018 02:06:18 +0000 (11:06 +0900)] 
Fixes build & run related bugs from builder refactor PR #461 (#490)

- General Code Refactor
- Removed builder type argument from getBuilder API
- Removed any reference of conditional statements around builder type
- Remove plugin handler install and uninstall option flag android_studio
- Remove --gradle flag references
- Fixed plugin handler install and uninstall pathing issues
- Added parseBuildOptions export so run can get build related options.
- Use the nobuild flag option to control the run build.
- Updated test spec to reflect the changes.

3 months agoUnit tests for android_sdk and AndroidProject (#464)
Gearóid [Sun, 2 Sep 2018 02:44:37 +0000 (11:44 +0900)] 
Unit tests for android_sdk and AndroidProject (#464)

<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist
is intended as a quick reference, for complete details please see our Contributor Guidelines:

http://cordova.apache.org/contribute/contribute_guidelines.html

Thanks!
-->

### Platforms affected
Android

### What does this PR do?
This is the last unit test PR for today, I promise! The `AndroidProject` tests were originally in #458. This PR also contains increased test coverage for `android_sdk.js`. I have also refactored that to remove `Q`, as with the other PRs I submitted today.

### What testing has been done on this change?
Run unit tests

### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [x] Added automated test coverage as appropriate for this change.

3 months agoCB-13685 android: Adaptive Icon Support
エリス [Tue, 5 Jun 2018 04:43:05 +0000 (13:43 +0900)] 
CB-13685 android: Adaptive Icon Support

- Update default project template's icons to be adaptive.
- Added backwards support for non-adaptive icon supported devices.

3 months agoGH-473: Do not attempt an activity for internal url loads
Darryl Pogue [Wed, 29 Aug 2018 17:10:23 +0000 (10:10 -0700)] 
GH-473: Do not attempt an activity for internal url loads

Merge pull request #487 from joeljeske/bugfix/473-crash-on-android-7

3 months agoFixes apache/cordova-android#473: Do not attempt an activity intent AND a url load... 487/head
Joel Jeske [Wed, 29 Aug 2018 15:52:12 +0000 (10:52 -0500)] 
Fixes apache/cordova-android#473: Do not attempt an activity intent AND a url load into the webview, return from the internal webview load.

4 months agoMerge pull request #461 from Menardi/refactor_builders_with_tests
Raphael von der Grün [Sat, 21 Jul 2018 14:43:34 +0000 (16:43 +0200)] 
Merge pull request #461 from Menardi/refactor_builders_with_tests

Remove old builders code

5 months agoRemove no longer needed AndroidStudio.js 461/head
Gearoid M [Fri, 29 Jun 2018 01:11:27 +0000 (10:11 +0900)] 
Remove no longer needed AndroidStudio.js

5 months agoRefactor ProjectBuilder to use class instead of prototype
Gearoid M [Fri, 29 Jun 2018 00:16:57 +0000 (09:16 +0900)] 
Refactor ProjectBuilder to use class instead of prototype

5 months agoRemove unused builders and add unit tests
Gearoid M [Wed, 27 Jun 2018 23:53:36 +0000 (08:53 +0900)] 
Remove unused builders and add unit tests

5 months agoMerge pull request #463 from Menardi/emulator_tests
Darryl Pogue [Tue, 3 Jul 2018 04:21:43 +0000 (21:21 -0700)] 
Merge pull request #463 from Menardi/emulator_tests

Emulator: Add unit tests and remove Q

5 months agoMerge pull request #462 from Menardi/device_tests
Darryl Pogue [Tue, 3 Jul 2018 04:19:05 +0000 (21:19 -0700)] 
Merge pull request #462 from Menardi/device_tests

Device: Add unit tests and remove Q

5 months agoIncrease unit test coverage for emulator 463/head
Gearoid M [Tue, 3 Jul 2018 01:30:15 +0000 (10:30 +0900)] 
Increase unit test coverage for emulator

5 months agoCB-14158: Refactor emulator to remove Q
Gearoid M [Tue, 3 Jul 2018 01:29:11 +0000 (10:29 +0900)] 
CB-14158: Refactor emulator to remove Q

5 months agoAdd unit tests for device 462/head
Gearoid M [Tue, 3 Jul 2018 01:34:39 +0000 (10:34 +0900)] 
Add unit tests for device

5 months agoCB-14158: Refactor device to remove Q
Gearoid M [Tue, 3 Jul 2018 01:34:31 +0000 (10:34 +0900)] 
CB-14158: Refactor device to remove Q

5 months agoRemove mention of ICLA from contribution guidelines (#460)
Gearóid [Fri, 29 Jun 2018 00:47:34 +0000 (09:47 +0900)] 
Remove mention of ICLA from contribution guidelines (#460)

5 months agoCB-14165 Emulator: handle "device still connecting" error (#457)
Rizal M. S [Mon, 25 Jun 2018 06:44:37 +0000 (13:44 +0700)] 
CB-14165 Emulator: handle "device still connecting" error (#457)

Keep waiting for emulator when connection fails with "device still connecting" error

5 months agoMerge pull request #456 from Menardi/more_android_tests
Raphael von der Grün [Fri, 22 Jun 2018 01:17:19 +0000 (03:17 +0200)] 
Merge pull request #456 from Menardi/more_android_tests

More android tests

5 months agoPrevent Api.js tests from polluting the reporter output 456/head
Gearoid M [Thu, 21 Jun 2018 07:46:34 +0000 (16:46 +0900)] 
Prevent Api.js tests from polluting the reporter output

5 months agoAdd unit tests for AndroidManifest.js
Gearoid M [Thu, 21 Jun 2018 07:16:11 +0000 (16:16 +0900)] 
Add unit tests for AndroidManifest.js

5 months agoAdd unit tests for Adb.js
Gearoid M [Thu, 21 Jun 2018 05:09:47 +0000 (14:09 +0900)] 
Add unit tests for Adb.js

5 months agoAdd unit tests for run and retryPromise
Gearoid M [Mon, 18 Jun 2018 06:15:24 +0000 (15:15 +0900)] 
Add unit tests for run and retryPromise

Co-authored-by: Raphael von der Grün <raphinesse@gmail.com>
5 months agoAllow mocks to reject without a reason
Raphael von der Grün [Wed, 20 Jun 2018 10:20:38 +0000 (12:20 +0200)] 
Allow mocks to reject without a reason

5 months agoUpdate Jasmine to support automatic promise handling
Gearoid M [Mon, 18 Jun 2018 05:07:32 +0000 (14:07 +0900)] 
Update Jasmine to support automatic promise handling

5 months agoFix unsafe property access
Gearoid M [Mon, 18 Jun 2018 06:15:24 +0000 (15:15 +0900)] 
Fix unsafe property access

5 months agoFix typo in variable name in retry.js
Gearoid M [Mon, 18 Jun 2018 06:15:24 +0000 (15:15 +0900)] 
Fix typo in variable name in retry.js

6 months agoLint JS files w/out extension too (#453)
Raphael von der Grün [Mon, 18 Jun 2018 21:48:02 +0000 (23:48 +0200)] 
Lint JS files w/out extension too (#453)

Prior to this change, JS files without extension had not been linted.

To match them, we need a combination of positive and negative globbing
that does not mix well with the existing file selection for linting. Thus, we use
npm-run-all to run two ESLint invocations unconditionally in sequence
while still preserving the error code.

* Lint JS w/out extension too
* Fix newly surfaced linting errors
* Make use of npm-run-all for test script too

6 months agoEmit log event instead of logging directly
Raphael von der Grün [Sat, 16 Jun 2018 17:09:49 +0000 (19:09 +0200)] 
Emit log event instead of logging directly

6 months agoMerge pull request #449 from jcesarmobile/CB-14125
jcesarmobile [Wed, 13 Jun 2018 21:00:55 +0000 (23:00 +0200)] 
Merge pull request #449 from jcesarmobile/CB-14125

CB-14125:(android) Increase old plugin compatibility

6 months agoMerge pull request #442 from raphinesse/fix-tests
Raphael von der Grün [Wed, 13 Jun 2018 14:28:29 +0000 (16:28 +0200)] 
Merge pull request #442 from raphinesse/fix-tests

Fixes and cleanup for Java tests and CI

6 months agoCB-14072 Update supported Node.js versions 442/head
Raphael von der Grün [Wed, 13 Jun 2018 14:09:12 +0000 (16:09 +0200)] 
CB-14072 Update supported Node.js versions

6 months agoDelete unused gradle-wrapper.properties for Java tests
Raphael von der Grün [Wed, 13 Jun 2018 14:09:11 +0000 (16:09 +0200)] 
Delete unused gradle-wrapper.properties for Java tests

6 months agoUnignore tracked build.gradle for Java tests
Raphael von der Grün [Wed, 13 Jun 2018 14:09:10 +0000 (16:09 +0200)] 
Unignore tracked build.gradle for Java tests

6 months agoCleanup CI configurations
Raphael von der Grün [Wed, 13 Jun 2018 14:09:09 +0000 (16:09 +0200)] 
Cleanup CI configurations

* Use latest Android SDK tools for easier license handling
* Reduce installed SDK components to minimum (tools & build tools)
* Reduce unnecessary PATH manipulation
* Use preinstalled Gradle on Travis CI
* Improve Gradle output on Travis CI
* Use default image on AppVeyor
* Improve formatting & other minor tweaks

6 months agoCleanup Java tests runner
Raphael von der Grün [Wed, 13 Jun 2018 14:09:08 +0000 (16:09 +0200)] 
Cleanup Java tests runner

* Print Gradle version used for Java tests during build
* Allow Java tests to be run from any directory
* Simplify Promise wrapping in Java tests runner
* Minor improvements

6 months agoFix Java tests on AppVeyor by disabling Gradle daemon
Raphael von der Grün [Wed, 13 Jun 2018 14:09:07 +0000 (16:09 +0200)] 
Fix Java tests on AppVeyor by disabling Gradle daemon

6 months agoQuick fix for Java tests on Travis CI
Raphael von der Grün [Wed, 13 Jun 2018 14:09:05 +0000 (16:09 +0200)] 
Quick fix for Java tests on Travis CI

This accepts any unaccepted Android SDK licenses in Travis.

6 months agoFix Java tests for older Gradle versions
Raphael von der Grün [Wed, 13 Jun 2018 14:09:04 +0000 (16:09 +0200)] 
Fix Java tests for older Gradle versions

Before this, Gradle 4.4 was required to build the Gradle wrapper and
thus run the Java tests. This was because of all the stuff that had to
be configured when running the wrapper task using the build.gradle file.

Now we use a config file that only specifies the required Gradle version
and nothing else to run the wrapper task. This allows tests to be run
with Gradle versions beginning with 2.

6 months agoFix output and exit code for Java tests
Raphael von der Grün [Wed, 13 Jun 2018 14:09:03 +0000 (16:09 +0200)] 
Fix output and exit code for Java tests

This fixes the following issues:
* run_java_unit_tests.js always has exit code of 0 thus never failing
  the npm tests.
* "Tests completed successfully" is printed after failing to create the
  Gradle wrapper and never running the tests.
* Gradle errors are printed twice

6 months agoCB-14101 Fix Java version check for Java >= 9 (#446)
Raphael von der Grün [Tue, 12 Jun 2018 20:18:55 +0000 (22:18 +0200)] 
CB-14101 Fix Java version check for Java >= 9 (#446)

This also checks that we have exactly 1.8 since nothing else works with
the Android SDK. The user facing error was updated accordingly.

6 months agoMerge pull request #450 from jcesarmobile/CB-14127
jcesarmobile [Tue, 12 Jun 2018 09:46:50 +0000 (11:46 +0200)] 
Merge pull request #450 from jcesarmobile/CB-14127

CB-14127: (android) Move google maven repo ahead of jcenter

6 months agoCB-14127: (android) Move google maven repo ahead of jcenter 450/head
Julio César [Mon, 11 Jun 2018 21:12:58 +0000 (23:12 +0200)] 
CB-14127: (android) Move google maven repo ahead of jcenter

6 months agoCB-14125:(android) Increase old plugin compatibility 449/head
Julio César [Sun, 10 Jun 2018 22:48:24 +0000 (00:48 +0200)] 
CB-14125:(android) Increase old plugin compatibility

6 months agoRemove obsolete jshint comments (#444)
Raphael von der Grün [Mon, 21 May 2018 10:02:14 +0000 (12:02 +0200)] 
Remove obsolete jshint comments (#444)

6 months agoMerge pull request #443 from raphinesse/eslint
Shazron Abdullah [Mon, 21 May 2018 10:00:44 +0000 (18:00 +0800)] 
Merge pull request #443 from raphinesse/eslint

Improve ESLint script

6 months agoImprove ESLint script 443/head
Raphael von der Grün [Sat, 19 May 2018 21:08:24 +0000 (23:08 +0200)] 
Improve ESLint script

It now lints all files in one go and lints a few extra files.

7 months agoMerge pull request #437 from jcesarmobile/CB-14038
Joe Bowser [Thu, 19 Apr 2018 18:08:54 +0000 (11:08 -0700)] 
Merge pull request #437 from jcesarmobile/CB-14038

CB-14038 (android): fix false positive detecting project type

I agree @jcesarmobile, it can wait for a future release.

8 months agoCB-14038 (android): fix false positive detecting project type 437/head
Julio César [Wed, 18 Apr 2018 11:16:54 +0000 (13:16 +0200)] 
CB-14038 (android): fix false positive detecting project type

8 months agoMerge pull request #436 from infil00p/update_gradle_deps
Joe Bowser [Tue, 10 Apr 2018 20:58:31 +0000 (13:58 -0700)] 
Merge pull request #436 from infil00p/update_gradle_deps

CB-14008: Updating Gradle Libraries to work with Android Studio 3.1.0

8 months agoCB-14008: Updating Gradle Libraries to work with Android Studio 3.1.0 436/head
Joe Bowser [Wed, 4 Apr 2018 20:54:39 +0000 (13:54 -0700)] 
CB-14008: Updating Gradle Libraries to work with Android Studio 3.1.0

8 months agoMerge pull request #435 from richturner/master
Joe Bowser [Tue, 27 Mar 2018 20:50:26 +0000 (13:50 -0700)] 
Merge pull request #435 from richturner/master

CB-13975: (android) Fix to fire pause event when cdvStartInBackground=true