Remove unused arguments and configure linter to report them

diff --git a/.eslintrc.yml b/.eslintrc.yml
index 7701c82..21a8e7b 100644 (file)
--- a/.eslintrc.yml
+++ b/.eslintrc.yml
@@ -8,4 +8,6 @@ rules:
   padded-blocks: off
   operator-linebreak: off
   no-throw-literal: off
-  
\ No newline at end of file
+  no-unused-vars:
+    - error
+    - args: after-used

diff --git a/spec/ConfigChanges/ConfigChanges.spec.js b/spec/ConfigChanges/ConfigChanges.spec.js
index ec7f250..0e200ae 100644 (file)
--- a/spec/ConfigChanges/ConfigChanges.spec.js
+++ b/spec/ConfigChanges/ConfigChanges.spec.js
@@ -56,7 +56,7 @@ function innerXML (xmltext) {
     return xmltext.replace(/^<[\w\s\-=\/"\.]+>/, '').replace(/<\/[\w\s\-=\/"\.]+>$/, ''); /* eslint no-useless-escape : 0 */
 }
 
-function get_munge_change (munge, keys) {
+function get_munge_change () {
     return mungeutil.deep_find.apply(null, arguments);
 }
 

diff --git a/spec/FileUpdater.spec.js b/spec/FileUpdater.spec.js
index 0dccc01..8370b97 100644 (file)
--- a/spec/FileUpdater.spec.js
+++ b/spec/FileUpdater.spec.js
@@ -118,7 +118,7 @@ var testDirStats = mockDirStats();
 var testFileStats = mockFileStats(now);
 var testFileStats2 = mockFileStats(now);
 var testFileStats3 = mockFileStats(now);
-var nullLogger = function (message) {};
+var nullLogger = function () {};
 
 describe('FileUpdater class', function () {
 

diff --git a/spec/PlatformJson.spec.js b/spec/PlatformJson.spec.js
index a92be65..fbf7746 100644 (file)
--- a/spec/PlatformJson.spec.js
+++ b/spec/PlatformJson.spec.js
@@ -123,7 +123,7 @@ describe('PlatformJson class', function () {
 describe('ModuleMetadata class', function () {\r
     it('Test 010 : should be constructable', function () {\r
         var meta;\r
-        expect(function name (params) {\r
+        expect(function () {\r
             meta = new ModuleMetadata('fakePlugin', {src: 'www/fakeModule.js'});\r
         }).not.toThrow();\r
         expect(meta instanceof ModuleMetadata).toBeTruthy();\r

diff --git a/src/ConfigParser/ConfigParser.js b/src/ConfigParser/ConfigParser.js
index 095ccf2..4f1cc39 100644 (file)
--- a/src/ConfigParser/ConfigParser.js
+++ b/src/ConfigParser/ConfigParser.js
@@ -91,7 +91,7 @@ ConfigParser.prototype = {
         return this.doc.getroot().attrib[attr];
     },
 
-    packageName: function (id) {
+    packageName: function () {
         return this.getAttribute('id');
     },
     setPackageName: function (id) {

diff --git a/src/FileUpdater.js b/src/FileUpdater.js
index c4eeb97..ea5d9e2 100644 (file)
--- a/src/FileUpdater.js
+++ b/src/FileUpdater.js
@@ -186,7 +186,7 @@ function updatePath (sourcePath, targetPath, options, log) {
         throw new Error('A target path is required.');
     }
 
-    log = log || function (message) { };
+    log = log || function () { };
 
     return updatePathInternal(sourcePath, targetPath, options, log);
 }
@@ -213,7 +213,7 @@ function updatePaths (pathMap, options, log) {
         throw new Error('An object mapping from target paths to source paths is required.');
     }
 
-    log = log || function (message) { };
+    log = log || function () { };
 
     var updated = false;
 
@@ -266,7 +266,7 @@ function mergeAndUpdateDir (sourceDirs, targetDir, options, log) {
         throw new Error('A target directory path is required.');
     }
 
-    log = log || function (message) { };
+    log = log || function () { };
 
     var rootDir = (options && options.rootDir) || '';
 

diff --git a/src/util/xml-helpers.js b/src/util/xml-helpers.js
index e2c8fd3..6b5d70f 100644 (file)
--- a/src/util/xml-helpers.js
+++ b/src/util/xml-helpers.js
@@ -328,7 +328,7 @@ function mergeXml (src, dest, platform, clobber) {
         });
 
         // write new preferences
-        Object.keys(prefHash).forEach(function (key, index) {
+        Object.keys(prefHash).forEach(function (key) {
             var element = et.SubElement(xml, 'preference');
             element.set('name', key);
             element.set('value', this[key]);