CB-13145: removed uncessary check in getFramework
authorSteve Gill <stevengill97@gmail.com>
Wed, 30 Aug 2017 05:36:53 +0000 (22:36 -0700)
committerSteve Gill <stevengill97@gmail.com>
Wed, 30 Aug 2017 05:42:42 +0000 (22:42 -0700)
spec/PluginInfo/PluginInfo.spec.js
src/PluginInfo/PluginInfo.js

index 5fdaf87..e7a7c4f 100644 (file)
@@ -64,10 +64,4 @@ describe('PluginInfo', function () {
         var result = p.getFrameworks('android', {cli_variables: { FCM_VERSION: '9.0.0' }});
         expect(result[2].src).toBe('com.google.firebase:firebase-messaging:9.0.0');
     });
-
-    it('Test 004: framework src uses default variable', function () {
-        var p = new PluginInfo(path.join(pluginsDir, 'org.test.src'));
-        var result = p.getFrameworks('android', {});
-        expect(result[2].src).toBe('com.google.firebase:firebase-messaging:11.0.1');
-    });
 });
index 4cb5307..4d77cbc 100644 (file)
@@ -312,11 +312,6 @@ function PluginInfo (dirname) {
             var src = el.attrib.src;
             if (options) {
                 var vars = options.cli_variables || {};
-                if (Object.keys(vars).length === 0) {
-                    // get variable defaults from plugin.xml for removal
-                    vars = self.getPreferences(platform);
-                }
-
                 var regExp;
                 // Iterate over plugin variables.
                 // Replace them in framework src if they exist