cordova-lib.git
3 days agoAdd Electron Platform (#744) master
エリス [Tue, 11 Dec 2018 06:36:16 +0000 (15:36 +0900)] 
Add Electron Platform (#744)

* Add Electron Platform
* Updated test spec to include Electron

3 days agoUpdated Platform Config Git URL Paths (#743)
エリス [Tue, 11 Dec 2018 06:35:28 +0000 (15:35 +0900)] 
Updated Platform Config Git URL Paths (#743)

10 days agoCleanup indentation spacing in */jasmine.json (#742)
Chris Brody [Tue, 4 Dec 2018 17:30:17 +0000 (12:30 -0500)] 
Cleanup indentation spacing in */jasmine.json (#742)

10 days agoFix crash in `cordova requirements` due to an unbound function (#741)
Ran Benita [Tue, 4 Dec 2018 13:52:39 +0000 (15:52 +0200)] 
Fix crash in `cordova requirements` due to an unbound function (#741)

Functions in utils.js expect to be called with `this` bound to the
module. So this call crashed with an error
    this.isCordova is not a function

Fixes #740.

2 months agoremove JIRA link
Jan Piotrowski [Wed, 3 Oct 2018 23:07:21 +0000 (01:07 +0200)] 
remove JIRA link

2 months agoFix 2 integration tests failures on macOS
Darryl Pogue [Sun, 30 Sep 2018 06:47:49 +0000 (23:47 -0700)] 
Fix 2 integration tests failures on macOS

2 months agoMerge pull request #710 from raphinesse/q-nomore
Raphael von der Grün [Sun, 30 Sep 2018 00:26:16 +0000 (02:26 +0200)] 
Merge pull request #710 from raphinesse/q-nomore

Drop dependency on Q, use native promises

2 months agoRemove Q :tada: 710/head
Raphael von der Grün [Sat, 29 Sep 2018 09:05:00 +0000 (11:05 +0200)] 
Remove Q :tada:

2 months agoFix some unhandled promises
Raphael von der Grün [Sat, 29 Sep 2018 09:04:59 +0000 (11:04 +0200)] 
Fix some unhandled promises

2 months agoAdd ESLint rule against unhandled promises
Raphael von der Grün [Sat, 29 Sep 2018 09:04:58 +0000 (11:04 +0200)] 
Add ESLint rule against unhandled promises

2 months agoRewrite cordova/requirements to get rid of `Q.allSettled`
Raphael von der Grün [Sat, 29 Sep 2018 09:04:57 +0000 (11:04 +0200)] 
Rewrite cordova/requirements to get rid of `Q.allSettled`

Behavior of cordova/requirements should remain unchanged.

2 months agoUse `superspawn` to get rid of `Q.defer` in plugman/install
Raphael von der Grün [Sat, 29 Sep 2018 09:04:56 +0000 (11:04 +0200)] 
Use `superspawn` to get rid of `Q.defer` in plugman/install

2 months agoReplace `Q.delay` with npm package `delay`
Raphael von der Grün [Sat, 29 Sep 2018 09:04:55 +0000 (11:04 +0200)] 
Replace `Q.delay` with npm package `delay`

2 months agoFix linting error `prefer-promise-reject-errors`
Raphael von der Grün [Sat, 29 Sep 2018 09:04:54 +0000 (11:04 +0200)] 
Fix linting error `prefer-promise-reject-errors`

2 months agoSearch and replace usage of Q's static API
Raphael von der Grün [Sat, 29 Sep 2018 09:04:52 +0000 (11:04 +0200)] 
Search and replace usage of Q's static API

2 months agoReplace leftover usage of Q's instance API
Raphael von der Grün [Sat, 29 Sep 2018 09:04:51 +0000 (11:04 +0200)] 
Replace leftover usage of Q's instance API

2 months agoMerge pull request #687 from raphinesse/to-serve-and-protect
Raphael von der Grün [Sat, 29 Sep 2018 00:07:42 +0000 (02:07 +0200)] 
Merge pull request #687 from raphinesse/to-serve-and-protect

Test, fix and cleanup `cordova serve`

2 months agoMerge pull request #707 from raphinesse/deprecate-requireCordovaModule
Raphael von der Grün [Fri, 28 Sep 2018 23:38:49 +0000 (01:38 +0200)] 
Merge pull request #707 from raphinesse/deprecate-requireCordovaModule

Deprecate `requireCordovaModule` for non-Cordova modules

2 months agoUpdate JSDoc and clarify inline comments 707/head
Raphael von der Grün [Fri, 28 Sep 2018 16:59:46 +0000 (18:59 +0200)] 
Update JSDoc and clarify inline comments

2 months agoEmit deprecation warning when requiring non-cordova modules
Raphael von der Grün [Fri, 28 Sep 2018 16:59:45 +0000 (18:59 +0200)] 
Emit deprecation warning when requiring non-cordova modules

2 months agoFix for module names that start with "cordova-lib"
Raphael von der Grün [Fri, 28 Sep 2018 16:59:43 +0000 (18:59 +0200)] 
Fix for module names that start with "cordova-lib"

2 months agoAdd unit tests for `Context#requireCordovaModule`
Raphael von der Grün [Fri, 28 Sep 2018 16:59:42 +0000 (18:59 +0200)] 
Add unit tests for `Context#requireCordovaModule`

Some of these are failing at this point

2 months agoDereference possible symlinks when copying plugin (#705)
Oliver Salzburg [Tue, 25 Sep 2018 11:06:17 +0000 (13:06 +0200)] 
Dereference possible symlinks when copying plugin (#705)

When `npm install`ing a local plugin, npm will create a symlink to the source. When we then attempt to copy that symlink, the result will be invalid on Windows OS. Thus, we need to dereference the link/junction and create a proper copy.

Fixes #700
Fixes #704

2 months agoIncrease timeout for cordova.platform e2e tests (#699)
Raphael von der Grün [Tue, 18 Sep 2018 12:04:26 +0000 (14:04 +0200)] 
Increase timeout for cordova.platform e2e tests (#699)

2 months agoIncrease plugman install test timeout (#698)
Raphael von der Grün [Tue, 18 Sep 2018 11:18:43 +0000 (13:18 +0200)] 
Increase plugman install test timeout (#698)

3 months agoUpdate cordova-windows pattern to ~6.0.0 (#691)
Chris Brody [Fri, 14 Sep 2018 14:16:39 +0000 (10:16 -0400)] 
Update cordova-windows pattern to ~6.0.0 (#691)

3 months agoStart 9.0.0-dev (#690)
Chris Brody [Wed, 12 Sep 2018 19:36:52 +0000 (15:36 -0400)] 
Start 9.0.0-dev (#690)

3 months agoFix waiting for launched server 687/head
Raphael von der Grün [Sat, 8 Sep 2018 15:19:41 +0000 (17:19 +0200)] 
Fix waiting for launched server

3 months agoAdd failing test for handling failed server launch
Raphael von der Grün [Sat, 8 Sep 2018 15:19:40 +0000 (17:19 +0200)] 
Add failing test for handling failed server launch

3 months agoOrganize imports
Raphael von der Grün [Sat, 8 Sep 2018 15:19:39 +0000 (17:19 +0200)] 
Organize imports

3 months agoImprove tests after improving testability
Raphael von der Grün [Sat, 8 Sep 2018 15:19:38 +0000 (17:19 +0200)] 
Improve tests after improving testability

3 months agoImprove testability of main export
Raphael von der Grün [Sat, 8 Sep 2018 15:19:37 +0000 (17:19 +0200)] 
Improve testability of main export

3 months agoMake use of express default 404
Raphael von der Grün [Sat, 8 Sep 2018 15:19:36 +0000 (17:19 +0200)] 
Make use of express default 404

3 months agoRender index page from a template
Raphael von der Grün [Sat, 8 Sep 2018 15:19:34 +0000 (17:19 +0200)] 
Render index page from a template

The template is virtually identical with the previously generated one.
There's minimal style changes and a few HTML fixes.

3 months agoSimplify absolute path handler
Raphael von der Grün [Sat, 8 Sep 2018 15:19:33 +0000 (17:19 +0200)] 
Simplify absolute path handler

3 months agoRefactor platform serve handler & add tests
Raphael von der Grün [Sat, 8 Sep 2018 15:19:32 +0000 (17:19 +0200)] 
Refactor platform serve handler & add tests

3 months agoUse `md5-file` to calculate MD5 sum of files
Raphael von der Grün [Sat, 8 Sep 2018 15:19:31 +0000 (17:19 +0200)] 
Use `md5-file` to calculate MD5 sum of files

3 months agoCorrectly reject promise when failing
Raphael von der Grün [Sat, 8 Sep 2018 15:19:30 +0000 (17:19 +0200)] 
Correctly reject promise when failing

3 months agoAdd failing test resulting in pending promise
Raphael von der Grün [Sat, 8 Sep 2018 15:19:29 +0000 (17:19 +0200)] 
Add failing test resulting in pending promise

3 months agoFix globby usage in cordova/serve
Raphael von der Grün [Sat, 8 Sep 2018 15:19:28 +0000 (17:19 +0200)] 
Fix globby usage in cordova/serve

3 months agoCB-7078 Rewrite disabled test for serve as unit test
Raphael von der Grün [Sat, 8 Sep 2018 15:19:27 +0000 (17:19 +0200)] 
CB-7078 Rewrite disabled test for serve as unit test

3 months agoRemove support for old option format (#686)
Raphael von der Grün [Fri, 7 Sep 2018 14:38:27 +0000 (16:38 +0200)] 
Remove support for old option format (#686)

Remove support for handling pre-5.4.0 style options

3 months agoRemove unused dependency properties-parser (#685)
Raphael von der Grün [Fri, 7 Sep 2018 14:29:14 +0000 (16:29 +0200)] 
Remove unused dependency properties-parser (#685)

Was not found earlier, since it is "used" in our test fixtures.

3 months agoMerge pull request #677 from raphinesse/fix-addhelper-tests
Raphael von der Grün [Fri, 7 Sep 2018 14:09:22 +0000 (16:09 +0200)] 
Merge pull request #677 from raphinesse/fix-addhelper-tests

Fix `cordova/platform/addHelper` tests

3 months agoFix faking cordova.prepare by faking require 677/head
Raphael von der Grün [Wed, 5 Sep 2018 18:56:04 +0000 (20:56 +0200)] 
Fix faking cordova.prepare by faking require

3 months agoClean up test double setup a bit
Raphael von der Grün [Wed, 5 Sep 2018 19:16:34 +0000 (21:16 +0200)] 
Clean up test double setup a bit

3 months agoFix test in addHelper.spec
Raphael von der Grün [Tue, 14 Aug 2018 18:41:44 +0000 (20:41 +0200)] 
Fix test in addHelper.spec

3 months agoWait for promise in cordova/platform/addHelper.spec
Raphael von der Grün [Tue, 14 Aug 2018 18:00:28 +0000 (20:00 +0200)] 
Wait for promise in cordova/platform/addHelper.spec

3 months agoMerge pull request #679 from raphinesse/platform.spec-cleanup
Raphael von der Grün [Fri, 7 Sep 2018 07:46:19 +0000 (09:46 +0200)] 
Merge pull request #679 from raphinesse/platform.spec-cleanup

platform.spec cleanup

3 months agoMerge pull request #684 from raphinesse/bits-and-pieces
Raphael von der Grün [Fri, 7 Sep 2018 00:08:41 +0000 (02:08 +0200)] 
Merge pull request #684 from raphinesse/bits-and-pieces

Bits and pieces

3 months agoFix two instances of broken Promises 684/head
Raphael von der Grün [Thu, 6 Sep 2018 09:16:05 +0000 (11:16 +0200)] 
Fix two instances of broken Promises

3 months agoDon't fake return values for functions that return `undefined`
Raphael von der Grün [Tue, 4 Sep 2018 23:29:00 +0000 (01:29 +0200)] 
Don't fake return values for functions that return `undefined`

3 months agoReduce test timeout in plugman/install.spec
Raphael von der Grün [Tue, 28 Aug 2018 18:09:33 +0000 (20:09 +0200)] 
Reduce test timeout in plugman/install.spec

3 months agoProperly join paths in plugman/platform
Raphael von der Grün [Tue, 4 Sep 2018 23:18:43 +0000 (01:18 +0200)] 
Properly join paths in plugman/platform

3 months agoStricter checks in cordova/restore-util.spec
Raphael von der Grün [Sun, 26 Aug 2018 19:32:30 +0000 (21:32 +0200)] 
Stricter checks in cordova/restore-util.spec

3 months agoSimplify hooks/Context using `Object.assign`
Raphael von der Grün [Mon, 27 Aug 2018 00:39:06 +0000 (02:39 +0200)] 
Simplify hooks/Context using `Object.assign`

3 months agoRemove unused npm utility functions (#683)
Raphael von der Grün [Thu, 6 Sep 2018 22:16:49 +0000 (00:16 +0200)] 
Remove unused npm utility functions (#683)

This also removes usage of Q-specific functionality (see #681)

3 months agoGH-676 Remove browserify (#682)
Raphael von der Grün [Thu, 6 Sep 2018 22:02:26 +0000 (00:02 +0200)] 
GH-676 Remove browserify (#682)

Resolves #676

3 months agoDo not install two platforms in plugin-focused test 008 679/head
Raphael von der Grün [Thu, 6 Sep 2018 18:20:49 +0000 (20:20 +0200)] 
Do not install two platforms in plugin-focused test 008

3 months agoGet rid of all the extra describe blocks
Raphael von der Grün [Thu, 6 Sep 2018 17:46:28 +0000 (19:46 +0200)] 
Get rid of all the extra describe blocks

3 months agoRemove 006 since it's a subset of 008 since removing --fetch
Raphael von der Grün [Thu, 6 Sep 2018 17:41:09 +0000 (19:41 +0200)] 
Remove 006 since it's a subset of 008 since removing --fetch

3 months agoFix commented-out test parts in 008
Raphael von der Grün [Thu, 6 Sep 2018 16:39:56 +0000 (18:39 +0200)] 
Fix commented-out test parts in 008

3 months agoRe-enable testing platform update
Raphael von der Grün [Thu, 6 Sep 2018 17:29:16 +0000 (19:29 +0200)] 
Re-enable testing platform update

3 months agoMerge tests 002 and 003 as they were doing the same thing
Raphael von der Grün [Thu, 6 Sep 2018 16:35:04 +0000 (18:35 +0200)] 
Merge tests 002 and 003 as they were doing the same thing

3 months agoUse fixture project instead of calling `cordova create`
Raphael von der Grün [Thu, 6 Sep 2018 16:30:23 +0000 (18:30 +0200)] 
Use fixture project instead of calling `cordova create`

3 months agoSilence noisy output caused by `cordova-browser`
Raphael von der Grün [Wed, 5 Sep 2018 23:57:27 +0000 (01:57 +0200)] 
Silence noisy output caused by `cordova-browser`

3 months agoFactor out project creation
Raphael von der Grün [Wed, 5 Sep 2018 23:42:54 +0000 (01:42 +0200)] 
Factor out project creation

3 months agoRe-enable more stuff
Raphael von der Grün [Wed, 5 Sep 2018 23:38:37 +0000 (01:38 +0200)] 
Re-enable more stuff

3 months agoMake use of existing path variables
Raphael von der Grün [Wed, 5 Sep 2018 23:25:52 +0000 (01:25 +0200)] 
Make use of existing path variables

3 months agoRe-enable platform.spec tests 001-003
Raphael von der Grün [Wed, 5 Sep 2018 21:07:00 +0000 (23:07 +0200)] 
Re-enable platform.spec tests 001-003

3 months agoIncrease test timeouts to 2min for all tests
Raphael von der Grün [Wed, 5 Sep 2018 20:47:45 +0000 (22:47 +0200)] 
Increase test timeouts to 2min for all tests

Hopefully will make timeouts like CI-3 in #642 less likely

3 months agoSimpler checking of installed platforms
Raphael von der Grün [Wed, 5 Sep 2018 00:43:17 +0000 (02:43 +0200)] 
Simpler checking of installed platforms

3 months agoFactor out common setup & teardown
Raphael von der Grün [Wed, 5 Sep 2018 00:28:56 +0000 (02:28 +0200)] 
Factor out common setup & teardown

3 months agoDestructure test helpers for easier access
Raphael von der Grün [Wed, 5 Sep 2018 00:17:45 +0000 (02:17 +0200)] 
Destructure test helpers for easier access

3 months agoOrganize imports
Raphael von der Grün [Wed, 5 Sep 2018 00:11:27 +0000 (02:11 +0200)] 
Organize imports

3 months agoUse const and let
Raphael von der Grün [Wed, 5 Sep 2018 00:08:13 +0000 (02:08 +0200)] 
Use const and let

3 months agoUse arrow functions
Raphael von der Grün [Wed, 5 Sep 2018 00:05:49 +0000 (02:05 +0200)] 
Use arrow functions

3 months agoPromise chain formatting
Raphael von der Grün [Tue, 4 Sep 2018 23:48:36 +0000 (01:48 +0200)] 
Promise chain formatting

3 months agoMake plugin.remove more easily understandable (#652)
Raphael von der Grün [Thu, 6 Sep 2018 18:03:16 +0000 (20:03 +0200)] 
Make plugin.remove more easily understandable (#652)

No functional changes. A by-product of debugging this module.

3 months agoMake cordova/platform/check more approachable (#650)
Raphael von der Grün [Thu, 6 Sep 2018 18:02:32 +0000 (20:02 +0200)] 
Make cordova/platform/check more approachable (#650)

This should not change anything regarding functionality just make the
code a _little_ more approachable and less horrible.

This was originally created during an effort to remove Q API usage.

3 months agoFix tests that are failing with npm config 'save-exact' set (#678)
Oliver Salzburg [Thu, 6 Sep 2018 15:30:00 +0000 (17:30 +0200)] 
Fix tests that are failing with npm config 'save-exact' set (#678)

3 months agoMerge pull request #675 from raphinesse/one-root-describe-per-suite
Raphael von der Grün [Wed, 5 Sep 2018 09:34:02 +0000 (11:34 +0200)] 
Merge pull request #675 from raphinesse/one-root-describe-per-suite

One root `describe` per suite

3 months agoMerge pull request #674 from raphinesse/plugman_install-cleanup
Raphael von der Grün [Wed, 5 Sep 2018 09:31:21 +0000 (11:31 +0200)] 
Merge pull request #674 from raphinesse/plugman_install-cleanup

plugman/install.spec cleanup

3 months agoMerge pull request #672 from raphinesse/plugman_uninstall-cleanup
Raphael von der Grün [Wed, 5 Sep 2018 09:29:49 +0000 (11:29 +0200)] 
Merge pull request #672 from raphinesse/plugman_uninstall-cleanup

plugman_uninstall.spec cleanup

3 months agoEnforce one root `describe` per suite 675/head
Raphael von der Grün [Mon, 3 Sep 2018 20:30:49 +0000 (22:30 +0200)] 
Enforce one root `describe` per suite

3 months agoRemove duplicated test from cordova-create
Raphael von der Grün [Mon, 3 Sep 2018 20:08:31 +0000 (22:08 +0200)] 
Remove duplicated test from cordova-create

Instead, only test that calling `create` does not fail

3 months agoDelete totally useless tests
Raphael von der Grün [Mon, 3 Sep 2018 20:00:14 +0000 (22:00 +0200)] 
Delete totally useless tests

3 months agoFix eslint warning 674/head
Raphael von der Grün [Tue, 4 Sep 2018 21:22:32 +0000 (23:22 +0200)] 
Fix eslint warning

3 months agoSimplify spying for install events
Raphael von der Grün [Tue, 4 Sep 2018 21:16:00 +0000 (23:16 +0200)] 
Simplify spying for install events

3 months agoFix expected-rejection promise handling
Raphael von der Grün [Tue, 4 Sep 2018 20:54:00 +0000 (22:54 +0200)] 
Fix expected-rejection promise handling

3 months agoUse arrow functions
Raphael von der Grün [Tue, 4 Sep 2018 20:46:03 +0000 (22:46 +0200)] 
Use arrow functions

3 months agoUse class
Raphael von der Grün [Tue, 4 Sep 2018 20:57:05 +0000 (22:57 +0200)] 
Use class

3 months agoUse const & let
Raphael von der Grün [Mon, 3 Sep 2018 23:11:18 +0000 (01:11 +0200)] 
Use const & let

3 months agoMove setup code to beforeAll
Raphael von der Grün [Mon, 3 Sep 2018 23:09:15 +0000 (01:09 +0200)] 
Move setup code to beforeAll

3 months agoDo cleanup in afterAll
Raphael von der Grün [Mon, 3 Sep 2018 22:53:01 +0000 (00:53 +0200)] 
Do cleanup in afterAll

3 months agoSimplify getting paths to test plugins
Raphael von der Grün [Mon, 3 Sep 2018 22:23:23 +0000 (00:23 +0200)] 
Simplify getting paths to test plugins

3 months agoSimplify collecting `results` events
Raphael von der Grün [Tue, 4 Sep 2018 20:34:27 +0000 (22:34 +0200)] 
Simplify collecting `results` events

3 months agoCosmetic changes
Raphael von der Grün [Tue, 4 Sep 2018 20:33:23 +0000 (22:33 +0200)] 
Cosmetic changes

3 months agoRemove unnecessary test setup
Raphael von der Grün [Tue, 4 Sep 2018 20:31:39 +0000 (22:31 +0200)] 
Remove unnecessary test setup

3 months agoOrganize imports
Raphael von der Grün [Mon, 3 Sep 2018 21:03:52 +0000 (23:03 +0200)] 
Organize imports