cordova-lib.git
2 years agochore: consolidate eslint configs (#828)
エリス [Wed, 27 Nov 2019 12:23:37 +0000 (21:23 +0900)] 
chore: consolidate eslint configs (#828)

2 years agotest: move cordova/platform/{platform => addHelper} (#803)
Raphael von der Grün [Sat, 23 Nov 2019 01:46:56 +0000 (02:46 +0100)] 
test: move cordova/platform/{platform => addHelper} (#803)

Following an existing TODO to get rid of an obsolete spec file.

2 years agofix: plugin installation from git url w/ semver (#827)
Raphael von der Grün [Fri, 22 Nov 2019 11:42:11 +0000 (12:42 +0100)] 
fix: plugin installation from git url w/ semver (#827)

AFAICT, the check that is removed here was part of our previous plugin
fetching mechanism and was not removed when migrating to cordova-fetch.

Fixes #795

2 years agotest: use fs.copySync for increased performance (#826)
Raphael von der Grün [Sat, 16 Nov 2019 12:56:41 +0000 (13:56 +0100)] 
test: use fs.copySync for increased performance (#826)

2 years agotest(e2e): re-enable HooksRunner#12 and move it to plugin#14 (#823)
Raphael von der Grün [Fri, 15 Nov 2019 15:36:30 +0000 (16:36 +0100)] 
test(e2e): re-enable HooksRunner#12 and move it to plugin#14 (#823)

HooksRunner#12 did not actually test the HooksRunner class at all but
instead tested what arguments plugin (un)install hooks would receive.
Therefore it's a better fit for the plugin E2E tests.

The test code has been cleaned up in the process without making
essential changes to what is being tested.

2 years agostyle: fix linting violations (#824)
Raphael von der Grün [Fri, 15 Nov 2019 12:20:56 +0000 (13:20 +0100)] 
style: fix linting violations (#824)

2 years agofeat: proper support for scoped plugins (#821)
Raphael von der Grün [Fri, 15 Nov 2019 11:36:12 +0000 (12:36 +0100)] 
feat: proper support for scoped plugins (#821)

* Merge PluginSpec.scope into PluginSpec.id

* Store scoped plugins in same dir structure as in node_modules

* Update and extend E2E tests for adding scoped plugins

* Fix plugman.uninstall for scoped plugins

* Remove top_plugins override

* Pass pluginsDir to get_fetch_metadata to support scoped plugins

* Fix cordova/util.findPlugins for scoped plugins

* Update to cordova-common@4.0.0-nightly

2 years agorefactor: eslint setup (#822)
エリス [Fri, 15 Nov 2019 02:06:05 +0000 (11:06 +0900)] 
refactor: eslint setup (#822)

* refactor: eslint setup

* replace dependencies with @cordova/eslint-config
* update eslint config
* eslint corrections
* chore: readded linebreak-style & promise/catch-or-return

2 years agorefactor: remove stub interface to `cordova-create` (#820)
Raphael von der Grün [Mon, 11 Nov 2019 12:41:31 +0000 (13:41 +0100)] 
refactor: remove stub interface to `cordova-create` (#820)

Instead, `cordova-create` should be depended on directly by its users.

Follow-up to apache/cordova-cli#489

BREAKING CHANGE: removes export `cordova.create`

2 years agorefactor: use execa's cross-platform shebang support in HooksRunner (#819)
Raphael von der Grün [Mon, 11 Nov 2019 12:40:01 +0000 (13:40 +0100)] 
refactor: use execa's cross-platform shebang support in HooksRunner (#819)

Up until now, we have maintained code for shebang support in hook
scripts on Windows. Fortunately, execa comes with support for that out
of the box. So this commit drops our implementation and makes use of
execa's.

2 years agochore: replace superspawn with execa (#812)
エリス [Fri, 8 Nov 2019 09:46:19 +0000 (18:46 +0900)] 
chore: replace superspawn with execa (#812)

* chore: replace superspawn with execa
* chore: remove comments
* chore: move catch to onRejected
* chore: move catch to onRejected
* chore: bump execa dependency
* chore: remove unused execa require

Co-Authored-By: Raphael von der Grün <raphinesse@gmail.com>
* Remove duplicate spy strategy application
* Show error message instead of stderr in info command
* Fix failSafeSpawn to always return a string
This also minimizes the diff
* Change warning as error.message already includes exit code
* Remove chmod option that was unique to superspawn
* Replace superspawn's printCommand w/ manual logging
* Use execa's error message which is a better version of the current one
* Minimize diff

2 years agochore: remove plugin save (#781)
エリス [Thu, 7 Nov 2019 16:16:57 +0000 (01:16 +0900)] 
chore: remove plugin save (#781)

2 years agochore: deprecate plugin save command (#780)
エリス [Thu, 7 Nov 2019 15:55:11 +0000 (00:55 +0900)] 
chore: deprecate plugin save command (#780)

2 years agoExtend and improve plugin tests in preparation of supporting scoped plugins (#818)
Raphael von der Grün [Wed, 6 Nov 2019 19:20:05 +0000 (20:20 +0100)] 
Extend and improve plugin tests in preparation of supporting scoped plugins (#818)

* Extend tests for addHelper.installPluginsForNewPlatform

Co-authored-by: Raphael von der Grün <raphinesse@gmail.com>
* Test plugin/add.getFetchVersion w/ scoped plugins

Co-authored-by: Raphael von der Grün <raphinesse@gmail.com>
* Add passing unit tests for plugman/util/metadata

Co-authored-by: Raphael von der Grün <raphinesse@gmail.com>
* Simplify and extend unit tests for cordova/util.findPlugins

* Less strict path comparison in plugman_fetch.spec

2 years agochore: bump production dependencies (#810)
エリス [Wed, 6 Nov 2019 06:50:02 +0000 (15:50 +0900)] 
chore: bump production dependencies (#810)

* detect-indent@^6.0.0
* fs-extra@^8.1.0
* globby@^10.0.1
* indent-string@^4.0.0
* read-chunk@^3.2.0
* semver@^6.3.0
* shebang-command@^2.0.0

2 years agoSimplify jasmine configuration (#816)
Raphael von der Grün [Sat, 2 Nov 2019 19:29:40 +0000 (20:29 +0100)] 
Simplify jasmine configuration (#816)

- use one shared jasmine.json for all tests
- remove key with default values from jasmine.json
- use default location spec/support/jasmine.json for configuration

2 years agoRemove dead code in integration-tests/plugin.spec (#817)
Raphael von der Grün [Sat, 2 Nov 2019 19:28:23 +0000 (20:28 +0100)] 
Remove dead code in integration-tests/plugin.spec (#817)

2 years agoDo not spawn child process to get platform version (#815)
Raphael von der Grün [Thu, 31 Oct 2019 07:10:18 +0000 (08:10 +0100)] 
Do not spawn child process to get platform version (#815)

2 years agoplugman_fetch.spec cleanup (#813)
Raphael von der Grün [Wed, 30 Oct 2019 15:15:26 +0000 (16:15 +0100)] 
plugman_fetch.spec cleanup (#813)

* Use Jasmine's built-in call counting

* Remove unnecessary wrapping in path.join

* Fix and re-enable disabled test

2 years agoRemove obsolete and duplicate ignore entries (#814)
Raphael von der Grün [Wed, 30 Oct 2019 15:14:41 +0000 (16:14 +0100)] 
Remove obsolete and duplicate ignore entries (#814)

2 years agochore: improve npm ignore list (#809)
エリス [Wed, 30 Oct 2019 01:36:57 +0000 (10:36 +0900)] 
chore: improve npm ignore list (#809)

= BEFORE =
npm notice package size:  105.7 kB
npm notice unpacked size: 487.6 kB
npm notice total files:   86

= AFTER =
npm notice package size:  88.3 kB
npm notice unpacked size: 394.7 kB
npm notice total files:   66

2 years agochore: update jasmine dependencies (#811)
エリス [Wed, 30 Oct 2019 01:30:51 +0000 (10:30 +0900)] 
chore: update jasmine dependencies (#811)

2 years agoRemove unused module plugman/platforms/common (#808)
Raphael von der Grün [Thu, 24 Oct 2019 09:54:52 +0000 (11:54 +0200)] 
Remove unused module plugman/platforms/common (#808)

2 years agoBreak dependency cycles (#807)
Raphael von der Grün [Mon, 21 Oct 2019 16:39:31 +0000 (18:39 +0200)] 
Break dependency cycles (#807)

* Break cycles caused by require-facade anti-pattern

All these dependency cycles were caused by sub-package members
requiring their respective sub-package facade module when all they
needed was another member from their own sub-package.

Cycles that were broken by this:
- cordova/{cordova > build}
- cordova/{cordova > emulate}
- cordova/{cordova > run}
- cordova/{cordova > serve}
- cordova/platform/{index > addHelper}
- plugman/{plugman > install}

* Break cycle between cordova/util and platforms/platforms

We do this by moving `cordova/util.hostSupports` to the `platforms`
sub-package. To not further pollute `platforms/platforms`, we introduce
a new facade module for the `platforms` sub-package.

`platforms/platforms` remains for the time being, especially because it
is part of our public interface (see `cordova-lib.js`).

This commit also simplifies the platforms.hostSupports utility function.
The support for indicating no host requirements by setting `hostos: '*'`
is dropped in favor of letting `hostos` undefined.

* Break cycles involving cordova/prepare.preparePlatforms

To achieve this, preparePlatforms had to be extracted into its own
module, so it could be required separately from cordova/prepare.
It now lives in cordova/prepare/platforms.

Cycles that were broken by this:

- cordova/{prepare > restore-util > ... > platform/addHelper}
- cordova/{prepare > restore-util > ... > plugin/add}
- cordova/{prepare > restore-util > ... > plugin/remove}

* Re-enable tests that needed to spy on preparePlatforms

These tests were disabled because it was difficult to spy on
preparePlatforms since it was only required during runtime.

The test in cordova/plugin/add.spec wasn't even implemented. I did my
best to follow the tests description with my implementation.

2 years agoFix cordova/emulate.spec (#804)
Raphael von der Grün [Sun, 20 Oct 2019 18:34:08 +0000 (20:34 +0200)] 
Fix cordova/emulate.spec (#804)

* Fix copy/paste errors in cordova/emulate.spec

* Remove filtering-out of non-existant platform

2 years agoRemove unused exports from cordova/util (#806)
Raphael von der Grün [Sun, 20 Oct 2019 11:31:39 +0000 (13:31 +0200)] 
Remove unused exports from cordova/util (#806)

* Remove unused support for global cordova config

* Remove unused exports and functions from cordova/util

2 years agoRemove support for obsolete <project>/.cordova/config.json (#805)
Raphael von der Grün [Sat, 19 Oct 2019 17:26:14 +0000 (19:26 +0200)] 
Remove support for obsolete <project>/.cordova/config.json (#805)

* Remove cordova/config module

* Remove obsolete function plugin.util.saveToConfigXmlOn

2 years agoMinor code cleanup (#802)
Raphael von der Grün [Mon, 14 Oct 2019 14:25:16 +0000 (16:25 +0200)] 
Minor code cleanup (#802)

* Simplify require path

* Break up overly long comment line

* Remove some mentions of --fetch in comments

* Remove commented out code

2 years agoDo not run legacy hooks from dirs anymore (#797)
Raphael von der Grün [Thu, 10 Oct 2019 17:57:42 +0000 (19:57 +0200)] 
Do not run legacy hooks from dirs anymore (#797)

2 years agoRemove platform.check (#800)
Raphael von der Grün [Thu, 10 Oct 2019 17:54:36 +0000 (19:54 +0200)] 
Remove platform.check (#800)

2 years agoRemove code to handle plugins that were added by cordova@<5.4.0 (#765)
Raphael von der Grün [Thu, 10 Oct 2019 17:40:14 +0000 (19:40 +0200)] 
Remove code to handle plugins that were added by cordova@<5.4.0 (#765)

2 years agoRemove parts of plugman that have been moved to the plugman repo (#766)
Raphael von der Grün [Thu, 10 Oct 2019 15:02:36 +0000 (17:02 +0200)] 
Remove parts of plugman that have been moved to the plugman repo (#766)

* Move CLI interface plugman.commands from cordova-lib to plugman

* Remove unused plugman.help (had been moved to plugman repo)

2 years agoReplace underscore with modern JS (#772)
Raphael von der Grün [Thu, 10 Oct 2019 14:58:48 +0000 (16:58 +0200)] 
Replace underscore with modern JS (#772)

* _.extend => Object.assign

* Rewrite plugman/variable-merge w/out underscore

* _.find => Array.prototype.find

* _.clone => Object.assign

* Rewrite plugman/util/dependencies w/out underscore

* Remove last occurence of underscore usage

* Remove dependency on underscore

2 years agochore: drop node 6 and 8 support (#799)
Raphael von der Grün [Thu, 10 Oct 2019 14:46:12 +0000 (16:46 +0200)] 
chore: drop node 6 and 8 support (#799)

2 years agochore: bump version to 10.0.0-dev (#798)
Raphael von der Grün [Thu, 10 Oct 2019 14:44:32 +0000 (16:44 +0200)] 
chore: bump version to 10.0.0-dev (#798)

2 years agoUse up-to-date fixtures in tests (#770)
Raphael von der Grün [Thu, 10 Oct 2019 13:26:00 +0000 (15:26 +0200)] 
Use up-to-date fixtures in tests (#770)

* Add helper to get up-to-date test fixtures

* Use up-to-date project fixture in E2E plugin dependency tests

* Use up-to-date platform fixture in plugman.install tests

* Use up-to-date platform in HooksRunner E2E tests

* Use up-to-date platform fixture in plugman.uninstall tests

* Use up-to-date project fixture in pkgJson plugin E2E tests

* Use up-to-date platform fixture in plugin.spec E2E tests

* Remove unused and outdated Android project fixture

* Remove unused project fixture "base"

* Use cordova-test-platform to test platform installation from local path

* Remove unused cordova-browser fixture

* Use cordova-test-platform to test getInstalledPlatformsWithVersions

* Remove unused cordova-android fixture

* Use testPlatformApp fixture to test cordova/util.getPlatformApiFunction

* Finally remove shelljs (again)

Had to be kept in devDeps before because of some outdated fixtures

* Make platformApi fixture project a minimal stub

2 years agoHooksRunner code & spec cleanup (#796)
Raphael von der Grün [Thu, 10 Oct 2019 08:50:51 +0000 (10:50 +0200)] 
HooksRunner code & spec cleanup (#796)

* Cleanup HooksRunner code

* Merge the 'plugin hooks' blocks in HooksRunner.spec

* Reduce amount of fixtures for HooksRunner test

2 years agofix: error message during plugin installation w/ missing engine (#791)
Geert Ijewski [Fri, 4 Oct 2019 14:39:27 +0000 (16:39 +0200)] 
fix: error message during plugin installation w/ missing engine (#791)

3 years agochore: add Node.js 12 to CI services (#777)
エリス [Sun, 21 Jul 2019 05:27:19 +0000 (14:27 +0900)] 
chore: add Node.js 12 to CI services (#777)

3 years agoQuick workaround for e2e failure on AppVeyor CI (#786)
Chris Brody [Tue, 18 Jun 2019 21:38:17 +0000 (17:38 -0400)] 
Quick workaround for e2e failure on AppVeyor CI (#786)

3 years agonyc@14 update in devDependencies (#783)
Chris Brody [Wed, 12 Jun 2019 21:42:56 +0000 (17:42 -0400)] 
nyc@14 update in devDependencies (#783)

3 years agoMerge pull request #775 from raphinesse/cpj-cleanup
Raphael von der Grün [Wed, 17 Apr 2019 00:11:14 +0000 (02:11 +0200)] 
Merge pull request #775 from raphinesse/cpj-cleanup

Cleanup plugman.createPackageJson

3 years agoSimpler and better cordova/util.getPlatformApiFunction (#767)
Raphael von der Grün [Wed, 17 Apr 2019 00:06:37 +0000 (02:06 +0200)] 
Simpler and better cordova/util.getPlatformApiFunction (#767)

* Simpler and better cordova/util.getPlatformApiFunction

* Apply suggestions from code review

Co-Authored-By: raphinesse <raphinesse@gmail.com>
3 years agoCollapse declaration of globals to a single line 775/head
Raphael von der Grün [Mon, 15 Apr 2019 11:37:05 +0000 (13:37 +0200)] 
Collapse declaration of globals to a single line

3 years agoGet rid of hacky default.json file for init-defaults
Raphael von der Grün [Sun, 14 Apr 2019 11:44:22 +0000 (13:44 +0200)] 
Get rid of hacky default.json file for init-defaults

3 years agoRemove unused parameter `test` from `readDeps`
Raphael von der Grün [Mon, 15 Apr 2019 11:15:28 +0000 (13:15 +0200)] 
Remove unused parameter `test` from `readDeps`

The parameter `test` was actually never used in `readDeps`. That means
that both `dependencies` and `devDependencies` will be populated with
_all_ packages installed to node_modules XD

3 years agoRemove unused key `defaults.bugs` in createpackagejson
Raphael von der Grün [Sun, 14 Apr 2019 13:33:57 +0000 (15:33 +0200)] 
Remove unused key `defaults.bugs` in createpackagejson

3 years agoRemove futile attempts to read npm config values
Raphael von der Grün [Sun, 14 Apr 2019 13:04:58 +0000 (15:04 +0200)] 
Remove futile attempts to read npm config values

Our init-defaults.js apparently is a slightly modified copy of
init-package-json/default-input.js. When npm calls `init-package-json`
they probably pass an object parsed from their configuration file.

We on the other hand always pass `{}`. Which means that any call to
`config.get` will return `undefined`.

This commit replaces all these calls in our code with `undefined` and
does some constant folding to tidy things up.

3 years agoMake src/plugman/init-defaults.js lintable (#774)
Raphael von der Grün [Mon, 15 Apr 2019 01:09:49 +0000 (03:09 +0200)] 
Make src/plugman/init-defaults.js lintable (#774)

Work around using the reserved word `package` to be able to lint
src/plugman/init-defaults.js

3 years agoHave plugman.createPackageJson create file in plugin dir, not in cwd (#773)
Raphael von der Grün [Sun, 14 Apr 2019 19:50:25 +0000 (21:50 +0200)] 
Have plugman.createPackageJson create file in plugin dir, not in cwd (#773)

Right now `plugman createpackagejson <plugin dir>` reads values from `plugin.xml` in `<plugin dir>` but creates the `package.json` in `process.cwd()`. This seems to be undocumented behavior, and is considered a bug.

With this patch, we always create the `package.json` in `<plugin dir>` next to `plugin.xml` instead.

3 years agoPrevent masking of errors during testing (#771)
Raphael von der Grün [Sun, 14 Apr 2019 10:47:53 +0000 (12:47 +0200)] 
Prevent masking of errors during testing (#771)

Node.js throws an Error if the error event is emitted on a EventEmitter instance that has no handlers attached for it. This is usually the case during testing and often masks the actual error that is causing the issue.

So we attach a listener to just log error events to console. During passing tests runs, no additional output is generated.

3 years agoProper async code in src/plugman/createpackagejson.js (#768)
Raphael von der Grün [Sun, 14 Apr 2019 10:45:49 +0000 (12:45 +0200)] 
Proper async code in src/plugman/createpackagejson.js (#768)

The existing code returned an instantly resolved promise despite the fact that it was doing async operations.

3 years agoMerge pull request #764 from raphinesse/expressive-pkgJson.spec
Raphael von der Grün [Sat, 13 Apr 2019 09:57:06 +0000 (11:57 +0200)] 
Merge pull request #764 from raphinesse/expressive-pkgJson.spec

Expressive pkg json.spec

3 years agoRemove unnecessary spy (#763)
Raphael von der Grün [Sat, 13 Apr 2019 09:42:33 +0000 (11:42 +0200)] 
Remove unnecessary spy (#763)

The stubbing is not actually needed for the tests. It rather causes problems if the tests are using an up-to-date cordova-android as that currently requires ActionStack.prototype.process to return a Q instance.

3 years agoRemove unused fixtures 764/head
Raphael von der Grün [Sat, 13 Apr 2019 00:14:37 +0000 (02:14 +0200)] 
Remove unused fixtures

3 years agoMerge describe blocks in pkgJson.spec
Raphael von der Grün [Sat, 13 Apr 2019 00:14:36 +0000 (02:14 +0200)] 
Merge describe blocks in pkgJson.spec

3 years agoCreate projects instead of asserting their properties in pkgJson.spec
Raphael von der Grün [Sat, 13 Apr 2019 00:14:35 +0000 (02:14 +0200)] 
Create projects instead of asserting their properties in pkgJson.spec

3 years agoFactor out common project test helpers
Raphael von der Grün [Sat, 13 Apr 2019 00:14:34 +0000 (02:14 +0200)] 
Factor out common project test helpers

3 years agoRemove unused fixtures (#762)
Raphael von der Grün [Fri, 12 Apr 2019 13:30:25 +0000 (15:30 +0200)] 
Remove unused fixtures (#762)

These are only test fixtures, so this is a patch-level change.

Related to #757

3 years agoMerge pull request #761 from raphinesse/misc-test-improvements
Raphael von der Grün [Mon, 1 Apr 2019 14:27:28 +0000 (16:27 +0200)] 
Merge pull request #761 from raphinesse/misc-test-improvements

Various test improvements

3 years agoMinor cleanup of CI configs (#760)
Raphael von der Grün [Mon, 1 Apr 2019 14:25:29 +0000 (16:25 +0200)] 
Minor cleanup of CI configs (#760)

* Cleanup CI configs

* Shallowly clone in AppVeyor CI

3 years agoFix some test descriptions in cordova/util.spec 761/head
Raphael von der Grün [Mon, 1 Apr 2019 10:43:25 +0000 (12:43 +0200)] 
Fix some test descriptions in cordova/util.spec

3 years agoStop cordova/util.spec from messing with the user's home directory!
Raphael von der Grün [Mon, 1 Apr 2019 10:43:24 +0000 (12:43 +0200)] 
Stop cordova/util.spec from messing with the user's home directory!

3 years agoProper temp folder usage in cordova/util.spec
Raphael von der Grün [Mon, 1 Apr 2019 10:43:23 +0000 (12:43 +0200)] 
Proper temp folder usage in cordova/util.spec

3 years agoRemove outdated test from cordova/util.spec
Raphael von der Grün [Mon, 1 Apr 2019 10:43:21 +0000 (12:43 +0200)] 
Remove outdated test from cordova/util.spec

isCordova does not actually care about the user's home directory.

3 years agoRemove rewire/revert anti-pattern
Raphael von der Grün [Mon, 1 Apr 2019 10:43:20 +0000 (12:43 +0200)] 
Remove rewire/revert anti-pattern

There is no need to clear all the test doubles in afterEach if we
re-set them in beforeEach anyway.

3 years agoRemove superspawn faking from HooksRunner.spec
Raphael von der Grün [Mon, 1 Apr 2019 10:43:19 +0000 (12:43 +0200)] 
Remove superspawn faking from HooksRunner.spec

This sets executable bit for plugin hooks launched by superspawn,
so that they actually run.

3 years agoIncremented package version to -dev
Darryl Pogue [Mon, 1 Apr 2019 04:33:36 +0000 (21:33 -0700)] 
Incremented package version to -dev

3 years agoUpdate version and RELEASENOTES for release 9.0.1 9.0.x 9.0.1 rel/9.0.1
Darryl Pogue [Mon, 1 Apr 2019 04:27:31 +0000 (21:27 -0700)] 
Update version and RELEASENOTES for release 9.0.1

3 years agoFix faulty Promise handling in plugman.uninstall (#759)
Raphael von der Grün [Sat, 30 Mar 2019 19:34:01 +0000 (20:34 +0100)] 
Fix faulty Promise handling in plugman.uninstall (#759)

* Fix unhandled rejections with dependent plugin uninstall

This also includes two changes to improve the robustness of plugman_uninstall.spec:
* Proper mock return value for npmUninstall
* Get rid of fs-stubbing

3 years agoRefactor plugin_fetch.spec (#758)
Raphael von der Grün [Sat, 30 Mar 2019 19:28:43 +0000 (20:28 +0100)] 
Refactor plugin_fetch.spec (#758)

- Refactored the test to be more readable, robust and self contained
- Removed the reliance on the outdated fixtures
- Moved the test to spec/ since it is actually a unit test

3 years agoFix restoring plugins from package.json
Darryl Pogue [Fri, 29 Mar 2019 16:44:05 +0000 (09:44 -0700)] 
Fix restoring plugins from package.json

Some of the code removed in GH-750 had side effects on the rest of the
plugin restoration procedure. Namely, despite wanting to migrate to
package.json, we actually relied on config.xml for retrieving the plugin
spec and variables. When we stopped syncing changes back to config.xml,
those plugins stopped getting restored.

I've refactored this significantly to reduce complexity and make it
easier to read and understand.

The existing tests did neither describe nor test the new behavior
sufficiently.

3 years agoDo not wrap engine script path in quotes (#755)
Oliver Salzburg [Wed, 27 Mar 2019 09:04:59 +0000 (10:04 +0100)] 
Do not wrap engine script path in quotes (#755)

Fixes #754
Fixes apache/cordova#52

3 years agoGH-10 Incremented package version to -dev
エリス [Fri, 15 Mar 2019 08:30:26 +0000 (17:30 +0900)] 
GH-10 Incremented package version to -dev

3 years agoGH-10 Updated version and RELEASENOTES.md for release 9.0.0 9.0.0 rel/9.0.0
エリス [Fri, 15 Mar 2019 07:40:23 +0000 (16:40 +0900)] 
GH-10 Updated version and RELEASENOTES.md for release 9.0.0

3 years agoRemove saving platforms/plugins to config.xml (#750)
Darryl Pogue [Fri, 15 Mar 2019 06:13:41 +0000 (23:13 -0700)] 
Remove saving platforms/plugins to config.xml (#750)

We've had one major version of cordova-lib that attempted to ensure both
config.xml and package.json were kept in sync, and now it's time to push
people more strongly towards using package.json.

We will still attempt to read values from config.xml and update them in
package.json, but we will no longer reflect changes back to config.xml.
Whatever's saved in package.json should always have priority over what
is read from config.xml.

The next phase will be to improve the handling of package.json updates,
and then in the next major to completely remove the code that looks at
config.xml for platforms/plugins.

3 years agoPass project config.xml path to platform's prepare (#751)
Darryl Pogue [Fri, 15 Mar 2019 06:12:27 +0000 (23:12 -0700)] 
Pass project config.xml path to platform's prepare (#751)

Currently we're passing in an already-constructed ConfigParser instance
as part of the fake projectInfo object, but the problem is that it's
constructed with the version of cordova-common depended on by
*cordova-lib* as opposed to the version of cordova-common depended on by
the *platform*. By passing the path in, we can construct the
ConfigParser at the Platform API level, using the correct version.

In the meantime, for compatibility reasons, we have to keep passing in a
ConfigParser instance, and the Platform API needs to handle the case
where rootConfigXml is undefined and it needs to fetch the path out of
the existing ConfigParser instance and then overwrite it with a newly
constructed ConfigParser.

We should at some point look into making this "root project info" object
a class in cordova-common so that we can document what it's expected to
contain and rely on that both here and in the platforms.

3 years agoMerge pull request #749 from erisu/cordova-9-prep
エリス [Thu, 14 Mar 2019 03:39:32 +0000 (12:39 +0900)] 
Merge pull request #749 from erisu/cordova-9-prep

Cordova Lib Release Preparation (Cordova 9)

3 years agoRemove unused property apiCompatibleSince from platformsConfig.json 749/head
Raphael von der Grün [Wed, 13 Mar 2019 16:36:42 +0000 (17:36 +0100)] 
Remove unused property apiCompatibleSince from platformsConfig.json

Property is unused since 9f1fbf4918cd

3 years agoFix plugin dependency tests when using npm >= 5
Raphael von der Grün [Wed, 13 Mar 2019 15:27:51 +0000 (16:27 +0100)] 
Fix plugin dependency tests when using npm >= 5

npm >= 5 automatically prunes any unsaved packages during installation
(see https://github.com/npm/npm/issues/16853). Therefore, installing
platforms and plugins without saving them to package.json is essentially
broken right now.

3 years agoBump All Platform Pinning and Support Minor SemVer
エリス [Wed, 13 Mar 2019 07:10:03 +0000 (16:10 +0900)] 
Bump All Platform Pinning and Support Minor SemVer

3 years agoBump dependency jasmine@^3.3.1
エリス [Wed, 13 Mar 2019 06:29:43 +0000 (15:29 +0900)] 
Bump dependency jasmine@^3.3.1

3 years agoBump dependency globby@^9.1.0
エリス [Wed, 13 Mar 2019 06:24:13 +0000 (15:24 +0900)] 
Bump dependency globby@^9.1.0

3 years agoBump dependency underscore@^1.9.1
エリス [Wed, 13 Mar 2019 06:12:54 +0000 (15:12 +0900)] 
Bump dependency underscore@^1.9.1

3 years agoBump dependency semver@^5.6.0
エリス [Wed, 13 Mar 2019 06:12:09 +0000 (15:12 +0900)] 
Bump dependency semver@^5.6.0

3 years agoBump dependency read-chunk@^3.1.0
エリス [Wed, 13 Mar 2019 06:11:18 +0000 (15:11 +0900)] 
Bump dependency read-chunk@^3.1.0

3 years agoBump dependency init-package-json@^1.10.3
エリス [Wed, 13 Mar 2019 06:10:37 +0000 (15:10 +0900)] 
Bump dependency init-package-json@^1.10.3

3 years agoBumped dependency fs-extra@^7.0.1
エリス [Wed, 13 Mar 2019 06:09:55 +0000 (15:09 +0900)] 
Bumped dependency fs-extra@^7.0.1

3 years agoAdded missing dev dependency shelljs to fix failing tests
エリス [Wed, 13 Mar 2019 06:02:54 +0000 (15:02 +0900)] 
Added missing dev dependency shelljs to fix failing tests

3 years agoRemove handling of legacy .fetch.json files (#748)
Raphael von der Grün [Tue, 12 Mar 2019 15:16:45 +0000 (16:16 +0100)] 
Remove handling of legacy .fetch.json files (#748)

The files in question have last been used in Cordova 4.3.0 and have been
removed by commit c49eaa86c92b.

3 years agoUpdated Dev Dependencies
エリス [Tue, 12 Mar 2019 07:45:38 +0000 (16:45 +0900)] 
Updated Dev Dependencies

- codecov@^3.2.0
- delay@^4.1.0

3 years agoUpdated nyc code coverage dependency
エリス [Tue, 12 Mar 2019 07:06:20 +0000 (16:06 +0900)] 
Updated nyc code coverage dependency

3 years agoUpdated ESlint dependencies with lint corrections
エリス [Tue, 12 Mar 2019 07:04:47 +0000 (16:04 +0900)] 
Updated ESlint dependencies with lint corrections

3 years agoUpdated Package Cordova Dependencies
エリス [Tue, 12 Mar 2019 06:54:12 +0000 (15:54 +0900)] 
Updated Package Cordova Dependencies

- cordova-common@^3.1.0
- cordova-create@^2.0.0
- cordova-fetch@^2.0.0
- cordova-serve@^3.0.0

3 years agoMerge pull request #709 from raphinesse/next-gen-requireCordovaModule
エリス [Tue, 12 Mar 2019 06:44:32 +0000 (15:44 +0900)] 
Merge pull request #709 from raphinesse/next-gen-requireCordovaModule

- Throw error if non-cordova module is required (Resolves #689)
- Remove outdated compatibility layer from 2015
- Lazily load Context.cordova to avoid cyclical dependency
- Use const for imports

3 years agoCB-14166: (cli) Fixed issue when install plugins on windows (#622)
Almir Kadric [Thu, 7 Mar 2019 06:32:22 +0000 (15:32 +0900)] 
CB-14166: (cli) Fixed issue when install plugins on windows (#622)

The npm package name is already wrapped in quotes to prevent special characters from being execute. However the additional win32 code was further injecting quotes around the version causing npm to return a EINVALIDTAGNAME error. The win32 code is redundant and seems to not be required.

3 years agoAdd or update GitHub pull request and issue template
Jan Piotrowski [Mon, 11 Feb 2019 17:37:37 +0000 (18:37 +0100)] 
Add or update GitHub pull request and issue template

3 years agoAdd Electron Platform (#744)
エリス [Tue, 11 Dec 2018 06:36:16 +0000 (15:36 +0900)] 
Add Electron Platform (#744)

* Add Electron Platform
* Updated test spec to include Electron

3 years agoUpdated Platform Config Git URL Paths (#743)
エリス [Tue, 11 Dec 2018 06:35:28 +0000 (15:35 +0900)] 
Updated Platform Config Git URL Paths (#743)

3 years agoCleanup indentation spacing in */jasmine.json (#742)
Chris Brody [Tue, 4 Dec 2018 17:30:17 +0000 (12:30 -0500)] 
Cleanup indentation spacing in */jasmine.json (#742)