cordova-lib.git
3 years agoGH-10 Updated version and RELEASENOTES.md for release 9.0.0 9.0.0 rel/9.0.0
エリス [Fri, 15 Mar 2019 07:40:23 +0000 (16:40 +0900)] 
GH-10 Updated version and RELEASENOTES.md for release 9.0.0

3 years agoRemove saving platforms/plugins to config.xml (#750)
Darryl Pogue [Fri, 15 Mar 2019 06:13:41 +0000 (23:13 -0700)] 
Remove saving platforms/plugins to config.xml (#750)

We've had one major version of cordova-lib that attempted to ensure both
config.xml and package.json were kept in sync, and now it's time to push
people more strongly towards using package.json.

We will still attempt to read values from config.xml and update them in
package.json, but we will no longer reflect changes back to config.xml.
Whatever's saved in package.json should always have priority over what
is read from config.xml.

The next phase will be to improve the handling of package.json updates,
and then in the next major to completely remove the code that looks at
config.xml for platforms/plugins.

3 years agoPass project config.xml path to platform's prepare (#751)
Darryl Pogue [Fri, 15 Mar 2019 06:12:27 +0000 (23:12 -0700)] 
Pass project config.xml path to platform's prepare (#751)

Currently we're passing in an already-constructed ConfigParser instance
as part of the fake projectInfo object, but the problem is that it's
constructed with the version of cordova-common depended on by
*cordova-lib* as opposed to the version of cordova-common depended on by
the *platform*. By passing the path in, we can construct the
ConfigParser at the Platform API level, using the correct version.

In the meantime, for compatibility reasons, we have to keep passing in a
ConfigParser instance, and the Platform API needs to handle the case
where rootConfigXml is undefined and it needs to fetch the path out of
the existing ConfigParser instance and then overwrite it with a newly
constructed ConfigParser.

We should at some point look into making this "root project info" object
a class in cordova-common so that we can document what it's expected to
contain and rely on that both here and in the platforms.

3 years agoMerge pull request #749 from erisu/cordova-9-prep
エリス [Thu, 14 Mar 2019 03:39:32 +0000 (12:39 +0900)] 
Merge pull request #749 from erisu/cordova-9-prep

Cordova Lib Release Preparation (Cordova 9)

3 years agoRemove unused property apiCompatibleSince from platformsConfig.json 749/head
Raphael von der Grün [Wed, 13 Mar 2019 16:36:42 +0000 (17:36 +0100)] 
Remove unused property apiCompatibleSince from platformsConfig.json

Property is unused since 9f1fbf4918cd

3 years agoFix plugin dependency tests when using npm >= 5
Raphael von der Grün [Wed, 13 Mar 2019 15:27:51 +0000 (16:27 +0100)] 
Fix plugin dependency tests when using npm >= 5

npm >= 5 automatically prunes any unsaved packages during installation
(see https://github.com/npm/npm/issues/16853). Therefore, installing
platforms and plugins without saving them to package.json is essentially
broken right now.

3 years agoBump All Platform Pinning and Support Minor SemVer
エリス [Wed, 13 Mar 2019 07:10:03 +0000 (16:10 +0900)] 
Bump All Platform Pinning and Support Minor SemVer

3 years agoBump dependency jasmine@^3.3.1
エリス [Wed, 13 Mar 2019 06:29:43 +0000 (15:29 +0900)] 
Bump dependency jasmine@^3.3.1

3 years agoBump dependency globby@^9.1.0
エリス [Wed, 13 Mar 2019 06:24:13 +0000 (15:24 +0900)] 
Bump dependency globby@^9.1.0

3 years agoBump dependency underscore@^1.9.1
エリス [Wed, 13 Mar 2019 06:12:54 +0000 (15:12 +0900)] 
Bump dependency underscore@^1.9.1

3 years agoBump dependency semver@^5.6.0
エリス [Wed, 13 Mar 2019 06:12:09 +0000 (15:12 +0900)] 
Bump dependency semver@^5.6.0

3 years agoBump dependency read-chunk@^3.1.0
エリス [Wed, 13 Mar 2019 06:11:18 +0000 (15:11 +0900)] 
Bump dependency read-chunk@^3.1.0

3 years agoBump dependency init-package-json@^1.10.3
エリス [Wed, 13 Mar 2019 06:10:37 +0000 (15:10 +0900)] 
Bump dependency init-package-json@^1.10.3

3 years agoBumped dependency fs-extra@^7.0.1
エリス [Wed, 13 Mar 2019 06:09:55 +0000 (15:09 +0900)] 
Bumped dependency fs-extra@^7.0.1

3 years agoAdded missing dev dependency shelljs to fix failing tests
エリス [Wed, 13 Mar 2019 06:02:54 +0000 (15:02 +0900)] 
Added missing dev dependency shelljs to fix failing tests

3 years agoRemove handling of legacy .fetch.json files (#748)
Raphael von der Grün [Tue, 12 Mar 2019 15:16:45 +0000 (16:16 +0100)] 
Remove handling of legacy .fetch.json files (#748)

The files in question have last been used in Cordova 4.3.0 and have been
removed by commit c49eaa86c92b.

3 years agoUpdated Dev Dependencies
エリス [Tue, 12 Mar 2019 07:45:38 +0000 (16:45 +0900)] 
Updated Dev Dependencies

- codecov@^3.2.0
- delay@^4.1.0

3 years agoUpdated nyc code coverage dependency
エリス [Tue, 12 Mar 2019 07:06:20 +0000 (16:06 +0900)] 
Updated nyc code coverage dependency

3 years agoUpdated ESlint dependencies with lint corrections
エリス [Tue, 12 Mar 2019 07:04:47 +0000 (16:04 +0900)] 
Updated ESlint dependencies with lint corrections

3 years agoUpdated Package Cordova Dependencies
エリス [Tue, 12 Mar 2019 06:54:12 +0000 (15:54 +0900)] 
Updated Package Cordova Dependencies

- cordova-common@^3.1.0
- cordova-create@^2.0.0
- cordova-fetch@^2.0.0
- cordova-serve@^3.0.0

3 years agoMerge pull request #709 from raphinesse/next-gen-requireCordovaModule
エリス [Tue, 12 Mar 2019 06:44:32 +0000 (15:44 +0900)] 
Merge pull request #709 from raphinesse/next-gen-requireCordovaModule

- Throw error if non-cordova module is required (Resolves #689)
- Remove outdated compatibility layer from 2015
- Lazily load Context.cordova to avoid cyclical dependency
- Use const for imports

3 years agoCB-14166: (cli) Fixed issue when install plugins on windows (#622)
Almir Kadric [Thu, 7 Mar 2019 06:32:22 +0000 (15:32 +0900)] 
CB-14166: (cli) Fixed issue when install plugins on windows (#622)

The npm package name is already wrapped in quotes to prevent special characters from being execute. However the additional win32 code was further injecting quotes around the version causing npm to return a EINVALIDTAGNAME error. The win32 code is redundant and seems to not be required.

3 years agoAdd or update GitHub pull request and issue template
Jan Piotrowski [Mon, 11 Feb 2019 17:37:37 +0000 (18:37 +0100)] 
Add or update GitHub pull request and issue template

3 years agoAdd Electron Platform (#744)
エリス [Tue, 11 Dec 2018 06:36:16 +0000 (15:36 +0900)] 
Add Electron Platform (#744)

* Add Electron Platform
* Updated test spec to include Electron

3 years agoUpdated Platform Config Git URL Paths (#743)
エリス [Tue, 11 Dec 2018 06:35:28 +0000 (15:35 +0900)] 
Updated Platform Config Git URL Paths (#743)

3 years agoCleanup indentation spacing in */jasmine.json (#742)
Chris Brody [Tue, 4 Dec 2018 17:30:17 +0000 (12:30 -0500)] 
Cleanup indentation spacing in */jasmine.json (#742)

3 years agoFix crash in `cordova requirements` due to an unbound function (#741)
Ran Benita [Tue, 4 Dec 2018 13:52:39 +0000 (15:52 +0200)] 
Fix crash in `cordova requirements` due to an unbound function (#741)

Functions in utils.js expect to be called with `this` bound to the
module. So this call crashed with an error
    this.isCordova is not a function

Fixes #740.

3 years agoremove JIRA link
Jan Piotrowski [Wed, 3 Oct 2018 23:07:21 +0000 (01:07 +0200)] 
remove JIRA link

3 years agoFix 2 integration tests failures on macOS
Darryl Pogue [Sun, 30 Sep 2018 06:47:49 +0000 (23:47 -0700)] 
Fix 2 integration tests failures on macOS

3 years agoMerge pull request #710 from raphinesse/q-nomore
Raphael von der Grün [Sun, 30 Sep 2018 00:26:16 +0000 (02:26 +0200)] 
Merge pull request #710 from raphinesse/q-nomore

Drop dependency on Q, use native promises

3 years agoRemove Q :tada: 710/head
Raphael von der Grün [Sat, 29 Sep 2018 09:05:00 +0000 (11:05 +0200)] 
Remove Q :tada:

3 years agoFix some unhandled promises
Raphael von der Grün [Sat, 29 Sep 2018 09:04:59 +0000 (11:04 +0200)] 
Fix some unhandled promises

3 years agoAdd ESLint rule against unhandled promises
Raphael von der Grün [Sat, 29 Sep 2018 09:04:58 +0000 (11:04 +0200)] 
Add ESLint rule against unhandled promises

3 years agoRewrite cordova/requirements to get rid of `Q.allSettled`
Raphael von der Grün [Sat, 29 Sep 2018 09:04:57 +0000 (11:04 +0200)] 
Rewrite cordova/requirements to get rid of `Q.allSettled`

Behavior of cordova/requirements should remain unchanged.

3 years agoUse `superspawn` to get rid of `Q.defer` in plugman/install
Raphael von der Grün [Sat, 29 Sep 2018 09:04:56 +0000 (11:04 +0200)] 
Use `superspawn` to get rid of `Q.defer` in plugman/install

3 years agoReplace `Q.delay` with npm package `delay`
Raphael von der Grün [Sat, 29 Sep 2018 09:04:55 +0000 (11:04 +0200)] 
Replace `Q.delay` with npm package `delay`

3 years agoFix linting error `prefer-promise-reject-errors`
Raphael von der Grün [Sat, 29 Sep 2018 09:04:54 +0000 (11:04 +0200)] 
Fix linting error `prefer-promise-reject-errors`

3 years agoSearch and replace usage of Q's static API
Raphael von der Grün [Sat, 29 Sep 2018 09:04:52 +0000 (11:04 +0200)] 
Search and replace usage of Q's static API

3 years agoReplace leftover usage of Q's instance API
Raphael von der Grün [Sat, 29 Sep 2018 09:04:51 +0000 (11:04 +0200)] 
Replace leftover usage of Q's instance API

3 years agoMerge pull request #687 from raphinesse/to-serve-and-protect
Raphael von der Grün [Sat, 29 Sep 2018 00:07:42 +0000 (02:07 +0200)] 
Merge pull request #687 from raphinesse/to-serve-and-protect

Test, fix and cleanup `cordova serve`

3 years agoUse const for imports 709/head
Raphael von der Grün [Fri, 28 Sep 2018 23:46:07 +0000 (01:46 +0200)] 
Use const for imports

3 years agoLazily load Context.cordova
Raphael von der Grün [Fri, 28 Sep 2018 19:08:50 +0000 (21:08 +0200)] 
Lazily load Context.cordova

3 years agoRemove compatibility layer from 2015
Raphael von der Grün [Fri, 28 Sep 2018 17:47:17 +0000 (19:47 +0200)] 
Remove compatibility layer from 2015

3 years agoThrow error if non-cordova module is required
Raphael von der Grün [Fri, 28 Sep 2018 15:56:35 +0000 (17:56 +0200)] 
Throw error if non-cordova module is required

Resolves #689

3 years agoMerge pull request #707 from raphinesse/deprecate-requireCordovaModule
Raphael von der Grün [Fri, 28 Sep 2018 23:38:49 +0000 (01:38 +0200)] 
Merge pull request #707 from raphinesse/deprecate-requireCordovaModule

Deprecate `requireCordovaModule` for non-Cordova modules

3 years agoUpdate JSDoc and clarify inline comments 707/head
Raphael von der Grün [Fri, 28 Sep 2018 16:59:46 +0000 (18:59 +0200)] 
Update JSDoc and clarify inline comments

3 years agoEmit deprecation warning when requiring non-cordova modules
Raphael von der Grün [Fri, 28 Sep 2018 16:59:45 +0000 (18:59 +0200)] 
Emit deprecation warning when requiring non-cordova modules

3 years agoFix for module names that start with "cordova-lib"
Raphael von der Grün [Fri, 28 Sep 2018 16:59:43 +0000 (18:59 +0200)] 
Fix for module names that start with "cordova-lib"

3 years agoAdd unit tests for `Context#requireCordovaModule`
Raphael von der Grün [Fri, 28 Sep 2018 16:59:42 +0000 (18:59 +0200)] 
Add unit tests for `Context#requireCordovaModule`

Some of these are failing at this point

3 years agoDereference possible symlinks when copying plugin (#705)
Oliver Salzburg [Tue, 25 Sep 2018 11:06:17 +0000 (13:06 +0200)] 
Dereference possible symlinks when copying plugin (#705)

When `npm install`ing a local plugin, npm will create a symlink to the source. When we then attempt to copy that symlink, the result will be invalid on Windows OS. Thus, we need to dereference the link/junction and create a proper copy.

Fixes #700
Fixes #704

3 years agoIncrease timeout for cordova.platform e2e tests (#699)
Raphael von der Grün [Tue, 18 Sep 2018 12:04:26 +0000 (14:04 +0200)] 
Increase timeout for cordova.platform e2e tests (#699)

3 years agoIncrease plugman install test timeout (#698)
Raphael von der Grün [Tue, 18 Sep 2018 11:18:43 +0000 (13:18 +0200)] 
Increase plugman install test timeout (#698)

3 years agoUpdate cordova-windows pattern to ~6.0.0 (#691)
Chris Brody [Fri, 14 Sep 2018 14:16:39 +0000 (10:16 -0400)] 
Update cordova-windows pattern to ~6.0.0 (#691)

3 years agoStart 9.0.0-dev (#690)
Chris Brody [Wed, 12 Sep 2018 19:36:52 +0000 (15:36 -0400)] 
Start 9.0.0-dev (#690)

3 years agoFix waiting for launched server 687/head
Raphael von der Grün [Sat, 8 Sep 2018 15:19:41 +0000 (17:19 +0200)] 
Fix waiting for launched server

3 years agoAdd failing test for handling failed server launch
Raphael von der Grün [Sat, 8 Sep 2018 15:19:40 +0000 (17:19 +0200)] 
Add failing test for handling failed server launch

3 years agoOrganize imports
Raphael von der Grün [Sat, 8 Sep 2018 15:19:39 +0000 (17:19 +0200)] 
Organize imports

3 years agoImprove tests after improving testability
Raphael von der Grün [Sat, 8 Sep 2018 15:19:38 +0000 (17:19 +0200)] 
Improve tests after improving testability

3 years agoImprove testability of main export
Raphael von der Grün [Sat, 8 Sep 2018 15:19:37 +0000 (17:19 +0200)] 
Improve testability of main export

3 years agoMake use of express default 404
Raphael von der Grün [Sat, 8 Sep 2018 15:19:36 +0000 (17:19 +0200)] 
Make use of express default 404

3 years agoRender index page from a template
Raphael von der Grün [Sat, 8 Sep 2018 15:19:34 +0000 (17:19 +0200)] 
Render index page from a template

The template is virtually identical with the previously generated one.
There's minimal style changes and a few HTML fixes.

3 years agoSimplify absolute path handler
Raphael von der Grün [Sat, 8 Sep 2018 15:19:33 +0000 (17:19 +0200)] 
Simplify absolute path handler

3 years agoRefactor platform serve handler & add tests
Raphael von der Grün [Sat, 8 Sep 2018 15:19:32 +0000 (17:19 +0200)] 
Refactor platform serve handler & add tests

3 years agoUse `md5-file` to calculate MD5 sum of files
Raphael von der Grün [Sat, 8 Sep 2018 15:19:31 +0000 (17:19 +0200)] 
Use `md5-file` to calculate MD5 sum of files

3 years agoCorrectly reject promise when failing
Raphael von der Grün [Sat, 8 Sep 2018 15:19:30 +0000 (17:19 +0200)] 
Correctly reject promise when failing

3 years agoAdd failing test resulting in pending promise
Raphael von der Grün [Sat, 8 Sep 2018 15:19:29 +0000 (17:19 +0200)] 
Add failing test resulting in pending promise

3 years agoFix globby usage in cordova/serve
Raphael von der Grün [Sat, 8 Sep 2018 15:19:28 +0000 (17:19 +0200)] 
Fix globby usage in cordova/serve

3 years agoCB-7078 Rewrite disabled test for serve as unit test
Raphael von der Grün [Sat, 8 Sep 2018 15:19:27 +0000 (17:19 +0200)] 
CB-7078 Rewrite disabled test for serve as unit test

3 years agoRemove support for old option format (#686)
Raphael von der Grün [Fri, 7 Sep 2018 14:38:27 +0000 (16:38 +0200)] 
Remove support for old option format (#686)

Remove support for handling pre-5.4.0 style options

3 years agoRemove unused dependency properties-parser (#685)
Raphael von der Grün [Fri, 7 Sep 2018 14:29:14 +0000 (16:29 +0200)] 
Remove unused dependency properties-parser (#685)

Was not found earlier, since it is "used" in our test fixtures.

3 years agoMerge pull request #677 from raphinesse/fix-addhelper-tests
Raphael von der Grün [Fri, 7 Sep 2018 14:09:22 +0000 (16:09 +0200)] 
Merge pull request #677 from raphinesse/fix-addhelper-tests

Fix `cordova/platform/addHelper` tests

3 years agoFix faking cordova.prepare by faking require 677/head
Raphael von der Grün [Wed, 5 Sep 2018 18:56:04 +0000 (20:56 +0200)] 
Fix faking cordova.prepare by faking require

3 years agoClean up test double setup a bit
Raphael von der Grün [Wed, 5 Sep 2018 19:16:34 +0000 (21:16 +0200)] 
Clean up test double setup a bit

3 years agoFix test in addHelper.spec
Raphael von der Grün [Tue, 14 Aug 2018 18:41:44 +0000 (20:41 +0200)] 
Fix test in addHelper.spec

3 years agoWait for promise in cordova/platform/addHelper.spec
Raphael von der Grün [Tue, 14 Aug 2018 18:00:28 +0000 (20:00 +0200)] 
Wait for promise in cordova/platform/addHelper.spec

3 years agoMerge pull request #679 from raphinesse/platform.spec-cleanup
Raphael von der Grün [Fri, 7 Sep 2018 07:46:19 +0000 (09:46 +0200)] 
Merge pull request #679 from raphinesse/platform.spec-cleanup

platform.spec cleanup

3 years agoMerge pull request #684 from raphinesse/bits-and-pieces
Raphael von der Grün [Fri, 7 Sep 2018 00:08:41 +0000 (02:08 +0200)] 
Merge pull request #684 from raphinesse/bits-and-pieces

Bits and pieces

3 years agoFix two instances of broken Promises 684/head
Raphael von der Grün [Thu, 6 Sep 2018 09:16:05 +0000 (11:16 +0200)] 
Fix two instances of broken Promises

3 years agoDon't fake return values for functions that return `undefined`
Raphael von der Grün [Tue, 4 Sep 2018 23:29:00 +0000 (01:29 +0200)] 
Don't fake return values for functions that return `undefined`

3 years agoReduce test timeout in plugman/install.spec
Raphael von der Grün [Tue, 28 Aug 2018 18:09:33 +0000 (20:09 +0200)] 
Reduce test timeout in plugman/install.spec

3 years agoProperly join paths in plugman/platform
Raphael von der Grün [Tue, 4 Sep 2018 23:18:43 +0000 (01:18 +0200)] 
Properly join paths in plugman/platform

3 years agoStricter checks in cordova/restore-util.spec
Raphael von der Grün [Sun, 26 Aug 2018 19:32:30 +0000 (21:32 +0200)] 
Stricter checks in cordova/restore-util.spec

3 years agoSimplify hooks/Context using `Object.assign`
Raphael von der Grün [Mon, 27 Aug 2018 00:39:06 +0000 (02:39 +0200)] 
Simplify hooks/Context using `Object.assign`

3 years agoRemove unused npm utility functions (#683)
Raphael von der Grün [Thu, 6 Sep 2018 22:16:49 +0000 (00:16 +0200)] 
Remove unused npm utility functions (#683)

This also removes usage of Q-specific functionality (see #681)

3 years agoGH-676 Remove browserify (#682)
Raphael von der Grün [Thu, 6 Sep 2018 22:02:26 +0000 (00:02 +0200)] 
GH-676 Remove browserify (#682)

Resolves #676

3 years agoDo not install two platforms in plugin-focused test 008 679/head
Raphael von der Grün [Thu, 6 Sep 2018 18:20:49 +0000 (20:20 +0200)] 
Do not install two platforms in plugin-focused test 008

3 years agoGet rid of all the extra describe blocks
Raphael von der Grün [Thu, 6 Sep 2018 17:46:28 +0000 (19:46 +0200)] 
Get rid of all the extra describe blocks

3 years agoRemove 006 since it's a subset of 008 since removing --fetch
Raphael von der Grün [Thu, 6 Sep 2018 17:41:09 +0000 (19:41 +0200)] 
Remove 006 since it's a subset of 008 since removing --fetch

3 years agoFix commented-out test parts in 008
Raphael von der Grün [Thu, 6 Sep 2018 16:39:56 +0000 (18:39 +0200)] 
Fix commented-out test parts in 008

3 years agoRe-enable testing platform update
Raphael von der Grün [Thu, 6 Sep 2018 17:29:16 +0000 (19:29 +0200)] 
Re-enable testing platform update

3 years agoMerge tests 002 and 003 as they were doing the same thing
Raphael von der Grün [Thu, 6 Sep 2018 16:35:04 +0000 (18:35 +0200)] 
Merge tests 002 and 003 as they were doing the same thing

3 years agoUse fixture project instead of calling `cordova create`
Raphael von der Grün [Thu, 6 Sep 2018 16:30:23 +0000 (18:30 +0200)] 
Use fixture project instead of calling `cordova create`

3 years agoSilence noisy output caused by `cordova-browser`
Raphael von der Grün [Wed, 5 Sep 2018 23:57:27 +0000 (01:57 +0200)] 
Silence noisy output caused by `cordova-browser`

3 years agoFactor out project creation
Raphael von der Grün [Wed, 5 Sep 2018 23:42:54 +0000 (01:42 +0200)] 
Factor out project creation

3 years agoRe-enable more stuff
Raphael von der Grün [Wed, 5 Sep 2018 23:38:37 +0000 (01:38 +0200)] 
Re-enable more stuff

3 years agoMake use of existing path variables
Raphael von der Grün [Wed, 5 Sep 2018 23:25:52 +0000 (01:25 +0200)] 
Make use of existing path variables

3 years agoRe-enable platform.spec tests 001-003
Raphael von der Grün [Wed, 5 Sep 2018 21:07:00 +0000 (23:07 +0200)] 
Re-enable platform.spec tests 001-003

3 years agoIncrease test timeouts to 2min for all tests
Raphael von der Grün [Wed, 5 Sep 2018 20:47:45 +0000 (22:47 +0200)] 
Increase test timeouts to 2min for all tests

Hopefully will make timeouts like CI-3 in #642 less likely

3 years agoSimpler checking of installed platforms
Raphael von der Grün [Wed, 5 Sep 2018 00:43:17 +0000 (02:43 +0200)] 
Simpler checking of installed platforms

3 years agoFactor out common setup & teardown
Raphael von der Grün [Wed, 5 Sep 2018 00:28:56 +0000 (02:28 +0200)] 
Factor out common setup & teardown