Moses Berra [Tue, 18 Aug 2020 17:45:52 +0000 (12:45 -0500)]
undo whitespace changes due to editor preferrences
Moses Berra [Tue, 18 Aug 2020 17:40:13 +0000 (12:40 -0500)]
ios: added InAppBrowserStatusBarStyle preference (#728)
Dave Alden [Thu, 23 Jul 2020 11:50:21 +0000 (12:50 +0100)]
Merge pull request #738 from lazydan/master
(ios): Fix incorrect view height from the second open time
Tim Brust [Fri, 3 Jul 2020 18:50:02 +0000 (18:50 +0000)]
chore: adds package-lock file (#748)
Tim Brust [Fri, 3 Jul 2020 13:31:23 +0000 (13:31 +0000)]
chore(npm): use short notation in package.json (#746)
Tim Brust [Thu, 2 Jul 2020 15:41:21 +0000 (15:41 +0000)]
refactor(eslint): use cordova-eslint /w fix (#747)
jcesarmobile [Mon, 22 Jun 2020 09:44:39 +0000 (11:44 +0200)]
fix(ios): exit event not fired on swipe down (#737)
lazydan [Fri, 19 Jun 2020 16:56:52 +0000 (00:56 +0800)]
(ios): Fix incorrect view height from the second open time
Niklas Merz [Tue, 9 Jun 2020 16:57:10 +0000 (18:57 +0200)]
Incremented plugin version. (cordova-plugin-inappbrowser-4.0.0)
Niklas Merz [Tue, 9 Jun 2020 16:54:58 +0000 (18:54 +0200)]
Updated version and RELEASENOTES.md for release 4.0.0 (cordova-plugin-inappbrowser-4.0.0)
Niklas Merz [Fri, 5 Jun 2020 13:23:10 +0000 (15:23 +0200)]
(ios): fix regression in
2706f34 (#715)
Fix merging issue from #656
Closes #714
jcesarmobile [Thu, 4 Jun 2020 14:48:03 +0000 (16:48 +0200)]
chore: update install engines (#685)
PDLMobileApps [Thu, 4 Jun 2020 14:32:07 +0000 (10:32 -0400)]
(ios) Remove fake status bar with hardcoded height to fix issues in iOS devices with a notch (#656)
* (ios) Removed fake statusbar with hardcoded height to fix issues in iOS devices with a notch
* (ios) Removed no longer needed bgToolbar
* (ios) Fixed issue with rotation in landscape mode and refactored/simplified the code
Co-authored-by: Alessandro Basso <Alessandro.Basso@PeapodDigitalLabs.com>
Dani Palou [Sat, 16 May 2020 22:24:36 +0000 (00:24 +0200)]
fix(ios): Allow loading local html files (#693)
Nicolas HENRY [Fri, 8 May 2020 12:02:39 +0000 (14:02 +0200)]
GH-292 android: SSL errors handling in Android (#293)
jcesarmobile [Mon, 27 Apr 2020 15:54:02 +0000 (17:54 +0200)]
fix(ios): prevent statusbar rotation after closing InAppBrowser (#672)
Erisu [Wed, 22 Apr 2020 04:41:11 +0000 (13:41 +0900)]
chore(asf): update git notification settings
csware [Tue, 14 Apr 2020 17:22:08 +0000 (19:22 +0200)]
Allow App using inappbrowser to be hosted in a cross-origin ifra… (#669)
Signed-off-by: Sven Strickroth <email@cs-ware.de>
Niklas Merz [Tue, 14 Apr 2020 13:25:54 +0000 (15:25 +0200)]
(all platforms): remove "window.open" overwrite (#600)
Closes #599
Tim Brust [Tue, 14 Apr 2020 12:56:53 +0000 (12:56 +0000)]
chore: bump version to 4.0.0-dev (#670)
Niklas Merz [Mon, 13 Apr 2020 12:29:50 +0000 (14:29 +0200)]
Update CONTRIBUTING.md
Tim Brust [Tue, 7 Apr 2020 13:20:36 +0000 (13:20 +0000)]
docs: replaces outdated transition and presentation style links (#662)
jcesarmobile [Mon, 6 Apr 2020 13:21:22 +0000 (15:21 +0200)]
chore: remove deprecated orientation methods (#666)
Kamil Burek [Fri, 3 Apr 2020 12:08:32 +0000 (13:08 +0100)]
Fix incorrect TypeScript typings (#515)
* fix #514
* Update based on conversation in #514
* Fixed whitespace
Jim Wright [Mon, 30 Mar 2020 10:47:30 +0000 (11:47 +0100)]
[GH-652] add check for openInSystem postNotification (#654)
Co-authored-by: Jim Wright <jim.wright@masabi.com>
Tim Brust [Fri, 27 Mar 2020 18:24:32 +0000 (18:24 +0000)]
ci: updates Node.js versions (#659)
Tim Brust [Fri, 27 Mar 2020 18:24:22 +0000 (18:24 +0000)]
chore(npm): improve ignore list (#658)
Jesse MacFadyen [Wed, 25 Mar 2020 18:08:04 +0000 (11:08 -0700)]
fix(android): Reset lefttoright if not set (#442)
This fixes #441
Mosab A [Wed, 25 Mar 2020 17:18:41 +0000 (19:18 +0200)]
[android] Correcting the documentation regarding lefttoright opt… (#648)
PDLMobileApps [Tue, 24 Mar 2020 13:24:14 +0000 (09:24 -0400)]
(android) Added option to turn on/off fullscreen mode in Android (#634)
* (android) Added option to turn on/off fullscreen mode in Android
* (android) Reverted version changes as requested
* (android) Changing default option value to enabled as per request
Co-authored-by: Alessandro Basso <Alessandro.Basso@PeapodDigitalLabs.com>
Slayterik [Fri, 20 Mar 2020 14:07:48 +0000 (17:07 +0300)]
Android GH-470 InAppBrowser: java.lang.IllegalArgumentException (#616)
Fix interacting with views when Activity destroyed
Bug description https://stackoverflow.com/questions/
22924825/view-not-attached-to-window-manager-crash
Co-authored-by: Sarafanov Valeriy <sarafanov_v@firma-gamma.ru>
jcesarmobile [Thu, 5 Mar 2020 14:51:31 +0000 (15:51 +0100)]
breaking(ios): remove UIWebView (#635)
Niklas Merz [Mon, 6 Jan 2020 06:23:15 +0000 (07:23 +0100)]
chore(release): 3.2.1-dev
Niklas Merz [Mon, 6 Jan 2020 06:20:07 +0000 (07:20 +0100)]
(ios) fix regression in injectScriptFile
Fixes issue introduced in #584
Niklas Merz [Sat, 4 Jan 2020 08:43:11 +0000 (09:43 +0100)]
chore(release): release notes for 3.2.0
Niklas Merz [Sat, 4 Jan 2020 08:24:36 +0000 (09:24 +0100)]
chore(release): 3.2.0 (version string)
Niklas Merz [Sat, 4 Jan 2020 07:57:52 +0000 (08:57 +0100)]
Merge pull request #503 from alexyazvinsky/def-fix
(android) Defensive code to prevent NULL reference exceptions for async
Maik Hummel [Wed, 27 Nov 2019 16:25:59 +0000 (17:25 +0100)]
(ios) add compile-time decision for disabling UIWebView (#584)
Niklas Merz [Thu, 2 Jan 2020 20:27:59 +0000 (21:27 +0100)]
chore(release): 3.2.0-dev
Niklas Merz [Thu, 2 Jan 2020 18:53:36 +0000 (19:53 +0100)]
(android) improve defensive code for NULL check
Alex Yaz [Tue, 26 Mar 2019 14:46:49 +0000 (10:46 -0400)]
(android) defensive code to prevent NULL reference exceptions for async
Signed-off-by: Niklas Merz <niklasmerz@apache.org>
Lorenzo B [Mon, 30 Dec 2019 09:47:37 +0000 (10:47 +0100)]
Replace "beforeload" with BEFORELOAD (#524)
Improve code formatting
mosababubakr [Mon, 4 Nov 2019 15:23:44 +0000 (17:23 +0200)]
Update missing closed brace to the insert.CSS (#568)
Norman Breau [Sun, 3 Nov 2019 15:09:54 +0000 (11:09 -0400)]
Merge pull request #567 from mosababubakr/patch-1
Update missing closed brace to the insert.CSS
mosababubakr [Sun, 3 Nov 2019 14:56:59 +0000 (16:56 +0200)]
Update missing closed brace to the insert.CSS
Dave Alden [Tue, 24 Sep 2019 15:21:19 +0000 (16:21 +0100)]
Merge pull request #401 from GEDYSIntraWare/bridge
Move bridge creation to injectDeferredObject
Dave Alden [Tue, 24 Sep 2019 14:43:48 +0000 (15:43 +0100)]
Merge pull request #534 from GEDYSIntraWare/fix-show-ios13
Fix inappbrowser not opening on iOS 13 by using reusable window. Resolves #492
Niklas Merz [Tue, 24 Sep 2019 14:28:07 +0000 (16:28 +0200)]
Fix unresponsive main window after hide
Niklas Merz [Mon, 23 Sep 2019 08:29:31 +0000 (10:29 +0200)]
Move window hiding to 'browserExit'
Fixes close, hide and toolbar 'done' and makes cordova window responsive
Niklas Merz [Fri, 20 Sep 2019 13:48:27 +0000 (15:48 +0200)]
New fix attempt
Niklas Merz [Fri, 20 Sep 2019 11:43:57 +0000 (13:43 +0200)]
Use tmpWindow and hide on close
Niklas Merz [Fri, 6 Sep 2019 12:14:51 +0000 (14:14 +0200)]
(ios) Fix iOS 13 show not working
Removed tmpWindow and controller.
This was introduced to fix IAB with WKWebView before WKIAB existed.
Niklas Merz [Fri, 6 Sep 2019 11:53:36 +0000 (13:53 +0200)]
Finish revert and correct Xcode warnings
Niklas Merz [Fri, 6 Sep 2019 06:29:55 +0000 (08:29 +0200)]
(ios) Fix inappbrowser not opening on iOS 13 by using reusable window
Closes #492
Jan Piotrowski [Mon, 1 Jul 2019 18:26:57 +0000 (20:26 +0200)]
ci(travis): upgrade to node8
Jan Piotrowski [Thu, 27 Jun 2019 21:31:13 +0000 (23:31 +0200)]
chore(release): 3.1.1-dev
Jan Piotrowski [Thu, 27 Jun 2019 21:20:54 +0000 (23:20 +0200)]
chore(release): 3.1.0 (version string)
Jan Piotrowski [Thu, 27 Jun 2019 21:20:54 +0000 (23:20 +0200)]
chore(release): release notes for 3.1.0
Jan Piotrowski [Thu, 27 Jun 2019 19:21:56 +0000 (21:21 +0200)]
chore: fix repo and issue urls and license in package.json and plugin.xml
Jan Piotrowski [Thu, 27 Jun 2019 19:15:40 +0000 (21:15 +0200)]
build: add `.npmignore` to remove unneeded files from npm package
Jan Piotrowski [Thu, 27 Jun 2019 19:15:22 +0000 (21:15 +0200)]
build: add `.gitattributes` to force LF (instead of possible CRLF on Windows)
Jan Piotrowski [Thu, 20 Jun 2019 13:19:13 +0000 (15:19 +0200)]
ci(travis): Update Travis CI configuration for new paramedic (#478)
* Update Travis CI configuration for new paramedic
* remove wrong ADDITIONAL_TESTS_DIR
* Update .travis.yml
* remove failing platform
Jan Piotrowski [Thu, 20 Jun 2019 13:18:42 +0000 (15:18 +0200)]
docs: remove outdated translations
Ralph Gutkowski [Wed, 12 Jun 2019 19:03:23 +0000 (21:03 +0200)]
Fix beforeload for Android <= 7 (#427)
* Fix beforeload for Android <= 7
* Change Android version check conditional
Jesse MacFadyen [Tue, 9 Apr 2019 17:49:41 +0000 (10:49 -0700)]
Fix failing CI tests (#460)
* bump node version to 6
* use default travis osx_image of xcode9.4
* comment out flakey local test
Jesse MacFadyen [Wed, 6 Mar 2019 08:00:48 +0000 (00:00 -0800)]
Merge pull request #440 from cordova-develop/fix-close-event-test
Fix test spec.5 to close inappbrowser after loadstop event
Jesse MacFadyen [Wed, 6 Mar 2019 07:55:34 +0000 (23:55 -0800)]
Merge pull request #383 from cvanem/master
Example documentation - Fix messageCallBack and beforeloadCallBack function names
Jesse MacFadyen [Wed, 6 Mar 2019 07:31:12 +0000 (23:31 -0800)]
Merge pull request #262 from landsbankinn/CB-13969
Cb 13969 - Allow close button and navigation buttons positions to be swapped
Jesse MacFadyen [Wed, 6 Mar 2019 07:27:13 +0000 (23:27 -0800)]
Merge pull request #439 from apache/revert-353-patch-1
Revert "Add support for right to left direction languages"
I mistakenly merged #353 instead of a similar one.
KNaito [Wed, 6 Mar 2019 02:47:21 +0000 (11:47 +0900)]
Fix test spec.5 to close inappbrowser after loadstop event
Jesse MacFadyen [Wed, 6 Mar 2019 01:56:34 +0000 (17:56 -0800)]
Revert "Add support for right to left direction languages"
Jesse MacFadyen [Wed, 6 Mar 2019 01:34:19 +0000 (17:34 -0800)]
Merge pull request #353 from transoceanic/patch-1
Add support for right to left direction languages
Jesse MacFadyen [Sat, 2 Mar 2019 04:54:49 +0000 (20:54 -0800)]
Merge pull request #436 from purplecabbage/ValidateCallbackId
[android] Prevent malformed callbackId from reaching app cordova view
Jesse MacFadyen [Thu, 28 Feb 2019 22:52:01 +0000 (14:52 -0800)]
Prevent malformed callbackId from reaching app cordova view
Steinar Ágúst [Thu, 28 Feb 2019 15:17:24 +0000 (15:17 +0000)]
CB-13969 fixing README to be correct for lefttoright option
Steinar Ágúst [Thu, 28 Feb 2019 14:39:26 +0000 (14:39 +0000)]
CB-13969 functionality extended to WKWebView
steinaragustli [Thu, 28 Feb 2019 14:11:04 +0000 (14:11 +0000)]
CB-13969 fix inappbrowser.css to be unmodified
Steinar Ágúst [Thu, 28 Feb 2019 14:05:05 +0000 (14:05 +0000)]
CB-13969 reverting to older version of inappbrowser.css to leave it out of PR
Steinar Á. Steinarsson [Thu, 28 Feb 2019 13:04:21 +0000 (13:04 +0000)]
CB-13969 trying to fix some wierd issue for PR
Steinar Á. Steinarsson [Thu, 28 Feb 2019 13:02:04 +0000 (13:02 +0000)]
CB-13969 trying to fix some wierd issue for PR
steinaragustli [Thu, 28 Feb 2019 12:50:53 +0000 (12:50 +0000)]
CB-13969 trying to remove inappbrowser from pr
steinaragustli [Thu, 28 Feb 2019 12:50:02 +0000 (12:50 +0000)]
CB-13969 trying to remove inappbrowser.css from pr
Steinar Ágúst [Thu, 28 Feb 2019 12:36:28 +0000 (12:36 +0000)]
CB-13969 adding newline at end of inappbrowser.cs
Steinar Ágúst [Thu, 28 Feb 2019 12:32:59 +0000 (12:32 +0000)]
CB-13969 fixing inappbrowser.css
Steinar Ágúst [Thu, 28 Feb 2019 12:28:58 +0000 (12:28 +0000)]
CB-13969 updating README.MD to better explain lefttoright parameter option, reverting unneccesary indent changes on inappbrowser.css
Steinar Ágúst [Thu, 28 Feb 2019 11:43:34 +0000 (11:43 +0000)]
Merge remote-tracking branch 'upstream/master'
Jan Piotrowski [Fri, 22 Feb 2019 17:27:30 +0000 (18:27 +0100)]
Add headline to window.open documentation (#406)
Dave Alden [Mon, 11 Feb 2019 23:14:18 +0000 (23:14 +0000)]
(iOS) Fix iframes in iOS/WKWebView which were broken by #418. Fixes #424. (#425)
Jan Piotrowski [Mon, 11 Feb 2019 17:39:42 +0000 (18:39 +0100)]
Add or update GitHub pull request and issue template
Dave Alden [Sun, 10 Feb 2019 17:06:35 +0000 (17:06 +0000)]
GH-417: Handle non-default target attribute values (e.g. target=on links in WKWebView implementation on iOS (#418)
Tim Brust [Tue, 29 Jan 2019 21:54:54 +0000 (22:54 +0100)]
fix(typescript): remove unused replace parameter (#410)
This closes #295
Niklas Merz [Wed, 16 Jan 2019 13:18:35 +0000 (14:18 +0100)]
(ios) Move createIframeBridge to injectDeferredObject
Avoid failed script injections for pages which did not finish loading.
cvanem [Tue, 25 Dec 2018 22:01:43 +0000 (15:01 -0700)]
Example documentation - Fix callBack function name
Dave Alden [Thu, 20 Dec 2018 19:31:14 +0000 (19:31 +0000)]
GH-359: Fix beforeload to work with POST requests (#367)
### Platforms affected
iOS and Android
### What does this PR do?
Fixes the behaviour of `beforeload` to resolve the problem with POST requests outlined in #359.
The `beforeload` parameter has been changed from taking only a boolean (`yes` or not defined) to a discrete string with possible values of `get`, `post`, or `yes` which correspond to request types of GET, POST or GET&POST respectively. The `README.md` has been updated to reflect this.
Note that use of `beforeload` to intercept POST requests is currently not supported on Android or iOS, so if `beforeload=yes` is specified and a POST request is detected as the HTTP request method, `beforeload` behaviour will not be applied. If `beforeload=post` is specified, a `loaderror` event will be dispatched which states that POST requests are not yet supported.
#### Notes for Android
The `shouldOverrideUrlLoading()` override method has been updated to support the [new method interface added in API 24 / Android 7][1] which receives the `WebResourceRequest` instead of just the `String url`, enabling the HTTP method of the request to be determined. The [deprecated method interface][2] has also been preserved for API <=23, but in this case the HTTP method cannot be determined so is passed as null.
Also note that due to a [Chromium bug](https://bugs.chromium.org/p/chromium/issues/detail?id=155250), `shouldOverrideUrlLoading()` is currently not called for POST requests. It's possible this may be resolved in a future Chromium version in the Android System Webview (given that this is now self-updating and independent of Android version since Android 5.0) - in prospective anticipation of this, code to handle POST requests has been added to `shouldOverrideUrlLoading()`.
However, it seems more likely that this won't be resolved any time soon given that [a Chromium dev said](https://bugs.chromium.org/p/chromium/issues/detail?id=155250#c39):
> We're looking at implementing a better way to handle request interception in a future OS version. There's no way to just "fix" this, the API doesn't accommodate this usage at all. This will not be something you can use any time soon.
Therefore if we want to go ahead and use `beforeload` to intercept request types other than GET, it's likely we'll instead need to use the `shouldInterceptRequest()` method override. As with `shouldOverrideUrlLoading()`, there are a two variants: the [new method interface][3] added in API 21 / Android 5.0 which which receives the `WebResourceRequest` object and the [deprecated one][4] which receives only `String url`. If we want to determine the HTTP request method, we'll need to use the new implementation. This has been empirically tested and *is* called for POST requests so would allow the possibility to intercept, delay, modify and send the POST request and its data via `beforeload`.
Both `shouldInterceptRequest()` method interfaces have been exposed in the Android implentation for potential future use but they currently do nothing other than return the unadulterated request object.
### What testing has been done on this change?
Manual testing of POST and GET requests on both platforms using a test app container:
https://github.com/dpa99c/cordova-plugin-inappbrowser-test
[1]: https://developer.android.com/reference/android/webkit/WebViewClient.html#shouldOverrideUrlLoading(android.webkit.WebView,%20android.webkit.WebResourceRequest)
[2]: https://developer.android.com/reference/android/webkit/WebViewClient.html#shouldOverrideUrlLoading(android.webkit.WebView,%20java.lang.String)
[3]: https://developer.android.com/reference/android/webkit/WebViewClient.html#shouldInterceptRequest(android.webkit.WebView,%20android.webkit.WebResourceRequest)
[4]: https://developer.android.com/reference/android/webkit/WebViewClient.html#shouldInterceptRequest(android.webkit.WebView,%20java.lang.String)
Dave Alden [Thu, 13 Dec 2018 16:21:45 +0000 (16:21 +0000)]
(iOS & Android) Add postMessage API support (#362)
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist
is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
Android
iOS (both UIWebView & WKWebView implementations)
### What does this PR do?
Adds support for [postMessage API](https://developer.mozilla.org/en-US/docs/Web/API/Window/postMessage) enabling pages loaded into the InappBrowser to post messages back to the parent Webview of the Cordova app.
For example, sending event messages associated with UI interactions such as button clicks from the wrapped page back to the parent app Webview.
### What testing has been done on this change?
Automated tests have been extended to cover the `message` event.
### Checklist
- [x ] Commit message follows the format: "GH-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [ x] Added automated test coverage as appropriate for this change.
transoceanic [Thu, 22 Nov 2018 13:45:34 +0000 (15:45 +0200)]
Added to support android devices with right to left direction languages (issue #352)
Dave Alden [Wed, 21 Nov 2018 18:04:04 +0000 (18:04 +0000)]
Fixes loadAfterBeforeload on iOS. Resolves #349. (#350)
For both UIWebView and WKWebView implementations on iOS.
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist
is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
iOS
### What does this PR do?
Fixes `beforeload` event (introduced by #276) for iOS
### What testing has been done on this change?
Tested both allow & deny loading of URL with both iOS implementations in [test container app](https://github.com/dpa99c/cordova-plugin-inappbrowser-wkwebview-test) (ignore its README).
- To test with UIWebView use options: `beforeload=yes,usewkwebview=no`
- To test with WKWebView use options: `beforeload=yes,usewkwebview=yes`
### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [x] Added automated test coverage as appropriate for this change.
closes #349
Dave Alden [Tue, 20 Nov 2018 16:12:29 +0000 (16:12 +0000)]
Fix crashes when using WKWebView implementation on iOS 9. (#337)
Fixes #323. Fixes #324.
Jonathan Li [Mon, 19 Nov 2018 17:28:25 +0000 (12:28 -0500)]
Fix iOS CDVWKInAppBrowser evaluateJavascript method randomly gets blocked on ios 12 (#341)
### Platforms affected
iOS
### What does this PR do?
fix issue[ #340](https://github.com/apache/cordova-plugin-inappbrowser/issues/340) iOS CDVWKInAppBrowser evaluateJavascript method randomly gets blocked on iOS 12
### What testing has been done on this change?
manual testing
### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [ ] Added automated test coverage as appropriate for this change.
Jan Piotrowski [Tue, 6 Nov 2018 18:53:54 +0000 (19:53 +0100)]
remove unwanted information in README table (#308)
remove unwanted information in README table