cordova-plugin-inappbrowser.git
2 years agoci(travis): upgrade to node8 504/head
Jan Piotrowski [Mon, 1 Jul 2019 18:26:57 +0000 (20:26 +0200)] 
ci(travis): upgrade to node8

3 years agochore(release): 3.1.1-dev
Jan Piotrowski [Thu, 27 Jun 2019 21:31:13 +0000 (23:31 +0200)] 
chore(release): 3.1.1-dev

3 years agochore(release): 3.1.0 (version string) 3.1.0 rel/3.1.0
Jan Piotrowski [Thu, 27 Jun 2019 21:20:54 +0000 (23:20 +0200)] 
chore(release): 3.1.0 (version string)

3 years agochore(release): release notes for 3.1.0
Jan Piotrowski [Thu, 27 Jun 2019 21:20:54 +0000 (23:20 +0200)] 
chore(release): release notes for 3.1.0

3 years agochore: fix repo and issue urls and license in package.json and plugin.xml
Jan Piotrowski [Thu, 27 Jun 2019 19:21:56 +0000 (21:21 +0200)] 
chore: fix repo and issue urls and license in package.json and plugin.xml

3 years agobuild: add `.npmignore` to remove unneeded files from npm package
Jan Piotrowski [Thu, 27 Jun 2019 19:15:40 +0000 (21:15 +0200)] 
build: add `.npmignore` to remove unneeded files from npm package

3 years agobuild: add `.gitattributes` to force LF (instead of possible CRLF on Windows)
Jan Piotrowski [Thu, 27 Jun 2019 19:15:22 +0000 (21:15 +0200)] 
build: add `.gitattributes` to force LF (instead of possible CRLF on Windows)

3 years agoci(travis): Update Travis CI configuration for new paramedic (#478)
Jan Piotrowski [Thu, 20 Jun 2019 13:19:13 +0000 (15:19 +0200)] 
ci(travis): Update Travis CI configuration for new paramedic (#478)

* Update Travis CI configuration for new paramedic

* remove wrong ADDITIONAL_TESTS_DIR

* Update .travis.yml

* remove failing platform

3 years agodocs: remove outdated translations
Jan Piotrowski [Thu, 20 Jun 2019 13:18:42 +0000 (15:18 +0200)] 
docs: remove outdated translations

3 years agoFix beforeload for Android <= 7 (#427)
Ralph Gutkowski [Wed, 12 Jun 2019 19:03:23 +0000 (21:03 +0200)] 
Fix beforeload for Android <= 7 (#427)

* Fix beforeload for Android <= 7
* Change Android version check conditional

3 years agoFix failing CI tests (#460)
Jesse MacFadyen [Tue, 9 Apr 2019 17:49:41 +0000 (10:49 -0700)] 
Fix failing CI tests (#460)

* bump node version to 6
* use default travis osx_image of xcode9.4
* comment out flakey local test

3 years agoMerge pull request #440 from cordova-develop/fix-close-event-test
Jesse MacFadyen [Wed, 6 Mar 2019 08:00:48 +0000 (00:00 -0800)] 
Merge pull request #440 from cordova-develop/fix-close-event-test

Fix test spec.5 to close inappbrowser after loadstop event

3 years agoMerge pull request #383 from cvanem/master
Jesse MacFadyen [Wed, 6 Mar 2019 07:55:34 +0000 (23:55 -0800)] 
Merge pull request #383 from cvanem/master

Example documentation - Fix messageCallBack and beforeloadCallBack function names

3 years agoMerge pull request #262 from landsbankinn/CB-13969
Jesse MacFadyen [Wed, 6 Mar 2019 07:31:12 +0000 (23:31 -0800)] 
Merge pull request #262 from landsbankinn/CB-13969

Cb 13969 - Allow close button and navigation buttons positions to be swapped

3 years agoMerge pull request #439 from apache/revert-353-patch-1
Jesse MacFadyen [Wed, 6 Mar 2019 07:27:13 +0000 (23:27 -0800)] 
Merge pull request #439 from apache/revert-353-patch-1

Revert "Add support for right to left direction languages"
I mistakenly merged #353 instead of a similar one.

3 years agoFix test spec.5 to close inappbrowser after loadstop event 440/head
KNaito [Wed, 6 Mar 2019 02:47:21 +0000 (11:47 +0900)] 
Fix test spec.5 to close inappbrowser after loadstop event

3 years agoRevert "Add support for right to left direction languages" revert-353-patch-1 439/head
Jesse MacFadyen [Wed, 6 Mar 2019 01:56:34 +0000 (17:56 -0800)] 
Revert "Add support for right to left direction languages"

3 years agoMerge pull request #353 from transoceanic/patch-1
Jesse MacFadyen [Wed, 6 Mar 2019 01:34:19 +0000 (17:34 -0800)] 
Merge pull request #353 from transoceanic/patch-1

Add support for right to left direction languages

3 years agoMerge pull request #436 from purplecabbage/ValidateCallbackId
Jesse MacFadyen [Sat, 2 Mar 2019 04:54:49 +0000 (20:54 -0800)] 
Merge pull request #436 from purplecabbage/ValidateCallbackId

[android] Prevent malformed callbackId from reaching app cordova view

3 years agoPrevent malformed callbackId from reaching app cordova view 436/head
Jesse MacFadyen [Thu, 28 Feb 2019 22:52:01 +0000 (14:52 -0800)] 
Prevent malformed callbackId from reaching app cordova view

3 years agoCB-13969 fixing README to be correct for lefttoright option 262/head
Steinar Ágúst [Thu, 28 Feb 2019 15:17:24 +0000 (15:17 +0000)] 
CB-13969 fixing README to be correct for lefttoright option

3 years agoCB-13969 functionality extended to WKWebView
Steinar Ágúst [Thu, 28 Feb 2019 14:39:26 +0000 (14:39 +0000)] 
CB-13969 functionality extended to WKWebView

3 years agoCB-13969 fix inappbrowser.css to be unmodified
steinaragustli [Thu, 28 Feb 2019 14:11:04 +0000 (14:11 +0000)] 
CB-13969 fix inappbrowser.css to be unmodified

3 years agoCB-13969 reverting to older version of inappbrowser.css to leave it out of PR
Steinar Ágúst [Thu, 28 Feb 2019 14:05:05 +0000 (14:05 +0000)] 
CB-13969 reverting to older version of inappbrowser.css to leave it out of PR

3 years agoCB-13969 trying to fix some wierd issue for PR
Steinar Á. Steinarsson [Thu, 28 Feb 2019 13:04:21 +0000 (13:04 +0000)] 
CB-13969 trying to fix some wierd issue for PR

3 years agoCB-13969 trying to fix some wierd issue for PR
Steinar Á. Steinarsson [Thu, 28 Feb 2019 13:02:04 +0000 (13:02 +0000)] 
CB-13969 trying to fix some wierd issue for PR

3 years agoCB-13969 trying to remove inappbrowser from pr
steinaragustli [Thu, 28 Feb 2019 12:50:53 +0000 (12:50 +0000)] 
CB-13969 trying to remove inappbrowser from pr

3 years agoCB-13969 trying to remove inappbrowser.css from pr
steinaragustli [Thu, 28 Feb 2019 12:50:02 +0000 (12:50 +0000)] 
CB-13969 trying to remove inappbrowser.css from pr

3 years agoCB-13969 adding newline at end of inappbrowser.cs
Steinar Ágúst [Thu, 28 Feb 2019 12:36:28 +0000 (12:36 +0000)] 
CB-13969 adding newline at end of inappbrowser.cs

3 years agoCB-13969 fixing inappbrowser.css
Steinar Ágúst [Thu, 28 Feb 2019 12:32:59 +0000 (12:32 +0000)] 
CB-13969 fixing inappbrowser.css

3 years agoCB-13969 updating README.MD to better explain lefttoright parameter option, reverting...
Steinar Ágúst [Thu, 28 Feb 2019 12:28:58 +0000 (12:28 +0000)] 
CB-13969 updating README.MD to better explain lefttoright parameter option, reverting unneccesary indent changes on inappbrowser.css

3 years agoMerge remote-tracking branch 'upstream/master'
Steinar Ágúst [Thu, 28 Feb 2019 11:43:34 +0000 (11:43 +0000)] 
Merge remote-tracking branch 'upstream/master'

3 years agoAdd headline to window.open documentation (#406)
Jan Piotrowski [Fri, 22 Feb 2019 17:27:30 +0000 (18:27 +0100)] 
Add headline to window.open documentation (#406)

3 years ago(iOS) Fix iframes in iOS/WKWebView which were broken by #418. Fixes #424. (#425)
Dave Alden [Mon, 11 Feb 2019 23:14:18 +0000 (23:14 +0000)] 
(iOS) Fix iframes in iOS/WKWebView which were broken by #418. Fixes #424. (#425)

3 years agoAdd or update GitHub pull request and issue template
Jan Piotrowski [Mon, 11 Feb 2019 17:39:42 +0000 (18:39 +0100)] 
Add or update GitHub pull request and issue template

3 years agoGH-417: Handle non-default target attribute values (e.g. target=on links in WKWebView...
Dave Alden [Sun, 10 Feb 2019 17:06:35 +0000 (17:06 +0000)] 
GH-417: Handle non-default target attribute values (e.g. target=on links in WKWebView implementation on iOS (#418)

3 years agofix(typescript): remove unused replace parameter (#410)
Tim Brust [Tue, 29 Jan 2019 21:54:54 +0000 (22:54 +0100)] 
fix(typescript): remove unused replace parameter (#410)

This closes #295

3 years agoExample documentation - Fix callBack function name 383/head
cvanem [Tue, 25 Dec 2018 22:01:43 +0000 (15:01 -0700)] 
Example documentation - Fix callBack function name

3 years agoGH-359: Fix beforeload to work with POST requests (#367)
Dave Alden [Thu, 20 Dec 2018 19:31:14 +0000 (19:31 +0000)] 
GH-359: Fix beforeload to work with POST requests (#367)

### Platforms affected
iOS and Android

### What does this PR do?
Fixes the behaviour of `beforeload` to resolve the problem with POST requests outlined in #359.

The `beforeload` parameter has been changed from taking only a boolean (`yes` or not defined) to a discrete string with possible values of `get`, `post`, or `yes` which correspond to request types of GET, POST or GET&POST respectively. The `README.md` has been updated to reflect this.

Note that use of `beforeload` to intercept POST requests is currently not supported on Android or iOS, so if `beforeload=yes` is specified and a POST request is detected as the HTTP request method, `beforeload` behaviour will not be applied. If `beforeload=post` is specified, a `loaderror` event will be dispatched which states that POST requests are not yet supported.

#### Notes for Android

The `shouldOverrideUrlLoading()` override method has been updated to support the [new method interface added in API 24 / Android 7][1] which receives the `WebResourceRequest` instead of just the `String url`, enabling the HTTP method of the request to be determined. The [deprecated method interface][2] has also been preserved for API <=23, but in this case the HTTP method cannot be determined so is passed as null.

Also note that due to a [Chromium bug](https://bugs.chromium.org/p/chromium/issues/detail?id=155250),  `shouldOverrideUrlLoading()` is currently not called for POST requests. It's possible this may be resolved in a future Chromium version in the Android System Webview (given that this is now self-updating and independent of Android version since Android 5.0) - in prospective anticipation of this, code to handle POST requests has been added to `shouldOverrideUrlLoading()`.

However, it seems more likely that this won't be resolved any time soon given that [a Chromium dev said](https://bugs.chromium.org/p/chromium/issues/detail?id=155250#c39):

 > We're looking at implementing a better way to handle request interception in a future OS version. There's no way to just "fix" this, the API doesn't accommodate this usage at all. This will not be something you can use any time soon.

Therefore if we want to go ahead and use `beforeload` to intercept request types other than GET, it's likely we'll instead need to use the `shouldInterceptRequest()` method override. As with `shouldOverrideUrlLoading()`, there are a two variants: the [new method interface][3] added in API 21 / Android 5.0 which  which receives the `WebResourceRequest` object and the [deprecated one][4] which receives only `String url`. If we want to determine the HTTP request method, we'll need to use the new implementation. This has been empirically tested and *is* called for POST requests so would allow the possibility to intercept, delay, modify and send the POST request and its data via `beforeload`.
Both `shouldInterceptRequest()` method interfaces have been exposed in the Android implentation for potential future use but they currently do nothing other than return the unadulterated request object.

### What testing has been done on this change?
Manual testing of POST and GET requests on both platforms using a test app container:
https://github.com/dpa99c/cordova-plugin-inappbrowser-test

[1]: https://developer.android.com/reference/android/webkit/WebViewClient.html#shouldOverrideUrlLoading(android.webkit.WebView,%20android.webkit.WebResourceRequest)
[2]: https://developer.android.com/reference/android/webkit/WebViewClient.html#shouldOverrideUrlLoading(android.webkit.WebView,%20java.lang.String)
[3]: https://developer.android.com/reference/android/webkit/WebViewClient.html#shouldInterceptRequest(android.webkit.WebView,%20android.webkit.WebResourceRequest)
[4]: https://developer.android.com/reference/android/webkit/WebViewClient.html#shouldInterceptRequest(android.webkit.WebView,%20java.lang.String)

3 years ago(iOS & Android) Add postMessage API support (#362)
Dave Alden [Thu, 13 Dec 2018 16:21:45 +0000 (16:21 +0000)] 
(iOS & Android) Add postMessage API support (#362)

<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist
is intended as a quick reference, for complete details please see our Contributor Guidelines:

http://cordova.apache.org/contribute/contribute_guidelines.html

Thanks!
-->

### Platforms affected
Android
iOS (both UIWebView & WKWebView implementations)

### What does this PR do?
Adds support for [postMessage API](https://developer.mozilla.org/en-US/docs/Web/API/Window/postMessage) enabling pages loaded into the InappBrowser to post messages back to the parent Webview of the Cordova app.

For example, sending event messages associated with UI interactions such as button clicks from the wrapped page back to the parent app Webview.

### What testing has been done on this change?
Automated tests have been extended to cover the `message` event.

### Checklist
- [x ] Commit message follows the format: "GH-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [ x] Added automated test coverage as appropriate for this change.

3 years agoAdded to support android devices with right to left direction languages (issue #352) 353/head
transoceanic [Thu, 22 Nov 2018 13:45:34 +0000 (15:45 +0200)] 
Added to support android devices with right to left direction languages (issue #352)

3 years agoFixes loadAfterBeforeload on iOS. Resolves #349. (#350)
Dave Alden [Wed, 21 Nov 2018 18:04:04 +0000 (18:04 +0000)] 
Fixes loadAfterBeforeload on iOS. Resolves #349. (#350)

For both UIWebView and WKWebView implementations on iOS.

<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist
is intended as a quick reference, for complete details please see our Contributor Guidelines:

http://cordova.apache.org/contribute/contribute_guidelines.html

Thanks!
-->

### Platforms affected
iOS

### What does this PR do?
Fixes `beforeload` event (introduced by #276) for iOS

### What testing has been done on this change?
Tested both allow & deny loading of URL with both iOS implementations in [test container app](https://github.com/dpa99c/cordova-plugin-inappbrowser-wkwebview-test) (ignore its README).

- To test with UIWebView use options: `beforeload=yes,usewkwebview=no`
- To test with WKWebView use options: `beforeload=yes,usewkwebview=yes`

### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [x] Added automated test coverage as appropriate for this change.

closes #349

3 years agoFix crashes when using WKWebView implementation on iOS 9. (#337)
Dave Alden [Tue, 20 Nov 2018 16:12:29 +0000 (16:12 +0000)] 
Fix crashes when using WKWebView implementation on iOS 9. (#337)

Fixes #323. Fixes #324.

3 years agoFix iOS CDVWKInAppBrowser evaluateJavascript method randomly gets blocked on ios...
Jonathan Li [Mon, 19 Nov 2018 17:28:25 +0000 (12:28 -0500)] 
Fix iOS CDVWKInAppBrowser evaluateJavascript method randomly gets blocked on ios 12 (#341)

### Platforms affected
iOS

### What does this PR do?
fix issue[ #340](https://github.com/apache/cordova-plugin-inappbrowser/issues/340) iOS CDVWKInAppBrowser evaluateJavascript method randomly gets blocked on iOS 12

### What testing has been done on this change?
manual testing

### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [ ] Added automated test coverage as appropriate for this change.

3 years agoremove unwanted information in README table (#308)
Jan Piotrowski [Tue, 6 Nov 2018 18:53:54 +0000 (19:53 +0100)] 
remove unwanted information in README table (#308)

remove unwanted information in README table

3 years agoMerge pull request #336 from purplecabbage/windowlevel
Jesse MacFadyen [Mon, 29 Oct 2018 21:01:35 +0000 (14:01 -0700)] 
Merge pull request #336 from purplecabbage/windowlevel

This lets the default window layering do it's thing.

3 years agoThis lets the default window layering do it's thing. Fixes #334. Fixes #314. 336/head
Jesse MacFadyen [Mon, 29 Oct 2018 20:43:37 +0000 (13:43 -0700)] 
This lets the default window layering do it's thing. Fixes #334. Fixes #314.

3 years agoMerge pull request #271 from dpa99c/CB-7179
Jesse MacFadyen [Wed, 17 Oct 2018 06:08:27 +0000 (23:08 -0700)] 
Merge pull request #271 from dpa99c/CB-7179

CB-7179 (iOS): Add WKWebView support for iOS

3 years agoMerge branch 'CB-7179' of https://github.com/dpa99c/cordova-plugin-themeablebrowser... 271/head
Dave Alden [Tue, 9 Oct 2018 10:58:18 +0000 (11:58 +0100)] 
Merge branch 'CB-7179' of https://github.com/dpa99c/cordova-plugin-themeablebrowser into CB-7179

3 years agoComment out iOS 9 target for Travis tests since it's not supported by the WKWebView...
Dave Alden [Tue, 9 Oct 2018 10:57:40 +0000 (11:57 +0100)] 
Comment out iOS 9 target for Travis tests since it's not supported by the WKWebView implementation

3 years agoFix indentation of tests.js for eslint
Dave Alden [Tue, 9 Oct 2018 10:48:15 +0000 (11:48 +0100)] 
Fix indentation of tests.js for eslint

3 years agoFix merge error
Dave Alden [Tue, 9 Oct 2018 10:31:26 +0000 (11:31 +0100)] 
Fix merge error

3 years agoMerge branch 'master' into CB-7179
Dave Alden [Tue, 9 Oct 2018 10:15:23 +0000 (11:15 +0100)] 
Merge branch 'master' into CB-7179

3 years agoAdd plugin to fix reporting of cordova-paramedic results when using WKWebView plugin.
Dave Alden [Tue, 9 Oct 2018 09:51:06 +0000 (10:51 +0100)] 
Add plugin to fix reporting of cordova-paramedic results when using WKWebView plugin.
See https://github.com/apache/cordova-paramedic/issues/52

3 years agoMerge branch 'CB-7179' of https://github.com/dpa99c/cordova-plugin-inappbrowser into...
Dave Alden [Fri, 5 Oct 2018 20:24:58 +0000 (21:24 +0100)] 
Merge branch 'CB-7179' of https://github.com/dpa99c/cordova-plugin-inappbrowser into CB-7179

3 years agoFix tests so they auto-start when run via cordova-paramedic
Dave Alden [Fri, 5 Oct 2018 20:23:56 +0000 (21:23 +0100)] 
Fix tests so they auto-start when run via cordova-paramedic

3 years agoremove JIRA link
Jan Piotrowski [Wed, 3 Oct 2018 23:16:19 +0000 (01:16 +0200)] 
remove JIRA link

3 years agoMerge pull request #276 from q-m/feature/beforeload-event
Chris Brody [Wed, 3 Oct 2018 22:43:59 +0000 (18:43 -0400)] 
Merge pull request #276 from q-m/feature/beforeload-event

CB-14188: Add beforeload event, catching navigation before it happens

3 years agoMerge branch 'master' into CB-7179
Jan Piotrowski [Wed, 3 Oct 2018 15:37:28 +0000 (17:37 +0200)] 
Merge branch 'master' into CB-7179

3 years agoupdate test configuration to xcode8.3
Jan Piotrowski [Wed, 3 Oct 2018 15:34:12 +0000 (17:34 +0200)] 
update test configuration to xcode8.3

3 years agoexperimental commit
Jan Piotrowski [Wed, 3 Oct 2018 14:55:12 +0000 (16:55 +0200)] 
experimental commit

3 years agoCB-12941: update typings (#267)
Tim Brust [Tue, 2 Oct 2018 09:49:11 +0000 (11:49 +0200)] 
CB-12941: update typings (#267)

### Platforms affected
n/a - development with TypeScript

### What does this PR do?
Updates the typings to match the latest published version on DefinitelyTyped.
See https://github.com/DefinitelyTyped/DefinitelyTyped/pull/17192 and https://stackoverflow.com/q/42095516/1902598

### What testing has been done on this change?
Project compiles again ;)

### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- n/a: Added automated test coverage as appropriate for this change.

fixes #300

3 years agoCB-14188: add beforeload event, catching navigation before it happens 276/head
wvengen [Fri, 13 Jul 2018 20:14:01 +0000 (22:14 +0200)] 
CB-14188: add beforeload event, catching navigation before it happens

3 years agoreenable testing on all platforms
Jan Piotrowski [Mon, 1 Oct 2018 10:46:54 +0000 (12:46 +0200)] 
reenable testing on all platforms

was disabled in #277

3 years agoalso accept terms for android sdk `android-27`
Jan Piotrowski [Mon, 1 Oct 2018 10:36:35 +0000 (12:36 +0200)] 
also accept terms for android sdk `android-27`

3 years agoMerge branch 'CB-7179' of https://github.com/dpa99c/cordova-plugin-inappbrowser into...
Dave Alden [Sun, 30 Sep 2018 12:22:32 +0000 (13:22 +0100)] 
Merge branch 'CB-7179' of https://github.com/dpa99c/cordova-plugin-inappbrowser into CB-7179

3 years agoCB-7179 (iOS): Add support to optionally use WKWebView for iOS
Dave Alden [Mon, 3 Sep 2018 12:12:15 +0000 (13:12 +0100)] 
CB-7179 (iOS): Add support to optionally use WKWebView for iOS

3 years agofix iOS 10 build
Dave Alden [Sun, 30 Sep 2018 07:03:16 +0000 (08:03 +0100)] 
fix iOS 10 build

3 years agoCB-7179 (iOS): Add support to optionally use WKWebView for iOS
Dave Alden [Mon, 3 Sep 2018 12:12:15 +0000 (13:12 +0100)] 
CB-7179 (iOS): Add support to optionally use WKWebView for iOS

3 years ago[CB-10795] Exclude current app from external intent list (#154)
Dan Polivy [Thu, 20 Sep 2018 20:43:52 +0000 (13:43 -0700)] 
[CB-10795] Exclude current app from external intent list (#154)

On Android, if the app defines an intent-filter for a given URL, and
then tries to use inappbrowser to launch that URL via the _system
target, the default handler for that intent is the app itself.

That behavior can lead to circular loops, and ultimately is not what the
developer wants -- the link should be launched in a browser.

Because there is no easy way to find the "default" system browser on a
device, this solution will do two things:
1) Check if the app is one of the targets for this intent
2) If so, create a custom chooser with all other targets, excluding the
current app.

If the app is not a target, then the current (existing) behavior is
preserved.

The only real "downside" to this approach is that a default handler can no longer be set for these URLs within the app, and a chooser will be shown each time the user taps a link that opens in a new browser.

Fixes https://issues.apache.org/jira/browse/CB-10795

3 years agoCB-14234: Don't call handleOpenURL for system URLs (#278)
Dan Polivy [Wed, 22 Aug 2018 21:43:06 +0000 (14:43 -0700)] 
CB-14234: Don't call handleOpenURL for system URLs (#278)

When calling `.open()` with a target of `_system`, the InAppBrowser on iOS is both launching the URL in the system browser AND also broadcasting to open the URL within the app (calling handleOpenURL). The latter behavior is problematic in many circumstances (e.g. when you want to explicitly open a link in a browser which is a universal link handled by the app).

This commit attempts to address this by checking the return value from openURL -- if it does not open the URL successfully, then (and only then) the code falls back to broadcasting the event within the app to handleOpenURL.

3 years agoCB-12875: (iOS) Pushes the inappbrowser window to a higher ui level than the existing...
Malte Norström [Tue, 21 Aug 2018 08:28:56 +0000 (10:28 +0200)] 
CB-12875: (iOS) Pushes the inappbrowser window to a higher ui level than the existing apps window. (#284)

3 years agoMerge pull request #277 from brodybits/quick-ci-fixes
Chris Brody [Tue, 31 Jul 2018 23:30:46 +0000 (19:30 -0400)] 
Merge pull request #277 from brodybits/quick-ci-fixes

Quick CI fixes

3 years agoSkip Android 6.0 on Travis CI (for now) 277/head
Christopher J. Brody [Tue, 31 Jul 2018 23:18:29 +0000 (19:18 -0400)] 
Skip Android 6.0 on Travis CI (for now)

3 years agoREADME.md add AppVeyor CI & Travis CI details
Christopher J. Brody [Tue, 31 Jul 2018 23:05:28 +0000 (19:05 -0400)] 
README.md add AppVeyor CI & Travis CI details

3 years ago.travis.yml quick fixes
Christopher J. Brody [Tue, 31 Jul 2018 23:02:30 +0000 (19:02 -0400)] 
.travis.yml quick fixes

- skip some platform versions for now
- mark FUTURE TBD platform versions

3 years ago.appveyor.yml add npm i & add eslint to test
Christopher J. Brody [Tue, 31 Jul 2018 22:03:47 +0000 (18:03 -0400)] 
.appveyor.yml add npm i & add eslint to test

(consistent with test script in package.json)

3 years ago.travis.yml add blank lines
Christopher J. Brody [Tue, 31 Jul 2018 20:54:01 +0000 (16:54 -0400)] 
.travis.yml add blank lines

3 years agoMerge pull request #272 from jcesarmobile/CB-12922
jcesarmobile [Wed, 11 Jul 2018 22:30:32 +0000 (00:30 +0200)] 
Merge pull request #272 from jcesarmobile/CB-12922

CB-12922 (ios): fix In-app browser does not cede control

3 years agoCB-12922 (ios): fix In-app browser does not cede control 272/head
Julio César [Sun, 1 Jul 2018 16:09:47 +0000 (18:09 +0200)] 
CB-12922 (ios): fix In-app browser does not cede control

4 years agoMerge pull request #269 from timbru31/fix/CB-14061-handle-more-url-schemes
jcesarmobile [Sat, 19 May 2018 11:57:13 +0000 (13:57 +0200)] 
Merge pull request #269 from timbru31/fix/CB-14061-handle-more-url-schemes

CB-14061: (android) comply with RFC 3986 for custom URL scheme handling

4 years agoMerge pull request #268 from wtrocki/CB-14048
jcesarmobile [Sat, 19 May 2018 11:49:36 +0000 (13:49 +0200)] 
Merge pull request #268 from wtrocki/CB-14048

CB-14048: (android) allowedSchemes check empty string fix

4 years agoCB-14061: (android) comply with RFC 3986 for custom URL scheme handling 269/head
Tim Brust [Wed, 2 May 2018 18:16:44 +0000 (20:16 +0200)] 
CB-14061: (android) comply with RFC 3986 for custom URL scheme handling

4 years agoCB-14048: (android) allowedSchemes check empty string fix 268/head
Wojciech Trocki [Thu, 26 Apr 2018 23:07:57 +0000 (00:07 +0100)] 
CB-14048: (android) allowedSchemes check empty string fix

4 years agoremove statusbar when inAppBrowser is open in andriod
Fiffi [Mon, 23 Apr 2018 16:07:17 +0000 (16:07 +0000)] 
remove statusbar when inAppBrowser is open in andriod

4 years agoCB-14030 Set VERSION to 3.0.1-dev (via coho)
Steve Gill [Fri, 13 Apr 2018 19:28:14 +0000 (12:28 -0700)] 
CB-14030 Set VERSION to 3.0.1-dev (via coho)

4 years agoCB-14030 Updated version and RELEASENOTES.md for release 3.0.0 (via coho) 3.0.x 332/head 3.0.0 rel/3.0.0
Steve Gill [Fri, 13 Apr 2018 19:24:16 +0000 (12:24 -0700)] 
CB-14030 Updated version and RELEASENOTES.md for release 3.0.0 (via coho)

4 years agoMerge pull request #266 from jcesarmobile/cordovaDependencies
Steve Gill [Fri, 13 Apr 2018 18:59:32 +0000 (11:59 -0700)] 
Merge pull request #266 from jcesarmobile/cordovaDependencies

Update cordovaDependencies to allow plugin install

4 years agoUpdate cordovaDependencies to allow plugin install 266/head
Julio César [Fri, 13 Apr 2018 09:26:53 +0000 (11:26 +0200)] 
Update cordovaDependencies to allow plugin install

4 years agoSet VERSION to 3.0.1-dev (via coho)
Steve Gill [Fri, 13 Apr 2018 00:16:16 +0000 (17:16 -0700)] 
Set VERSION to 3.0.1-dev (via coho)

4 years agoCB-14030 Updated version and RELEASENOTES.md for release 3.0.0 (via coho)
Steve Gill [Fri, 13 Apr 2018 00:06:22 +0000 (17:06 -0700)] 
CB-14030 Updated version and RELEASENOTES.md for release 3.0.0 (via coho)

4 years agoMerge pull request #254 from NiklasMerz/loading-spinner
Steve Gill [Thu, 12 Apr 2018 19:04:06 +0000 (12:04 -0700)] 
Merge pull request #254 from NiklasMerz/loading-spinner

CB-13659 (iOS) Add hidespinner option

4 years agoMerge pull request #263 from SailingSteve/CB-14013-InAppBrowser-AllowCustomSchemes
Joe Bowser [Thu, 12 Apr 2018 19:01:59 +0000 (12:01 -0700)] 
Merge pull request #263 from SailingSteve/CB-14013-InAppBrowser-AllowCustomSchemes

CB-14013: (android) Change the InAppBrowser to allow custom schemes for oAuth

4 years agoMerge pull request #260 from bentleyo/navigation-buttons
Steve Gill [Thu, 12 Apr 2018 18:40:20 +0000 (11:40 -0700)] 
Merge pull request #260 from bentleyo/navigation-buttons

Fix nav buttons on iOS and allow custom color

4 years agoIn file AppBrowser.java: New code within shouldOverrideUrlLoading() to 263/head
stevepodell [Thu, 5 Apr 2018 19:45:02 +0000 (12:45 -0700)] 
In file AppBrowser.java: New code within shouldOverrideUrlLoading() to
check for whitelisting custom schemes via a new "AllowedSchemes"
preference configuration item.  Allows custom schemes like
"mycoolapp://" or "wevotetwitterscheme://"

In file inappbrowser.js: Added new "customscheme" channel.

4 years agoIn file AppBrowser.java: New code within shouldOverrideUrlLoading() to
stevepodell [Thu, 5 Apr 2018 18:54:32 +0000 (11:54 -0700)] 
In file AppBrowser.java: New code within shouldOverrideUrlLoading() to
check for whitelisting custom schemes via a new "AllowedSchemes"
preference configuration item.  Allows custom schemes like
"mycoolapp://" or "wevotetwitterscheme://"

In file inappbrowser.js: Added new "customscheme" channel.

4 years agoInAppBrowser.java: New method isURLWhileListed to check for whitelisting of
stevepodell [Thu, 5 Apr 2018 17:31:00 +0000 (10:31 -0700)] 
InAppBrowser.java: New method isURLWhileListed to check for whitelisting of
"AllowedSchemes" in a new preference configuration item.
There is a new check in shouldOverrideUrlLoading, to allow whitelisted
custom schemes like "mycoolapp://"

inappbrowser.js: Added "customscheme" channel.

4 years agoInAppBrowser.java: New method isURLWhileListed to check for whitelisting of
stevepodell [Thu, 5 Apr 2018 17:14:54 +0000 (10:14 -0700)] 
InAppBrowser.java: New method isURLWhileListed to check for whitelisting of
"AllowedSchemes" in a new preference configuration item.
There is a new check in shouldOverrideUrlLoading, to allow whitelisted
custom schemes like "mycoolapp://"

inappbrowser.js: Added "customscheme" channel.

4 years agoInAppBrowser.java: New method isURLWhileListed to check for whitelisting.
stevepodell [Wed, 4 Apr 2018 22:57:13 +0000 (15:57 -0700)] 
InAppBrowser.java: New method isURLWhileListed to check for whitelisting.
Newtest in shouldOverrideUrlLoading, to allow whitelisted custom schemes
like"mycoolapp://"

inappbrowser.js: Added "customscheme" channel.

4 years agoInAppBrowser.java: New method isURLWhileListed to check for whitelisting.
stevepodell [Wed, 4 Apr 2018 15:42:00 +0000 (08:42 -0700)] 
InAppBrowser.java: New method isURLWhileListed to check for whitelisting.
Newtest in shouldOverrideUrlLoading, to allow whitelisted custom schemes
like"mycoolapp://"

inappbrowser.js: Added "customscheme" channel.