Fix end_time field in /_replicate response
authorNick Vatamaniuc <vatamane@apache.org>
Tue, 8 Jan 2019 20:17:06 +0000 (15:17 -0500)
committerNick Vatamaniuc <nickva@users.noreply.github.com>
Tue, 8 Jan 2019 22:37:59 +0000 (17:37 -0500)
Previously `end_time` was generated converting the start_time to universal,
then passing that to `httpd_util:rfc1123_date/1`. However, `rfc1123_date/1`
also transates its argument from local to UTC time, that is it accepts input to
be in local time format.

Fixes #1841

src/couch_replicator/src/couch_replicator_scheduler_job.erl

index f669d46..412ff7d 100644 (file)
@@ -735,8 +735,8 @@ do_checkpoint(State) ->
     {SrcInstanceStartTime, TgtInstanceStartTime} ->
         couch_log:notice("recording a checkpoint for `~s` -> `~s` at source update_seq ~p",
             [SourceName, TargetName, NewSeq]),
-        UniversalStartTime = calendar:now_to_universal_time(ReplicationStartTime),
-        StartTime = ?l2b(httpd_util:rfc1123_date(UniversalStartTime)),
+        LocalStartTime = calendar:now_to_local_time(ReplicationStartTime),
+        StartTime = ?l2b(httpd_util:rfc1123_date(LocalStartTime)),
         EndTime = ?l2b(httpd_util:rfc1123_date()),
         NewHistoryEntry = {[
             {<<"session_id">>, SessionId},