datasketches-cpp.git
8 weeks agoadd ::value_type and ::comparator to REQ for consistency across quantiles 275/head
Jon [Mon, 9 May 2022 23:43:56 +0000 (16:43 -0700)] 
add ::value_type and ::comparator to REQ for consistency across quantiles

8 weeks agoAdd KS Test to python, updating docs where appropriate
Jon [Mon, 9 May 2022 23:37:34 +0000 (16:37 -0700)] 
Add KS Test to python, updating docs where appropriate

8 weeks agoMerge pull request #274 from apache/common_kolmogorov_smirnov
Alexander Saydakov [Mon, 9 May 2022 17:03:03 +0000 (10:03 -0700)] 
Merge pull request #274 from apache/common_kolmogorov_smirnov

Common Kolmogorov-Smirnov test

8 weeks agohigher resolution 274/head
AlexanderSaydakov [Sat, 7 May 2022 00:54:42 +0000 (17:54 -0700)] 
higher resolution

8 weeks agocommon Kolmogorov-Smirnov test, some minor fixes
AlexanderSaydakov [Fri, 6 May 2022 23:29:04 +0000 (16:29 -0700)] 
common Kolmogorov-Smirnov test, some minor fixes

8 weeks agoMerge pull request #273 from apache/sorted_view
Jon Malkin [Fri, 6 May 2022 18:20:01 +0000 (11:20 -0700)] 
Merge pull request #273 from apache/sorted_view

move quantiles and req from quantile_calculator to sorted_view

8 weeks agoadd sanity check on item counts in deserialization constructor 273/head
Jon Malkin [Fri, 6 May 2022 16:16:02 +0000 (09:16 -0700)] 
add sanity check on item counts in deserialization constructor

8 weeks agomove quantiles and req from quantile_calculator to sorted_view (and fix a quantiles...
Jon [Fri, 6 May 2022 03:05:54 +0000 (20:05 -0700)] 
move quantiles and req from quantile_calculator to sorted_view (and fix a quantiles deser bug)

2 months agoMerge pull request #271 from apache/quantiles
Jon Malkin [Thu, 5 May 2022 18:18:17 +0000 (11:18 -0700)] 
Merge pull request #271 from apache/quantiles

Quantiles

2 months agoMerge branch 'master' into quantiles 271/head
Jon Malkin [Thu, 5 May 2022 18:05:30 +0000 (11:05 -0700)] 
Merge branch 'master' into quantiles

2 months agoimprove language around the inclusive flag
Jon [Thu, 5 May 2022 17:27:15 +0000 (10:27 -0700)] 
improve language around the inclusive flag

2 months agotest get_quantile with and without inclusive
Jon [Thu, 5 May 2022 09:54:28 +0000 (02:54 -0700)] 
test get_quantile with and without inclusive

2 months agoremove asserts, mostly replacing with std::logic_error
Jon [Thu, 5 May 2022 02:57:48 +0000 (19:57 -0700)] 
remove asserts, mostly replacing with std::logic_error

2 months agochanges based on review comments aside from asserts
Jon [Thu, 5 May 2022 02:32:38 +0000 (19:32 -0700)] 
changes based on review comments aside from asserts

2 months agoMerge pull request #272 from apache/fix_wheels
Jon Malkin [Wed, 4 May 2022 23:27:40 +0000 (16:27 -0700)] 
Merge pull request #272 from apache/fix_wheels

Fix wheels

2 months agospecify Python3 rather than Python in MSVC-specific block 272/head
Jon Malkin [Wed, 4 May 2022 21:51:07 +0000 (14:51 -0700)] 
specify Python3 rather than Python in MSVC-specific block

2 months agorestore wheel matrix, remove verbosity, condition find_package(Python3) on cmake...
Jon Malkin [Wed, 4 May 2022 21:41:08 +0000 (14:41 -0700)] 
restore wheel matrix, remove verbosity, condition find_package(Python3) on cmake version to address issue

2 months agotrace-expand cmake logs
Jon Malkin [Wed, 4 May 2022 18:35:43 +0000 (11:35 -0700)] 
trace-expand cmake logs

2 months agohave cibuildwheel install cmake>=3.18 before build
Jon Malkin [Wed, 4 May 2022 18:26:52 +0000 (11:26 -0700)] 
have cibuildwheel install cmake>=3.18 before build

2 months agomore debug messages
Jon Malkin [Wed, 4 May 2022 17:46:51 +0000 (10:46 -0700)] 
more debug messages

2 months agofix verbosity
Jon Malkin [Wed, 4 May 2022 17:34:48 +0000 (10:34 -0700)] 
fix verbosity

2 months agofix sdist build
Jon Malkin [Wed, 4 May 2022 17:19:51 +0000 (10:19 -0700)] 
fix sdist build

2 months agodisble mac/windows and 32bit builds for speed, increase logging and verbosity
Jon Malkin [Wed, 4 May 2022 17:05:13 +0000 (10:05 -0700)] 
disble mac/windows and 32bit builds for speed, increase logging and verbosity

2 months agotell pybind to use newer python-finding approach
Jon Malkin [Tue, 3 May 2022 23:24:29 +0000 (16:24 -0700)] 
tell pybind to use newer python-finding approach

2 months agotry letting pybind11 find python on its own
Jon Malkin [Tue, 3 May 2022 22:25:32 +0000 (15:25 -0700)] 
try letting pybind11 find python on its own

2 months agotry backing off to cmake 3.16 for greater compatibility
Jon Malkin [Tue, 3 May 2022 19:48:23 +0000 (12:48 -0700)] 
try backing off to cmake 3.16 for greater compatibility

2 months agoensure pyproject.toml has consistent cmake version
Jon Malkin [Tue, 3 May 2022 16:52:44 +0000 (09:52 -0700)] 
ensure pyproject.toml has consistent cmake version

2 months agobump cmake version to specify development.module w/in python
Jon [Tue, 3 May 2022 10:05:21 +0000 (03:05 -0700)] 
bump cmake version to specify development.module w/in python

2 months agocombine a couple branches to address issues with python wheels
Jon [Tue, 3 May 2022 09:46:29 +0000 (02:46 -0700)] 
combine a couple branches to address issues with python wheels

2 months agoMerge pull request #269 from apache/serde_instance
Jon Malkin [Mon, 2 May 2022 20:08:13 +0000 (13:08 -0700)] 
Merge pull request #269 from apache/serde_instance

Serde instance

2 months agofix CMakeLists to include correct quantile calculator filenames
Jon [Wed, 27 Apr 2022 20:50:13 +0000 (13:50 -0700)] 
fix CMakeLists to include correct quantile calculator filenames

2 months agoclone and minorly adapt python kll testing to classic quantiles
Jon Malkin [Tue, 26 Apr 2022 07:17:00 +0000 (00:17 -0700)] 
clone and minorly adapt python kll testing to classic quantiles

2 months agomore test coverage
Jon Malkin [Tue, 26 Apr 2022 06:59:42 +0000 (23:59 -0700)] 
more test coverage

2 months agoimprove test coverage
Jon Malkin [Tue, 26 Apr 2022 06:55:28 +0000 (23:55 -0700)] 
improve test coverage

2 months agoclean up a few warnings
Jon [Sat, 23 Apr 2022 07:09:37 +0000 (00:09 -0700)] 
clean up a few warnings

2 months agofinish merge, update types to be able handle const input sketchs instead of just...
Jon [Sat, 23 Apr 2022 06:38:27 +0000 (23:38 -0700)] 
finish merge, update types to be able handle const input sketchs instead of just exact matches

2 months agoincomplete merge implementation
Jon [Wed, 20 Apr 2022 23:25:24 +0000 (16:25 -0700)] 
incomplete merge implementation

2 months agowrong offset 269/head
AlexanderSaydakov [Tue, 19 Apr 2022 00:06:55 +0000 (17:06 -0700)] 
wrong offset

2 months agoquantile calculator missing algorithm
Jon Malkin [Wed, 6 Apr 2022 23:11:29 +0000 (16:11 -0700)] 
quantile calculator missing algorithm

2 months agoadd missing cassert include -- should probably ultimately remove asserts instead
Jon Malkin [Wed, 6 Apr 2022 23:04:25 +0000 (16:04 -0700)] 
add missing cassert include -- should probably ultimately remove asserts instead

2 months agoadd python wrapper (w/o merging as that's not implemented yet)
Jon Malkin [Wed, 6 Apr 2022 22:43:07 +0000 (15:43 -0700)] 
add python wrapper (w/o merging as that's not implemented yet)

2 months agoensure k is power of 2 to match java
Jon Malkin [Tue, 5 Apr 2022 23:49:14 +0000 (16:49 -0700)] 
ensure k is power of 2 to match java

2 months agoRead correct sketch from java for testing
Jon Malkin [Tue, 5 Apr 2022 20:10:21 +0000 (13:10 -0700)] 
Read correct sketch from java for testing

2 months agoAdd more tests ported from kll test suite (all except merging)
Jon Malkin [Tue, 5 Apr 2022 19:11:38 +0000 (12:11 -0700)] 
Add more tests ported from kll test suite (all except merging)

2 months agoremove unnecessary move, sort BB as side-effect on serialize despite const method...
Jon Malkin [Tue, 5 Apr 2022 18:54:11 +0000 (11:54 -0700)] 
remove unnecessary move, sort BB as side-effect on serialize despite const method since always compact

3 months agominor cleanup
Jon Malkin [Tue, 5 Apr 2022 08:15:38 +0000 (01:15 -0700)] 
minor cleanup

3 months ago(de)serializatio fixes and compatibility with java, including older serialization...
Jon Malkin [Tue, 5 Apr 2022 08:11:39 +0000 (01:11 -0700)] 
(de)serializatio fixes and compatibility with java, including older serialization versions

3 months agono class-level serde, support serde instance
AlexanderSaydakov [Mon, 28 Mar 2022 23:59:49 +0000 (16:59 -0700)] 
no class-level serde, support serde instance

3 months agono class-level serde, support serde instance
AlexanderSaydakov [Mon, 28 Mar 2022 21:34:32 +0000 (14:34 -0700)] 
no class-level serde, support serde instance

3 months agomore warning fixes
Jon Malkin [Sat, 26 Mar 2022 02:20:11 +0000 (19:20 -0700)] 
more warning fixes

3 months agoupdates to reduce warnings
Jon Malkin [Sat, 26 Mar 2022 02:13:31 +0000 (19:13 -0700)] 
updates to reduce warnings

3 months agonaming consistency for serde template parameter
Jon Malkin [Fri, 25 Mar 2022 22:37:18 +0000 (15:37 -0700)] 
naming consistency for serde template parameter

3 months agosupport serde instance
AlexanderSaydakov [Fri, 25 Mar 2022 21:40:50 +0000 (14:40 -0700)] 
support serde instance

3 months agounnecessary
AlexanderSaydakov [Fri, 25 Mar 2022 21:09:28 +0000 (14:09 -0700)] 
unnecessary

3 months agosupport serde instance
AlexanderSaydakov [Fri, 25 Mar 2022 20:17:23 +0000 (13:17 -0700)] 
support serde instance

3 months agobetter for transition
AlexanderSaydakov [Fri, 25 Mar 2022 18:54:43 +0000 (11:54 -0700)] 
better for transition

3 months agoMerge pull request #267 from apache/hll-deserialize-test
Alexander Saydakov [Thu, 24 Mar 2022 18:19:55 +0000 (11:19 -0700)] 
Merge pull request #267 from apache/hll-deserialize-test

serialize-deserialize-serialize tests

3 months agoMerge pull request #268 from apache/sorted_view_performance
Alexander Saydakov [Thu, 24 Mar 2022 18:19:16 +0000 (11:19 -0700)] 
Merge pull request #268 from apache/sorted_view_performance

quantile sorted view performance improvement

3 months agoremove extraneous serde template parameter
Jon Malkin [Thu, 24 Mar 2022 00:40:02 +0000 (17:40 -0700)] 
remove extraneous serde template parameter

3 months agomove serde from class onto only methods needing it
Jon Malkin [Thu, 24 Mar 2022 00:25:58 +0000 (17:25 -0700)] 
move serde from class onto only methods needing it

3 months agodeserialize void*
Jon Malkin [Thu, 24 Mar 2022 00:00:13 +0000 (17:00 -0700)] 
deserialize void*

3 months agodocs
AlexanderSaydakov [Wed, 23 Mar 2022 23:10:44 +0000 (16:10 -0700)] 
docs

3 months agosupport serde instance
AlexanderSaydakov [Wed, 23 Mar 2022 23:10:16 +0000 (16:10 -0700)] 
support serde instance

3 months agocheckpoint: streaming deserialization
Jon Malkin [Wed, 23 Mar 2022 21:39:14 +0000 (14:39 -0700)] 
checkpoint: streaming deserialization

3 months agobetter name - not always a pointer 268/head
AlexanderSaydakov [Tue, 22 Mar 2022 20:37:30 +0000 (13:37 -0700)] 
better name - not always a pointer

3 months agofaster merge
AlexanderSaydakov [Thu, 17 Mar 2022 21:57:00 +0000 (14:57 -0700)] 
faster merge

3 months agoserialize-deserialize-serialize tests 267/head
AlexanderSaydakov [Mon, 14 Mar 2022 22:06:03 +0000 (15:06 -0700)] 
serialize-deserialize-serialize tests

3 months agoMerge pull request #266 from etseidl/patch-1
Jon Malkin [Sat, 12 Mar 2022 00:12:06 +0000 (16:12 -0800)] 
Merge pull request #266 from etseidl/patch-1

is CouponHashSet deserialization incorrect?

3 months agois CouponHashSet deserialization incorrect? 266/head
etseidl [Wed, 9 Mar 2022 16:46:56 +0000 (08:46 -0800)] 
is CouponHashSet deserialization incorrect?

When deserializing an updatable CouponHashSet from a byte array, wouldn't you need to copy the entire coupons array rather than just using couponCount since the hash array is not populated sequentially like the CouponList?

3 months agoMerge pull request #264 from apache/kll_forwarding
Alexander Saydakov [Tue, 8 Mar 2022 03:26:48 +0000 (19:26 -0800)] 
Merge pull request #264 from apache/kll_forwarding

Reduced code duplication in KLL

3 months agoadded forwarding 264/head
AlexanderSaydakov [Mon, 7 Mar 2022 20:47:09 +0000 (12:47 -0800)] 
added forwarding

4 months agoMerge pull request #265 from aseure/fix-python-build
Alexander Saydakov [Tue, 1 Mar 2022 00:21:43 +0000 (16:21 -0800)] 
Merge pull request #265 from aseure/fix-python-build

fix: add missing <stdexcept> includes

4 months agofix: add missing <stdexcept> includes 265/head
Anthony Seure [Mon, 28 Feb 2022 15:32:41 +0000 (16:32 +0100)] 
fix: add missing <stdexcept> includes

4 months agoadded necessary include
AlexanderSaydakov [Fri, 25 Feb 2022 22:54:10 +0000 (14:54 -0800)] 
added necessary include

4 months agofixed docs
AlexanderSaydakov [Fri, 25 Feb 2022 19:39:06 +0000 (11:39 -0800)] 
fixed docs

4 months agoreduced code duplication
AlexanderSaydakov [Wed, 23 Feb 2022 22:17:46 +0000 (14:17 -0800)] 
reduced code duplication

4 months agoreduced code duplication
AlexanderSaydakov [Wed, 23 Feb 2022 00:41:08 +0000 (16:41 -0800)] 
reduced code duplication

4 months agoadd serialization (self-consistent, not fully tested)
Jon Malkin [Fri, 18 Feb 2022 10:08:16 +0000 (02:08 -0800)] 
add serialization (self-consistent, not fully tested)

4 months agoMerge pull request #259 from apache/quantile_sketch_sorted_view
Alexander Saydakov [Tue, 8 Feb 2022 21:23:22 +0000 (13:23 -0800)] 
Merge pull request #259 from apache/quantile_sketch_sorted_view

Quantile sketch sorted view

4 months agouse the same type as in the sorted view 259/head
AlexanderSaydakov [Mon, 7 Feb 2022 21:13:25 +0000 (13:13 -0800)] 
use the same type as in the sorted view

4 months agoreturn a value from get_quantile() for arithmetic types
AlexanderSaydakov [Sat, 5 Feb 2022 00:44:25 +0000 (16:44 -0800)] 
return a value from get_quantile() for arithmetic types

4 months agoslightly larger margin
AlexanderSaydakov [Fri, 4 Feb 2022 22:16:21 +0000 (14:16 -0800)] 
slightly larger margin

4 months agoinclude floating point types, simplify comparator
AlexanderSaydakov [Fri, 4 Feb 2022 20:14:11 +0000 (12:14 -0800)] 
include floating point types, simplify comparator

4 months agosingular
AlexanderSaydakov [Fri, 4 Feb 2022 20:08:54 +0000 (12:08 -0800)] 
singular

4 months agoremoved some unnecessary complexity
AlexanderSaydakov [Fri, 4 Feb 2022 19:34:59 +0000 (11:34 -0800)] 
removed some unnecessary complexity

5 months agocopy items of integral types instead of using pointers
AlexanderSaydakov [Mon, 31 Jan 2022 22:04:12 +0000 (14:04 -0800)] 
copy items of integral types instead of using pointers

5 months agoinclude cmath for std::isnan
AlexanderSaydakov [Wed, 26 Jan 2022 01:04:18 +0000 (17:04 -0800)] 
include cmath for std::isnan

5 months agoadjusted python wrapper
AlexanderSaydakov [Wed, 26 Jan 2022 01:03:53 +0000 (17:03 -0800)] 
adjusted python wrapper

5 months agoimplicit conversion
AlexanderSaydakov [Tue, 25 Jan 2022 23:49:10 +0000 (15:49 -0800)] 
implicit conversion

5 months agoquantile sketch sorted view
AlexanderSaydakov [Tue, 25 Jan 2022 23:41:46 +0000 (15:41 -0800)] 
quantile sketch sorted view

5 months agouse common quantiles calculator between req and classic quantiles
Jon Malkin [Thu, 20 Jan 2022 09:05:33 +0000 (01:05 -0800)] 
use common quantiles calculator between req and classic quantiles

5 months agofix backwards logic on a comparator, simplify to reduce redundancy, add additional...
Jon Malkin [Sat, 15 Jan 2022 03:13:28 +0000 (19:13 -0800)] 
fix backwards logic on a comparator, simplify to reduce redundancy, add additional asserts for debugging

5 months agoadd missing header, fix comparator usage
Jon Malkin [Fri, 14 Jan 2022 17:15:09 +0000 (09:15 -0800)] 
add missing header, fix comparator usage

5 months agoinclude chrono in the right place
Jon Malkin [Fri, 14 Jan 2022 17:04:59 +0000 (09:04 -0800)] 
include chrono in the right place

5 months agouse the same random_bit implementation across all quantiles sketches, in common_defs.hpp
Jon Malkin [Fri, 14 Jan 2022 10:29:35 +0000 (02:29 -0800)] 
use the same random_bit implementation across all quantiles sketches, in common_defs.hpp

5 months agoMerge pull request #258 from apache/kll_inclusive_rank
Alexander Saydakov [Thu, 13 Jan 2022 22:13:19 +0000 (14:13 -0800)] 
Merge pull request #258 from apache/kll_inclusive_rank

KLL inclusive rank

5 months agotest inclusive PMF and CDF 258/head
AlexanderSaydakov [Tue, 11 Jan 2022 00:54:21 +0000 (16:54 -0800)] 
test inclusive PMF and CDF

5 months agoadjusted the python wrapper
AlexanderSaydakov [Mon, 10 Jan 2022 21:24:44 +0000 (13:24 -0800)] 
adjusted the python wrapper

5 months agokll inclusive rank
AlexanderSaydakov [Sat, 8 Jan 2022 01:35:28 +0000 (17:35 -0800)] 
kll inclusive rank

5 months agoMerge pull request #255 from apache/theta_common_reading_bytes
Alexander Saydakov [Wed, 5 Jan 2022 23:52:54 +0000 (15:52 -0800)] 
Merge pull request #255 from apache/theta_common_reading_bytes

Theta: common code for wrap and deserialize