datasketches-java.git
4 months agoFixed issues from latest comments.
Lee Rhodes [Wed, 30 Mar 2022 18:10:59 +0000 (11:10 -0700)] 
Fixed issues from latest comments.

4 months agoFix issues reported in PR Review, branch "Direct kll double" #360
Lee Rhodes [Wed, 30 Mar 2022 04:05:46 +0000 (21:05 -0700)] 
Fix issues reported in PR Review, branch "Direct kll double" #360

4 months agoEnabled the ability to grow into a larger configured Memory to reduce
Lee Rhodes [Tue, 29 Mar 2022 18:39:52 +0000 (11:39 -0700)] 
Enabled the ability to grow into a larger configured Memory to reduce
the number of calls to the MemoryRequestServer.

4 months agoImproved the KllHelper class to make it useful internally as well as to
Lee Rhodes [Sun, 27 Mar 2022 21:32:47 +0000 (14:32 -0700)] 
Improved the KllHelper class to make it useful internally as well as to
interested users.

4 months agoFixed a small issue with getSerializedSizeBytes().
Lee Rhodes [Sun, 27 Mar 2022 00:17:24 +0000 (17:17 -0700)] 
Fixed a small issue with getSerializedSizeBytes().

4 months agoRemove multiple empty lines
Lee Rhodes [Sat, 26 Mar 2022 22:31:39 +0000 (15:31 -0700)] 
Remove multiple empty lines

4 months agoMerge branch 'DirectKllDouble' of git@github.com:apache/datasketches-java.git into...
Lee Rhodes [Sat, 26 Mar 2022 22:10:20 +0000 (15:10 -0700)] 
Merge branch 'DirectKllDouble' of git@github.com:apache/datasketches-java.git into DirectKllDouble

4 months agoFixed the LGTM issues detected on the last push.
Lee Rhodes [Sat, 26 Mar 2022 20:07:24 +0000 (13:07 -0700)] 
Fixed the LGTM issues detected on the last push.

4 months agoFixed the LGTM issues detected on the last push.
Lee Rhodes [Sat, 26 Mar 2022 20:07:24 +0000 (13:07 -0700)] 
Fixed the LGTM issues detected on the last push.

4 months agoIteration 11, ready for review.
Lee Rhodes [Sat, 26 Mar 2022 02:24:56 +0000 (19:24 -0700)] 
Iteration 11, ready for review.

4 months agoInterim 11. Almost done. KllDirectDoublesSketch working and tested.
Lee Rhodes [Fri, 25 Mar 2022 21:30:54 +0000 (14:30 -0700)] 
Interim 11.  Almost done.  KllDirectDoublesSketch working and tested.

Next: Create the KllDirectFloatsSketch and tests.

4 months agoInterim 10
Lee Rhodes [Thu, 17 Mar 2022 00:41:09 +0000 (17:41 -0700)] 
Interim 10

5 months agoInterim 9
Lee Rhodes [Wed, 9 Mar 2022 23:40:15 +0000 (15:40 -0800)] 
Interim 9

5 months agoInterim 8
Lee Rhodes [Mon, 7 Mar 2022 18:08:28 +0000 (10:08 -0800)] 
Interim 8

5 months agoInterim 7 Fixes a bug introduced in Interim 6
Lee Rhodes [Sat, 5 Mar 2022 21:23:04 +0000 (13:23 -0800)] 
Interim 7 Fixes a bug introduced in Interim 6

5 months agoInterim 6
Lee Rhodes [Sat, 5 Mar 2022 20:24:55 +0000 (12:24 -0800)] 
Interim 6

5 months agoInterim 5
Lee Rhodes [Sat, 5 Mar 2022 01:26:21 +0000 (17:26 -0800)] 
Interim 5

5 months agointerim 4
Lee Rhodes [Fri, 4 Mar 2022 20:23:24 +0000 (12:23 -0800)] 
interim 4

5 months agoInterim 3
Lee Rhodes [Fri, 4 Mar 2022 05:28:56 +0000 (21:28 -0800)] 
Interim 3

5 months agoInterim 2
Lee Rhodes [Thu, 3 Mar 2022 19:26:38 +0000 (11:26 -0800)] 
Interim 2

5 months agoInterim 1
Lee Rhodes [Tue, 1 Mar 2022 01:00:41 +0000 (17:00 -0800)] 
Interim 1

5 months agoMerge pull request #389 from apache/RefactorKLL
Lee Rhodes [Tue, 22 Feb 2022 17:50:38 +0000 (09:50 -0800)] 
Merge pull request #389 from apache/RefactorKLL

Refactor kll

5 months agoMinor changes in code documentation as a result of review. 389/head
Lee Rhodes [Mon, 21 Feb 2022 22:14:04 +0000 (14:14 -0800)] 
Minor changes in code documentation as a result of review.

5 months agoMore minor refactoring.
Lee Rhodes [Sun, 20 Feb 2022 23:18:37 +0000 (15:18 -0800)] 
More minor refactoring.

5 months agoMore refactoring and polishing:
Lee Rhodes [Sun, 20 Feb 2022 01:16:08 +0000 (17:16 -0800)] 
More refactoring and polishing:

Improved variable naming and method naming to be type specific where it
applied.

Rewrote toByteArray to use Memory.  This will make it easier to port to
Panama.

Moved class level javadocs to package-info because it is independent of
type.

5 months agoRefactor KllDoublesSketch and KllFloatsSketch to extend a BaseKllSketch.
Lee Rhodes [Sat, 19 Feb 2022 00:09:38 +0000 (16:09 -0800)] 
Refactor KllDoublesSketch and KllFloatsSketch to extend a BaseKllSketch.

The base class contains all the common methods that don't depend on
float or double type. This reduced a lot of duplicate code.

5 months agoInitial interim commit
Lee Rhodes [Fri, 18 Feb 2022 18:59:36 +0000 (10:59 -0800)] 
Initial interim commit

5 months agoMerge pull request #388 from apache/getUnionSize
Lee Rhodes [Wed, 16 Feb 2022 22:44:54 +0000 (14:44 -0800)] 
Merge pull request #388 from apache/getUnionSize

Get union size

5 months agoIt turns out that the MurmurHash3v2Test.java file was the ONLY file in 388/head
Lee Rhodes [Wed, 16 Feb 2022 22:20:30 +0000 (14:20 -0800)] 
It turns out that the MurmurHash3v2Test.java file was the ONLY file in
the datasketches-java repo that had blank lines with extra spaces.

So I piggy-backed it here to avoid another PR.

5 months agoOops, forgot to comment out a print method.
Lee Rhodes [Wed, 16 Feb 2022 05:02:46 +0000 (21:02 -0800)] 
Oops, forgot to comment out a print method.

5 months agoAdd two methods to Union:
Lee Rhodes [Wed, 16 Feb 2022 04:03:31 +0000 (20:03 -0800)] 
Add two methods to Union:

getCurrentBytes() and getMaxUnionBytes()

Requested by Druid.

5 months agoUpdate unit tests for KllDoubles and KllFloats
Lee Rhodes [Tue, 15 Feb 2022 21:47:42 +0000 (13:47 -0800)] 
Update unit tests for KllDoubles and KllFloats

5 months agoMerge pull request #387 from apache/KLLdoubles
Lee Rhodes [Wed, 9 Feb 2022 23:40:52 +0000 (15:40 -0800)] 
Merge pull request #387 from apache/KLLdoubles

KLL doubles

5 months agoFix typos: ≥ should have been ≥, etc. 387/head
Lee Rhodes [Wed, 9 Feb 2022 21:25:26 +0000 (13:25 -0800)] 
Fix typos: ≥ should have been ≥, etc.

5 months agoRemoved print statement in test. Fixed issue found by -P strict.
Lee Rhodes [Wed, 9 Feb 2022 20:58:44 +0000 (12:58 -0800)] 
Removed print statement in test. Fixed issue found by -P strict.

5 months agoCreate common KllHelper to contain common methods between float and
Lee Rhodes [Wed, 9 Feb 2022 20:17:51 +0000 (12:17 -0800)] 
Create common KllHelper to contain common methods between float and
double helpers.

6 months agoUpdated SketchesCheckstyle.xml.
Lee Rhodes [Mon, 7 Feb 2022 02:06:42 +0000 (18:06 -0800)] 
Updated SketchesCheckstyle.xml.

Improved Javadocs on InequalitySearch and GenericInequalitySearch.

6 months agoThis is the second phase of the creation of the KllDoublesSketch.
Lee Rhodes [Fri, 4 Feb 2022 05:51:24 +0000 (21:51 -0800)] 
This is the second phase of the creation of the KllDoublesSketch.

It runs all unit tests including the manual validation test.

6 months agoThis first commit prepares the current float-based classes.
Lee Rhodes [Fri, 4 Feb 2022 02:29:23 +0000 (18:29 -0800)] 
This first commit prepares the current float-based classes.

No change in logic. Just some renaming of classes to be type specific.
Plus a few cosmetic code comment changes.

The KllFloatsValidationTest does work when properly enabled in that test
and in the KllFloatsHelper.

6 months agoMerge pull request #385 from apache/FixAoDIntersect
Lee Rhodes [Wed, 2 Feb 2022 05:39:44 +0000 (21:39 -0800)] 
Merge pull request #385 from apache/FixAoDIntersect

Changed AoDIntersection check of matching numValues to an exception

6 months agoChanged AoDIntersection check of matching numValues to an exception 385/head
Lee Rhodes [Wed, 2 Feb 2022 00:22:49 +0000 (16:22 -0800)] 
Changed AoDIntersection check of matching numValues to an exception
instead of an assert.

Added Javadoc comments relevant to this requirement to Union, AnotB and
Intersection.

6 months agoMerge pull request #384 from apache/FixKllComments
Lee Rhodes [Sat, 29 Jan 2022 23:34:16 +0000 (15:34 -0800)] 
Merge pull request #384 from apache/FixKllComments

Fix kll comments

6 months agofix spelling, improved comments, etc. 384/head
Lee Rhodes [Sat, 29 Jan 2022 23:19:10 +0000 (15:19 -0800)] 
fix spelling, improved comments, etc.

No actual code changes.

6 months agoMerge branch 'master' into CommonQuantilesCalculator
Lee Rhodes [Fri, 28 Jan 2022 01:39:04 +0000 (17:39 -0800)] 
Merge branch 'master' into CommonQuantilesCalculator

6 months agoMerge pull request #383 from apache/3.1.X
Lee Rhodes [Wed, 26 Jan 2022 20:12:44 +0000 (12:12 -0800)] 
Merge pull request #383 from apache/3.1.X

3.1.x

6 months agoMerge branch 'master' into 3.1.X 383/head
Lee Rhodes [Wed, 26 Jan 2022 19:44:14 +0000 (11:44 -0800)] 
Merge branch 'master' into 3.1.X

6 months agoUpdate comments and code structure.
Lee Rhodes [Wed, 26 Jan 2022 19:34:30 +0000 (11:34 -0800)] 
Update comments and code structure.

Minor changes to KLL.toString() format.

6 months agoupdate toString to reveal more info.
Lee Rhodes [Tue, 25 Jan 2022 23:59:16 +0000 (15:59 -0800)] 
update toString to reveal more info.

6 months agoSpelling and make easier to read.
Lee Rhodes [Tue, 25 Jan 2022 20:24:18 +0000 (12:24 -0800)] 
Spelling and make easier to read.

No code changes.

6 months agoUpdate pom with correct coordinates for git-commit-id-plugin. 3.1.0 3.1.0-RC1
Lee Rhodes [Fri, 21 Jan 2022 04:53:53 +0000 (20:53 -0800)] 
Update pom with correct coordinates for git-commit-id-plugin.

6 months agoMinor pom changes
Lee Rhodes [Tue, 18 Jan 2022 23:45:32 +0000 (17:45 -0600)] 
Minor pom changes

6 months agoRelease Process: Change pom version to 3.2.0-SNAPSHOT
Lee Rhodes [Sun, 16 Jan 2022 19:14:56 +0000 (13:14 -0600)] 
Release Process: Change pom version to 3.2.0-SNAPSHOT

6 months agoCreate Release Branch 3.1.X
Lee Rhodes [Sun, 16 Jan 2022 18:59:49 +0000 (12:59 -0600)] 
Create Release Branch 3.1.X

6 months agoRemove Print statement
Lee Rhodes [Sun, 16 Jan 2022 17:29:34 +0000 (11:29 -0600)] 
Remove Print statement

6 months agoMerge pull request #381 from apache/SpotBugs_Fixes
Lee Rhodes [Wed, 12 Jan 2022 21:31:58 +0000 (13:31 -0800)] 
Merge pull request #381 from apache/SpotBugs_Fixes

Fixes problems found when running latest version of SpotBugs.

6 months agoRemoved test and method isMarkValid() as requested. 381/head
Lee Rhodes [Wed, 12 Jan 2022 21:20:11 +0000 (13:20 -0800)] 
Removed test and method isMarkValid() as requested.

6 months agoFixed Typo.
Lee Rhodes [Wed, 12 Jan 2022 00:06:27 +0000 (16:06 -0800)] 
Fixed Typo.

6 months agoFixes problems found when running latest version of SpotBugs.
Lee Rhodes [Tue, 11 Jan 2022 23:16:09 +0000 (15:16 -0800)] 
Fixes problems found when running latest version of SpotBugs.

7 months agoMerge pull request #380 from apache/Cleanup_ArrayOfDoubles
Lee Rhodes [Sat, 8 Jan 2022 00:10:55 +0000 (16:10 -0800)] 
Merge pull request #380 from apache/Cleanup_ArrayOfDoubles

In executing Clover in prep for release I found some obsolete classes in

7 months agoResponding to Review Comment. 380/head
Lee Rhodes [Sat, 8 Jan 2022 00:01:18 +0000 (16:01 -0800)] 
Responding to Review Comment.

Fixing fully qualified methods by import static ...

7 months agoIn executing Clover in prep for release I found some obsolete classes in
Lee Rhodes [Fri, 7 Jan 2022 00:38:44 +0000 (16:38 -0800)] 
In executing Clover in prep for release I found some obsolete classes in
AoD that were totally not used (probably my bad!).

I also found some critical missing functionality at the root Sketch
level. So I added that.

7 months agoMerge pull request #379 from apache/Add_HeapifyWrapCompactSketch2
Lee Rhodes [Thu, 6 Jan 2022 00:35:37 +0000 (16:35 -0800)] 
Merge pull request #379 from apache/Add_HeapifyWrapCompactSketch2

Add heapify wrap compact sketch2

7 months agoCorrect typo: extra </p>. 379/head
Lee Rhodes [Thu, 6 Jan 2022 00:08:45 +0000 (16:08 -0800)] 
Correct typo: extra </p>.

7 months agoChanged seed to expectedSeed where applicable
Lee Rhodes [Wed, 5 Jan 2022 23:59:22 +0000 (15:59 -0800)] 
Changed seed to expectedSeed where applicable

and seedHash to expectedSeedHash where applicable for the public APIs
in Sketches, Sketch, CompactSketch, SetOperation, UpdateSketch, as
well as internal HeapAlphaSketch and UnionImpl classes.

Updated Javadocs for the CompactSketch static methods to be clearer
about what the methods do.

7 months agoAdded tests for the Sketches.wrap() and Sketches.wrapCompactSketch().
Lee Rhodes [Tue, 4 Jan 2022 05:25:31 +0000 (21:25 -0800)] 
Added tests for the Sketches.wrap() and Sketches.wrapCompactSketch().

7 months agoMinor corrections and a few code comment changes.
Lee Rhodes [Mon, 3 Jan 2022 22:18:11 +0000 (14:18 -0800)] 
Minor corrections and a few code comment changes.

7 months agoChanged problematic test to a cluster test to avoid random errors.
Lee Rhodes [Fri, 24 Dec 2021 22:33:21 +0000 (14:33 -0800)] 
Changed problematic test to a cluster test to avoid random errors.

7 months agoRemoved comment.
Lee Rhodes [Fri, 24 Dec 2021 17:11:00 +0000 (09:11 -0800)] 
Removed comment.

7 months agoAdd more tests
Lee Rhodes [Fri, 24 Dec 2021 07:23:15 +0000 (23:23 -0800)] 
Add more tests

7 months agoThis adds tests, see SketchTest2.
Lee Rhodes [Fri, 24 Dec 2021 07:12:32 +0000 (23:12 -0800)] 
This adds tests, see SketchTest2.

Fixed a couple of bugs.

7 months agoMerge branch 'master' into Add_HeapifyWrapCompactSketch
Lee Rhodes [Thu, 23 Dec 2021 02:38:54 +0000 (18:38 -0800)] 
Merge branch 'master' into Add_HeapifyWrapCompactSketch

7 months agoDelete .mvn folder from master
Lee Rhodes [Thu, 23 Dec 2021 02:13:39 +0000 (18:13 -0800)] 
Delete .mvn folder from master

7 months agoRemove edit from pom. 378/head
Lee Rhodes [Thu, 23 Dec 2021 02:05:39 +0000 (18:05 -0800)] 
Remove edit from pom.

7 months agoFix older LGTM warning.
Lee Rhodes [Thu, 23 Dec 2021 01:31:27 +0000 (17:31 -0800)] 
Fix older LGTM warning.

7 months agoRemove .mvn/jvm.config
Lee Rhodes [Thu, 23 Dec 2021 00:44:26 +0000 (16:44 -0800)] 
Remove .mvn/jvm.config

7 months agoMerge branch 'master' into Add_HeapifyWrapCompactSketch
Lee Rhodes [Thu, 23 Dec 2021 00:28:26 +0000 (16:28 -0800)] 
Merge branch 'master' into Add_HeapifyWrapCompactSketch

7 months agoAdding collaborators to .asf.config
Lee Rhodes [Thu, 23 Dec 2021 00:26:26 +0000 (16:26 -0800)] 
Adding collaborators to .asf.config
Adding .mvn/jvm.config

7 months agoCode additions requested by Will.
Lee Rhodes [Wed, 22 Dec 2021 20:57:58 +0000 (12:57 -0800)] 
Code additions requested by Will.

Added 4 methods to Sketches class:

heapifyCompactSketch(Memory)
heapifyCompactSketch(Memory, long)
wrapCompactSketch(Memory)
wrapCompactSketch(Memory, long)

Changed the behavior of heapifySketch(2) and wrapSketch(2) calls
so that if the given image is a CompactSketch the behavior will
be the same as above.

The basic behavior change is that a seed is no longer required to
heapify or wrap a CompactSketch image.
But if it is given, it will be used to check the
hashSeed of the image, if there is one.

This push represents the main code changes.
More test code needs to be added.

7 months agoMerge pull request #377 from apache/Update_SetOperationCornerCases_Union
Lee Rhodes [Mon, 20 Dec 2021 21:48:20 +0000 (13:48 -0800)] 
Merge pull request #377 from apache/Update_SetOperationCornerCases_Union

Updated SetOperationCornerCases for Unions and cleaned up the code.

7 months agoAdded assert to satisfy the LGTM warning, 377/head
Lee Rhodes [Mon, 20 Dec 2021 21:25:22 +0000 (13:25 -0800)] 
Added assert to satisfy the LGTM warning,

which complains about a null pointer that can never happen.
Removed an obsolete comment.

7 months agoHopefully the final fixes and code cleanup.
Lee Rhodes [Fri, 17 Dec 2021 02:25:01 +0000 (18:25 -0800)] 
Hopefully the final fixes and code cleanup.

7 months agoInterim changes, all harmless at this point:
Lee Rhodes [Thu, 16 Dec 2021 21:15:04 +0000 (13:15 -0800)] 
Interim changes, all harmless at this point:

Mostly renamed variables for clarity, added code documentation.

7 months agoInterim changes toward AoD set operations compatibility
Lee Rhodes [Mon, 13 Dec 2021 17:54:11 +0000 (09:54 -0800)] 
Interim changes toward AoD set operations compatibility

8 months agoAdded union tests to theta and tuple.
Lee Rhodes [Wed, 8 Dec 2021 20:34:41 +0000 (12:34 -0800)] 
Added union tests to theta and tuple.

Cosmetic changes most everywhere else.

Added one theta union test for sanity.

8 months agoFinished updating Corner case tests against of Union for both Theta and
Lee Rhodes [Sat, 4 Dec 2021 02:25:49 +0000 (18:25 -0800)] 
Finished updating Corner case tests against of Union for both Theta and
Tuple.

All Tests pass.

8 months agoMerge pull request #376 from apache/FixSetOpLeakage
Lee Rhodes [Fri, 3 Dec 2021 20:44:43 +0000 (12:44 -0800)] 
Merge pull request #376 from apache/FixSetOpLeakage

Fix set op leakage

8 months agoUpdated SetOperationCornerCases for Unions and cleaned up the code.
Lee Rhodes [Fri, 3 Dec 2021 20:42:15 +0000 (12:42 -0800)] 
Updated SetOperationCornerCases for Unions and cleaned up the code.

8 months agoDid not mean to update this in this branch. 376/head
Lee Rhodes [Fri, 3 Dec 2021 01:57:17 +0000 (17:57 -0800)] 
Did not mean to update this in this branch.

8 months agoMore fixes related to parameter leakage
Lee Rhodes [Fri, 3 Dec 2021 01:52:49 +0000 (17:52 -0800)] 
More fixes related to parameter leakage

8 months agoMerge pull request #374 from apache/simplified_setop_cases
Lee Rhodes [Sun, 21 Nov 2021 00:18:23 +0000 (16:18 -0800)] 
Merge pull request #374 from apache/simplified_setop_cases

Simplified set operations

8 months agoadjusted test 374/head
AlexanderSaydakov [Fri, 19 Nov 2021 21:49:25 +0000 (13:49 -0800)] 
adjusted test

8 months agoadjusted tests
AlexanderSaydakov [Fri, 19 Nov 2021 21:43:55 +0000 (13:43 -0800)] 
adjusted tests

8 months agoenforce theta=1 for empty sketch
AlexanderSaydakov [Fri, 19 Nov 2021 21:35:57 +0000 (13:35 -0800)] 
enforce theta=1 for empty sketch

8 months agoremoved NewDegen state, renamed New to Empty, some rearrangement
AlexanderSaydakov [Thu, 18 Nov 2021 23:43:03 +0000 (15:43 -0800)] 
removed NewDegen state, renamed New to Empty, some rearrangement

8 months agominor Javadoc changes.
Lee Rhodes [Mon, 15 Nov 2021 18:05:08 +0000 (10:05 -0800)] 
minor Javadoc changes.

8 months agoMerge pull request #373 from apache/PomUpdate
Lee Rhodes [Wed, 10 Nov 2021 17:03:21 +0000 (09:03 -0800)] 
Merge pull request #373 from apache/PomUpdate

Update pom

8 months agoUpdate pom 373/head
Lee Rhodes [Tue, 9 Nov 2021 23:34:52 +0000 (15:34 -0800)] 
Update pom

8 months agoMerge pull request #372 from apache/parameterLeakage
Lee Rhodes [Tue, 9 Nov 2021 23:28:39 +0000 (15:28 -0800)] 
Merge pull request #372 from apache/parameterLeakage

Parameter leakage

9 months agodisabled printing 372/head
Lee Rhodes [Tue, 9 Nov 2021 00:41:29 +0000 (16:41 -0800)] 
disabled printing

9 months agoMerge branch 'master' into parameterLeakage
Lee Rhodes [Mon, 8 Nov 2021 22:17:53 +0000 (14:17 -0800)] 
Merge branch 'master' into parameterLeakage