Lee Rhodes [Wed, 2 Feb 2022 00:22:49 +0000 (16:22 -0800)]
Changed AoDIntersection check of matching numValues to an exception
instead of an assert.
Added Javadoc comments relevant to this requirement to Union, AnotB and
Intersection.
Lee Rhodes [Sat, 29 Jan 2022 23:34:16 +0000 (15:34 -0800)]
Merge pull request #384 from apache/FixKllComments
Fix kll comments
Lee Rhodes [Sat, 29 Jan 2022 23:19:10 +0000 (15:19 -0800)]
fix spelling, improved comments, etc.
No actual code changes.
Lee Rhodes [Fri, 28 Jan 2022 01:39:04 +0000 (17:39 -0800)]
Merge branch 'master' into CommonQuantilesCalculator
Lee Rhodes [Wed, 26 Jan 2022 20:12:44 +0000 (12:12 -0800)]
Merge pull request #383 from apache/3.1.X
3.1.x
Lee Rhodes [Wed, 26 Jan 2022 19:44:14 +0000 (11:44 -0800)]
Merge branch 'master' into 3.1.X
Lee Rhodes [Wed, 26 Jan 2022 19:34:30 +0000 (11:34 -0800)]
Update comments and code structure.
Minor changes to KLL.toString() format.
Lee Rhodes [Tue, 25 Jan 2022 23:59:16 +0000 (15:59 -0800)]
update toString to reveal more info.
Lee Rhodes [Tue, 25 Jan 2022 20:24:18 +0000 (12:24 -0800)]
Spelling and make easier to read.
No code changes.
Lee Rhodes [Fri, 21 Jan 2022 04:53:53 +0000 (20:53 -0800)]
Update pom with correct coordinates for git-commit-id-plugin.
Lee Rhodes [Tue, 18 Jan 2022 23:45:32 +0000 (17:45 -0600)]
Minor pom changes
Lee Rhodes [Sun, 16 Jan 2022 19:14:56 +0000 (13:14 -0600)]
Release Process: Change pom version to 3.2.0-SNAPSHOT
Lee Rhodes [Sun, 16 Jan 2022 18:59:49 +0000 (12:59 -0600)]
Create Release Branch 3.1.X
Lee Rhodes [Sun, 16 Jan 2022 17:29:34 +0000 (11:29 -0600)]
Remove Print statement
Lee Rhodes [Wed, 12 Jan 2022 21:31:58 +0000 (13:31 -0800)]
Merge pull request #381 from apache/SpotBugs_Fixes
Fixes problems found when running latest version of SpotBugs.
Lee Rhodes [Wed, 12 Jan 2022 21:20:11 +0000 (13:20 -0800)]
Removed test and method isMarkValid() as requested.
Lee Rhodes [Wed, 12 Jan 2022 00:06:27 +0000 (16:06 -0800)]
Fixed Typo.
Lee Rhodes [Tue, 11 Jan 2022 23:16:09 +0000 (15:16 -0800)]
Fixes problems found when running latest version of SpotBugs.
Lee Rhodes [Sat, 8 Jan 2022 00:10:55 +0000 (16:10 -0800)]
Merge pull request #380 from apache/Cleanup_ArrayOfDoubles
In executing Clover in prep for release I found some obsolete classes in
Lee Rhodes [Sat, 8 Jan 2022 00:01:18 +0000 (16:01 -0800)]
Responding to Review Comment.
Fixing fully qualified methods by import static ...
Lee Rhodes [Fri, 7 Jan 2022 00:38:44 +0000 (16:38 -0800)]
In executing Clover in prep for release I found some obsolete classes in
AoD that were totally not used (probably my bad!).
I also found some critical missing functionality at the root Sketch
level. So I added that.
Lee Rhodes [Thu, 6 Jan 2022 00:35:37 +0000 (16:35 -0800)]
Merge pull request #379 from apache/Add_HeapifyWrapCompactSketch2
Add heapify wrap compact sketch2
Lee Rhodes [Thu, 6 Jan 2022 00:08:45 +0000 (16:08 -0800)]
Correct typo: extra </p>.
Lee Rhodes [Wed, 5 Jan 2022 23:59:22 +0000 (15:59 -0800)]
Changed seed to expectedSeed where applicable
and seedHash to expectedSeedHash where applicable for the public APIs
in Sketches, Sketch, CompactSketch, SetOperation, UpdateSketch, as
well as internal HeapAlphaSketch and UnionImpl classes.
Updated Javadocs for the CompactSketch static methods to be clearer
about what the methods do.
Lee Rhodes [Tue, 4 Jan 2022 05:25:31 +0000 (21:25 -0800)]
Added tests for the Sketches.wrap() and Sketches.wrapCompactSketch().
Lee Rhodes [Mon, 3 Jan 2022 22:18:11 +0000 (14:18 -0800)]
Minor corrections and a few code comment changes.
Lee Rhodes [Fri, 24 Dec 2021 22:33:21 +0000 (14:33 -0800)]
Changed problematic test to a cluster test to avoid random errors.
Lee Rhodes [Fri, 24 Dec 2021 17:11:00 +0000 (09:11 -0800)]
Removed comment.
Lee Rhodes [Fri, 24 Dec 2021 07:23:15 +0000 (23:23 -0800)]
Add more tests
Lee Rhodes [Fri, 24 Dec 2021 07:12:32 +0000 (23:12 -0800)]
This adds tests, see SketchTest2.
Fixed a couple of bugs.
Lee Rhodes [Thu, 23 Dec 2021 02:38:54 +0000 (18:38 -0800)]
Merge branch 'master' into Add_HeapifyWrapCompactSketch
Lee Rhodes [Thu, 23 Dec 2021 02:13:39 +0000 (18:13 -0800)]
Delete .mvn folder from master
Lee Rhodes [Thu, 23 Dec 2021 02:05:39 +0000 (18:05 -0800)]
Remove edit from pom.
Lee Rhodes [Thu, 23 Dec 2021 01:31:27 +0000 (17:31 -0800)]
Fix older LGTM warning.
Lee Rhodes [Thu, 23 Dec 2021 00:44:26 +0000 (16:44 -0800)]
Remove .mvn/jvm.config
Lee Rhodes [Thu, 23 Dec 2021 00:28:26 +0000 (16:28 -0800)]
Merge branch 'master' into Add_HeapifyWrapCompactSketch
Lee Rhodes [Thu, 23 Dec 2021 00:26:26 +0000 (16:26 -0800)]
Adding collaborators to .asf.config
Adding .mvn/jvm.config
Lee Rhodes [Wed, 22 Dec 2021 20:57:58 +0000 (12:57 -0800)]
Code additions requested by Will.
Added 4 methods to Sketches class:
heapifyCompactSketch(Memory)
heapifyCompactSketch(Memory, long)
wrapCompactSketch(Memory)
wrapCompactSketch(Memory, long)
Changed the behavior of heapifySketch(2) and wrapSketch(2) calls
so that if the given image is a CompactSketch the behavior will
be the same as above.
The basic behavior change is that a seed is no longer required to
heapify or wrap a CompactSketch image.
But if it is given, it will be used to check the
hashSeed of the image, if there is one.
This push represents the main code changes.
More test code needs to be added.
Lee Rhodes [Mon, 20 Dec 2021 21:48:20 +0000 (13:48 -0800)]
Merge pull request #377 from apache/Update_SetOperationCornerCases_Union
Updated SetOperationCornerCases for Unions and cleaned up the code.
Lee Rhodes [Mon, 20 Dec 2021 21:25:22 +0000 (13:25 -0800)]
Added assert to satisfy the LGTM warning,
which complains about a null pointer that can never happen.
Removed an obsolete comment.
Lee Rhodes [Fri, 17 Dec 2021 02:25:01 +0000 (18:25 -0800)]
Hopefully the final fixes and code cleanup.
Lee Rhodes [Thu, 16 Dec 2021 21:15:04 +0000 (13:15 -0800)]
Interim changes, all harmless at this point:
Mostly renamed variables for clarity, added code documentation.
Lee Rhodes [Mon, 13 Dec 2021 17:54:11 +0000 (09:54 -0800)]
Interim changes toward AoD set operations compatibility
Lee Rhodes [Wed, 8 Dec 2021 20:34:41 +0000 (12:34 -0800)]
Added union tests to theta and tuple.
Cosmetic changes most everywhere else.
Added one theta union test for sanity.
Lee Rhodes [Sat, 4 Dec 2021 02:25:49 +0000 (18:25 -0800)]
Finished updating Corner case tests against of Union for both Theta and
Tuple.
All Tests pass.
Lee Rhodes [Fri, 3 Dec 2021 20:44:43 +0000 (12:44 -0800)]
Merge pull request #376 from apache/FixSetOpLeakage
Fix set op leakage
Lee Rhodes [Fri, 3 Dec 2021 20:42:15 +0000 (12:42 -0800)]
Updated SetOperationCornerCases for Unions and cleaned up the code.
Lee Rhodes [Fri, 3 Dec 2021 01:57:17 +0000 (17:57 -0800)]
Did not mean to update this in this branch.
Lee Rhodes [Fri, 3 Dec 2021 01:52:49 +0000 (17:52 -0800)]
More fixes related to parameter leakage
Lee Rhodes [Sun, 21 Nov 2021 00:18:23 +0000 (16:18 -0800)]
Merge pull request #374 from apache/simplified_setop_cases
Simplified set operations
AlexanderSaydakov [Fri, 19 Nov 2021 21:49:25 +0000 (13:49 -0800)]
adjusted test
AlexanderSaydakov [Fri, 19 Nov 2021 21:43:55 +0000 (13:43 -0800)]
adjusted tests
AlexanderSaydakov [Fri, 19 Nov 2021 21:35:57 +0000 (13:35 -0800)]
enforce theta=1 for empty sketch
AlexanderSaydakov [Thu, 18 Nov 2021 23:43:03 +0000 (15:43 -0800)]
removed NewDegen state, renamed New to Empty, some rearrangement
Lee Rhodes [Mon, 15 Nov 2021 18:05:08 +0000 (10:05 -0800)]
minor Javadoc changes.
Lee Rhodes [Wed, 10 Nov 2021 17:03:21 +0000 (09:03 -0800)]
Merge pull request #373 from apache/PomUpdate
Update pom
Lee Rhodes [Tue, 9 Nov 2021 23:34:52 +0000 (15:34 -0800)]
Update pom
Lee Rhodes [Tue, 9 Nov 2021 23:28:39 +0000 (15:28 -0800)]
Merge pull request #372 from apache/parameterLeakage
Parameter leakage
Lee Rhodes [Tue, 9 Nov 2021 00:41:29 +0000 (16:41 -0800)]
disabled printing
Lee Rhodes [Mon, 8 Nov 2021 22:17:53 +0000 (14:17 -0800)]
Merge branch 'master' into parameterLeakage
Lee Rhodes [Mon, 8 Nov 2021 22:16:29 +0000 (14:16 -0800)]
Add one test
Lee Rhodes [Thu, 4 Nov 2021 05:57:12 +0000 (22:57 -0700)]
Merge pull request #369 from apache/FixMikhailsBug
Fix Mikhail's bug
Lee Rhodes [Wed, 3 Nov 2021 01:01:27 +0000 (18:01 -0700)]
Changes as a result of 2nd reviews.
Lee Rhodes [Mon, 1 Nov 2021 22:54:04 +0000 (15:54 -0700)]
Fixes relative to review comments.
Lee Rhodes [Mon, 1 Nov 2021 18:08:18 +0000 (11:08 -0700)]
Renaming of enum constants to be consistent with website documentation.
Lee Rhodes [Sun, 31 Oct 2021 23:50:28 +0000 (16:50 -0700)]
Javadoc update
Lee Rhodes [Sun, 31 Oct 2021 23:44:59 +0000 (16:44 -0700)]
Update
Lee Rhodes [Fri, 29 Oct 2021 04:31:29 +0000 (21:31 -0700)]
Fix testng.annotations.Test missing -- can't have @Test functions in
main.
Lee Rhodes [Fri, 29 Oct 2021 04:19:56 +0000 (21:19 -0700)]
Rewrote the Tuple AnotB logic.
This new structure could be leveraged with the Intersection logic and
also be used for the Intersection and AnotB for the theta sketch. But
since they are now all working against the rigorous testing I
implemented, this move could be done later.
Lee Rhodes [Sat, 23 Oct 2021 18:35:19 +0000 (11:35 -0700)]
Merge branch 'master' into FixMikhailsBug
Lee Rhodes [Sat, 23 Oct 2021 03:43:44 +0000 (20:43 -0700)]
Merge pull request #371 from apache/tupleUpdatableSerDeDeprecation
Tuple updatable ser de deprecation
Lee Rhodes [Sat, 23 Oct 2021 02:54:48 +0000 (19:54 -0700)]
Merge branch 'FixMinorCheckstyleIssues' into tupleUpdatableDeprecation
Lee Rhodes [Sat, 23 Oct 2021 01:47:09 +0000 (18:47 -0700)]
Cleanup Imports mostly
Lee Rhodes [Sat, 23 Oct 2021 01:31:14 +0000 (18:31 -0700)]
Deprecate all occurrences of serializing or deserializing UpdateSketch
or its derivatives.
Lee Rhodes [Thu, 21 Oct 2021 23:47:55 +0000 (16:47 -0700)]
Added tests for the tuple intersections(Tuple, Theta) and AnotB(Tuple,
Theta). And found some bugs that are now fixed.
Alexander Saydakov [Thu, 21 Oct 2021 23:17:19 +0000 (16:17 -0700)]
Merge pull request #370 from apache/tuple_serial_ver3
serial version 3 for compatibility with C++
AlexanderSaydakov [Thu, 21 Oct 2021 21:47:09 +0000 (14:47 -0700)]
renamed legacy serial version
AlexanderSaydakov [Thu, 21 Oct 2021 21:44:16 +0000 (14:44 -0700)]
renamed legacy flags
Lee Rhodes [Thu, 21 Oct 2021 19:27:57 +0000 (12:27 -0700)]
Update changes in FixMikhailsBug
Lee Rhodes [Thu, 21 Oct 2021 00:14:42 +0000 (17:14 -0700)]
Fixes as a result of PR Review (mostly).
Plus a few other minor changes.
AlexanderSaydakov [Wed, 20 Oct 2021 23:50:12 +0000 (16:50 -0700)]
serial version 3 for compatibility with C++
Lee Rhodes [Tue, 19 Oct 2021 17:13:41 +0000 (10:13 -0700)]
Add license.
Lee Rhodes [Tue, 19 Oct 2021 17:08:59 +0000 (10:08 -0700)]
Add Mikhail's bug as specific test.
Lee Rhodes [Mon, 18 Oct 2021 19:59:04 +0000 (15:59 -0400)]
This fixes Mikhail's Bug: datasketches-java Issue #368.
In addition to the issue that Mikhail found, I found a number of other
discrepancies in the treatment of various corner cases in the Set
Operations. Those were also fixed.
Lee Rhodes [Wed, 13 Oct 2021 01:45:53 +0000 (21:45 -0400)]
Fix Mikhail's Bug # 2
Lee Rhodes [Wed, 13 Oct 2021 01:42:03 +0000 (21:42 -0400)]
Fix Mikhails bug
Lee Rhodes [Sat, 2 Oct 2021 00:53:06 +0000 (17:53 -0700)]
Merge remote-tracking branch 'origin/3.0.X'
David Cromberge [Tue, 28 Sep 2021 23:00:23 +0000 (00:00 +0100)]
Add git.properties to rat exclusions
David Cromberge [Tue, 28 Sep 2021 21:49:40 +0000 (22:49 +0100)]
Release Process: Change pom version to 3.1.0-SNAPSHOT.
David Cromberge [Tue, 28 Sep 2021 21:41:28 +0000 (22:41 +0100)]
Remove SNAPSHOT
David Cromberge [Tue, 28 Sep 2021 21:35:34 +0000 (22:35 +0100)]
Increment major version before release
Lee Rhodes [Tue, 28 Sep 2021 21:18:32 +0000 (14:18 -0700)]
Merge pull request #367 from apache/remove-deprecated-methods
Remove deprecated methods
David Cromberge [Tue, 28 Sep 2021 15:01:16 +0000 (16:01 +0100)]
Plugin dependency updates
David Cromberge [Tue, 28 Sep 2021 12:46:59 +0000 (13:46 +0100)]
Remove suppress warnings no longer required
David Cromberge [Tue, 28 Sep 2021 12:36:51 +0000 (13:36 +0100)]
Remove deprecated update method from Tuple Union
David Cromberge [Tue, 28 Sep 2021 12:35:48 +0000 (13:35 +0100)]
Remove deprecated getKey from Tuple SketchIterator
David Cromberge [Tue, 28 Sep 2021 12:34:45 +0000 (13:34 +0100)]
Remove deprecated update methods from AoD set ops
David Cromberge [Tue, 28 Sep 2021 12:30:47 +0000 (13:30 +0100)]
Remove deprecated update method from Tuple Intersection
David Cromberge [Tue, 28 Sep 2021 12:27:42 +0000 (13:27 +0100)]
Remove deprecated getNormalizedRankError from KllFloats
David Cromberge [Tue, 28 Sep 2021 12:21:50 +0000 (13:21 +0100)]
Remove deprecated update from Theta Union (2)