fineract-cn-portfolio.git
8 weeks agoMerge pull request #8 from myrle-krantz/develop develop
Myrle Krantz [Thu, 19 Apr 2018 17:22:23 +0000 (19:22 +0200)] 
Merge pull request #8 from myrle-krantz/develop

Removing dependency to java money library.

8 weeks agoRemoving dependency to java money library. 8/head
Myrle Krantz [Thu, 19 Apr 2018 15:36:35 +0000 (17:36 +0200)] 
Removing dependency to java money library.

2 months agoMerge pull request #7 from myrle-krantz/develop
Myrle Krantz [Mon, 16 Apr 2018 19:18:13 +0000 (21:18 +0200)] 
Merge pull request #7 from myrle-krantz/develop

Updating package names.

2 months agoRemoving last references to mifos. 7/head
Myrle Krantz [Mon, 16 Apr 2018 08:11:20 +0000 (10:11 +0200)] 
Removing last references to mifos.

2 months agoChange package names from mifos to apache fineract.
Myrle Krantz [Mon, 16 Apr 2018 08:07:16 +0000 (10:07 +0200)] 
Change package names from mifos to apache fineract.

2 months agoAdjusting to package name changes in upstream repositories.
Myrle Krantz [Mon, 16 Apr 2018 07:21:38 +0000 (09:21 +0200)] 
Adjusting to package name changes in upstream repositories.

2 months agoMerge pull request #6 from myrle-krantz/develop
Myrle Krantz [Mon, 9 Apr 2018 18:37:41 +0000 (20:37 +0200)] 
Merge pull request #6 from myrle-krantz/develop

Adding rat checks.

2 months agoAdding rat checks. 6/head
Myrle Krantz [Mon, 9 Apr 2018 18:36:38 +0000 (20:36 +0200)] 
Adding rat checks.

2 months agoMerge pull request #5 from ebenezergraham/patch-1
Myrle Krantz [Mon, 9 Apr 2018 08:28:38 +0000 (10:28 +0200)] 
Merge pull request #5 from ebenezergraham/patch-1

Minor update to the README.md file to ensure consistent naming

2 months agoUpdate README.md 5/head
Ebenezer Graham [Fri, 6 Apr 2018 16:39:18 +0000 (20:39 +0400)] 
Update README.md

2 months agoMerge pull request #4 from myrle-krantz/develop
Myrle Krantz [Thu, 5 Apr 2018 14:35:27 +0000 (16:35 +0200)] 
Merge pull request #4 from myrle-krantz/develop

Fix broken unit test.

2 months agoFix broken unit test. 4/head
Myrle Krantz [Thu, 5 Apr 2018 14:29:49 +0000 (16:29 +0200)] 
Fix broken unit test.

3 months agoMerge pull request #3 from Izakey/develop
Myrle Krantz [Fri, 16 Mar 2018 10:45:42 +0000 (11:45 +0100)] 
Merge pull request #3 from Izakey/develop

Updated copyright information for portfolio

3 months agoRemoved unused year and name variables 3/head
Isaac Kamga [Mon, 5 Mar 2018 20:10:12 +0000 (21:10 +0100)] 
Removed unused year and name variables

3 months agoUpdated copyright information for portfolio
Isaac Kamga [Fri, 2 Mar 2018 20:43:40 +0000 (21:43 +0100)] 
Updated copyright information for portfolio

3 months agoMerge pull request #2 from myrle-krantz/develop
Myrle Krantz [Mon, 26 Feb 2018 17:34:27 +0000 (18:34 +0100)] 
Merge pull request #2 from myrle-krantz/develop

updating artifact ids to apache fineract from mifos io

3 months agoupdating artifact ids to apache fineract from mifos io 2/head
Myrle Krantz [Mon, 26 Feb 2018 17:12:20 +0000 (18:12 +0100)] 
updating artifact ids to apache fineract from mifos io

3 months agoMerge pull request #1 from crain/develop
Myrle Krantz [Tue, 20 Feb 2018 11:56:16 +0000 (12:56 +0100)] 
Merge pull request #1 from crain/develop

Sync with latest Mifos I/O

5 months agoMerge pull request #27 from myrlen/develop 1/head
myrlen [Wed, 20 Dec 2017 16:04:29 +0000 (17:04 +0100)] 
Merge pull request #27 from myrlen/develop

Improved annotations for new endpoint.

5 months agoImproved annotations for new endpoint.
Myrle Krantz [Wed, 20 Dec 2017 16:01:44 +0000 (17:01 +0100)] 
Improved annotations for new endpoint.

5 months agoMerge pull request #26 from myrlen/develop
myrlen [Wed, 20 Dec 2017 15:58:45 +0000 (16:58 +0100)] 
Merge pull request #26 from myrlen/develop

Made it possible to get planned payments with just case parameters, even

5 months agoMade it possible to get planned payments with just case parameters, even
Myrle Krantz [Wed, 20 Dec 2017 15:57:49 +0000 (16:57 +0100)] 
Made it possible to get planned payments with just case parameters, even
though the case hasn't been created yet.

6 months agoMerge pull request #25 from markusgeiss/develop
Markus Geiss [Fri, 8 Dec 2017 07:15:35 +0000 (08:15 +0100)] 
Merge pull request #25 from markusgeiss/develop

added holder to account generation

6 months agoremoved unnecessary portfolio designator for api
Markus Geiss [Fri, 8 Dec 2017 07:14:35 +0000 (08:14 +0100)] 
removed unnecessary portfolio designator for api

6 months agoadded holder information to account generation
Markus Geiss [Fri, 8 Dec 2017 07:12:10 +0000 (08:12 +0100)] 
added holder information to account generation

6 months agoMerge pull request #24 from myrlen/develop
myrlen [Fri, 24 Nov 2017 16:42:21 +0000 (17:42 +0100)] 
Merge pull request #24 from myrlen/develop

Loan repayment should not be restricted to current teller balance.

6 months agoTightened test parameters for disbursement and repayment. Disburse to a customer...
Myrle Krantz [Fri, 24 Nov 2017 16:02:09 +0000 (17:02 +0100)] 
Tightened test parameters for disbursement and repayment.  Disburse to a customer account shouldn't be bothered by a zero balance, and repay via a teller account shouldn't be bothered by a zero balance.

6 months agoAdjusting entry account assignment helper and workflow tests to make it possible...
Myrle Krantz [Fri, 24 Nov 2017 15:33:31 +0000 (16:33 +0100)] 
Adjusting entry account assignment helper and workflow tests to make it possible to vary entry account assignment.

6 months agoAdjusting entry account assignment helper and workflow tests to make it possible...
Myrle Krantz [Fri, 24 Nov 2017 14:49:54 +0000 (15:49 +0100)] 
Adjusting entry account assignment helper and workflow tests to make it possible to vary entry account assignment.

6 months agoGetting account sign from accounting via adapter.
Myrle Krantz [Fri, 24 Nov 2017 12:55:58 +0000 (13:55 +0100)] 
Getting account sign from accounting via adapter.

6 months agoFixing payment cycle test.
Myrle Krantz [Thu, 23 Nov 2017 15:51:13 +0000 (16:51 +0100)] 
Fixing payment cycle test.

6 months agoPreparing to get account sign from accounting rather than internal assumptions by...
Myrle Krantz [Thu, 23 Nov 2017 15:22:24 +0000 (16:22 +0100)] 
Preparing to get account sign from accounting rather than internal assumptions by getting Account object rather than just balance from the AccountingAdapter.

6 months agoFixed test case for out of range alignment week.
Myrle Krantz [Thu, 23 Nov 2017 15:21:21 +0000 (16:21 +0100)] 
Fixed test case for out of range alignment week.

6 months agoMerge pull request #23 from myrlen/develop
myrlen [Thu, 23 Nov 2017 12:07:09 +0000 (13:07 +0100)] 
Merge pull request #23 from myrlen/develop

Validation of case parameters had been accidentally left out.

6 months agoValidation of case parameters had been accidentally left out. This caused us to...
Myrle Krantz [Thu, 23 Nov 2017 12:04:19 +0000 (13:04 +0100)] 
Validation of case parameters had been accidentally left out.  This caused us to accumulate out of range values for the alignment week.  Now case parameters are validated, but I've weakened the week alignment validation temporarily until the UI can be fixed.

6 months agoMerge pull request #22 from myrlen/develop
myrlen [Wed, 22 Nov 2017 20:28:32 +0000 (21:28 +0100)] 
Merge pull request #22 from myrlen/develop

There is a small chance that a transaction uniqueifier fails to make …

6 months agoThere is a small chance that a transaction uniqueifier fails to make the transaction...
Myrle Krantz [Wed, 22 Nov 2017 20:25:21 +0000 (21:25 +0100)] 
There is a small chance that a transaction uniqueifier fails to make the transaction unique.  In this case, the accounting adapter should retry the booking with a new uniqueifier.

7 months agoMerge pull request #21 from myrlen/develop
myrlen [Tue, 14 Nov 2017 09:55:13 +0000 (10:55 +0100)] 
Merge pull request #21 from myrlen/develop

Fixed misnaming with real consequences: reference account should've been

7 months agoFixed misnaming with real consequences: reference account should've been
Myrle Krantz [Tue, 14 Nov 2017 09:53:35 +0000 (10:53 +0100)] 
Fixed misnaming with real consequences: reference account should've been
alternative account.

7 months agoMerge pull request #20 from myrlen/develop
myrlen [Fri, 10 Nov 2017 09:34:39 +0000 (10:34 +0100)] 
Merge pull request #20 from myrlen/develop

Polishing import

7 months agoAdded minor check for planned payment count in "normal" case.
Myrle Krantz [Fri, 10 Nov 2017 09:33:12 +0000 (10:33 +0100)] 
Added minor check for planned payment count in "normal" case.

7 months agoMaking sure planned payments uses the saved payment size rather than the calculated...
Myrle Krantz [Fri, 10 Nov 2017 08:55:46 +0000 (09:55 +0100)] 
Making sure planned payments uses the saved payment size rather than the calculated payment size for imported loans.

7 months agoLate fee checking happy case and interest works for imported loans now.
Myrle Krantz [Thu, 9 Nov 2017 17:23:14 +0000 (18:23 +0100)] 
Late fee checking happy case and interest works for imported loans now.

7 months agoPersisting/creating accounts for import.
Myrle Krantz [Thu, 9 Nov 2017 12:22:26 +0000 (13:22 +0100)] 
Persisting/creating accounts for import.

7 months agoSetting start and end of term and payment size correctly for imported loans.
Myrle Krantz [Wed, 8 Nov 2017 16:22:07 +0000 (17:22 +0100)] 
Setting start and end of term and payment size correctly for imported loans.

7 months agoMerge pull request #19 from myrlen/develop
myrlen [Tue, 7 Nov 2017 07:36:02 +0000 (08:36 +0100)] 
Merge pull request #19 from myrlen/develop

API for loan import

7 months agoAPI for loan import.
Myrle Krantz [Tue, 7 Nov 2017 07:34:36 +0000 (08:34 +0100)] 
API for loan import.

7 months agoAdding missing header.
Myrle Krantz [Mon, 6 Nov 2017 16:41:16 +0000 (17:41 +0100)] 
Adding missing header.

7 months agoMerge pull request #18 from ndelvos78/sortLoanProductsByEnabled
Markus Geiss [Fri, 3 Nov 2017 13:39:50 +0000 (14:39 +0100)] 
Merge pull request #18 from ndelvos78/sortLoanProductsByEnabled

Allow loan products to be sorted by Enabled column without error.

7 months agoAllow loan products to be sorted by Enabled column without error.
ndelvos78 [Tue, 31 Oct 2017 00:32:58 +0000 (20:32 -0400)] 
Allow loan products to be sorted by Enabled column without error.

7 months agoMerge pull request #17 from myrlen/develop
myrlen [Thu, 19 Oct 2017 11:32:01 +0000 (13:32 +0200)] 
Merge pull request #17 from myrlen/develop

Added the ability to reference customer documents from a loan.

7 months agoAdded the ability to reference customer documents from a loan.
Myrle Krantz [Thu, 19 Oct 2017 11:25:14 +0000 (13:25 +0200)] 
Added the ability to reference customer documents from a loan.

8 months agoMerge pull request #16 from myrlen/develop
myrlen [Thu, 12 Oct 2017 09:58:56 +0000 (11:58 +0200)] 
Merge pull request #16 from myrlen/develop

fixing edge cases

8 months agoFixed bug in which if the fees due exceed the current payment, too much
Myrle Krantz [Thu, 12 Oct 2017 09:57:36 +0000 (11:57 +0200)] 
Fixed bug in which if the fees due exceed the current payment, too much
is booked from entry to pay off the full amount of the fees.

8 months agoIntroduced some new test cases for AcceptPaymentBuilderService to insure
Myrle Krantz [Wed, 11 Oct 2017 13:09:44 +0000 (15:09 +0200)] 
Introduced some new test cases for AcceptPaymentBuilderService to insure
that upcoming changes don't break existing functionality.

8 months agoMinor restructuring of payment builder test cases to prepare to correct
Myrle Krantz [Wed, 11 Oct 2017 11:17:31 +0000 (13:17 +0200)] 
Minor restructuring of payment builder test cases to prepare to correct
behavior when the disbursement fees exceed the initial payment size.

8 months agoMerge branch 'develop' of https://github.com/KuelapInc/portfolio into develop
Myrle Krantz [Wed, 11 Oct 2017 09:49:18 +0000 (11:49 +0200)] 
Merge branch 'develop' of https://github.com/KuelapInc/portfolio into develop

8 months agoIn response to Dayna's (non-urgent) feedback from October 6th, removing
Myrle Krantz [Wed, 11 Oct 2017 09:47:56 +0000 (11:47 +0200)] 
In response to Dayna's (non-urgent) feedback from October 6th, removing
balance floor of zero from GENERAL_LOSS_ALLOWANCE account.  This account
can now be sent into negative territory by a loan write-off.

8 months agoMerge pull request #15 from myrlen/develop
myrlen [Tue, 10 Oct 2017 08:03:18 +0000 (10:03 +0200)] 
Merge pull request #15 from myrlen/develop

Automatic creation of the product loss provisioning account.

8 months agoAutomatic creation of the product loss provisioning account.
Myrle Krantz [Tue, 10 Oct 2017 08:01:30 +0000 (10:01 +0200)] 
creation of the product loss provisioning account.

8 months agoMerge pull request #14 from myrlen/arrearsAndWriteOff
myrlen [Fri, 6 Oct 2017 13:11:57 +0000 (15:11 +0200)] 
Merge pull request #14 from myrlen/arrearsAndWriteOff

Arrears and write off

8 months agointerest and late fee accrual "stored" in product loss allowance account.
Myrle Krantz [Fri, 6 Oct 2017 13:09:41 +0000 (15:09 +0200)] 
interest and late fee accrual "stored" in product loss allowance account.

8 months agoWrite off of principal implemented and tested.
Myrle Krantz [Fri, 6 Oct 2017 11:27:03 +0000 (13:27 +0200)] 
Write off of principal implemented and tested.

8 months agoMerge branch 'develop' into arrearsAndWriteOff
Myrle Krantz [Thu, 5 Oct 2017 15:50:54 +0000 (17:50 +0200)] 
Merge branch 'develop' into arrearsAndWriteOff

8 months agoMerge pull request #13 from myrlen/develop
myrlen [Thu, 5 Oct 2017 12:03:25 +0000 (14:03 +0200)] 
Merge pull request #13 from myrlen/develop

Improved saving of lossprovisioningsteps.

8 months agoImproved saving of lossprovisioningsteps.
Myrle Krantz [Thu, 5 Oct 2017 12:02:45 +0000 (14:02 +0200)] 
Improved saving of lossprovisioningsteps.

8 months agoMerge pull request #12 from myrlen/develop
myrlen [Thu, 5 Oct 2017 10:07:40 +0000 (12:07 +0200)] 
Merge pull request #12 from myrlen/develop

Adjusted validation of loss provisiong configuration.  Steps are no l…

8 months agoAdjusted validation of loss provisiong configuration. Steps are no longer
Myrle Krantz [Thu, 5 Oct 2017 10:04:58 +0000 (12:04 +0200)] 
Adjusted validation of loss provisiong configuration.  Steps are no longer
forced to 100%, but they should now be unique by daysLate.

8 months agoMerge pull request #11 from myrlen/develop
myrlen [Wed, 4 Oct 2017 15:28:14 +0000 (17:28 +0200)] 
Merge pull request #11 from myrlen/develop

permittable group id was too long.

8 months agopermittable group id was too long.
Myrle Krantz [Wed, 4 Oct 2017 15:27:20 +0000 (17:27 +0200)] 
permittable group id was too long.

8 months agoCleaning up warnings.
Myrle Krantz [Wed, 4 Oct 2017 14:45:45 +0000 (16:45 +0200)] 
Cleaning up warnings.

8 months agoImplementing checking for arrears based on the already implemented configuration.
Myrle Krantz [Wed, 4 Oct 2017 14:43:49 +0000 (16:43 +0200)] 
Implementing checking for arrears based on the already implemented configuration.
Fixing mark late checking -- fees needed to be included in consideration.

8 months agoFormatting and documentation
Myrle Krantz [Wed, 4 Oct 2017 14:37:25 +0000 (16:37 +0200)] 
Formatting and documentation

8 months agoIncreasing timeout for ledger creation.
Myrle Krantz [Wed, 4 Oct 2017 07:55:46 +0000 (09:55 +0200)] 
Increasing timeout for ledger creation.

8 months agoRemoving unused code.
Myrle Krantz [Wed, 4 Oct 2017 07:55:27 +0000 (09:55 +0200)] 
Removing unused code.

8 months agoMerge pull request #10 from KuelapInc/plannedPaymentsAsCostoComponents
myrlen [Tue, 3 Oct 2017 10:56:42 +0000 (12:56 +0200)] 
Merge pull request #10 from KuelapInc/plannedPaymentsAsCostoComponents

Planned payments as costo components

8 months agoImplemented persistence and default values for loan loss provisioning.
Myrle Krantz [Mon, 2 Oct 2017 20:24:23 +0000 (22:24 +0200)] 
Implemented persistence and default values for loan loss provisioning.
Connected API to persistence.

8 months agoSlight formatting improvement.
Myrle Krantz [Mon, 2 Oct 2017 19:48:20 +0000 (21:48 +0200)] 
Slight formatting improvement.

8 months agoReattempting ledger creation when id is already assigned.
Myrle Krantz [Mon, 2 Oct 2017 19:25:18 +0000 (21:25 +0200)] 
Reattempting ledger creation when id is already assigned.

8 months agoFixing bug resulting from the implementation of JournalEntry credits and
Myrle Krantz [Mon, 2 Oct 2017 19:05:42 +0000 (21:05 +0200)] 
Fixing bug resulting from the implementation of JournalEntry credits and
debits as sets.  If multiple identical charges were made to the same
account via different account designators then the Set eliminates the
duplicates creating an unbalanced journal entry.  For this reason, we
must sum the entries again after they are mapped from designators to
account identifiers.

8 months agoFixing test broken by last change.
Myrle Krantz [Mon, 2 Oct 2017 13:45:40 +0000 (15:45 +0200)] 
Fixing test broken by last change.

8 months agoReplacing create ledger with add sub ledger.
Myrle Krantz [Mon, 2 Oct 2017 13:09:44 +0000 (15:09 +0200)] 
Replacing create ledger with add sub ledger.

8 months agoBaby steps (get it? : o) towards implementing loss provisioning api.
Myrle Krantz [Mon, 2 Oct 2017 13:08:05 +0000 (15:08 +0200)] 
Baby steps (get it? : o) towards implementing loss provisioning api.

8 months agoFirst draft loss provisioning API.
Myrle Krantz [Mon, 2 Oct 2017 10:31:50 +0000 (12:31 +0200)] 
First draft loss provisioning API.

8 months agoTaking a brief break from more important things for clearing out some todos.
Myrle Krantz [Mon, 2 Oct 2017 09:49:44 +0000 (11:49 +0200)] 
Taking a brief break from more important things for clearing out some todos.

8 months agoAdded product arrears configuration, and began drawing on it to
Myrle Krantz [Mon, 2 Oct 2017 08:58:32 +0000 (10:58 +0200)] 
Added product arrears configuration, and began drawing on it to
calculate loan loss provisioning upon disbursement.

8 months agoAdding command history, and reconstructing mark late to go to
Myrle Krantz [Sun, 1 Oct 2017 14:59:19 +0000 (16:59 +0200)] 
Adding command history, and reconstructing mark late to go to
command history rather than transaction history.  This in
preparation for arrears handling.

8 months agoI apparently need to take a look at the late fee calculating code...
Myrle Krantz [Sun, 1 Oct 2017 13:46:30 +0000 (15:46 +0200)] 
I apparently need to take a look at the late fee calculating code...
Temporary fix.

8 months agoAdding missing headers
Myrle Krantz [Sun, 1 Oct 2017 13:28:44 +0000 (15:28 +0200)] 
Adding missing headers

8 months agoCompound interest to simple interest
Myrle Krantz [Fri, 29 Sep 2017 11:13:27 +0000 (13:13 +0200)] 
Compound interest to simple interest

8 months agoChanged charge persistence so that only those charges which the user may
Myrle Krantz [Fri, 29 Sep 2017 09:10:00 +0000 (11:10 +0200)] 
Changed charge persistence so that only those charges which the user may
change are also persisted. This protects users better from breaking their
products than the previous readonly flag did, and also makes data migrations
much easier when changes are made to those charges.  It also makes it possible
to adjust "readonly" charges based on product parameters.

In the process switched from lists to streaming for transporting the charges.

8 months agoCommenting out comparison with planned payments -- we still have a
Myrle Krantz [Thu, 28 Sep 2017 12:31:27 +0000 (14:31 +0200)] 
Commenting out comparison with planned payments -- we still have a
diversion in 2 of 12 payments between planned payments and payments.  I
need to get on to other things and need a green test baseline to start
on them from.

8 months agoFixed precision inconsistency between planned payments and payments
Myrle Krantz [Thu, 28 Sep 2017 11:23:18 +0000 (13:23 +0200)] 
Fixed precision inconsistency between planned payments and payments
which was causing the loan payment calculation to be inconsistent by
cents.

8 months agoRestructuring to a parameterized test in preparation for adding more
Myrle Krantz [Thu, 28 Sep 2017 10:26:33 +0000 (12:26 +0200)] 
Restructuring to a parameterized test in preparation for adding more
cases.

8 months agoFixed inconsistency in interest calculation between planned payment and
Myrle Krantz [Thu, 28 Sep 2017 10:23:49 +0000 (12:23 +0200)] 
Fixed inconsistency in interest calculation between planned payment and
payment by accruing interest on the real amount rather than compounding
the calculated daily interest, then applying it for the planned payment.

This resulted in some misbehavior in planned payments around the interest
costcomponent since both accrual and incurral were being added to that
costcomponent.  To fix this I excluded accrued costcomponents from the
payment and changed the basis of journal entry creation from the
costcomponents to the balanceAdjustments in the payment builder.

This approach gives a more accurate result anyways because sometimes
when two identical charges were debitting the same account, one of them
was getting lost in the set.  It also makes it easier to filter out
entries which cancel each other producing a zero debit or credit.

8 months ago* Filled out last payment to make sure "leftover" amounts are payed.
Myrle Krantz [Wed, 27 Sep 2017 19:10:30 +0000 (21:10 +0200)] 
* Filled out last payment to make sure "leftover" amounts are payed.

8 months ago* Fixed regression in loan payment size calculation
Myrle Krantz [Wed, 27 Sep 2017 16:23:35 +0000 (18:23 +0200)] 
* Fixed regression in loan payment size calculation
* Added comparison to planned payments to loan workflow test.

8 months ago* Changed interest calculation to exclude fees.
Myrle Krantz [Wed, 27 Sep 2017 10:31:13 +0000 (12:31 +0200)] 
* Changed interest calculation to exclude fees.
* Fixed lateness test to check for the lateness charge correctly.

8 months ago* Various repairs to TestAccountingInteractionInLoanWorkflow
Myrle Krantz [Tue, 26 Sep 2017 20:19:07 +0000 (22:19 +0200)] 
* Various repairs to TestAccountingInteractionInLoanWorkflow
* Fixed accrual accounting of interest (was calculating double interest).

8 months ago* More refactoring to facilitate unit testing.
Myrle Krantz [Tue, 26 Sep 2017 10:42:30 +0000 (12:42 +0200)] 
* More refactoring to facilitate unit testing.
* Added coverage for core part of interest calculation.