GEODE-5839: Fixes misc clang-tidy warnings.
authorJacob Barrett <jbarrett@pivotal.io>
Tue, 9 Oct 2018 00:21:48 +0000 (17:21 -0700)
committerJacob Barrett <jbarrett@pivotal.io>
Wed, 10 Oct 2018 16:59:40 +0000 (09:59 -0700)
commitecc62a61c93d72c759a3139ce4620eb335f89a15
treeb99ed3c7132e7c86f1bbccda2e2f02ce2f91caad
parent9ed0ceddf4cf15a40801cc1ed8436bf58cfd1b14
GEODE-5839: Fixes misc clang-tidy warnings.

* Fixes clang-analyzer-core.CallAndMessage warning
* Fixes clang-diagnostic-return-std-move-in-c++11 warning.
* Cleanup NOLINT with specific warning it suppresses.
* Fixes clang-analyzer-core.CallAndMessage warning
* Updates to Boost 1.68 to fix uninitilalized variable.
* Fixes clang-analyzer-unix.* warnings.
* Fixes clang-analyzer-unix.* warnings.
* Fixes clang-analyzer-cplusplus.NewDeleteLeaks warnings.
* Fixes clang-analyzer-security.insecureAPI.rand warnings.
* Fixes remaining clang-diagnostic-* warnings.
* Fixes clang-analyzer-deadcode.DeadStores warnings.
* Fixes clang-analyzer-security.insecureAPI.strcpy warning
* Fixes clang-analyzer-cplusplus.NewDelete warning
* Cleanup clang-tidy configs
137 files changed:
.clang-tidy
cppcache/include/geode/DataOutput.hpp
cppcache/include/geode/RegionAttributesFactory.hpp
cppcache/integration-test-2/framework/.clang-tidy [new file with mode: 0644]
cppcache/integration-test/BBNamingContext.cpp
cppcache/integration-test/BuiltinCacheableWrappers.hpp
cppcache/integration-test/CacheHelper.cpp
cppcache/integration-test/CacheImplHelper.hpp
cppcache/integration-test/DeltaEx.hpp
cppcache/integration-test/LocatorHelper.hpp
cppcache/integration-test/QueryHelper.hpp
cppcache/integration-test/ThinClientCallbackArg.hpp
cppcache/integration-test/ThinClientDistOps.hpp
cppcache/integration-test/ThinClientDistOps2.hpp
cppcache/integration-test/ThinClientDurable.hpp
cppcache/integration-test/ThinClientDurableFailover.hpp
cppcache/integration-test/ThinClientDurableInterest.hpp
cppcache/integration-test/ThinClientDurableReconnect.hpp
cppcache/integration-test/ThinClientFailover.hpp
cppcache/integration-test/ThinClientFailover2.hpp
cppcache/integration-test/ThinClientFailover3.hpp
cppcache/integration-test/ThinClientFailoverInterest.hpp
cppcache/integration-test/ThinClientFailoverInterest2.hpp
cppcache/integration-test/ThinClientFailoverInterestAllWithCache.hpp
cppcache/integration-test/ThinClientFailoverRegex.hpp
cppcache/integration-test/ThinClientGatewayTest.hpp
cppcache/integration-test/ThinClientHelper.hpp
cppcache/integration-test/ThinClientInterest3.hpp
cppcache/integration-test/ThinClientInterest3Cacheless.hpp
cppcache/integration-test/ThinClientInterestList.hpp
cppcache/integration-test/ThinClientInterestList2.hpp
cppcache/integration-test/ThinClientListenerInit.hpp
cppcache/integration-test/ThinClientListenerWriter.hpp
cppcache/integration-test/ThinClientLocalCacheLoader.hpp
cppcache/integration-test/ThinClientMultipleCaches.hpp
cppcache/integration-test/ThinClientNotification.hpp
cppcache/integration-test/ThinClientPdxSerializer.hpp
cppcache/integration-test/ThinClientPdxSerializers.hpp
cppcache/integration-test/ThinClientPutAll.hpp
cppcache/integration-test/ThinClientPutAllTimeout.hpp
cppcache/integration-test/ThinClientPutAllWithCallBack.hpp
cppcache/integration-test/ThinClientPutGetAll.hpp
cppcache/integration-test/ThinClientRIwithlocalRegionDestroy.hpp
cppcache/integration-test/ThinClientRegex.hpp
cppcache/integration-test/ThinClientRegex2.hpp
cppcache/integration-test/ThinClientRegex3.hpp
cppcache/integration-test/ThinClientRemoveAll.hpp
cppcache/integration-test/ThinClientSSL.hpp
cppcache/integration-test/ThinClientSSLWithPassword.hpp
cppcache/integration-test/ThinClientSecurity.hpp
cppcache/integration-test/ThinClientSecurityHelper.hpp
cppcache/integration-test/ThinClientTXFailover.hpp
cppcache/integration-test/ThinClientTasks_C2S2.hpp
cppcache/integration-test/ThinClientTransactions.hpp
cppcache/integration-test/ThinClientTransactionsXA.hpp
cppcache/integration-test/fw_dunit.cpp
cppcache/integration-test/fw_dunit.hpp
cppcache/integration-test/fw_spawn.hpp
cppcache/integration-test/locator_globals.hpp
cppcache/integration-test/testRegionTemplateArgs.cpp
cppcache/integration-test/testSerialization.cpp
cppcache/integration-test/testSpinLock.cpp
cppcache/integration-test/testThinClientBigValue.cpp
cppcache/integration-test/testThinClientCacheablesLimits.cpp
cppcache/integration-test/testThinClientFixedPartitionResolver.cpp
cppcache/integration-test/testThinClientPRSingleHop.cpp
cppcache/integration-test/testThinClientPartitionResolver.cpp
cppcache/integration-test/testThinClientPdxInstance.cpp
cppcache/integration-test/testThinClientRemoteQueryRS.cpp
cppcache/integration-test/testThinClientRemoteRegionQuery.cpp
cppcache/integration-test/testThinClientSSLWithSecurityAuthz.cpp
cppcache/integration-test/testThinClientSecurityAuthentication.cpp
cppcache/integration-test/testThinClientSecurityAuthenticationMU.cpp
cppcache/integration-test/testThinClientSecurityAuthenticationSetAuthInitialize.cpp
cppcache/integration-test/testThinClientSecurityAuthorization.cpp
cppcache/integration-test/testThinClientSecurityAuthorizationMU.cpp
cppcache/integration-test/testThinClientSecurityCQAuthorizationMU.cpp
cppcache/integration-test/testThinClientSecurityDH.cpp
cppcache/integration-test/testThinClientSecurityDH_MU.cpp
cppcache/integration-test/testThinClientSecurityDurableCQAuthorizationMU.cpp
cppcache/integration-test/testThinClientWriterException.cpp
cppcache/integration-test/testUtils.hpp
cppcache/src/AuthenticatedView.cpp
cppcache/src/CacheXmlParser.cpp
cppcache/src/ClientMetadataService.cpp
cppcache/src/ClientMetadataService.hpp
cppcache/src/CqService.cpp
cppcache/src/ExpiryTaskManager.cpp
cppcache/src/FarSideEntryOp.cpp
cppcache/src/InternalCacheTransactionManager2PCImpl.cpp
cppcache/src/LocalRegion.cpp
cppcache/src/MapSegment.hpp
cppcache/src/PdxHelper.cpp
cppcache/src/PdxInstanceFactory.cpp
cppcache/src/PdxTypeRegistry.cpp
cppcache/src/PoolFactory.cpp
cppcache/src/PoolXmlCreation.cpp
cppcache/src/PoolXmlCreation.hpp
cppcache/src/ProxyRegion.hpp
cppcache/src/Queue.hpp
cppcache/src/RegionAttributesFactory.cpp
cppcache/src/RegionCommit.cpp
cppcache/src/RegionXmlCreation.cpp
cppcache/src/RegionXmlCreation.hpp
cppcache/src/RemoteQuery.cpp
cppcache/src/SerializationRegistry.cpp
cppcache/src/SerializationRegistry.hpp
cppcache/src/TXCommitMessage.cpp
cppcache/src/TcrConnectionManager.hpp
cppcache/src/TcrMessage.cpp
cppcache/src/ThinClientBaseDM.hpp
cppcache/src/ThinClientLocatorHelper.cpp
cppcache/src/ThinClientLocatorHelper.hpp
cppcache/src/ThinClientPoolDM.cpp
cppcache/src/ThinClientRedundancyManager.cpp
cppcache/src/ThinClientRegion.cpp
cppcache/src/Utils.cpp
cppcache/src/Utils.hpp
cppcache/src/statistics/HostStatSampler.cpp
cppcache/src/statistics/HostStatSampler.hpp
cppcache/test/ByteArray.cpp
cppcache/test/CacheableKeyCreateTests.cpp
cppcache/test/SerializableCreateTests.cpp
cryptoimpl/DHImpl.cpp
dependencies/boost/CMakeLists.txt
dependencies/boost/patches [new file with mode: 0644]
dependencies/boost/solaris.patch [deleted file]
dhimpl/DHImpl.cpp
tests/cpp/fwklib/FwkLog.cpp
tests/cpp/fwklib/IpcHandler.cpp
tests/cpp/security/PkcsAuthInit.cpp
tests/cpp/security/PkcsCredentialGenerator.hpp
tests/cpp/security/XmlAuthzCredentialGenerator.hpp
tests/cpp/testobject/DeltaFastAssetAccount.hpp
tests/cpp/testobject/PdxClassV1.hpp
tests/cpp/testobject/PdxClassV2.hpp
tests/cpp/testobject/TestObject1.cpp