geode.git
2 weeks agoMerge branch 'master' into release/1.6.0 master
Mike Stolz [Wed, 2 May 2018 17:54:55 +0000 (13:54 -0400)] 
Merge branch 'master' into release/1.6.0

3 weeks agoAdd KEYS file with Mike's Sig
Mike Stolz [Wed, 25 Apr 2018 21:13:38 +0000 (17:13 -0400)] 
Add KEYS file with Mike's Sig

4 weeks agoRevert "GEODE-3926: Lucene Query Exception is thrown if queries are executed in the... rel/v1.6.0 rel/v1.6.0.RC1
nabarun [Thu, 19 Apr 2018 22:12:58 +0000 (15:12 -0700)] 
Revert "GEODE-3926: Lucene Query Exception is thrown if queries are executed in the middle of reindexing a region (#1742)"

This reverts commit 75ae584

4 weeks agoGEODE-5056: when found the dropped events at primary sender, send (#1794)
Xiaojian Zhou [Fri, 13 Apr 2018 17:09:22 +0000 (10:09 -0700)] 
GEODE-5056: when found the dropped events at primary sender, send (#1794)

QueueRemovalMessage for it

(cherry picked from commit f7bb77c89a3d19673e8929275fc6c407a4b382bd)

4 weeks agoGEODE-5085 authentication failure when auto-reconnecting
Bruce Schuchardt [Wed, 18 Apr 2018 20:45:33 +0000 (13:45 -0700)] 
GEODE-5085 authentication failure when auto-reconnecting

Modified auto-reconnect to gather the security properties from the
DistributionConfig and to use the non-parsed values of properties
instead of the parsed versions.

Modified unit tests to gather the security properties and use the
non-parsed values when deciding whether to create a new distributed system.

Added a security manager to all of the ReconnectDUnitTest test cases.

This closes #1807

(cherry picked from commit 08ec4af911baa9eaca05f2aaf5d021618734bfe1)

4 weeks agoGEODE-4716 Document new stats and missing gateway sender/receiver MXBean (#1813)
Karen Miller [Tue, 17 Apr 2018 21:49:41 +0000 (14:49 -0700)] 
GEODE-4716 Document new stats and missing gateway sender/receiver MXBean (#1813)

- found and fixed a subnav typo for a link to the MXBean doc
- corrected a bad Object Name for the AsyncEventQueueMXBean

4 weeks agoGEODE-5046: Handle RegionDestroyedException in RemotePutMessage to re… (#1773)
pivotal-eshu [Thu, 12 Apr 2018 16:50:26 +0000 (09:50 -0700)] 
GEODE-5046: Handle RegionDestroyedException in RemotePutMessage to re… (#1773)

   cherry-pick 2203273307a8695dafc3b617cac9979ff0305f9b

4 weeks agoGEODE-5068: bump Jackson version. (#1796) (#1801)
Galen O'Sullivan [Mon, 16 Apr 2018 16:45:26 +0000 (09:45 -0700)] 
GEODE-5068: bump Jackson version. (#1796) (#1801)

GEODE-5068: bump Jackson version to 2.9.5.

5 weeks agoGEODE-5039: Change AbstractRegion to correctly construct EvictionAttributesMutator...
pivotal-eshu [Thu, 12 Apr 2018 16:44:44 +0000 (09:44 -0700)] 
GEODE-5039: Change AbstractRegion to correctly construct EvictionAttributesMutator (#1766)

     git cherry-pick c62846d643d35c68945320dc8a0e85197b28b0f6

5 weeks agoGEODE-4384 Add docs for gfsh destroy jndi-binding command (#1780)
Karen Miller [Fri, 13 Apr 2018 20:55:21 +0000 (13:55 -0700)] 
GEODE-4384 Add docs for gfsh destroy jndi-binding command (#1780)

5 weeks agoUpdated release type in preparation for the release
Mike Stolz [Thu, 12 Apr 2018 21:51:31 +0000 (14:51 -0700)] 
Updated release type in preparation for the release

5 weeks agoGEODE-4919: Update the PRConfig (#1666)
Nabarun Nag [Thu, 12 Apr 2018 15:42:46 +0000 (08:42 -0700)] 
GEODE-4919: Update the PRConfig (#1666)

        * Before adding any gateway sender or AEQ now do the following
* Assign buckets to the partition region
* Update the PartitionRegionConfig for the region with the updated set of gateway senders
* For Lucene reindex AEQs will be created at this point.
* Mutators then add the gateway senders to the internal region attributes.

5 weeks agoGEODE-3237: Loading cluster configuration from a dir that does not ha… (#1746)
Sai Boorlagadda [Wed, 11 Apr 2018 20:03:41 +0000 (13:03 -0700)] 
GEODE-3237: Loading cluster configuration from a dir that does not ha… (#1746)

    command option --load-cluster-config-from-dir is deprecated and a warning
    is added to the gfsh command output in case if its used.

5 weeks agoGEODE-4909: Additional lucene reindex tests with security
Lynn Hughes-Godfrey [Tue, 27 Mar 2018 22:23:07 +0000 (15:23 -0700)] 
GEODE-4909: Additional lucene reindex tests with security

* Extended existing tests with and without gfsh to create region prior to creating lucene index.

5 weeks agoGEODE-4858: pulling JaxbService out of InternalClusterConfigurationSe… (#1754)
jinmeiliao [Wed, 11 Apr 2018 15:09:49 +0000 (08:09 -0700)] 
GEODE-4858: pulling JaxbService out of InternalClusterConfigurationSe… (#1754)

* GEODE-4858: pulling JaxbService out of InternalClusterConfigurationService

* add capability for JaxService to validate with another xsd
* cache element use the default namespace ""
* add capability for modules to register schema location
* use package-info to do namespace mapping

5 weeks agoGEODE-3926: Disabling queryOnlyWhenIndexIsAvailable
nabarunnag [Wed, 11 Apr 2018 02:54:38 +0000 (19:54 -0700)] 
GEODE-3926: Disabling queryOnlyWhenIndexIsAvailable

* Disabling the test till for a short while till the solution is found

5 weeks agoGEODE-4942: when sender is starting, and not running yet, put event at primary should...
Xiaojian Zhou [Wed, 11 Apr 2018 02:18:18 +0000 (19:18 -0700)] 
GEODE-4942: when sender is starting, and not running yet, put event at primary should be saved for QueueRemovalMessage (#1771)

5 weeks agoGEODE-3926: Lucene Query Exception is thrown if queries are executed in the middle...
Jason Huynh [Wed, 11 Apr 2018 01:14:54 +0000 (18:14 -0700)] 
GEODE-3926: Lucene Query Exception is thrown if queries are executed in the middle of reindexing a region (#1742)

  * Add new internal exception, LuceneIndexCreationInProgressException
  * Index the region even if it's empty
  * Added awaitility clauses to reindexing tests
  * getRepositories will throw an exception if the index is not available
  * getRepositories will not throw an exception if the data region is empty (this scenario can occur when creating the index before the region)

5 weeks agofixing backward-compatibility test dependencies to allow running in IntelliJ
Bruce Schuchardt [Tue, 10 Apr 2018 22:29:38 +0000 (15:29 -0700)] 
fixing backward-compatibility test dependencies to allow running in IntelliJ

5 weeks agoRevert "GEODE-4942: when sender is starting, and not running yet, put event at primar...
zhouxh [Tue, 10 Apr 2018 21:08:49 +0000 (14:08 -0700)] 
Revert "GEODE-4942: when sender is starting, and not running yet, put event at primary should be saved for QueueRemovalMessage (#1740)"

This reverts commit e42ebec32518c014ab6bd3ffe6d1ee3cab813762.
Due to acceptance test failed after merge. Need to double check the merge.

5 weeks agoGEODE-4999: Added tomcat 8.5 directory for tcserver support (#1762)
Jason Huynh [Tue, 10 Apr 2018 20:33:51 +0000 (13:33 -0700)] 
GEODE-4999: Added tomcat 8.5 directory for tcserver support (#1762)

5 weeks agoGEODE-4942: when sender is starting, and not running yet, put event at primary should...
Xiaojian Zhou [Tue, 10 Apr 2018 17:51:10 +0000 (10:51 -0700)] 
GEODE-4942: when sender is starting, and not running yet, put event at primary should be saved for QueueRemovalMessage (#1740)

5 weeks agoGEODE-4991: do no use hard coded quotes (#1728)
Darrel Schneider [Tue, 10 Apr 2018 17:40:59 +0000 (10:40 -0700)] 
GEODE-4991: do no use hard coded quotes (#1728)

java.sql.DatabaseMetaData.getIdentifierQuoteString is now used when quoting identifiers.
If this method returns null, an empty string, or a string with all spaces then no quoting will be done.

5 weeks agoGEODE-5027 Bump version to 1.6.0 and add v1.5.0 for testing
Bruce Schuchardt [Tue, 10 Apr 2018 17:30:30 +0000 (10:30 -0700)] 
GEODE-5027 Bump version to 1.6.0 and add v1.5.0 for testing

Reducing the amount of servers or locators in a number of RollingUpgradeDUnitTest
methods and accelerating the startup of the initial locators in clusters
created by the test.

This reduces the runtime of the test from 14 minutes to 9 minutes

5 weeks agoGEODE-4915: Ignore the 'for testing' exception (#1752)
Kenneth Howe [Tue, 10 Apr 2018 14:56:47 +0000 (07:56 -0700)] 
GEODE-4915: Ignore the 'for testing' exception (#1752)

* GEODE-4915: Ignore the 'for testing' exception

5 weeks agoGEODE-5009: Add unit tests for GfJsonObject (#1761)
Jens Deppe [Tue, 10 Apr 2018 13:31:29 +0000 (06:31 -0700)] 
GEODE-5009: Add unit tests for GfJsonObject (#1761)

5 weeks agoGEODE-5008: Add unit tests for GfJsonArray (#1758)
Jens Deppe [Tue, 10 Apr 2018 13:31:06 +0000 (06:31 -0700)] 
GEODE-5008: Add unit tests for GfJsonArray (#1758)

* GEODE-5008: Add unit tests for GfJsonArray

- Remove some unused methods from GfJsonArray

5 weeks agoGEODE-5027 Bump version to 1.6.0 and add v1.5.0 for testing
Bruce Schuchardt [Mon, 9 Apr 2018 23:03:50 +0000 (16:03 -0700)] 
GEODE-5027 Bump version to 1.6.0 and add v1.5.0 for testing

Reducing the amount of servers or locators in a number of RollingUpgrade2DUnitTest
methods and accelerating the startup of the initial locators in clusters
created by the test.

This reduces the runtime of the test from 51 minutes to 24 minutes.

5 weeks agoGEODE-4995 ClusterStartupRule is inefficient when shutting down the cluster
Bruce Schuchardt [Mon, 9 Apr 2018 22:04:02 +0000 (15:04 -0700)] 
GEODE-4995 ClusterStartupRule is inefficient when shutting down the cluster

modified after() to shut down non-locators before shutting down locators,
allowing membership coordination to stay in the locator instead of
causing cascading movement of the role.

5 weeks agoGEODE-3820 CI failure: DataSerializerPropogationDUnitTest.testDataSerializersEventIdV...
Bruce Schuchardt [Mon, 9 Apr 2018 20:52:11 +0000 (13:52 -0700)] 
GEODE-3820 CI failure: DataSerializerPropogationDUnitTest.testDataSerializersEventIdVerification

This was actually fixed in 5fe3c76d6b1a595c250d924d0115e20f2491cd2a but the
flakytest categorization wasn't removed from the test.  I also added a bounce()
of one of the VMs in a test that would fail if the test is accidentally run
multiple times.

5 weeks agoGEODE-5027 Bump version to 1.6.0 and add v1.5.0 for testing
Bruce Schuchardt [Mon, 9 Apr 2018 18:13:10 +0000 (11:13 -0700)] 
GEODE-5027 Bump version to 1.6.0 and add v1.5.0 for testing

* I bumped the version in Version.java to 1.6.0 and added a 1.6 command set
  to CommandInitializer.
* I added v1.5.0 to geode-old-versions for backward compatibility testing.

* I removed junk in Version.java that hasn't been used since the SQLFire/GFX
  days.
* I also removed AcceptorImpl.VERSION which seemed to serve no good purpose.

* I added a unit test to make sure that folks update the CommandInitializer
  table when adding a new Version.  Without this test folks would have to run
  distributedTests to notice any problems with their changes.

* I changed CommandInitializer to not create new maps unless necessary.

* I fixed a test's expectation that the default connection pool exists after starting
  a client cache.  Starting with 1.5 the pool isn't created until it's needed.

This closes #1753

5 weeks agoGEODE-5029: Improve docs around query timeout and low memory (#1755)
Karen Miller [Mon, 9 Apr 2018 17:02:38 +0000 (10:02 -0700)] 
GEODE-5029: Improve docs around query timeout and low memory (#1755)

* GEODE-5029: Improve docs around query timeout and low memory

* GEODE-5029 Revise wording
 - both davebarnes97 and joeymcallister contributed rewrite suggestions
implemented in this commit

5 weeks agoGEODE-5024: Use debug version of gradle-dockerized-test-plugin (#1749)
Jens Deppe [Mon, 9 Apr 2018 16:35:07 +0000 (09:35 -0700)] 
GEODE-5024: Use debug version of gradle-dockerized-test-plugin (#1749)

- This version is forked at
  github.com/jdeppe-pivotal/gradle-dockerized-test-plugin and the artifacts
  have been published to http://geode-maven.s3-website-us-west-2.amazonaws.com.

5 weeks agoGEODE-5007: Add unit tests to TabularResultData (#1757)
Jens Deppe [Mon, 9 Apr 2018 16:17:36 +0000 (09:17 -0700)] 
GEODE-5007: Add unit tests to TabularResultData (#1757)

5 weeks agoGEODE-5006: Remove unused ObjectResultData (#1756)
Jens Deppe [Mon, 9 Apr 2018 16:17:10 +0000 (09:17 -0700)] 
GEODE-5006: Remove unused ObjectResultData (#1756)

- Also remove associated and unused RegionAttributesInfo, RegionDetails,
  RegionMemberDetails and CliJsonSerializable*

6 weeks agoRevert "GEODE-4999: Added explicit tomcat 8.5 directory for tcserver support (#1737)"
nabarun [Fri, 6 Apr 2018 23:24:13 +0000 (16:24 -0700)] 
Revert "GEODE-4999: Added explicit tomcat 8.5 directory for tcserver support (#1737)"

This reverts commit 2d45dad835d70e731ecc8053f75184f0dd0a9265.

6 weeks agoGEODE-4999: Added explicit tomcat 8.5 directory for tcserver support (#1737)
Jason Huynh [Fri, 6 Apr 2018 22:16:58 +0000 (15:16 -0700)] 
GEODE-4999: Added explicit tomcat 8.5 directory for tcserver support (#1737)

6 weeks agoMerge branch 'release/1.5.0'
Swapnil Bawaskar [Fri, 6 Apr 2018 20:09:30 +0000 (13:09 -0700)] 
Merge branch 'release/1.5.0'

6 weeks agoGEODE-4518: Replace DSCODE with an enumeration. (#1738)
Michael "Sarge" Dodge [Fri, 6 Apr 2018 18:52:09 +0000 (11:52 -0700)] 
GEODE-4518: Replace DSCODE with an enumeration. (#1738)

* GEODE-4518: Replace DSCODE with an enumeration.
- Deprecate DSCODE interface.
- Introduce HeaderByte enum.
- Replace explicit references to DSCODE with
  explicit references to HeaderByte.

* GEODE-4518: Update analysis files.

* GEODE-4518: Add unit test for value uniqueness.

* GEODE-4518: Convert DSCODE into enum that replaces HeaderByte.

6 weeks agoMerge pull request #1751 from jdeppe-pivotal/feature/GEODE-5026
Dick Cavender [Fri, 6 Apr 2018 17:33:48 +0000 (10:33 -0700)] 
Merge pull request #1751 from jdeppe-pivotal/feature/GEODE-5026

GEODE-5026: Do not run acceptanceTest in parallel under docker

6 weeks agoCOMMIT THEN REVIEW. fix spelling: PARTITIION -> PARTITION
Karen Miller [Fri, 6 Apr 2018 17:10:46 +0000 (10:10 -0700)] 
COMMIT THEN REVIEW.  fix spelling: PARTITIION -> PARTITION

6 weeks agoGEODE-5026: Do not run acceptanceTest in parallel under docker 1751/head
Jens Deppe [Fri, 6 Apr 2018 16:52:36 +0000 (09:52 -0700)] 
GEODE-5026: Do not run acceptanceTest in parallel under docker

6 weeks agoGEODE_1279: Rename MembershipAttributesAreSerializableRegressionTest
Kirk Lund [Wed, 4 Apr 2018 17:45:18 +0000 (10:45 -0700)] 
GEODE_1279: Rename MembershipAttributesAreSerializableRegressionTest

6 weeks agoGEODE-1279: Rename FinalStaticArrayShouldNotCauseSegFaultRegressionTest
Kirk Lund [Wed, 4 Apr 2018 17:40:59 +0000 (10:40 -0700)] 
GEODE-1279: Rename FinalStaticArrayShouldNotCauseSegFaultRegressionTest

6 weeks agoGEODE-5021: Add parameters to connection in jdbc-1.0.xsd (#1748)
Kirk Lund [Fri, 6 Apr 2018 16:21:13 +0000 (09:21 -0700)] 
GEODE-5021: Add parameters to connection in jdbc-1.0.xsd (#1748)

6 weeks agoGEODE-5004: Add unit tests for ErrorResultData (#1744)
Jens Deppe [Fri, 6 Apr 2018 16:04:06 +0000 (09:04 -0700)] 
GEODE-5004: Add unit tests for ErrorResultData (#1744)

6 weeks agoGEODE-5005: Add unit tests for InfoResultData (#1745)
Jens Deppe [Fri, 6 Apr 2018 16:03:37 +0000 (09:03 -0700)] 
GEODE-5005: Add unit tests for InfoResultData (#1745)

6 weeks agoGEODE-4819: Separating authorization out from protobuf handlers
Bruce Schuchardt [Fri, 6 Apr 2018 15:46:16 +0000 (08:46 -0700)] 
GEODE-4819: Separating authorization out from protobuf handlers

Removed unused imports that were causing compilation warnings

6 weeks agoGEODE-5000: do not request/apply cluster config when creating client … (#1739)
jinmeiliao [Fri, 6 Apr 2018 15:23:08 +0000 (08:23 -0700)] 
GEODE-5000: do not request/apply cluster config when creating client … (#1739)

* do not request/apply cluster config when creating client cache.
* give client cache a no-op security service to avoid NPE.

6 weeks agoGEODE-4830: modify the message when no jndi-binding is found. (#1732)
jinmeiliao [Fri, 6 Apr 2018 15:21:48 +0000 (08:21 -0700)] 
GEODE-4830: modify the message when no jndi-binding is found. (#1732)

6 weeks agoGEODE-5003: Add tests for CompositeResultData (#1743)
Jens Deppe [Fri, 6 Apr 2018 13:42:14 +0000 (06:42 -0700)] 
GEODE-5003: Add tests for CompositeResultData (#1743)

6 weeks agoGEODE-4947: JdbcConnector tests run against external database as AcceptanceTest categ...
agingade [Thu, 5 Apr 2018 23:36:26 +0000 (16:36 -0700)] 
GEODE-4947: JdbcConnector tests run against external database as AcceptanceTest category (#1747)

Add test with Postgres and MySQL for JDBC connector
Add rule for Postgres, MySQL and Derby standing up Docker instance to enable testing
Update integration tests to use mysql and postgres
Convert distributed tests to use mysql and postgres
Fix issue with null character string in Postgres
Add geode-connectors test to acceptance tests

6 weeks agoGEODE-4961: Allowing custom serialization formats with the protobuf protocol
Dan Smith [Thu, 5 Apr 2018 20:38:35 +0000 (13:38 -0700)] 
GEODE-4961: Allowing custom serialization formats with the protobuf protocol

Adding a new ValueSerializer interface that users can implement to
control the serialization format of data sent using the protobuf
protocol.

ValueSerializers are registered on the server side using the java
ServiceLoader mechanism. They are selected by the client using a new
valueFormat field in the handshake.

Renamed AuthenticationRequest to HandshakeRequest. Credentials
and valueFormat are all sent as part of a single HandshakeRequest.

Renamed the connection states to make them a little easier to
understand, and removed some duplicate states.

The new states are RequireVersion, RequireAuthentication,
AcceptMessages, InvalidSecurity, and TerminateConnection

6 weeks agoGEODE-4849: Add integration test for existing REST API. (#1721)
Michael "Sarge" Dodge [Thu, 5 Apr 2018 18:23:36 +0000 (11:23 -0700)] 
GEODE-4849: Add integration test for existing REST API. (#1721)

* GEODE-4849: Add integration tests for existing REST API.

* GEODE-4849: Move test to geode-assembly.

6 weeks agoRevert "GEODE-4822 The second server instance startup error: Could not create an...
Bruce Schuchardt [Thu, 5 Apr 2018 16:20:30 +0000 (09:20 -0700)] 
Revert "GEODE-4822 The second server instance startup error: Could not create an instance of PartitionRegionConfig"

This reverts commit d044ce0ca5bb6742af96bb1c504e329572d686fa.

6 weeks agoRevert "GEODE-4989 CQ reply message fromData method deserializes query results"
Bruce Schuchardt [Thu, 5 Apr 2018 16:02:18 +0000 (09:02 -0700)] 
Revert "GEODE-4989 CQ reply message fromData method deserializes query results"

This reverts commit 3c263e9220cd56486e3ec4d39cdd0a694482fb49.

6 weeks agoGEODE-4971: Add version capability to GfshRule (#1731)
Jens Deppe [Thu, 5 Apr 2018 15:17:58 +0000 (08:17 -0700)] 
GEODE-4971: Add version capability to GfshRule (#1731)

- Move GfshRuleTest to geode-assembly module since it depends on a full product distro

6 weeks agoGEODE-4960: Jar deploy fails when SSL is enabled (#1698)
Jens Deppe [Thu, 5 Apr 2018 14:20:31 +0000 (07:20 -0700)] 
GEODE-4960: Jar deploy fails when SSL is enabled (#1698)

- Print the deployed jar MD5 hash in hex

6 weeks agoGEODE-4644: Move static to member of distributed system. (#1734)
Michael "Sarge" Dodge [Wed, 4 Apr 2018 21:51:47 +0000 (14:51 -0700)] 
GEODE-4644: Move static to member of distributed system. (#1734)

6 weeks agoGEODE-4456: Remove singleton calls from all tests in org.apache.geode.internal.cache
Darrel Schneider [Wed, 4 Apr 2018 21:39:40 +0000 (14:39 -0700)] 
GEODE-4456: Remove singleton calls from all tests in org.apache.geode.internal.cache

* removed InternalDistributedSystem.getConnectedInstance call from TombstoneCreationJUnitTest
* Also the cache is now created in a @Before method and uses non-deprecated methods to create it.
* removed InternalDistributedSystem.getConnectedInstance call from ClientServerTransactionDUnitTest
* removed getAnyInstance calls in GridAdvisorDUnitTest

6 weeks agoGEODE-4984 Add new Use Cases section to docs (#1733)
Karen Miller [Wed, 4 Apr 2018 20:10:54 +0000 (13:10 -0700)] 
GEODE-4984 Add new Use Cases section to docs (#1733)

- add the start of a subsection on using Geode as an inline cache

6 weeks agoGEODE-4983 PluckStacks is no longer detecting idle executors and weeding them out
Bruce Schuchardt [Wed, 4 Apr 2018 18:22:16 +0000 (11:22 -0700)] 
GEODE-4983 PluckStacks is no longer detecting idle executors and weeding them out

fixing the sort order of thread dumps

6 weeks agoGEODE-4970: Overhaul and split up PartitionedRegionQueryDUnitTest (#1718)
Kirk Lund [Wed, 4 Apr 2018 17:29:37 +0000 (10:29 -0700)] 
GEODE-4970: Overhaul and split up PartitionedRegionQueryDUnitTest (#1718)

Rename:
* PartitionedRegionQueryDUnitTest -> PRQueryDistributedTest

Extract the following tests from PRQueryDistributedTest:
* PRQueryWithIndexAndPdxDistributedTest
* PRQueryWithIndexDistributedTest
* PRQueryWithOrderByDistributedTest
* PRQueryWithPdxDuringRebalanceRegressionTest
* PRWithIndexAfterRebalanceRegressionTest

Introduce and use:
* InternalClientCache interface
* ClientCacheRule

6 weeks agoGEODE-4893: add test to make sure the callbacks will be loaded correctly (#1729)
jinmeiliao [Wed, 4 Apr 2018 17:27:07 +0000 (10:27 -0700)] 
GEODE-4893: add test to make sure the callbacks will be loaded correctly (#1729)

6 weeks agoGEODE-4989 CQ reply message fromData method deserializes query results
Bruce Schuchardt [Wed, 4 Apr 2018 16:43:50 +0000 (09:43 -0700)] 
GEODE-4989 CQ reply message fromData method deserializes query results

CqEntry was using DataSerializer.readObject() to read the entry's value
instead of InternalDataSerializer.readUserObject().  The latter is needed
to respect the setting of pdx-read-serialized in the query service's
StreamingReplyMessage.

This closes #1719

6 weeks agoGEODE-4911: Deprecate DataSerializer.TRACE_SERIALIZABLE. (#1722)
Michael "Sarge" Dodge [Wed, 4 Apr 2018 15:24:11 +0000 (08:24 -0700)] 
GEODE-4911: Deprecate DataSerializer.TRACE_SERIALIZABLE. (#1722)

6 weeks agoGEODE-4902: Refactor LogMarker class and usage (#1678)
Patrick Rhomberg [Tue, 3 Apr 2018 23:33:58 +0000 (16:33 -0700)] 
GEODE-4902: Refactor LogMarker class and usage (#1678)

* GEODE-4902: Refactor LogMarker and usage
* Distinguish those markers at the TRACE and DEBUG levels (now Markers named *_VERBOSE) from those that log at a coarser grainularity (now Markers named *_MARKER)
* Suppress only *_VERBOSE markers by default, from previous behavior of suppressing all markers.
* Refactor some pathological log checks, e.g., change a log from debug to trace when it is gated behind ifTraceEnabled block.
* Remove unused Markers.
* Remove any log marker logic from AdminWaiters exception message generation.  Exceptions now always include a full message.
* Remove marker-gated print to System.out in PersistentOplogSet -- direct calls to System.out should not exist in that class.
* Add marker EVENT_ID_TO_STRING_VERBOSE to explicitly distinguish instance of marker used in logic not immediately consumed by a logger.  The consumption of EventId::toString should only exist at logging in any event.
**
* Remove nearby dead code and dead code detected during marker removal.
* Expand wildcard imports in touched files.
* Remove TODO comments, at least one of which was a decade old.
* Collapse nearby, redundant catch blocks
* Remove empty finally blocks
* Update documentation page to refer to GEODE_VERBOSE, from deprecated GEMFIRE_VERBOSE
* The change in log marker names causes one class to compile larger.  Updated sanctionedDataSerializables.

6 weeks agoGEODE-4972: Move VersionManager to geode-old-versions module (#1703)
Jens Deppe [Tue, 3 Apr 2018 23:00:55 +0000 (16:00 -0700)] 
GEODE-4972: Move VersionManager to geode-old-versions module (#1703)

- This will facilitate other modules being able to use VersionManager;
  specifically geode-junit.

6 weeks agoGeode-4950 + GEODE-4951: Upgrade spotless version and reduce run time.
Patrick Rhomberg [Tue, 3 Apr 2018 22:04:59 +0000 (15:04 -0700)] 
Geode-4950 + GEODE-4951: Upgrade spotless version and reduce run time.

* GEODE-4950: Update spotless plugin to newest version.
* GEODE-4951: Allow spotless to skip UP-TO-DATE files.

6 weeks agoGEODE-4840: do not deserialize PdxInstances for remote gets (#1693)
Darrel Schneider [Tue, 3 Apr 2018 21:58:09 +0000 (14:58 -0700)] 
GEODE-4840: do not deserialize PdxInstances for remote gets (#1693)

The preferCD flag is now passed down to convertPdxInstanceIfNeeded.
if preferCD is true then the caller wants the serialized form back
from the load and in that case the PdxInstances bytes are wrapped
in a PreferBytesCachedDeserializable and it is returned.
So now the PdxInstance will only be deserialized if a local get is
done and pdx-read-serialized is false.

6 weeks agoGEODE-4867: Unused imports
nabarun [Tue, 3 Apr 2018 18:14:35 +0000 (11:14 -0700)] 
GEODE-4867: Unused imports

* Removed unused imports from the previous commit.

6 weeks agoGEODE-4872: handle Blob when reading from JDBC (#1692)
Darrel Schneider [Tue, 3 Apr 2018 17:38:25 +0000 (10:38 -0700)] 
GEODE-4872: handle Blob when reading from JDBC (#1692)

When a pdx BYTE_ARRAY or OBJECT field is read and
the column type is BLOB, getBlob is called and
its value is converted to a byte[].

6 weeks agoGEODE-4983 PluckStacks is no longer detecting idle executors and weeding them out
Bruce Schuchardt [Tue, 3 Apr 2018 17:08:52 +0000 (10:08 -0700)] 
GEODE-4983 PluckStacks is no longer detecting idle executors and weeding them out

fixing check for idle executors

6 weeks agoGEODE-4981 CI failure: SSLConfigurationFactoryJUnitTest.getNonSSLConfiguration
Bruce Schuchardt [Tue, 3 Apr 2018 17:06:04 +0000 (10:06 -0700)] 
GEODE-4981 CI failure: SSLConfigurationFactoryJUnitTest.getNonSSLConfiguration

fixing another test that configures SSL and leaves state behind

6 weeks agoGEODE-4979: Incorrect description in docs of ResourcePermission in OQL
masaki.yamakawa [Sun, 1 Apr 2018 07:29:46 +0000 (16:29 +0900)] 
GEODE-4979: Incorrect description in docs of ResourcePermission in OQL

6 weeks agoGEODE-3456: Fix display of 'null' hosts in Pulse UI (#1717)
Jens Deppe [Tue, 3 Apr 2018 04:00:15 +0000 (21:00 -0700)] 
GEODE-3456: Fix display of 'null' hosts in Pulse UI (#1717)

6 weeks agoGEODE-4386: Return 'not found' if the JNDI binding does not exist (#1713)
Jens Deppe [Mon, 2 Apr 2018 21:05:48 +0000 (14:05 -0700)] 
GEODE-4386: Return 'not found' if the JNDI binding does not exist (#1713)

6 weeks agoGEODE-4867: Added query time expiration checks. (#1624)
Nabarun Nag [Mon, 2 Apr 2018 17:10:30 +0000 (10:10 -0700)] 
GEODE-4867: Added query time expiration checks. (#1624)

* Along with low memory checks, the query execution time limit is also checked.

6 weeks agoGEODE-4893: Improve reloading the cluster configuration on existing vanilla servers
jinmeiliao [Mon, 2 Apr 2018 17:02:53 +0000 (10:02 -0700)] 
GEODE-4893: Improve reloading the cluster configuration on existing vanilla servers

6 weeks agoGEODE-4981 CI failure: SSLConfigurationFactoryJUnitTest.getNonSSLConfiguration
Bruce Schuchardt [Mon, 2 Apr 2018 16:56:42 +0000 (09:56 -0700)] 
GEODE-4981 CI failure: SSLConfigurationFactoryJUnitTest.getNonSSLConfiguration

Added SocketCreatorFactory.close() in @After methods to SSL tests that
weren't cleaning up after themselves.

6 weeks agoCOMMIT THEN REVIEW: Fixed doc typos.
Karen Miller [Mon, 2 Apr 2018 16:21:20 +0000 (09:21 -0700)] 
COMMIT THEN REVIEW: Fixed doc typos.

6 weeks agoGEODE-4817: Fix SSLTest. (#1714)
Michael "Sarge" Dodge [Mon, 2 Apr 2018 16:07:48 +0000 (09:07 -0700)] 
GEODE-4817: Fix SSLTest. (#1714)

6 weeks agoGEODE-4980 CI failure: AutoConnectionSourceImplJUnitTest. testServerLocationUsedInLis...
Bruce Schuchardt [Mon, 2 Apr 2018 16:02:41 +0000 (09:02 -0700)] 
GEODE-4980 CI failure: AutoConnectionSourceImplJUnitTest. testServerLocationUsedInListenerNotification

Modified the test to not expect a numeric host name for an InetAddress of
"1.1.1.1".  That address has been seen to resolve to a host name and when
that happened the test failed.

6 weeks agoRevert "GEODE-4386: Return 'not found' if the JNDI binding does not exist (#1710)"
Jens Deppe [Mon, 2 Apr 2018 15:19:30 +0000 (08:19 -0700)] 
Revert "GEODE-4386: Return 'not found' if the JNDI binding does not exist (#1710)"

This reverts commit 60614fb818363128e6fe4587973a11e87e98ed45.

6 weeks agoRevert "GEODE-4386: Correct check in the case where JNDI binding does not exist"
Jens Deppe [Mon, 2 Apr 2018 15:19:13 +0000 (08:19 -0700)] 
Revert "GEODE-4386: Correct check in the case where JNDI binding does not exist"

This reverts commit 0297afdd80098364d55d476160d42820581dd320.

6 weeks agoGEODE-4386: Correct check in the case where JNDI binding does not exist
Jens Deppe [Mon, 2 Apr 2018 14:48:17 +0000 (07:48 -0700)] 
GEODE-4386: Correct check in the case where JNDI binding does not exist

7 weeks agoGEODE-4386: Return 'not found' if the JNDI binding does not exist (#1710)
Jens Deppe [Sat, 31 Mar 2018 16:48:09 +0000 (09:48 -0700)] 
GEODE-4386: Return 'not found' if the JNDI binding does not exist (#1710)

- Return with an error code if the JNDI binding is not found
- Add availability indication

7 weeks agoGEODE-4817: Add support for SSL to the experimental driver. (#1683)
Michael "Sarge" Dodge [Fri, 30 Mar 2018 23:46:49 +0000 (16:46 -0700)] 
GEODE-4817: Add support for SSL to the experimental driver. (#1683)

* GEODE-4817: Add support for SSL to the experimental driver.
- Adding a test that a locator can shut itself down
  with SSL. In order to use a locator with SSL, the
  locator must trust itself. Modifying the truststore
  and adding a test of shutting down a locator with SSL.
- The locator needs to trust itself. Fixing the
  truststore so that this test can shutdown.

Signed-off-by: Dan Smith <dsmith@pivotal.io>
* GEODE-4817: Adding ssl tests with bad certificates

Adding tests that the client cannot connect if the server or the client
has a bad ssl certificate.

* GEODE-4817: Adding protocols and cipher parameters to the experimental driver

Adding parameters that let the user restrict the protocols and ciphers
used.

7 weeks agoGEODE-3820: Remove all invocations of Wait.pause(). (#1694)
Michael "Sarge" Dodge [Fri, 30 Mar 2018 23:39:21 +0000 (16:39 -0700)] 
GEODE-3820: Remove all invocations of Wait.pause(). (#1694)

7 weeks agoGEODE-4917: Remove dead and redundant code from LinkedStructSet.
Patrick Rhomberg [Fri, 30 Mar 2018 23:01:24 +0000 (16:01 -0700)] 
GEODE-4917: Remove dead and redundant code from LinkedStructSet.

* Minor refactors of unnecessarily verbose if-statements.

7 weeks agoGEODE-4976: Fix misspelling and misattribution in test logging. (#1708)
Michael "Sarge" Dodge [Fri, 30 Mar 2018 22:03:54 +0000 (15:03 -0700)] 
GEODE-4976: Fix misspelling and misattribution in test logging. (#1708)

7 weeks agoGEODE-4974: Create single connection pool per cache (#1707)
Nick Reich [Fri, 30 Mar 2018 21:35:05 +0000 (14:35 -0700)] 
GEODE-4974: Create single connection pool per cache (#1707)

7 weeks agoGEODE-3563: use a timeout for newly created sockets in TcpConduit.run() (#1671)
Galen O'Sullivan [Fri, 30 Mar 2018 18:13:15 +0000 (11:13 -0700)] 
GEODE-3563: use a timeout for newly created sockets in TcpConduit.run() (#1671)

* GEODE-3563: use a timeout in SocketCreator.ConfigureServerSSLSocket()

Also close newly accepted sockets in TcpConduit.run() if SSL
configuration fails (or any other IOException).

* Add units.

* Rename to startHandshakeIfSocketIsSSL for clarity.

7 weeks agoGEODE-4928 DistributedLockService doesn't work as expected while the dlock grantor...
Bruce Schuchardt [Fri, 30 Mar 2018 17:56:24 +0000 (10:56 -0700)] 
GEODE-4928 DistributedLockService doesn't work as expected while the dlock grantor is initialized

Fixing an issue with the test

This closes #1680

7 weeks agoGEODE-4811: Add @Disabled "feature flag" annotation for gfsh commands.
Patrick Rhomberg [Fri, 30 Mar 2018 17:29:29 +0000 (10:29 -0700)] 
GEODE-4811: Add @Disabled "feature flag" annotation for gfsh commands.

7 weeks agoGEODE-4934: Throw exception if shutdown fails in GfshRule (#1699)
Kenneth Howe [Fri, 30 Mar 2018 16:37:57 +0000 (09:37 -0700)] 
GEODE-4934: Throw exception if shutdown fails in GfshRule (#1699)

* GEODE-4934: Throw exception if shutdown fails in GfshRule

The conjecture is that we're missing shutdown problems with a test
that can cause problems in later tests. This change is an attempt
to catch the real error in the sporadic AcceptanceTest failures.

Throw the exception if one or more processes failed the shutdown.

7 weeks agoGEODE-4929: Add ability for tests to overide the default DiskDirs (#1701)
Kirk Lund [Fri, 30 Mar 2018 16:37:33 +0000 (09:37 -0700)] 
GEODE-4929: Add ability for tests to overide the default DiskDirs (#1701)

* System property geode.defaultDiskDirs is used to specify some dir
  other than "."
* DiskDirRule can be used by IntegrationTests
* DistributedDiskDirRule can be used by DistributedTests
* Update BucketRegionSizeWithOverflowRegressionTest to use
  DistributedDiskDirRule

7 weeks agoGEODE-4928 DistributedLockService doesn't work as expected while the dlock grantor...
Bruce Schuchardt [Fri, 30 Mar 2018 16:11:27 +0000 (09:11 -0700)] 
GEODE-4928 DistributedLockService doesn't work as expected while the dlock grantor is initialized

backing out test to fix connection issues

7 weeks agoGEODE-3720: Add additional output pattern to failure assertion for ConnectCommandWith...
Jens Deppe [Fri, 30 Mar 2018 16:04:54 +0000 (09:04 -0700)] 
GEODE-3720: Add additional output pattern to failure assertion for ConnectCommandWithSSLTest (#1704)

7 weeks agoGEODE-2321: Pulse application works incorrectly in some locales (#1661)
Jens Deppe [Fri, 30 Mar 2018 14:15:21 +0000 (07:15 -0700)] 
GEODE-2321: Pulse application works incorrectly in some locales (#1661)

- Ensure that all number formatting is consistent. Formatting, as it exists,
  will be according to the US locale.
- This also fixes GEODE-1409