2 days agoMerge branch 'release/1.8.0' master
Alexander Murmann [Wed, 12 Dec 2018 22:26:43 +0000 (14:26 -0800)] 
Merge branch 'release/1.8.0'

3 weeks agoGEODE-6065: Continue event processing when hostname lookup fails (#2883) release/1.8.0 rel/v1.8.0 rel/v1.8.0.RC1 rel/v1.8.0.RC2
Ryan McMahon [Wed, 21 Nov 2018 02:49:51 +0000 (18:49 -0800)] 
GEODE-6065: Continue event processing when hostname lookup fails (#2883)

Co-authored-by: Ryan McMahon <>
Co-authored-by: Bill Burcham <>
3 weeks agoGEODE-6063 remove PublishArtifacts from Geode release pipelines (#2865)
Owen Nichols [Fri, 16 Nov 2018 19:45:45 +0000 (11:45 -0800)] 
GEODE-6063 remove PublishArtifacts from Geode release pipelines (#2865)

4 weeks agoGEODE-6053: Parameterized Queries fixed (#2859)
Nabarun Nag [Fri, 16 Nov 2018 20:33:40 +0000 (12:33 -0800)] 
GEODE-6053: Parameterized Queries fixed (#2859)

* Parameterized queries were throwing UnsupportedOperationExceptions.
* This was because of trying to pre-compute values for join optimization.
* When the query was parameterized it is not possible to compute these values and hence these exceptions are thrown
* The fix was to prevent this computation when it is not needed or not possible.

4 weeks agoGEODE-5884: Adding to function exception list if cause is FunctionInvocationTargetExc...
Jason Huynh [Thu, 8 Nov 2018 23:18:19 +0000 (15:18 -0800)] 
GEODE-5884: Adding to function exception list if cause is FunctionInvocationTargetException (#2809)

4 weeks agoGEODE-5884: Added new command and restored pre 1.8 region function behavior (#2829)
Jason Huynh [Tue, 13 Nov 2018 23:16:48 +0000 (15:16 -0800)] 
GEODE-5884: Added new command and restored pre 1.8 region function behavior (#2829)

* Due to the refactor that caused us to lose wrapping of exceptions,
  the fix to GEODE-5884 cannot be applied to GEODE 1.0-1.7 clients
* Adding new command class will allow clients to identify which function class
  it is expecting to execute and what behavior to expect

4 weeks agoGEODE-5993: Eliminate race in monitorQueryThread() (#2818) 2860/head
Bill Burcham [Fri, 9 Nov 2018 23:12:03 +0000 (15:12 -0800)] 
GEODE-5993: Eliminate race in monitorQueryThread() (#2818)

A race existed between setting low memory in the heap monitor thread,
and checking the low memory state in query monitoring thread.

The cancelation executor was shut down and no longer accepting new
tasks when this race occurred, causing a RejectedExecutionException.

This commit solves that problem by encapsulating the scheduling
behavior using the state design pattern.

Co-authored-by: Ryan McMahon <>
Co-authored-by: Bill Burcham <>
4 weeks agoRevert "GEODE-5729: when DistributedCacheOperation needs 2 messages, should let ...
Ryan McMahon [Wed, 7 Nov 2018 21:11:05 +0000 (13:11 -0800)] 
Revert "GEODE-5729: when DistributedCacheOperation needs 2 messages, should let (#2458)" (#2801)

This reverts commit 49eb1c5fd13aefff0995d76ec7864c82d5730dd8.

4 weeks agoGEODE-6048 build should work on release branches (#2847)
Owen Nichols [Wed, 14 Nov 2018 18:59:12 +0000 (10:59 -0800)] 
GEODE-6048 build should work on release branches (#2847)

before this fix, ./gradlew build install will fail on release branch

with this fix, now it will succeed (signing will only be attempted if
signing properties are set)

Cherry-picked from 249fa0ed6078901ffe08991ee39193efd4ecdede

5 weeks agoGEODE-6018 Remove reflections from LICENSE
Anthony Baker [Thu, 8 Nov 2018 18:06:25 +0000 (10:06 -0800)] 
GEODE-6018 Remove reflections from LICENSE

Remove reflections from LICENSE.  It was previously a transitive
dependency of springfox, which no longer pulls it in.  WTFPL is
no longer needed.

(cherry picked from commit 379ee68ce61d95e569a042c2fecdf5a588223dea)

5 weeks agoUpdate version numbers for 1.8.0 release
Alexander Murmann [Thu, 8 Nov 2018 17:01:11 +0000 (09:01 -0800)] 
Update version numbers for 1.8.0 release

5 weeks agoGEODE-5947: Make dependencies explicit in connectors and experimental-driver modules...
Patrick Rhomberg [Tue, 6 Nov 2018 19:39:59 +0000 (11:39 -0800)] 
GEODE-5947: Make dependencies explicit in connectors and experimental-driver modules (#2738)

5 weeks agoGEODE-5918 Geode function security should be dynamically determined by function argum...
ivorzhou [Tue, 6 Nov 2018 19:05:31 +0000 (03:05 +0800)] 
GEODE-5918 Geode function security should be dynamically determined by function arguments (#2727)

5 weeks agoGEODE-5978: Expand GeodeAwaitility and add test coverage
Kirk Lund [Fri, 2 Nov 2018 22:27:01 +0000 (15:27 -0700)] 
GEODE-5978: Expand GeodeAwaitility and add test coverage

Add getTimeout to allow the default timeout to be used for more than
just Awaitility (for example, with Mockito.timeout).

Add toTimeDuration to facilitate conversions between java.time.Duration
and org.awaitility.Duration.

Make timeout non-static for testing and write some unit tests.

5 weeks agoGEODE-5985 Possible integer overflow
Bruce Schuchardt [Tue, 6 Nov 2018 18:36:42 +0000 (10:36 -0800)] 
GEODE-5985 Possible integer overflow

We had a number of calculations that were taking place with ints instead
of longs.  I've modified them to, in most places, just add an L to the
constant multiplier.  In other places I had to change a variable type
from int to long.

There were a few places that were also assigning a long to an int
variable or an int to a byte variable.  In these I added bit AND
operators to reduce the chances of overflow.

IndexElemArray needed a lot of work due to its "size" instvar being
a byte.

This closes #2783

5 weeks agoGEODE-5984 Address LGTM recommendations
Bruce Schuchardt [Tue, 6 Nov 2018 17:16:54 +0000 (09:16 -0800)] 
GEODE-5984 Address LGTM recommendations

Addressing minor issues in javadocs and code reported by LooksGoodToMe.

One change that I made wasn't reported by that tool: I removed
two static variables from AcceptorImpl that duplicated variables in

This closes #2780

5 weeks agoGEODE-5884: Restores behavior of exceptions/wrapping of exceptions (#2786)
Jason Huynh [Tue, 6 Nov 2018 01:24:22 +0000 (17:24 -0800)] 
GEODE-5884: Restores behavior of exceptions/wrapping of exceptions (#2786)

* Previous refactor in a5daa924 was causing behavioral changes
   with function exceptions when combining with GEODE-5884

5 weeks agoGEODE-5992 Fix bugs identified by static analysis
Anthony Baker [Mon, 5 Nov 2018 20:47:38 +0000 (12:47 -0800)] 
GEODE-5992 Fix bugs identified by static analysis

5 weeks agoGEODE-5983: use equals() instead of == (#2777)
Nabarun Nag [Mon, 5 Nov 2018 23:27:03 +0000 (15:27 -0800)] 
GEODE-5983: use equals() instead of == (#2777)

* For boxed primitive types equals() is used instead of ==

5 weeks agoGEODE-5980: Removed unused collections. (#2774)
Nabarun Nag [Mon, 5 Nov 2018 22:55:39 +0000 (14:55 -0800)] 
GEODE-5980: Removed unused collections. (#2774)

* Removed collections that are populated but are never used.

5 weeks agoGEODE-5976:Prevent conversion of string to bytes (#2772)
Nabarun Nag [Mon, 5 Nov 2018 21:28:09 +0000 (13:28 -0800)] 
GEODE-5976:Prevent conversion of string to bytes (#2772)

* prevents the conversion of string to bytes everytime equals is called on the immutable strings

5 weeks agoGEODE-5937: Made dependencies explicit in geode-protobuf modules. (#2722)
Patrick Rhomberg [Mon, 5 Nov 2018 19:57:26 +0000 (11:57 -0800)] 
GEODE-5937: Made dependencies explicit in geode-protobuf modules. (#2722)

5 weeks agoGEODE-5938: Make dependencies explicit in cq and rebalancer modules. (#2729)
Patrick Rhomberg [Mon, 5 Nov 2018 19:48:09 +0000 (11:48 -0800)] 
GEODE-5938: Make dependencies explicit in cq and rebalancer modules. (#2729)

5 weeks agoGEODE-5975: Fixed container access. (#2771)
Nabarun Nag [Mon, 5 Nov 2018 18:35:01 +0000 (10:35 -0800)] 
GEODE-5975: Fixed container access. (#2771)

* Ensured that container access is done with the proper object type as a parameter.

5 weeks agoGEODE-5981: No operations on null values (#2775)
Nabarun Nag [Mon, 5 Nov 2018 18:28:39 +0000 (10:28 -0800)] 
GEODE-5981: No operations on null values (#2775)

* no method invocation on de-referenced objects.

5 weeks agoGEODE-5974: Removal of dead code. (#2770)
Nabarun Nag [Mon, 5 Nov 2018 18:19:40 +0000 (10:19 -0800)] 
GEODE-5974: Removal of dead code. (#2770)

* Due to contradictory dynamic type checks, dead codes were create.
* This commit deletes those dead code.

5 weeks agoGEODE-5963: Change destroy no entry found log statement to debug (#2756)
Kirk Lund [Mon, 5 Nov 2018 17:13:29 +0000 (09:13 -0800)] 
GEODE-5963: Change destroy no entry found log statement to debug (#2756)

Also fixed new Object[] mistake in log statement in Destroy65
that was introduced by changes for GEODE-5686.

5 weeks agoGEODE-5971: Refactor gateway receiver/gateway sender commands to extend SingleGfshCom...
Aditya Anchuri [Sun, 4 Nov 2018 04:03:51 +0000 (21:03 -0700)] 
GEODE-5971: Refactor gateway receiver/gateway sender commands to extend SingleGfshCommand base type (#2769)

* GEODE-5971 Refactor gateway receiver/gateway sender commands to extend SingleGfshCommand base type

Signed-off-by: Aditya Anchuri <>
6 weeks agoGEODE-5970: remove field-mapping from jdbc:mapping (#2766)
Darrel Schneider [Fri, 2 Nov 2018 23:26:02 +0000 (16:26 -0700)] 
GEODE-5970: remove field-mapping from jdbc:mapping (#2766)

6 weeks agoGEODE-5969: remove value-contains-primary-key from jdbc-mapping (#2765)
Darrel Schneider [Fri, 2 Nov 2018 21:37:12 +0000 (14:37 -0700)] 
GEODE-5969: remove value-contains-primary-key from jdbc-mapping (#2765)

6 weeks agoGEODE-5686 Remove LocalizedStrings
Bruce Schuchardt [Fri, 2 Nov 2018 19:36:59 +0000 (12:36 -0700)] 
GEODE-5686 Remove LocalizedStrings

Fixing two tests to expect exception text that has been slightly

6 weeks agoGEODE-5968: remove gfsh alter jdbc-mapping command (#2763)
Darrel Schneider [Fri, 2 Nov 2018 17:31:36 +0000 (10:31 -0700)] 
GEODE-5968: remove gfsh alter jdbc-mapping command (#2763)

6 weeks agoGEODE-5967: change pdx-class-name to pdx-name (#2761)
Darrel Schneider [Fri, 2 Nov 2018 15:52:50 +0000 (08:52 -0700)] 
GEODE-5967: change pdx-class-name to pdx-name (#2761)

Renamed the gfsh "--pdx-class-name" to "--pdx-name".
Renamed the xsd "pdx-class" to "pdx-name".

6 weeks agoGEODE-5951: add a create data-source gfsh command (#2758)
Darrel Schneider [Fri, 2 Nov 2018 01:12:12 +0000 (18:12 -0700)] 
GEODE-5951: add a create data-source gfsh command (#2758)

The new "create data-source" command is a replacement for "create jndi-binding". It has fewer options so will be easier for users to understand. Once it is done parsing its options it ends up using the same internal code as "create jndi-binding" to create the actual data-source.

Co-authored-by: @dschneider-pivotal
Co-authored-by: @jchen21
Co-authored-by: @monkeyherder
6 weeks agoAdd public key for Alexander Murmann to KEYS file
Alexander Murmann [Fri, 2 Nov 2018 00:21:46 +0000 (17:21 -0700)] 
Add public key for Alexander Murmann to KEYS file

6 weeks agoGEODE-5965 make JDK11 tests gating
Owen Nichols [Wed, 31 Oct 2018 22:54:07 +0000 (15:54 -0700)] 
GEODE-5965 make JDK11 tests gating

6 weeks agoGEODE-5966: mark PooledDataSourceFactory experimental (#2760)
Darrel Schneider [Thu, 1 Nov 2018 23:03:49 +0000 (16:03 -0700)] 
GEODE-5966: mark PooledDataSourceFactory experimental (#2760)

6 weeks agoGEODE-5338: Document 'ssl-use-default-context' property (#2762)
Dave Barnes [Thu, 1 Nov 2018 23:00:03 +0000 (16:00 -0700)] 
GEODE-5338: Document 'ssl-use-default-context' property (#2762)

* GEODE-5338: Document 'ssl-use-default-context' property

6 weeks agoGEODE-5686: Remove LocalizedStrings
Bruce Schuchardt [Thu, 1 Nov 2018 22:09:54 +0000 (15:09 -0700)] 
GEODE-5686: Remove LocalizedStrings

Fixing mixed parameter markers (\{.*%s and %s.*\{)

6 weeks agoGEODE-5686: Remove LocalizedStrings
Bruce Schuchardt [Thu, 1 Nov 2018 20:59:55 +0000 (13:59 -0700)] 
GEODE-5686: Remove LocalizedStrings

Fixing problems found by

There were a lot of logging calls that were improperly converted from
(MessageFormatString, Argument, Exception) to a form that treated the
Exception as part of the String.format() call.

There were a number of errors in format strings or number of arguments.
MessageFormat was more forgiving about this than String.format().

There were a few dangling MessageFormat specs that needed to be
converted to String.format() specs.

This closes #2757

6 weeks agoGEODE-5960: Add test to verify CommandMarker file for the JDBC connector (#2751)
BenjaminPerryRoss [Thu, 1 Nov 2018 20:45:08 +0000 (13:45 -0700)] 
GEODE-5960: Add test to verify CommandMarker file for the JDBC connector (#2751)

Added a new test to the JDBC connector project to verify that the list
of commands loaded via the scanner and the command marker match the list
of commands found via these two sources. This is to avoid
errors/warnings due to commands which appear in Command Marker files but
don't have available source code.

Co-authored-by: Ben Ross <>
Co-authored-by: Darrel Schneider <>
6 weeks agoGEODE-5803: Remove dependencies resulting from bad merge. (#2720)
Patrick Rhomberg [Thu, 1 Nov 2018 18:04:14 +0000 (11:04 -0700)] 
GEODE-5803: Remove dependencies resulting from bad merge. (#2720)

Co-authored-by: Robert Houghton <>
Co-authored-by: Patrick Rhomberg <>
6 weeks agoRevert "GEODE-5908: should compare mostSig, then leastSig (#2676)"
zhouxh [Thu, 1 Nov 2018 16:26:43 +0000 (09:26 -0700)] 
Revert "GEODE-5908: should compare mostSig, then leastSig (#2676)"

This reverts commit ab5fafbe188de4ffb30c0ddff926a42a713da914.

This fix conceptually is correct, but it somehow caused more data mismatch in
concurrency conflicts handling. Since there's no found bug related with this
fix, revert it for now.

6 weeks agoGEODE-5881: simplify DefaultQuery.TestHook (#2755)
Bill Burcham [Wed, 31 Oct 2018 23:33:36 +0000 (16:33 -0700)] 
GEODE-5881: simplify DefaultQuery.TestHook (#2755)

Consolidate three interface methods into one that takes an enum
to identify the "spot" in the query processing logic.

Co-authored-by: Bill Burcham <>
Co-authored-by: Dale Emery <>
Co-authored-by: Galen O'Sullivan <>
6 weeks agoGEODE-5948: Updated the cookie name (#2740)
mhansonp [Wed, 31 Oct 2018 22:16:48 +0000 (15:16 -0700)] 
GEODE-5948: Updated the cookie name (#2740)

Co-Authored-By: Patrick Rhomberg <>
6 weeks agoGEODE-5943: rework calculation for expected eviction to fix this test in jdk11 (...
jinmeiliao [Wed, 31 Oct 2018 20:48:27 +0000 (13:48 -0700)] 
GEODE-5943: rework calculation for expected eviction to fix this test in jdk11 (#2754)

Co-authored-by: Patrick Rhomberg <>
6 weeks agoGEODE-5953: set target member when transaction hosted locally (#2746)
pivotal-eshu [Wed, 31 Oct 2018 19:35:54 +0000 (12:35 -0700)] 
GEODE-5953: set target member when transaction hosted locally (#2746)

  * to be able to detect primary bucket has moved due to rebalance.
  * add debug level logging for transaction.

6 weeks agoGEODE-5952: Provide full cache XML entity for root region when a subregion is created...
Aditya Anchuri [Wed, 31 Oct 2018 19:24:31 +0000 (12:24 -0700)] 
GEODE-5952: Provide full cache XML entity for root region when a subregion is created with gfsh (#2747)

Signed-off-by: Jens Deppe <>
6 weeks agoGEODE-5961: Add commons-validator jar to docs for tomcat dependencies (#2749)
Kirk Lund [Wed, 31 Oct 2018 19:12:54 +0000 (12:12 -0700)] 
GEODE-5961: Add commons-validator jar to docs for tomcat dependencies (#2749)

6 weeks agoGEODE-5935: move jdbc xml mapping to be in a region (#2739)
Darrel Schneider [Wed, 31 Oct 2018 15:40:42 +0000 (08:40 -0700)] 
GEODE-5935: move jdbc xml mapping to be in a region  (#2739)

The jdbc region-mapping xml element is now jdbc:mapping.
It no longer has a "region" attribute since it is nested in a region.
Creating a jdbc-mapping requires that the region already exists.
The jdbc:mapping element is now nested in a region element instead of the cache element.
The old connector-service element has been completely removed.
Some of the jdbc-mapping gfsh commands now require at least one server to be running.

Co-authored-by: Darrel Schneider <>
Co-authored-by: Jianxia Chen <>
Co-authored-by: Ben Ross @BenjaminPerryRoss
6 weeks agoGEODE-5943: Refactor EvictionDUnitTest and OffHeapEvictionDUnitTest (#2734)
jinmeiliao [Wed, 31 Oct 2018 15:06:11 +0000 (08:06 -0700)] 
GEODE-5943: Refactor EvictionDUnitTest and OffHeapEvictionDUnitTest (#2734)

* GEODE-5943: Refactor EvictionDUnitTest and OffHeapEvictionDUnitTest

* break the test into dunit and integration tests
* use the rules to better see what's the setup and what the test is doing

6 weeks agoGEODE-5884: Fix spotless errors
Jens Deppe [Wed, 31 Oct 2018 14:06:07 +0000 (07:06 -0700)] 
GEODE-5884: Fix spotless errors

6 weeks agoGEODE-5884: Fix typo and renamed test exception class
Jason Huynh [Tue, 23 Oct 2018 16:45:19 +0000 (09:45 -0700)] 
GEODE-5884: Fix typo and renamed test exception class

6 weeks agoGEODE-5884: Refactored methods and added tests
Jason Huynh [Thu, 18 Oct 2018 17:26:30 +0000 (10:26 -0700)] 
GEODE-5884: Refactored methods and added tests

6 weeks agoGEODE-5884: Non HA Function waits for all results if exception occurs
Jason Huynh [Tue, 16 Oct 2018 21:23:40 +0000 (14:23 -0700)] 
GEODE-5884: Non HA Function waits for all results if exception occurs

  * Non HA functions will attempt to return as many results as possible when an exception occurs
  * This behavior will be more in-line with single-hop execution

6 weeks agoGEODE-5568: Rewrite QueryMonitor to use ScheduledThreadPoolExecutor (#2744)
Ryan McMahon [Wed, 31 Oct 2018 02:06:49 +0000 (19:06 -0700)] 
GEODE-5568: Rewrite QueryMonitor to use ScheduledThreadPoolExecutor (#2744)

* GEODE-5568: Rewrite QueryMonitor to use ScheduledThreadPoolExecutor

Eliminate notify/wait bugs and improve hot-path performance.

Co-authored-by: Bill Burcham <>
Co-authored-by: Ryan McMahon <>
6 weeks agoGEODE-5864: Put GLOBAL_GRADLE_ARGS in the right place. (#2753)
Sean Goller [Tue, 30 Oct 2018 23:25:09 +0000 (16:25 -0700)] 
GEODE-5864: Put GLOBAL_GRADLE_ARGS in the right place. (#2753)

Authored-by: Sean Goller <>
6 weeks agoGEODE-5864: Add GLOBAL_GRADLE_ARGS to PublishArtifacts. (#2752)
Sean Goller [Tue, 30 Oct 2018 22:38:18 +0000 (15:38 -0700)] 
GEODE-5864: Add GLOBAL_GRADLE_ARGS to PublishArtifacts. (#2752)

Authored-by: Sean Goller <>
6 weeks agoGEODE-5945: Remove ref to JDBC connection commands (#2737)
Jianxia Chen [Tue, 30 Oct 2018 21:02:42 +0000 (14:02 -0700)] 
GEODE-5945: Remove ref to JDBC connection commands (#2737)

Removed the references to the JDBC connection commands, which no longer exist,  from the gfsh CommandMarker file.

Co-authored-by: Ben Ross <>
Co-authored-by: Jianxia Chen <>
6 weeks agodeploy_meta enhancements: (#2748)
Owen Nichols [Tue, 30 Oct 2018 19:49:52 +0000 (12:49 -0700)] 
deploy_meta enhancements: (#2748)

* currently deploy_meta infers the branch name with no way to override.  print this with the other default variables and allow to be overridden if necessary like the other defaults (for example if your local branch name is tracking a remote branch that is named differently)
* when local overrides are not set up, print a kinder message about how to set them up
* handle 'pending' status for concourse jobs

6 weeks agoGEODE-5917: Modified instanceof to check for CachedDeserializable
Barry Oglesby [Tue, 30 Oct 2018 18:19:50 +0000 (11:19 -0700)] 
GEODE-5917: Modified instanceof to check for CachedDeserializable

6 weeks agoGEODE-5819: update the keystore used in ssl test to make it jdk11 com… (#2743)
jinmeiliao [Tue, 30 Oct 2018 16:58:10 +0000 (09:58 -0700)] 
GEODE-5819: update the keystore used in ssl test to make it jdk11 com… (#2743)

* GEODE-5819: update the keystore used in ssl test to make it jdk11 compatible.

Co-authored-by: Patrick Rhomberg <>
6 weeks agoGEODE-3 Update LICENSE to include jaxb reference
Anthony Baker [Tue, 30 Oct 2018 15:36:28 +0000 (08:36 -0700)] 
GEODE-3 Update LICENSE to include jaxb reference

6 weeks agoMerge pull request #2742 from onichols-pivotal/GEODE-5950-automate-jdk11-updates
Dick Cavender [Mon, 29 Oct 2018 20:37:54 +0000 (13:37 -0700)] 
Merge pull request #2742 from onichols-pivotal/GEODE-5950-automate-jdk11-updates

GEODE-5950 ensure images pick up new Java11 versions

6 weeks agoGEODE-5950 ensure images pick up new Java11 versions 2742/head
Owen Nichols [Mon, 29 Oct 2018 18:33:07 +0000 (11:33 -0700)] 
GEODE-5950 ensure images pick up new Java11 versions

6 weeks agoGEODE-5797: Move assertion to async invoke (#2635)
Helena Bales [Mon, 29 Oct 2018 18:43:58 +0000 (11:43 -0700)] 
GEODE-5797: Move assertion to async invoke (#2635)

GEODE-5797: throw CacheClosed in ColocationHelper

The ColocationHelper runs in the background and wrote a suspect string
to the logs during this test when the cache was closed at the wrong
time, causing the test to fail.

The ColocationHelper would check a static variable to get colocated
regions, and if the cache was closed at the wrong point in this process,
the static region would have already been reset by closing the cache,
and the ColocationHelper would write a suspect string.

To fix this test, and the behavior of the ColocationHelper, we first
check if the cache is in the process of being cancelled. If it is, a
CacheClosedException is thrown instead of an IllegalStateException.
CacheClosedExceptions are ignored.

* add unit test for changes to ColocationHelper. Tests that a
CacheClosedException is thrown from getColocatedRegion when the cache is
* remove wait for regions to be ready as it was never the correct fix
for this bug.
* create the senders before the regions, since that is the correct order

Signed-off-by: Dan Smith <>
6 weeks agoGEODE-1603: wait for receiver MBean federation (#2726)
Helena Bales [Mon, 29 Oct 2018 17:26:34 +0000 (10:26 -0700)] 
GEODE-1603: wait for receiver MBean federation (#2726)

The check of receiver MBeans was failing with an exception of invalid
member name or id intermittently, when the check occured before the
member was added to DistributedSystemBridge's list of members. This adds
an awaitility around the method that calls this check, since the member
will eventually be put to that list.

6 weeks agoGEODE-5925 Server shutdown delays election of new primary bucket owners
Bruce Schuchardt [Mon, 29 Oct 2018 17:24:32 +0000 (10:24 -0700)] 
GEODE-5925 Server shutdown delays election of new primary bucket owners

Undoing removal of null check when sending profile updates.  The method
that sends profile update messages may return null instead of a reply
processor object so this check is still needed.

6 weeks agoGEODE-5941: Remove comments containing developer name (#2731)
Kirk Lund [Mon, 29 Oct 2018 16:59:46 +0000 (09:59 -0700)] 
GEODE-5941: Remove comments containing developer name (#2731)

This removes all mention of KIRK. There are still other developer
names present in comments.

7 weeks agoGEODE-5946 spelling error in
Bruce Schuchardt [Fri, 26 Oct 2018 22:24:20 +0000 (15:24 -0700)] 
GEODE-5946 spelling error in

Reworded to "Done waiting for index removal"

7 weeks agoRevert "GEM-2250 Misspelling in info level log message "Done wating for remove index...
Bruce Schuchardt [Fri, 26 Oct 2018 22:20:33 +0000 (15:20 -0700)] 
Revert "GEM-2250 Misspelling in info level log message "Done wating for remove index...""

This reverts commit 93e27d1ded29f3d20a7a42d9c4b04ae30fbba8a4.

7 weeks agoGEM-2250 Misspelling in info level log message "Done wating for remove index..."
Bruce Schuchardt [Fri, 26 Oct 2018 22:18:37 +0000 (15:18 -0700)] 
GEM-2250 Misspelling in info level log message "Done wating for remove index..."

Reworded to "Done waiting for index removal"

7 weeks agoGEODE-5925 Server shutdown delays election of new primary bucket owners
Bruce Schuchardt [Fri, 26 Oct 2018 21:59:41 +0000 (14:59 -0700)] 
GEODE-5925 Server shutdown delays election of new primary bucket owners

Addressing nitpick with variable names in old test code

7 weeks agoGEODE-5819: Reduce 16h40m wait on shutdown to 120 seconds. (#2736)
Patrick Rhomberg [Fri, 26 Oct 2018 21:59:40 +0000 (14:59 -0700)] 
GEODE-5819: Reduce 16h40m wait on shutdown to 120 seconds. (#2736)

* While this is unlikely to correct the Java11 SSL handshake failures, it should make tests currently hanging properly fail out so that a full failure-set can be analyzed.

7 weeks agoGEODE-5925 Server shutdown delays election of new primary bucket owners
Bruce Schuchardt [Fri, 26 Oct 2018 21:49:04 +0000 (14:49 -0700)] 
GEODE-5925 Server shutdown delays election of new primary bucket owners

This PR addresses the problem of AcceptorImpl sending out expensive
profile update messages when it's being stopped during Cache.close().
There is no reason to send these messages if the affected regions are
going to be destroyed since that also sends profile updates
to other members of the cluster.

This closes #2717

7 weeks agoRestore update passing ref (#2733)
Sean Goller [Fri, 26 Oct 2018 18:23:01 +0000 (11:23 -0700)] 
Restore update passing ref (#2733)

* add x permissions

Co-authored-by: Sean Goller <>
Co-authored-by: Dick Cavender <>
7 weeks agoGEODE-5925 locks are not released in shutdown hook
Bruce Schuchardt [Fri, 26 Oct 2018 18:13:09 +0000 (11:13 -0700)] 
GEODE-5925 locks are not released in shutdown hook

If the cache is closed because the JVM is exiting we aren't releasing
locks until the DistributedSystem disconnects.  This alters the behavior
of shutdown and, in particular, causes long delays in designating new
primary bucket owners and reestablishing redundancy.

This commit enables unlocking during shutdown.

This closes #2725

7 weeks agoRestore update passing ref (#2732)
Sean Goller [Fri, 26 Oct 2018 18:07:01 +0000 (11:07 -0700)] 
Restore update passing ref (#2732)

* Restore UpdatePassingRef for now.

Co-authored-by: Sean Goller <>
Co-authored-by: Dick Cavender <>
* Restore

Co-authored-by: Sean Goller <>
Co-authored-by: Dick Cavender <>
7 weeks agoGEODE-5927: enhance create jndi-binding to configure pool (#2711)
Darrel Schneider [Fri, 26 Oct 2018 17:27:06 +0000 (10:27 -0700)] 
GEODE-5927: enhance create jndi-binding to configure pool (#2711)

The create jndi-binding --datasource-config-properties will now check each
name for a "pool." prefix. If found then that property, minus the prefix,
will be added to the properties that the PooledDataSourceFactory gets to
configure the pool. The other datasource config properties are still used
to configure the database.
The help strings on create jndi-binding have been updated.

Co-authored-by: @BenjaminPerryRoss
7 weeks agoRestore UpdatePassingRef for now. (#2728)
Sean Goller [Fri, 26 Oct 2018 16:30:56 +0000 (09:30 -0700)] 
Restore UpdatePassingRef for now. (#2728)

Co-authored-by: Sean Goller <>
Co-authored-by: Dick Cavender <>
7 weeks agoGEODE-5922 SerialGatewaySenderQueue concurrency is poorly implemented
Bruce Schuchardt [Thu, 25 Oct 2018 22:26:36 +0000 (15:26 -0700)] 
GEODE-5922 SerialGatewaySenderQueue concurrency is poorly implemented

Replaced simple synchronization with a fair write-lock.  The use of
sync to enforce serial queueing wasn't fair and caused inconsistent
latency.  I observed one thread that was blocked trying to get the
sync for over 30 seconds while other subsequent threads were able to
get the sync and queue their events.

This closes #2705

7 weeks agoGEODE-5936 Document OpenJDK support for Geode (#2719)
Karen Miller [Thu, 25 Oct 2018 22:13:35 +0000 (15:13 -0700)] 
GEODE-5936 Document OpenJDK support for Geode (#2719)

7 weeks agoFix typo. (#2724)
Sean Goller [Thu, 25 Oct 2018 21:20:52 +0000 (14:20 -0700)] 
Fix typo. (#2724)

Co-authored-by: Sean Goller <>
Co-authored-by: Dick Cavender <>
7 weeks agoEcho out pre and post hashing name for instances. (#2721)
Sean Goller [Thu, 25 Oct 2018 21:15:11 +0000 (14:15 -0700)] 
Echo out pre and post hashing name for instances. (#2721)

Co-authored-by: Sean Goller <>
Co-authored-by: Dick Cavender <>
7 weeks agoMerge pull request #2718 from onichols-pivotal/GEODE-5930-revert-concourse-metadata
Dick Cavender [Thu, 25 Oct 2018 19:26:08 +0000 (12:26 -0700)] 
Merge pull request #2718 from onichols-pivotal/GEODE-5930-revert-concourse-metadata

Revert "GEODE-5930 clean up dangling outputs in concourse (#2713)"

7 weeks agoRevert "GEODE-5930 clean up dangling outputs in concourse (#2713)" 2718/head
Owen Nichols [Thu, 25 Oct 2018 19:10:17 +0000 (12:10 -0700)] 
Revert "GEODE-5930 clean up dangling outputs in concourse (#2713)"

This reverts commit 5503d5cd1e48f9810c85c2a0a05e730157d13211.

7 weeks agoGEODE-5764: Use a thread-safe set to record keys (#2709)
Dale Emery [Thu, 25 Oct 2018 18:01:38 +0000 (11:01 -0700)] 
GEODE-5764: Use a thread-safe set to record keys (#2709)

AbstractMovingAsyncEventListener.processEvents() recorded keys using
unsynchronized modification of a HashSet, though some tests could call
the method concurrently on as many as 3 threads.

AbstractMovingAsyncEventListener now uses a synchronized set to record

7 weeks agoGEODE-5923: Add test for local alerts and cleanup classes (#2710)
Kirk Lund [Thu, 25 Oct 2018 17:58:17 +0000 (10:58 -0700)] 
GEODE-5923: Add test for local alerts and cleanup classes (#2710)

* Create DistributedSystemMXBeanIntegrationTest
* Add ignored test that confirms bug GEODE-5923
* Cleanup alert related classes and add lots of comments about how they work

7 weeks agoGEODE-5827: Use standard pattern converters in suspect appender (#2704)
Kirk Lund [Thu, 25 Oct 2018 17:57:22 +0000 (10:57 -0700)] 
GEODE-5827: Use standard pattern converters in suspect appender (#2704)

The suspect appender is added programmatically without a log4j2.xml
so there is apparently no way to specify additional plugin packages.

Change hexTid back to tid to prevent error messages about not finding
the HexThreadIdPatternConverter.

7 weeks agoMerge pull request #2685 from onichols-pivotal/GEODE-5913
Dick Cavender [Thu, 25 Oct 2018 17:06:27 +0000 (10:06 -0700)] 
Merge pull request #2685 from onichols-pivotal/GEODE-5913

GEODE-5913 resolve jstack using JAVA_HOME, if set

7 weeks agoMerge pull request #2716 from onichols-pivotal/GEODE-5934-fix-examples-pipeline
Dick Cavender [Thu, 25 Oct 2018 16:46:29 +0000 (09:46 -0700)] 
Merge pull request #2716 from onichols-pivotal/GEODE-5934-fix-examples-pipeline

GEODE-5934 change start/stop instance to create/delete instance

7 weeks agoGEODE-5783: have a single source for ThreadFactory
Bruce Schuchardt [Thu, 25 Oct 2018 15:37:22 +0000 (08:37 -0700)] 
GEODE-5783: have a single source for ThreadFactory

Use the keepalive parameter when initializing the thread factory.

I also made some logging changes while debugging the problems this
missing setting was causing.

7 weeks agoGEODE-5819: fix ssl test failures in jdk11 (#2702)
jinmeiliao [Thu, 25 Oct 2018 04:31:50 +0000 (21:31 -0700)] 
GEODE-5819: fix ssl test failures in jdk11 (#2702)

* do not call getSession after startHandshake on a socket to make it TLS1.3 compliant
* when using TLS1.3 protocol in the tests, make sure to user a certificate that are TLS1.3 compliant.

7 weeks agoGEODE-5934 change start/stop instance to create/delete instance 2716/head
Owen Nichols [Thu, 25 Oct 2018 00:30:23 +0000 (17:30 -0700)] 
GEODE-5934 change start/stop instance to create/delete instance

7 weeks agoGEODE-5929 concourse workers no longer need java (#2712)
Owen Nichols [Thu, 25 Oct 2018 00:12:16 +0000 (17:12 -0700)] 
GEODE-5929 concourse workers no longer need java (#2712)

7 weeks agoGEODE-5930 clean up dangling outputs in concourse (#2713)
Owen Nichols [Thu, 25 Oct 2018 00:11:49 +0000 (17:11 -0700)] 
GEODE-5930 clean up dangling outputs in concourse (#2713)

7 weeks agoGEODE-5933 make it easier to use deploy_meta with forks (#2715)
Owen Nichols [Thu, 25 Oct 2018 00:11:06 +0000 (17:11 -0700)] 
GEODE-5933 make it easier to use deploy_meta with forks (#2715)

7 weeks agoGEODE-5909: Remove unknown tag causing compile warning. (#2678)
Patrick Rhomberg [Wed, 24 Oct 2018 23:43:44 +0000 (16:43 -0700)] 
GEODE-5909: Remove unknown tag causing compile warning. (#2678)

* Also cleanup various pieces of dead code or now-inapplicable comments.

7 weeks agoGEODE-5899: Make dependencies explicit in old-client and lucene* modules. (#2675)
Patrick Rhomberg [Wed, 24 Oct 2018 23:41:12 +0000 (16:41 -0700)] 
GEODE-5899: Make dependencies explicit in old-client and lucene* modules. (#2675)

Co-authored-by: Robert Houghton <>
Co-authored-by: Patrick Rhomberg <>
7 weeks agoGEODE-5897: change create jndi-binding to fail on an exception (#2680)
Darrel Schneider [Wed, 24 Oct 2018 23:15:02 +0000 (16:15 -0700)] 
GEODE-5897: change create jndi-binding to fail on an exception (#2680)

Create jndi-binding will now fail if an exception occurs during the create.
Also the data-source is now validated by asking it for a connection when the jndi-binding is created.
If a connection can not be obtained, the create fails and the data-source is closed.
Previously if an exception occurred when creating a jndi-binding an info message was logged.
Now, as the docs state, a warning is logged.

The problem was caused by an exception being caught, logged, and not rethrown.
Now the gfsh function will get the thrown exception and pass a failure back
to gfsh. For backwards compatibility, the XML parser still logs a warning if
the jndi-binding can not be created, instead of having it cause the cache not
to start.