2 weeks agoGUACAMOLE-1595: Merge mouse mask initialization fix. master
James Muehlner [Tue, 3 May 2022 00:24:58 +0000 (17:24 -0700)] 
GUACAMOLE-1595: Merge mouse mask initialization fix.

2 weeks agoGUACAMOLE-1595: Ensure all mouse buttons are initially released when terminal starts. 381/head
Michael Jumper [Tue, 3 May 2022 00:20:08 +0000 (00:20 +0000)] 
GUACAMOLE-1595: Ensure all mouse buttons are initially released when terminal starts.

8 weeks agoGUACAMOLE-1312: Merge add Canadian French RDP keymap
Virtually Nick [Wed, 23 Mar 2022 13:58:58 +0000 (09:58 -0400)] 
GUACAMOLE-1312: Merge add Canadian French RDP keymap

2 months agoGUACAMOLE-1312: Added fr_ca keymap 376/head
Kaven Rousseau [Thu, 20 Feb 2020 22:44:16 +0000 (17:44 -0500)] 
GUACAMOLE-1312: Added fr_ca keymap

2 months agoMerge 1.5.0 changes back to master.
Virtually Nick [Thu, 17 Mar 2022 19:24:48 +0000 (15:24 -0400)] 
Merge 1.5.0 changes back to master.

2 months agoGUACAMOLE-1115: Merge ensure RDP print process does not block itself from completing. staging/1.5.0
Virtually Nick [Thu, 17 Mar 2022 19:20:51 +0000 (15:20 -0400)] 
GUACAMOLE-1115: Merge ensure RDP print process does not block itself from completing.

2 months agoGUACAMOLE-1115: Forcibly kill any outstanding PDF filter job when cleaning up resources. 378/head
Michael Jumper [Thu, 17 Mar 2022 18:27:05 +0000 (18:27 +0000)] 
GUACAMOLE-1115: Forcibly kill any outstanding PDF filter job when cleaning up resources.

2 months agoGUACAMOLE-1115: Do not hold general RDP message lock while waiting for print operations.
Michael Jumper [Thu, 17 Mar 2022 17:32:37 +0000 (17:32 +0000)] 
GUACAMOLE-1115: Do not hold general RDP message lock while waiting for print operations.

Holding the message lock will block handling of things like mouse and
keyboard events, as the message lock must be acquired before sending the
corresponding messages to the RDP server. If mouse and keyboard events
are blocked, then handling of further Guacamole instructions like "ack"
is also blocked. If the print job is blocked until an "ack" is received,
this results in deadlock.

2 months agoGUACAMOLE-1543: Merge changes moving recording structures/functions to the public...
Mike Jumper [Tue, 1 Mar 2022 17:58:50 +0000 (09:58 -0800)] 
GUACAMOLE-1543: Merge changes moving recording structures/functions to the public API.

2 months agoGUACAMOLE-1543: Move recording functionality from common to libguac. 374/head
James Muehlner [Tue, 1 Mar 2022 03:38:25 +0000 (03:38 +0000)] 
GUACAMOLE-1543: Move recording functionality from common to libguac.

2 months agoGUACAMOLE-1538: Merge corrections to libguac-terminal build and scope.
Mike Jumper [Tue, 1 Mar 2022 00:56:04 +0000 (16:56 -0800)] 
GUACAMOLE-1538: Merge corrections to libguac-terminal build and scope.

2 months agoGUACAMOLE-1538: Only the core functionality of the terminal lib should be public. 373/head
James Muehlner [Sat, 26 Feb 2022 02:13:22 +0000 (02:13 +0000)] 
GUACAMOLE-1538: Only the core functionality of the terminal lib should be public.

2 months agoGUACAMOLE-1538: Make it clear which functions are getters by adding _get_ to the...
James Muehlner [Thu, 24 Feb 2022 19:22:12 +0000 (11:22 -0800)] 
GUACAMOLE-1538: Make it clear which functions are getters by adding _get_ to the name of each.

2 months agoGUACAMOLE-1538 Use dashes instead of underscores in filenames for consistency with...
James Muehlner [Thu, 24 Feb 2022 19:12:05 +0000 (11:12 -0800)] 
GUACAMOLE-1538 Use dashes instead of underscores in filenames for consistency with libguac public API.

2 months agoGUACAMOLE-1538: Autogenerate docs for new library.
James Muehlner [Wed, 23 Feb 2022 19:16:43 +0000 (11:16 -0800)] 
GUACAMOLE-1538: Autogenerate docs for new library.

2 months agoGUACAMOLE-1538: Improve code style and cleanliness.
James Muehlner [Wed, 23 Feb 2022 04:37:42 +0000 (20:37 -0800)] 
GUACAMOLE-1538: Improve code style and cleanliness.

2 months agoGUACAMOLE-1538: Do not use terminal internals outside of terminal code.
James Muehlner [Wed, 23 Feb 2022 00:06:48 +0000 (16:06 -0800)] 
GUACAMOLE-1538: Do not use terminal internals outside of terminal code.

2 months agoGUACAMOLE-1538 - Consolidate clipboard handling; opaque clipboard struct to avoid...
James Muehlner [Tue, 22 Feb 2022 20:45:35 +0000 (12:45 -0800)] 
GUACAMOLE-1538 - Consolidate clipboard handling; opaque clipboard struct to avoid exposing internal guac_common_clipboard.

2 months agoGUACAMOLE-1538: Explicitly include the common lib; ensure no undefined symbols.
James Muehlner [Tue, 22 Feb 2022 19:07:24 +0000 (11:07 -0800)] 
GUACAMOLE-1538: Explicitly include the common lib; ensure no undefined symbols.

2 months agoGUACAMOLE-1538: Rename library to match conventions.
James Muehlner [Mon, 21 Feb 2022 21:34:54 +0000 (13:34 -0800)] 
GUACAMOLE-1538: Rename library to match conventions.

2 months agoGUACAMOLE-1540: Merge changes correcting Docker-specific search for FreeRDP install...
Mike Jumper [Tue, 22 Feb 2022 01:32:23 +0000 (17:32 -0800)] 
GUACAMOLE-1540: Merge changes correcting Docker-specific search for FreeRDP install location.

2 months agoGUACAMOLE-1540: Search for libfreerdp2 installation directly instead of checking... 372/head
James Muehlner [Tue, 22 Feb 2022 00:57:48 +0000 (16:57 -0800)] 
GUACAMOLE-1540: Search for libfreerdp2 installation directly instead of checking links.

2 months agoGUACAMOLE-1538: Merge refactor libguac_terminal for easier extensibility, and migrate...
Virtually Nick [Mon, 21 Feb 2022 19:30:40 +0000 (14:30 -0500)] 
GUACAMOLE-1538: Merge refactor libguac_terminal for easier extensibility, and migrate to shared library.

2 months agoGUACAMOLE-1538: Use an options struct instead of hardcoding params in constructor. 369/head
James Muehlner [Thu, 17 Feb 2022 22:16:05 +0000 (14:16 -0800)] 
GUACAMOLE-1538: Use an options struct instead of hardcoding params in constructor.

2 months agoGUACAMOLE-1538: Update libguac_terminal to be a shared library.
James Muehlner [Thu, 17 Feb 2022 19:06:50 +0000 (11:06 -0800)] 
GUACAMOLE-1538: Update libguac_terminal to be a shared library.

2 months agoGUACAMOLE-1540: Merge migration of guacd Docker image to Ubuntu 21.10.
Mike Jumper [Sat, 19 Feb 2022 00:20:17 +0000 (16:20 -0800)] 
GUACAMOLE-1540: Merge migration of guacd Docker image to Ubuntu 21.10.

2 months agoGUACAMOLE-1540: Build using Ubuntu 21.10 as a base instead of buster-slim. 371/head
James Muehlner [Fri, 18 Feb 2022 20:52:42 +0000 (12:52 -0800)] 
GUACAMOLE-1540: Build using Ubuntu 21.10 as a base instead of buster-slim.

2 months agoGUACAMOLE-876: Merge null-check fix for RDP open file check.
James Muehlner [Fri, 18 Feb 2022 21:50:03 +0000 (13:50 -0800)] 
GUACAMOLE-876: Merge null-check fix for RDP open file check.

2 months agoGUACAMOLE-876: Test for open files only if filesystem has been allocated. 370/head
Michael Jumper [Fri, 18 Feb 2022 21:40:15 +0000 (13:40 -0800)] 
GUACAMOLE-876: Test for open files only if filesystem has been allocated.

2 months agoGUACAMOLE-1495: Merge add keymap for Polish keyboard layout for RDP
Virtually Nick [Thu, 17 Feb 2022 17:46:01 +0000 (12:46 -0500)] 
GUACAMOLE-1495: Merge add keymap for Polish keyboard layout for RDP

2 months agoGUACAMOLE-462: Merge create recordings/typescripts with group read permission.
Virtually Nick [Thu, 17 Feb 2022 17:43:51 +0000 (12:43 -0500)] 
GUACAMOLE-462: Merge create recordings/typescripts with group read permission.

2 months agoGUACAMOLE-462: Create recordings/typescripts with group read permission. 368/head
Michael Jumper [Thu, 17 Feb 2022 17:25:26 +0000 (09:25 -0800)] 
GUACAMOLE-462: Create recordings/typescripts with group read permission.

Previously, all recordings/typescripts were strictly readable by the
service user that created them (guacd). This prevents reading by other
services like the Guacamole web application. Instead,
recordings/typescripts should at least be group-readable.

3 months agoGUACAMOLE-876: Merge changes deferring reconnect-to-resize until active transfers...
Mike Jumper [Wed, 2 Feb 2022 17:56:41 +0000 (09:56 -0800)] 
GUACAMOLE-876: Merge changes deferring reconnect-to-resize until active transfers are complete.

3 months agoGUACAMOLE-876: Avoid disrupting open files and active print jobs to update display. 362/head
Virtually Nick [Wed, 5 Jan 2022 13:12:29 +0000 (08:12 -0500)] 
GUACAMOLE-876: Avoid disrupting open files and active print jobs to update display.

4 months agoGUACAMOLE-745: Merge support for OpenSSH-format private keys / Ed25519.
Mike Jumper [Wed, 12 Jan 2022 19:38:12 +0000 (11:38 -0800)] 
GUACAMOLE-745: Merge support for OpenSSH-format private keys / Ed25519.

4 months agoGUACAMOLE-745: Support OpenSSH private keys & ED25519 349/head
Joshua Roys [Wed, 15 Dec 2021 14:35:46 +0000 (09:35 -0500)] 
GUACAMOLE-745: Support OpenSSH private keys & ED25519

Let libssh2 parse PEM and ssh-native keys. Requires libssh2 1.9.0+
compiled against a crypto backend supporting ed25519.

4 months agoGUACAMOLE-1495: add entry for pl_pl_qwerty 364/head
ClassicGOD [Mon, 10 Jan 2022 19:31:41 +0000 (20:31 +0100)] 
GUACAMOLE-1495: add entry for pl_pl_qwerty

Add pl_pl_qwerty.keymap to rdp_keymaps

4 months agoGUACAMOLE-1495: add pl_pl_qwerty keymap
ClassicGOD [Mon, 10 Jan 2022 19:28:11 +0000 (20:28 +0100)] 
GUACAMOLE-1495: add pl_pl_qwerty keymap

Add keymap file for Polish keyboard layout

4 months agoGUACAMOLE-1435: Merge correction to FreeRDP plugin entrypoint return type.
Mike Jumper [Tue, 4 Jan 2022 05:59:57 +0000 (21:59 -0800)] 
GUACAMOLE-1435: Merge correction to FreeRDP plugin entrypoint return type.

4 months agoGUACAMOLE-1435: Correctly return UINT for DVCPluginEntry 361/head
Virtually Nick [Tue, 4 Jan 2022 01:15:11 +0000 (20:15 -0500)] 
GUACAMOLE-1435: Correctly return UINT for DVCPluginEntry

4 months agoMerge 1.4.0 changes back to master.
Virtually Nick [Sat, 25 Dec 2021 15:21:40 +0000 (10:21 -0500)] 
Merge 1.4.0 changes back to master.

4 months agoGUACAMOLE-478: Merge add clipboard line ending normalization option for RDP. 1.4.0 1.4.0-RC1
Virtually Nick [Sat, 25 Dec 2021 15:18:39 +0000 (10:18 -0500)] 
GUACAMOLE-478: Merge add clipboard line ending normalization option for RDP.

4 months agoGUACAMOLE-478: Add optional clipboard line ending normalization for RDP. 357/head
Michael Jumper [Sat, 25 Dec 2021 08:31:17 +0000 (00:31 -0800)] 
GUACAMOLE-478: Add optional clipboard line ending normalization for RDP.

4 months agoGUACAMOLE-478: Implement encoding translation functions for normalizing newline seque...
Michael Jumper [Sat, 25 Dec 2021 08:07:47 +0000 (00:07 -0800)] 
GUACAMOLE-478: Implement encoding translation functions for normalizing newline sequences.

4 months agoMerge 1.4.0 changes back to master.
Virtually Nick [Sat, 25 Dec 2021 00:24:36 +0000 (19:24 -0500)] 
Merge 1.4.0 changes back to master.

4 months agoGUACAMOLE-1190: Merge explicitly use "localhost" as guacd default bind host, matching...
Virtually Nick [Sat, 25 Dec 2021 00:23:53 +0000 (19:23 -0500)] 
GUACAMOLE-1190: Merge explicitly use "localhost" as guacd default bind host, matching default of webapp.

4 months agoGUACAMOLE-1190: Explicitly use "localhost" as guacd default bind host, matching defau... 356/head
Michael Jumper [Fri, 24 Dec 2021 23:45:28 +0000 (15:45 -0800)] 
GUACAMOLE-1190: Explicitly use "localhost" as guacd default bind host, matching default of webapp.

4 months agoMerge 1.4.0 changes back to master.
Virtually Nick [Mon, 20 Dec 2021 03:17:47 +0000 (22:17 -0500)] 
Merge 1.4.0 changes back to master.

4 months agoGUACAMOLE-1047: Merge notify connecting client of invalid connection IDs.
Virtually Nick [Sun, 19 Dec 2021 23:39:15 +0000 (18:39 -0500)] 
GUACAMOLE-1047: Merge notify connecting client of invalid connection IDs.

4 months agoGUACAMOLE-1047: Remove unnecessary use of snprintf() in favor of guacd_log(). 355/head
Michael Jumper [Sat, 18 Dec 2021 23:13:10 +0000 (15:13 -0800)] 
GUACAMOLE-1047: Remove unnecessary use of snprintf() in favor of guacd_log().

5 months agoMerge 1.4.0 changes back to master.
Virtually Nick [Sat, 11 Dec 2021 12:44:56 +0000 (07:44 -0500)] 
Merge 1.4.0 changes back to master.

5 months agoGUACAMOLE-1411: Merge bump version numbers to 1.4.0.
Virtually Nick [Sat, 11 Dec 2021 12:44:19 +0000 (07:44 -0500)] 
GUACAMOLE-1411: Merge bump version numbers to 1.4.0.

5 months agoGUACAMOLE-1411: Update libtool version info for libguac (interfaces added and changed). 354/head
Michael Jumper [Sat, 11 Dec 2021 07:55:16 +0000 (23:55 -0800)] 
GUACAMOLE-1411: Update libtool version info for libguac (interfaces added and changed).

5 months agoGUACAMOLE-1411: Bump version numbers to 1.4.0.
Michael Jumper [Sat, 11 Dec 2021 07:51:34 +0000 (23:51 -0800)] 
GUACAMOLE-1411: Bump version numbers to 1.4.0.

6 months agoGUACAMOLE-1330: Merge dynamically allocate AVPacket when possible
Virtually Nick [Mon, 8 Nov 2021 23:47:03 +0000 (18:47 -0500)] 
GUACAMOLE-1330: Merge dynamically allocate AVPacket when possible

6 months agoGUACAMOLE-1330: Dynamically allocate AVPacket when supported (static allocation depre... 352/head
Michael Jumper [Mon, 8 Nov 2021 22:23:02 +0000 (14:23 -0800)] 
GUACAMOLE-1330: Dynamically allocate AVPacket when supported (static allocation deprecated as of libavcodec 58.133.100).

8 months agoGUACAMOLE-1416: Merge fix unreleased terminal lock in ssh_client_thread
Virtually Nick [Fri, 10 Sep 2021 14:40:10 +0000 (10:40 -0400)] 
GUACAMOLE-1416: Merge fix unreleased terminal lock in ssh_client_thread

8 months agoGUACAMOLE-1416: Fix unreleased the lock in the ssh_client_thread 346/head
ycaibb [Fri, 10 Sep 2021 12:44:46 +0000 (20:44 +0800)] 
GUACAMOLE-1416: Fix unreleased the lock in the ssh_client_thread

GUACAMOLE-1416: Fix unreleased the lock ssh_client->term_channel_lock in the ssh_client_thread.

9 months agoGUACAMOLE-1388: Merge ensure RDP-specific resources are cleaned up after channel...
Virtually Nick [Thu, 29 Jul 2021 23:54:35 +0000 (19:54 -0400)] 
GUACAMOLE-1388: Merge ensure RDP-specific resources are cleaned up after channel disconnect.

9 months agoGUACAMOLE-1388: Ensure RDP-specific resources are cleaned up after channel disconnect. 345/head
Michael Jumper [Wed, 28 Jul 2021 22:50:13 +0000 (15:50 -0700)] 
GUACAMOLE-1388: Ensure RDP-specific resources are cleaned up after channel disconnect.

Without these changes, RDP-specific resources like the CLIPRDR and RDPEI
channels may remain from past connections if the RDP connection is
dynamically reconnected via the "Reconnect" display resize method,
resulting in assertion failures or memory errors if those stale
resources are reused after reconnect is completed.

9 months agoGUACAMOLE-1386: Merge add proper RDP mapping of "Meta" ("Windows") key.
Virtually Nick [Tue, 27 Jul 2021 13:51:48 +0000 (09:51 -0400)] 
GUACAMOLE-1386: Merge add proper RDP mapping of "Meta" ("Windows") key.

9 months agoGUACAMOLE-1386: Add proper RDP mapping of "Meta" ("Windows") key. 343/head
Michael Jumper [Tue, 27 Jul 2021 02:56:56 +0000 (19:56 -0700)] 
GUACAMOLE-1386: Add proper RDP mapping of "Meta" ("Windows") key.

11 months agoGUACAMOLE-1064: Merge Norwegian keyboard layout for RDP.
Mike Jumper [Thu, 3 Jun 2021 05:34:29 +0000 (22:34 -0700)] 
GUACAMOLE-1064: Merge Norwegian keyboard layout for RDP.

11 months agoGUACAMOLE-1064: add Norwegian keyboard 342/head
Øyvind Harboe [Fri, 28 May 2021 11:44:15 +0000 (13:44 +0200)] 
GUACAMOLE-1064: add Norwegian keyboard

Tested on top of Guacamole 1.3.0

The following works beyond a simple smoke-test:

- æøå
- \
- |
- dead acute á
- dead grave à
- dead umlaut ö
- dead cirumflex ê
- dead tilde ~

11 months agoGUACAMOLE-1350: Merge corrections for defined but unused leave_handlers.
Mike Jumper [Tue, 25 May 2021 18:44:35 +0000 (11:44 -0700)] 
GUACAMOLE-1350: Merge corrections for defined but unused leave_handlers.

11 months agoGUACAMOLE-1350: Add code to join leave_handler when connecting in other protocols. 341/head
Jimmy [Mon, 24 May 2021 23:03:07 +0000 (02:03 +0300)] 
GUACAMOLE-1350: Add code to join leave_handler when connecting in other protocols.

11 months agoGUACAMOLE-1350: Add code to join leave_handler when connecting in rdp.
Jimmy [Sun, 23 May 2021 22:11:28 +0000 (01:11 +0300)] 
GUACAMOLE-1350: Add code to join leave_handler when connecting in rdp.

12 months agoGUACAMOLE-1215: Merge correction for escaping of backslashes in JSON strings.
Mike Jumper [Mon, 17 May 2021 19:25:23 +0000 (12:25 -0700)] 
GUACAMOLE-1215: Merge correction for escaping of backslashes in JSON strings.

12 months agoGUACAMOLE-1215: Add backslash to list of JSON-escaped characters. 339/head
Virtually Nick [Mon, 17 May 2021 18:14:48 +0000 (14:14 -0400)] 
GUACAMOLE-1215: Add backslash to list of JSON-escaped characters.

12 months agoGUACAMOLE-1276: Merge correction for 32-bit truncation regression affecting RDP uploads.
Mike Jumper [Fri, 14 May 2021 17:51:13 +0000 (10:51 -0700)] 
GUACAMOLE-1276: Merge correction for 32-bit truncation regression affecting RDP uploads.

12 months agoGUACAMOLE-1276: Correct file upload offset type. 338/head
Virtually Nick [Fri, 14 May 2021 13:19:28 +0000 (09:19 -0400)] 
GUACAMOLE-1276: Correct file upload offset type.

12 months agoGUACAMOLE-1201: Merge throttle outbound audio data to avoid overflowing RDP server...
Virtually Nick [Sun, 2 May 2021 02:10:11 +0000 (22:10 -0400)] 
GUACAMOLE-1201: Merge throttle outbound audio data to avoid overflowing RDP server audio input buffer.

12 months agoGUACAMOLE-1201: Throttle outbound audio data to avoid overflowing RDP server audio... 337/head
Michael Jumper [Thu, 29 Apr 2021 01:32:39 +0000 (18:32 -0700)] 
GUACAMOLE-1201: Throttle outbound audio data to avoid overflowing RDP server audio input buffer.

The RDP specification for the AUDIO_INPUT channel requires that all
audio be sent in packets of a specific size. Guacamole does correctly
limit itself to sending packets of this size to the RDP server, but will
send quite a few of these packets all at once if it has received more
audio data than the RDP packet size. This is OK in principle (the
Guacamole client should be able to send audio in packets of whatever
size it chooses), but may overwhelm the software running within the RDP
server if the amount of data received exceeds the available buffer
space, resulting in dropped samples.

As there is no way to know the size of the remote audio buffer, we need
to instead ensure that audio is streamed as close to real time as
possible, with each audio packet of N bytes not being sent until roughly
the amount of time represented by those N bytes has elapsed since the
last packet. This throttling ensures that software expecting to process
audio in real time should never run out of buffer space.

That said, if we never exceed the per-packet data rate and occasionally
send a packet earlier than real time would dictate, unavoidable latency
in sending/receiving audio data would accumulate over time. For example,
if each audio packet represents 10ms of audio data, but we receive that
audio packet 10.1ms after the previous packet, we need to adjust the
timing of the next audio packet(s) to account for that additional 0.1ms.
Simply waiting 10ms after sending each packet would cause that 0.1ms to
accumulate each time it occurs, eventually resulting in noticable
latency and finally running out of buffer space.

Thus, these changes:

1. Leverage a flush thread and per-packet scheduling to ensure that each
   flushed audio packet does not exceed the equivalent real time rate.
2. Calculate the amount of additional latency from the amount of data
   received beyond the required packet size, and amortize scheduling
   corrections to account for that latency over the next several audio

This ensures that audio is streamed exactly as it is received if the
audio matches the packet size of the RDP server, and audio that is
received in a different size or varying sizes is buffered and throttled
to keep things within the expectations of software running within the
RDP server.

13 months agoGUACAMOLE-1283: Merge add synchronization around absolutely all outbound RDP messages.
Virtually Nick [Sat, 17 Apr 2021 17:11:32 +0000 (13:11 -0400)] 
GUACAMOLE-1283: Merge add synchronization around absolutely all outbound RDP messages.

13 months agoGUACAMOLE-1283: Remove redundant parameters from guac_rdp_audio_buffer callback. 336/head
Michael Jumper [Wed, 14 Apr 2021 00:47:51 +0000 (17:47 -0700)] 
GUACAMOLE-1283: Remove redundant parameters from guac_rdp_audio_buffer callback.

The buffer and data parameters of the guac_rdp_audio_buffer flush
handler are redundant now that the guac_rdp_audio_buffer is being passed
to the handler. They can instead be referenced as audio_buffer->packet
and audio_buffer->data respectively.

13 months agoGUACAMOLE-1283: Add synchronization around absolutely all outbound RDP messages.
Michael Jumper [Thu, 8 Apr 2021 00:13:48 +0000 (17:13 -0700)] 
GUACAMOLE-1283: Add synchronization around absolutely all outbound RDP messages.

The FreeRDP library is intended to be threadsafe, but is not reliably so
with respect to legacy RDP encryption and outbound messages. When
outbound messages are sent by multiple threads, the encryption key used
for legacy RDP encryption may not be updated correctly, resulting in a
fatal connection error like:

"ERRINFO_DECRYPT_FAILED (0x00001192):(a) Decryption using Standard RDP
Security mechanisms (section 5.3.6) failed. (b) Session key creation
using Standard RDP Security mechanisms (section 5.3.5) failed."

14 months agoGUACAMOLE-1307: Merge use VerifyCertificateEx callback if supported.
Virtually Nick [Wed, 10 Mar 2021 19:38:43 +0000 (14:38 -0500)] 
GUACAMOLE-1307: Merge use VerifyCertificateEx callback if supported.

14 months agoGUACAMOLE-1307: Use VerifyCertificateEx callback if supported. 335/head
Michael Jumper [Wed, 10 Mar 2021 06:53:11 +0000 (22:53 -0800)] 
GUACAMOLE-1307: Use VerifyCertificateEx callback if supported.

14 months agoGUACAMOLE-1302: Merge support for forcing lossless compression in VNC and RDP connect...
James Muehlner [Thu, 4 Mar 2021 03:31:25 +0000 (19:31 -0800)] 
GUACAMOLE-1302: Merge support for forcing lossless compression in VNC and RDP connections.

14 months agoGUACAMOLE-1302: Add RDP support for forcing lossless compression. 333/head
Michael Jumper [Tue, 2 Mar 2021 01:39:41 +0000 (17:39 -0800)] 
GUACAMOLE-1302: Add RDP support for forcing lossless compression.

14 months agoGUACAMOLE-1302: Add VNC support for forcing lossless compression.
Michael Jumper [Tue, 2 Mar 2021 01:39:29 +0000 (17:39 -0800)] 
GUACAMOLE-1302: Add VNC support for forcing lossless compression.

14 months agoGUACAMOLE-1302: Always use lossless compression for text-based protocols leveraging...
Michael Jumper [Tue, 2 Mar 2021 01:34:17 +0000 (17:34 -0800)] 
GUACAMOLE-1302: Always use lossless compression for text-based protocols leveraging the terminal.

14 months agoGUACAMOLE-1302: Add surface/display level support for forcing lossless compression.
Michael Jumper [Tue, 2 Mar 2021 01:33:27 +0000 (17:33 -0800)] 
GUACAMOLE-1302: Add surface/display level support for forcing lossless compression.

14 months agoGUACAMOLE-1305: Merge fix pt-br keyboard layout
Virtually Nick [Wed, 3 Mar 2021 21:19:20 +0000 (16:19 -0500)] 
GUACAMOLE-1305: Merge fix pt-br keyboard layout

14 months agoGUACAMOLE-1305: Fix pt-br keyboard layout. Key being recognized as right shift. 334/head
Higor Cavalcanti [Wed, 3 Mar 2021 19:49:59 +0000 (16:49 -0300)] 
GUACAMOLE-1305: Fix pt-br keyboard layout. Key being recognized as right shift.

14 months agoGUACAMOLE-1174: Merge correct handling of truncated parameters when appending to...
Virtually Nick [Mon, 22 Feb 2021 01:32:47 +0000 (20:32 -0500)] 
GUACAMOLE-1174: Merge correct handling of truncated parameters when appending to URLs.

14 months agoGUACAMOLE-1174: Correct logic detecting truncation of appended parameter. 332/head
Michael Jumper [Sun, 21 Feb 2021 22:55:25 +0000 (14:55 -0800)] 
GUACAMOLE-1174: Correct logic detecting truncation of appended parameter.

The previous implementation passed `length - str_len` to `snprintf()`,
yet compared the return value to `length`. This is incorrect, as
`length` is not the buffer size provided to `snprintf()`.

14 months agoGUACAMOLE-1174: Add unit tests for URL utility functions.
Michael Jumper [Sun, 21 Feb 2021 22:42:08 +0000 (14:42 -0800)] 
GUACAMOLE-1174: Add unit tests for URL utility functions.

14 months agoGUACAMOLE-1174: Clarify behavior of URL parameter appending function.
Michael Jumper [Sun, 21 Feb 2021 22:15:17 +0000 (14:15 -0800)] 
GUACAMOLE-1174: Clarify behavior of URL parameter appending function.

14 months agoGUACAMOLE-1174: Merge support for Kubernetes "exec" API call.
Mike Jumper [Sun, 21 Feb 2021 19:09:53 +0000 (11:09 -0800)] 
GUACAMOLE-1174: Merge support for Kubernetes "exec" API call.

15 months agoGUACAMOLE-1047: Changed returned status code per review 271/head
Tomer Gabel [Sun, 14 Feb 2021 14:21:54 +0000 (16:21 +0200)] 
GUACAMOLE-1047: Changed returned status code per review

15 months agoGUACAMOLE-1204: Merge addition of server-side support for multi-touch events.
James Muehlner [Fri, 12 Feb 2021 04:53:22 +0000 (20:53 -0800)] 
GUACAMOLE-1204: Merge addition of server-side support for multi-touch events.

15 months agoGUACAMOLE-1204: Add support for including touch events within session recordings. 331/head
Michael Jumper [Sat, 6 Feb 2021 23:10:50 +0000 (15:10 -0800)] 
GUACAMOLE-1204: Add support for including touch events within session recordings.

15 months agoGUACAMOLE-1204: Add RDP support for multi-touch events via RDPEI channel.
Michael Jumper [Sat, 6 Feb 2021 22:56:17 +0000 (14:56 -0800)] 
GUACAMOLE-1204: Add RDP support for multi-touch events via RDPEI channel.

15 months agoGUACAMOLE-1204: Add support for declaring layer multi-touch capabilities.
Michael Jumper [Sat, 6 Feb 2021 22:42:02 +0000 (14:42 -0800)] 
GUACAMOLE-1204: Add support for declaring layer multi-touch capabilities.

15 months agoGUACAMOLE-1204: Add libguac support for processing the "touch" instruction.
Michael Jumper [Sat, 6 Feb 2021 22:31:49 +0000 (14:31 -0800)] 
GUACAMOLE-1204: Add libguac support for processing the "touch" instruction.

15 months agoGUACAMOLE-1277: Merge unswap - and _ on fr-be-azerty keymap
Virtually Nick [Tue, 2 Feb 2021 20:54:12 +0000 (15:54 -0500)] 
GUACAMOLE-1277: Merge unswap - and _ on fr-be-azerty keymap

15 months agoGUACAMOLE-1277: Unswap -/_ on fr-be-azerty keymap 330/head
Sander Vanheule [Tue, 2 Feb 2021 16:52:15 +0000 (17:52 +0100)] 
GUACAMOLE-1277: Unswap -/_ on fr-be-azerty keymap

When using the fr-be-azerty remote keyboard layout on an RDP connection,
the dash ('-') and underscore ('_') are swapped.

Underscore and dash are located on the same key on a Belgian azerty
layout. Dash should be the normal/unshifted character, and underscore
should be the shifted character. The current mapping has this the other
way around, so let's fix this.

Signed-off-by: Sander Vanheule <>
15 months agoGUACAMOLE-1133: Merge build-time sanity check for libvncserver usage of gcrypt.
Mike Jumper [Sun, 24 Jan 2021 22:15:35 +0000 (14:15 -0800)] 
GUACAMOLE-1133: Merge build-time sanity check for libvncserver usage of gcrypt.

15 months agoGUACAMOLE-1133: Add gcrypt build dependency for Docker image. 329/head
Nick Couchman [Sun, 24 Jan 2021 03:16:58 +0000 (22:16 -0500)] 
GUACAMOLE-1133: Add gcrypt build dependency for Docker image.