Re-enable strict CJS interop
authorRandall Leeds <randall@apache.org>
Sat, 9 Jun 2018 18:26:32 +0000 (11:26 -0700)
committerRandall Leeds <randall@apache.org>
Mon, 11 Jun 2018 15:45:24 +0000 (08:45 -0700)
babel.config.js
package.json
webpack.config.js
yarn.lock

index fbc40b3..99864b3 100644 (file)
@@ -20,12 +20,11 @@ module.exports = api => {
   const CJS = ENV === 'cjs';
 
   // Options for the @babel/transform-modules-commonjs plugin.
-  // TODO: re-evaluate this
   const cjsOptions = {
     // Disable require default interop.
-    // noInterop: true,
+    noInterop: true,
     // Disable export default interop.
-    // strict: true,
+    strict: true,
   };
 
   // Options for the @babel/env preset.
index 56d15a4..8d7c200 100644 (file)
@@ -43,7 +43,7 @@
     "eslint-plugin-import": "^2.9.0",
     "eslint-plugin-node": "^6.0.1",
     "eslint-plugin-prettier": "^2.6.0",
-    "esm": "^3.0.9",
+    "esm": "^3.0.49",
     "husky": "^0.14.0",
     "lerna": "^2.9.0",
     "lint-staged": "^7.0.0",
index 35fb76c..638fc1e 100644 (file)
@@ -35,8 +35,6 @@ module.exports = {
         test: /\.m?js$/,
         exclude: /node_modules/,
         use: 'babel-loader',
-        // TODO: remove this
-        type: 'javascript/auto',
       },
     ],
   },
index 98bf46e..c37ed76 100644 (file)
--- a/yarn.lock
+++ b/yarn.lock
@@ -2593,9 +2593,9 @@ eslint@^4.19.1:
     table "4.0.2"
     text-table "~0.2.0"
 
-esm@^3.0.9:
-  version "3.0.48"
-  resolved "https://registry.yarnpkg.com/esm/-/esm-3.0.48.tgz#24bf3834428b44cac7d953bb5b196d2e4ec0d815"
+esm@^3.0.49:
+  version "3.0.49"
+  resolved "https://registry.yarnpkg.com/esm/-/esm-3.0.49.tgz#24e2a305c742f9565f2ededa5665493347f8a412"
 
 espree@^3.5.4:
   version "3.5.4"