RATIS-476. checkstyle SuppressionCommentFilter and SuppressWithNearbyCommentFilter...
authorTsz Wo Nicholas Sze <szetszwo@apache.org>
Fri, 25 Jan 2019 20:12:52 +0000 (12:12 -0800)
committerTsz Wo Nicholas Sze <szetszwo@apache.org>
Fri, 25 Jan 2019 21:43:38 +0000 (13:43 -0800)
dev-support/checkstyle.xml
pom.xml

index 7fdc712..5e52d98 100644 (file)
@@ -56,8 +56,6 @@
     <property name="fileExtensions" value="java, properties, xml"/>
 
     <module name="SuppressWarningsFilter"/>
-    <module name="SuppressionCommentFilter"/>
-    <module name="SuppressWithNearbyCommentFilter"/>
 
     <!-- Checks that a package-info.java file exists for each package.     -->
     <!-- See http://checkstyle.sf.net/config_javadoc.html#JavadocPackage -->
@@ -97,6 +95,8 @@
 
     <module name="TreeWalker">
         <module name="SuppressWarningsHolder"/>
+        <module name="SuppressionCommentFilter"/>
+        <module name="SuppressWithNearbyCommentFilter"/>
 
         <!-- Checks for Javadoc comments.                     -->
         <!-- See http://checkstyle.sf.net/config_javadoc.html -->
diff --git a/pom.xml b/pom.xml
index 4d4282d..ded40d7 100644 (file)
--- a/pom.xml
+++ b/pom.xml
     <test.exclude.pattern>_</test.exclude.pattern>
     <!-- number of threads/forks to use when running tests in parallel, see parallel-tests profile -->
     <testsThreadCount>4</testsThreadCount>
+
+    <checkstyle.version>8.16</checkstyle.version>
   </properties>
 
   <dependencyManagement>
         <groupId>org.apache.maven.plugins</groupId>
         <artifactId>maven-checkstyle-plugin</artifactId>
         <version>${maven-checkstyle-plugin.version}</version>
+        <dependencies>
+          <dependency>
+            <groupId>com.puppycrawl.tools</groupId>
+            <artifactId>checkstyle</artifactId>
+            <version>${checkstyle.version}</version>
+          </dependency>
+        </dependencies>
         <configuration>
           <configLocation>${basedir}/../dev-support/checkstyle.xml</configLocation>
           <failOnViolation>false</failOnViolation>